') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ARROW-17728: [C++][Gandiva] Accept LLVM 15.0 by js8544 · Pull Request #14125 · apache/arrow · GitHub
Skip to content

ARROW-17728: [C++][Gandiva] Accept LLVM 15.0 - #14125

Merged
kou merged 7 commits into
apache:masterfrom
js8544:jinshang/accept_llvm_15
Sep 16, 2022
Merged

ARROW-17728: [C++][Gandiva] Accept LLVM 15.0#14125
kou merged 7 commits into
apache:masterfrom
js8544:jinshang/accept_llvm_15

Conversation

@js8544

@js8544js8544 commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented Sep 14, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17728

@github-actions

github-actionsBot commented Sep 14, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@js8544

js8544 commented Sep 14, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

There is another problem now: LLVM 15 adds dependency on zstd. It looks for target zstd::libzstd_shared, but arrow prefers zstd::libzstd. Let me try to turn off LLVM_ENABLE_ZSTD and see if it works.

@js8544
js8544force-pushed the jinshang/accept_llvm_15 branch from 27a11e1 to 59372feCompareSeptember 14, 2022 19:59
@koukou changed the title ARROW-17728: [C++] Accept llvm 15.0ARROW-17728: [C++][Gandiva] Accept LLVM 15.0Sep 14, 2022
@kou

kou commented Sep 14, 2022

Copy link
Copy Markdown
Member

It seems that the Zstd's official CMake package uses zstd::libzstd_shared and zstd::libzstd_static.
So our CMake configurations should follow it. (And our Findzstd.cmake should support the Zstd's official CMake package too.)

I'll push a change for it to this branch later. Please wait for a while...

@pitrou

pitrou commented Sep 15, 2022

Copy link
Copy Markdown
Member

There is another problem now: LLVM 15 adds dependency on zstd

Is it a mandatory dependency? zstd shouldn't be required to write a JIT...

@js8544

js8544 commented Sep 15, 2022

Copy link
Copy Markdown
ContributorAuthor

There is another problem now: LLVM 15 adds dependency on zstd

Is it a mandatory dependency? zstd shouldn't be required to write a JIT...

The dependency can be avoided by turning LLVM_ENABLE_ZSTD off. But I'm a CMake newbie and not sure how to do it properly...

@pitrou

pitrou commented Sep 15, 2022

Copy link
Copy Markdown
Member

Most probably, we must also accomodate for the fact that pre-built binary packages for LLVM probably have zstd enabled anyway.

@kou

kou commented Sep 16, 2022

Copy link
Copy Markdown
Member

It seems that Gandiva with LLVM 15 have problems at least on MinGW.
But I'm not sure it's caused only on MinGW or can be caused on other platforms.
It's difficult to debug this on MinGW. So I propose that we merge this by disabling Gandiva related tests or Gandiva support only on MinGW for now. We can fix the problem when other platforms provide LLVM 15 and the same problem is occurred on these platforms.

@pitrou

pitrou commented Sep 16, 2022

Copy link
Copy Markdown
Member

It's difficult to debug this on MinGW. So I propose that we merge this by disabling Gandiva related tests or Gandiva support only on MinGW for now. We can fix the problem when other platforms provide LLVM 15 and the same problem is occurred on these platforms.

That is fine with me.

kou
kou approved these changes Sep 16, 2022
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We can merge this after we can confirm new CI failures aren't increased with this.

@kou

kou commented Sep 16, 2022

Copy link
Copy Markdown
Member

"R / rhub/debian-gcc-devel:latest" is failed:

https://github.com/apache/arrow/actions/runs/3063524875/jobs/4951928558#step:5:27585

══ Failed tests ════════════════════════════════════════════════════════════════
── Error (test-duckdb.R:212:3): Joining, auto-cleanup enabled ──────────────────
Error: rapi_execute: Failed to run query
Error: Invalid Error: std::exception
Backtrace:
▆
1. ├─DBI::dbGetQuery(...) at test-duckdb.R:212:2
2. └─DBI::dbGetQuery(...)
3. └─DBI (local) .local(conn, statement, ...)
4. ├─DBI::dbSendQuery(conn, statement, ...)
5. └─duckdb::dbSendQuery(conn, statement, ...)
6. └─duckdb (local) .local(conn, statement, ...)
7. └─duckdb:::duckdb_result(...)
8. └─duckdb:::duckdb_execute(res)
9. └─duckdb:::rapi_execute(...)
[ FAIL 1 | WARN 0 | SKIP 28 | PASS 8467 ]

("AMD64 Ubuntu 20.04 R 4.2 Force-Tests true" has the same failure.)

But this will be solved by #14149. So I merge this.

@kou
kou merged commit 9131724 into apache:masterSep 16, 2022
@ursabot

ursabot commented Sep 18, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 6bc2e01 and contender = 9131724. 9131724 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.2% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 9131724e ec2-t3-xlarge-us-east-2
[Failed] 9131724e test-mac-arm
[Failed] 9131724e ursa-i9-9960x
[Finished] 9131724e ursa-thinkcentre-m75q
[Finished] 6bc2e010 ec2-t3-xlarge-us-east-2
[Failed] 6bc2e010 test-mac-arm
[Failed] 6bc2e010 ursa-i9-9960x
[Finished] 6bc2e010 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented Sep 18, 2022

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@js8544@kou@zagto
ARROW-17728: [C++][Gandiva] Accept LLVM 15.0 (apache#14125)
c1f482a
Lead-authored-by: Jin Shang <shangjin1997@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@js8544
js8544 deleted the jinshang/accept_llvm_15 branch October 11, 2022 08:43
@asfimportasfimport mentioned this pull request Sep 21, 2022
Closed
@jorisvandenbosschejorisvandenbossche mentioned this pull request Mar 29, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@pitroupitroupitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@js8544@kou@pitrou@ursabot