You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a grouped data.frame is converted to arrow dplyr query and then back to a data.frame again, the data.frame-era groups are restored, even if it is ungrouped in the query.
I don't know if this (handling of tables with no rows) is a problem.
A table with 0 rows and multiple columns appears to be quite exceptional, since creating a table from a data frame with no rows results in 0 x 0.
mtcars|>dplyr::select(NULL) |>arrow::arrow_table()
#> Table#> 0 rows x 0 columns#>#>#> See $metadata for additional Schema metadata
eitsupi
changed the title
ARROW-17737: [R] Continue to retain grouping metadata even if ungroup arrow dplyr queryARROW-17737: [R] Groups before conversion to a Table must not be restored after collect()Oct 7, 2022
The reason will be displayed to describe this comment to others. Learn more.
One suggestion for simplifying this change. Thanks for taking this on, will be nice to get this in the upcoming release along with your other changes around here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a grouped data.frame is converted to arrow dplyr query and then back to a data.frame again, the data.frame-era groups are restored, even if it is ungrouped in the query.
This PR will update to ensure that the arrow dplyr query's groups are applied when
computeorcollect.