ARROW-17814: [C++] Remove make_unique reimplementation

[wgtmac]

Use std::make_unique instead.

[pitrou]

Thanks! Is it also possible to remove occurrences of using std::make_unique and instead write std::make_unique in full?

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17814

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[wgtmac]

Thanks! Is it also possible to remove occurrences of using std::make_unique and instead write std::make_unique in full?

Thanks for the review! Please check it again. @pitrou

[pitrou]

LGTM.

[pitrou]

I'll just wait for CI now.

[pitrou]

I rebased and fixed conflicts.

[wgtmac]

I rebased and fixed conflicts.

I have done the same thing. Sorry for missing your commit. @pitrou

[ursabot]

Benchmark runs are scheduled for baseline = 0310add and contender = 4cb7b50. 4cb7b50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.55% ⬆️0.24%] test-mac-arm
[Failed ⬇️1.1% ⬆️0.27%] ursa-i9-9960x
[Finished ⬇️0.46% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4cb7b500 ec2-t3-xlarge-us-east-2
[Failed] 4cb7b500 test-mac-arm
[Failed] 4cb7b500 ursa-i9-9960x
[Finished] 4cb7b500 ursa-thinkcentre-m75q
[Finished] 0310add1 ec2-t3-xlarge-us-east-2
[Finished] 0310add1 test-mac-arm
[Failed] 0310add1 ursa-i9-9960x
[Finished] 0310add1 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[ursabot]

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

[kou]

@wgtmac This breaks our lint: https://github.com/apache/arrow/actions/runs/3105831802/jobs/5031935208#step:5:866

--- /arrow/cpp/src/arrow/type.cc+++ /arrow/cpp/src/arrow/type.cc (after clang format)@@ -1723,8 +1723,7 @@
SchemaBuilder::SchemaBuilder(std::vector<std::shared_ptr<Field>> fields,
ConflictPolicy policy,
Field::MergeOptions field_merge_options) {
- impl_ = std::make_unique<Impl>(std::move(fields), nullptr, policy,- field_merge_options);+ impl_ = std::make_unique<Impl>(std::move(fields), nullptr, policy, field_merge_options);
}
SchemaBuilder::SchemaBuilder(const std::shared_ptr<Schema>& schema, ConflictPolicy policy,
...

Could you fix this as a follow-up pull request? Or do you want me to fix this?

[kou]

See also: https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci

[pitrou]

Oops, I don't know how I missed that. @kou I'd be glad if you could do it :-)

[kou]

OK. I'll do it.

[kou]

#14218