Skip to content

ARROW-17823: [C++] Revert std::make_shared change for CUDA - #14233

Merged
kou merged 1 commit into
apache:masterfrom
kou:cpp-make-shared-cuda
Sep 26, 2022
Merged

ARROW-17823: [C++] Revert std::make_shared change for CUDA#14233
kou merged 1 commit into
apache:masterfrom
kou:cpp-make-shared-cuda

Conversation

@kou

@koukou commented Sep 25, 2022

Copy link
Copy Markdown
Member

This is a follow-up of #14216. We can't use std::make_shared for CUDA related classes because their constructors aren't public.

@kou
ARROW-17823: [C++] Revert std::make_shared change for CUDA
13856fc
This is a follow-up of apache#14216. We can't use std::make_shared for CUDA
related classes because their constructors aren't public.
@kou

kou commented Sep 25, 2022

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit debian-bookworm-amd64

@github-actions

github-actionsBot commented Sep 25, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17823

@github-actions

github-actionsBot commented Sep 25, 2022

Copy link
Copy Markdown

Revision: 13856fc

Submitted crossbow builds: ursacomputing/crossbow @ actions-00cfe95e4e

TaskStatus
debian-bookworm-amd64Github Actions

@kou

kou commented Sep 26, 2022

Copy link
Copy Markdown
MemberAuthor

+1

@kou
kou merged commit b76ddf1 into apache:masterSep 26, 2022
@kou
kou deleted the cpp-make-shared-cuda branch September 26, 2022 01:39
@ursabot

ursabot commented Sep 26, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 7808280 and contender = b76ddf1. b76ddf1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.48% ⬆️0.1%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.5% ⬆️0.18%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] b76ddf19 ec2-t3-xlarge-us-east-2
[Failed] b76ddf19 test-mac-arm
[Failed] b76ddf19 ursa-i9-9960x
[Finished] b76ddf19 ursa-thinkcentre-m75q
[Finished] 78082800 ec2-t3-xlarge-us-east-2
[Failed] 78082800 test-mac-arm
[Failed] 78082800 ursa-i9-9960x
[Finished] 78082800 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@kou@zagto
ARROW-17823: [C++] Revert std::make_shared change for CUDA (apache#14233
a0bae16
)
This is a follow-up of apache#14216. We can't use std::make_shared for CUDA related classes because their constructors aren't public.
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kou@ursabot