Skip to content

ARROW-17844: [C++] Remove atomic shared_ptr compatibility functions - #14239

Merged
pitrou merged 2 commits into
apache:masterfrom
pitrou:ARROW-17844-atomic-shared-ptr
Sep 26, 2022
Merged

ARROW-17844: [C++] Remove atomic shared_ptr compatibility functions#14239
pitrou merged 2 commits into
apache:masterfrom
pitrou:ARROW-17844-atomic-shared-ptr

Conversation

@pitrou

Copy link
Copy Markdown
Member

No description provided.

@pitrou

Copy link
Copy Markdown
MemberAuthor

Revision: d6b8a00

Submitted crossbow builds: ursacomputing/crossbow @ atomic-shared-ptr-0

TaskStatus
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-fedora-35-cppGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-22.04-cppGithub Actions

@westonpacewestonpace left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

#include "arrow/type.h"
#include "arrow/type_fwd.h"
#include "arrow/type_traits.h"
#include "arrow/util/atomic_shared_ptr.h"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I suppose we should add #include <atomic> for IWYU but it is probably transitively included by most standard includes.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, let's do it.

@pitrou

Copy link
Copy Markdown
MemberAuthor

CI looks green on my fork (apart from a seemingly unrelated R failure), will merge.

@pitrou
pitrou merged commit 5b29dd0 into apache:masterSep 26, 2022
@pitrou
pitrou deleted the ARROW-17844-atomic-shared-ptr branch September 26, 2022 17:20
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 9b4a181 and contender = 5b29dd0. 5b29dd0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.48% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.43% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5b29dd06 ec2-t3-xlarge-us-east-2
[Finished] 5b29dd06 test-mac-arm
[Failed] 5b29dd06 ursa-i9-9960x
[Finished] 5b29dd06 ursa-thinkcentre-m75q
[Finished] 9b4a181d ec2-t3-xlarge-us-east-2
[Failed] 9b4a181d test-mac-arm
[Failed] 9b4a181d ursa-i9-9960x
[Finished] 9b4a181d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@ursabot@westonpace