Uh oh!
There was an error while loading. Please reload this page.
ARROW-17160: [C++] Create a base directory for PyArrow CPP header files - #14275
Conversation
Uh oh!
There was an error while loading. Please reload this page.
jorisvandenbossche
left a comment
There was a problem hiding this comment.
There is still the question about moving the include paths from "arrow/python/.." to "pyarrow/.." (and how to provide some transition path for this), but assuming the current status of exposing those as "arrow/python/.." (which seems the safe assumption for 10.0), this seems like a good change to use those paths in the code and headers itself.
Uh oh!
There was an error while loading. Please reload this page.
AlenkaF
commented
Oct 7, 2022
I suggest we try to move the include paths from |
kou
commented
Oct 7, 2022
Could you create a separate JIRA issue for it? |
AlenkaF
commented
Oct 7, 2022
I am sorry for rerunning this travis ci job at https://app.travis-ci.com/github/apache/arrow/builds/256419696 while the job was already succeeded. |
AlenkaF
commented
Oct 7, 2022
No problem at all =) |
pitrou
commented
Oct 7, 2022
@kou Do you have any other concerns? |
kou
commented
Oct 8, 2022
No. |
AlenkaF
commented
Oct 10, 2022
I will merge later today, if there is no objection =) |
jorisvandenbossche
commented
Oct 10, 2022
The Python failure is one of the flaky dataset tests |
jorisvandenbossche
commented
Oct 10, 2022
Thanks @AlenkaF ! |
ursabot
commented
Oct 10, 2022
Benchmark runs are scheduled for baseline = d8f3946 and contender = 21dbf4a. 21dbf4a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR is a follow-up of #13311 where it was decided to change the base directory for PyArrow C++ headers to avoid top level inclusions. See #13311 (comment)