Uh oh!
There was an error while loading. Please reload this page.
ARROW-17891: [Docs][Python] Update and sync Win section of the developers/python page - #14350
Merged
Conversation
jorisvandenbossche
left a comment
Member
There was a problem hiding this comment.
Thanks! A few comments / questions
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AlenkaF
commented
Oct 17, 2022
MemberAuthor
@jorisvandenbossche I think this changes would be good to have in 10.0.0. You think it is ready to get merged with |
jorisvandenbossche
approved these changes
Oct 19, 2022
jorisvandenbossche
commented
Oct 19, 2022
Member
Thanks! |
kou pushed a commit
that referenced
this pull request
Oct 20, 2022
…pers/python page (#14350) This PR updates Windows section of the Python Development page. Main changes: - use Python 3.10 (also in instructions for Linux/MacOs) - definition of `PATH` not needed as Python doesn't search in `PATH` for dlls anymore ([3.8 +](https://bugs.python.org/issue43173)) - use `CONDA_PREFIX` to define `ARROW_HOME` as in other parts of the docs - remove **Running C++ unit tests for Python integration** section (C++ unit tests are part of `pytest`-based test module as of #14117) cc @wjones127@jorisvandenbossche Authored-by: Alenka Frim <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Windows section of the Python Development page. Main changes:
PATHnot needed as Python doesn't search inPATHfor dlls anymore (3.8 +)CONDA_PREFIXto defineARROW_HOMEas in other parts of the docspytest-based test module as of ARROW-17016: [C++][Python] Move Arrow Python C++ tests into Cython #14117)cc @wjones127@jorisvandenbossche