GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build - #15014

Merged
kou merged 6 commits into
apache:masterfrom
h-vetinari:conda_ci
Dec 20, 2022
Merged

GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build#15014
kou merged 6 commits into
apache:masterfrom
h-vetinari:conda_ci

Conversation

@h-vetinari

@h-vetinarih-vetinari commented Dec 18, 2022•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Dec 18, 2022

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:

ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@h-vetinarih-vetinari changed the title fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: fix missing RECIPE_ROOT variable now expected by conda buildDec 18, 2022
@github-actions

github-actionsBot commented Dec 18, 2022

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Dec 18, 2022

Copy link
Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.

@h-vetinari

h-vetinari commented Dec 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit -g conda

@github-actions

github-actionsBot commented Dec 18, 2022

Copy link
Copy Markdown

Revision: f3b77cc

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccb0a7fe84

TaskStatus
conda-cleanAzure
conda-linux-aarch64-cpu-py3Azure
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-ppc64le-cpu-py3Azure
conda-linux-x64-cpu-py3Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-linux-x64-cuda-py3Azure
conda-osx-arm64-cpu-py3Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-py3Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-py3Azure
conda-win-x64-cpu-r41Azure
conda-win-x64-cuda-py3Azure

@h-vetinarih-vetinari mentioned this pull request Dec 18, 2022
Closed
@h-vetinari

h-vetinari commented Dec 18, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

So, the R-builds for aarch are still failing with:

> library('arrow')
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '[...]lib/R/library/arrow/libs/arrow.so':
[...]/lib/R/library/arrow/libs/arrow.so: undefined symbol: _ZTIN5arrow17RecordBatchReaderE
Execution halted

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.

CC @xhochy

@h-vetinari

h-vetinari commented Dec 18, 2022

Copy link
Copy Markdown
ContributorAuthor

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.

Though on the other hand, the build.sh for r-arrow is calling straight into the top-level r/-folder:

${R} CMD INSTALL --build r/. ${R_ARGS}

so something broke there in the last couple of days. For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.

CC @thisisnic

@xhochy

xhochy commented Dec 18, 2022

Copy link
Copy Markdown
Member

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.

This is OK, arrow.so is the R module. libarrow.so is the pure C++ shared library.

@xhochy

xhochy commented Dec 18, 2022

Copy link
Copy Markdown
Member

@h-vetinari This looks problematic:

2022-12-18T05:51:13.5618933Z *** Found local C++ source: '../cpp'
2022-12-18T05:51:13.5619835Z *** Building libarrow from source
2022-12-18T05:51:13.5620314Z For build options and troubleshooting, see the install guide:
2022-12-18T05:51:13.5621188Z https://arrow.apache.org/docs/r/articles/install.html
2022-12-18T05:51:13.8434741Z **** cmake
2022-12-18T05:51:18.7191251Z **** arrow 2022-12-18T05:51:20.8624297Z **** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information. 2022-12-18T05:51:21.5582869Z PKG_CFLAGS= -std=c++17
2022-12-18T05:51:21.5589264Z PKG_LIBS=

@xhochy

xhochy commented Dec 18, 2022

Copy link
Copy Markdown
Member

@github-actions crossbow submit conda-linux-aarch64-cpu-r41

@github-actions

github-actionsBot commented Dec 18, 2022

Copy link
Copy Markdown

Revision: 6efeeec

Submitted crossbow builds: ursacomputing/crossbow @ actions-8a6b714265

TaskStatus
conda-linux-aarch64-cpu-r41Azure

@kou

kou commented Dec 19, 2022

Copy link
Copy Markdown
Member

For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.

Oh, the change was by me. I'll look into this.

@kou

kou commented Dec 19, 2022

Copy link
Copy Markdown
Member

@github-actions crossbow submit conda-linux-aarch64-cpu-r41

@github-actions

github-actionsBot commented Dec 19, 2022

Copy link
Copy Markdown

Revision: e04c9dc

Submitted crossbow builds: ursacomputing/crossbow @ actions-297ce68126

TaskStatus
conda-linux-aarch64-cpu-r41Azure

@kou

kou commented Dec 19, 2022

Copy link
Copy Markdown
Member

@github-actions crossbow submit conda-linux-aarch64-cpu-r41

@github-actions

github-actionsBot commented Dec 19, 2022

Copy link
Copy Markdown

Revision: b26892d

Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2723bac4

TaskStatus
conda-linux-aarch64-cpu-r41Azure

@kou
"pkg-config --cflags" may be empty
3b9c72d
For example, Apache Arrow C++ is installed in system directory.
@kou

kou commented Dec 19, 2022

Copy link
Copy Markdown
Member

@github-actions crossbow submit conda-linux-aarch64-cpu-r41

@github-actions

github-actionsBot commented Dec 19, 2022

Copy link
Copy Markdown

Revision: 3b9c72d

Submitted crossbow builds: ursacomputing/crossbow @ actions-5e596172d1

TaskStatus
conda-linux-aarch64-cpu-r41Azure

This was referenced Dec 19, 2022
Closed
Merged
@h-vetinari

h-vetinari commented Dec 19, 2022

Copy link
Copy Markdown
ContributorAuthor

Success! 🥳

Well done @kou & @xhochy

xhochy
xhochy reviewed Dec 19, 2022
View reviewed changes
Comment threaddev/tasks/conda-recipes/r-arrow/build.sh Outdated
fi

export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"

@xhochyxhochyDec 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. BUILD_PREFIX is the build system, not host. It has been failing in the cross-compiling case and this change makes me suspicious whether we then link to the wrong libraries.

@koukouDec 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. This is not related to fix the R problem.
We may be able remove this line entirely. I'll try it.

@koukou changed the title GH-14993: fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda buildDec 19, 2022
@github-actions

github-actionsBot commented Dec 19, 2022

Copy link
Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.

@kou

kou commented Dec 19, 2022

Copy link
Copy Markdown
Member

@github-actions crossbow submit conda-linux--cpu-r -g r

@github-actions

github-actionsBot commented Dec 19, 2022

Copy link
Copy Markdown

Revision: f018c90

Submitted crossbow builds: ursacomputing/crossbow @ actions-5001db49ca

TaskStatus
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-install-local-minsizerelGithub Actions
test-r-library-r-base-latestAzure
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure

@h-vetinari

h-vetinari commented Dec 19, 2022

Copy link
Copy Markdown
ContributorAuthor

crossbow submit conda-linux-_-cpu-r_ -g r

is _ the placeholder here? And what's the difference between before -g and after?

Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as

crossbow submit - g conda-*-r

@kou

kou commented Dec 20, 2022

Copy link
Copy Markdown
Member

is _ the placeholder here?

_ isn't a placeholder. The real crossbow command what I used is @github-actions crossbow submit conda-linux-*-cpu-r* -g r. * is a glob pattern. If the command is processed as a Markdown text, *...* is replaced with <em>...</em>. This is the trick. :-)

And what's the difference between before -g and after?

Without -g: Find tasks from tasks: in dev/tasks/tasks.yml

With -g: Find groups from groups: in dev/tasks/tasks.yml`. Found groups are expanded to tasks.

Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as

crossbow submit - g conda-*-r

We can use @github-actions crossbow submit conda-*-r for them.

@h-vetinari

h-vetinari commented Dec 20, 2022

Copy link
Copy Markdown
ContributorAuthor

@kou, I think this would be good to merge (as all the conda builds now pass)? I have other changes lined up, but those would be better in a separate PR IMO.

@kou

kou commented Dec 20, 2022

Copy link
Copy Markdown
Member

OK. I merge this.

@kou
kou merged commit 4e9b65a into apache:masterDec 20, 2022
@h-vetinari
h-vetinari deleted the conda_ci branch December 20, 2022 03:26
@h-vetinarih-vetinari mentioned this pull request Dec 20, 2022
Closed
@ursabot

ursabot commented Dec 20, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 23a7a15 and contender = 4e9b65a. 4e9b65a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.42% ⬆️0.07%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4e9b65a4 ec2-t3-xlarge-us-east-2
[Finished] 4e9b65a4 test-mac-arm
[Finished] 4e9b65a4 ursa-i9-9960x
[Finished] 4e9b65a4 ursa-thinkcentre-m75q
[Finished] 23a7a159 ec2-t3-xlarge-us-east-2
[Finished] 23a7a159 test-mac-arm
[Finished] 23a7a159 ursa-i9-9960x
[Finished] 23a7a159 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@h-vetinarih-vetinari mentioned this pull request Jun 12, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@xhochyxhochyxhochy left review comments

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI][Conda] conda-linux-aarch64-* are failing

4 participants

@h-vetinari@xhochy@kou@ursabot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build - #15014
Merged
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Dec 20, 2022
Merged
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build#15014
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Conversation
@h-vetinari
@h-vetinarih-vetinari
commented
Dec 18, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Thanks for opening a pull request!
If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or
MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:
ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:
@h-vetinarih-vetinari
changed the title
fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: fix missing RECIPE_ROOT variable now expected by conda buildDec 18, 2022
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g conda
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: f3b77cc
Submitted crossbow builds: ursacomputing/crossbow @ actions-ccb0a7fe84
TaskStatus
conda-cleanAzure
conda-linux-aarch64-cpu-py3Azure
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-ppc64le-cpu-py3Azure
conda-linux-x64-cpu-py3Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-linux-x64-cuda-py3Azure
conda-osx-arm64-cpu-py3Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-py3Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-py3Azure
conda-win-x64-cpu-r41Azure
conda-win-x64-cuda-py3Azure
@h-vetinarih-vetinari
mentioned this pull request
Dec 18, 2022

Closed

@h-vetinari
h-vetinari
commented
Dec 18, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So, the R-builds for aarch are still failing with:
> library('arrow')
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '[...]lib/R/library/arrow/libs/arrow.so':
[...]/lib/R/library/arrow/libs/arrow.so: undefined symbol: _ZTIN5arrow17RecordBatchReaderE
Execution halted

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
CC @xhochy
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
Though on the other hand, the build.sh for r-arrow is calling straight into the top-level r/-folder:
${R} CMD INSTALL --build r/. ${R_ARGS}

so something broke there in the last couple of days. For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
CC @thisisnic
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
This is OK, arrow.so is the R module. libarrow.so is the pure C++ shared library.
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@h-vetinari This looks problematic:
2022-12-18T05:51:13.5618933Z *** Found local C++ source: '../cpp'
2022-12-18T05:51:13.5619835Z *** Building libarrow from source
2022-12-18T05:51:13.5620314Z For build options and troubleshooting, see the install guide:
2022-12-18T05:51:13.5621188Z https://arrow.apache.org/docs/r/articles/install.html
2022-12-18T05:51:13.8434741Z **** cmake
2022-12-18T05:51:18.7191251Z **** arrow 2022-12-18T05:51:20.8624297Z **** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information. 2022-12-18T05:51:21.5582869Z PKG_CFLAGS= -std=c++17
2022-12-18T05:51:21.5589264Z PKG_LIBS= 
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: 6efeeec
Submitted crossbow builds: ursacomputing/crossbow @ actions-8a6b714265
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
Oh, the change was by me. I'll look into this.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: e04c9dc
Submitted crossbow builds: ursacomputing/crossbow @ actions-297ce68126
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: b26892d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2723bac4
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
"pkg-config --cflags" may be empty
3b9c72d
For example, Apache Arrow C++ is installed in system directory.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: 3b9c72d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5e596172d1
TaskStatus
conda-linux-aarch64-cpu-r41Azure

This was referenced Dec 19, 2022

Closed

 Merged

@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
Success! 🥳
Well done @kou & @xhochy
xhochy
xhochy
reviewed
Dec 19, 2022
View reviewed changes
Comment threaddev/tasks/conda-recipes/r-arrow/build.sh
Outdated

fi

export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
@xhochyxhochyDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. BUILD_PREFIX is the build system, not host. It has been failing in the cross-compiling case and this change makes me suspicious whether we then link to the wrong libraries.
@koukouDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. This is not related to fix the R problem.

We may be able remove this line entirely. I'll try it.
@koukou
changed the title
GH-14993: fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda buildDec 19, 2022
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux--cpu-r -g r
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: f018c90
Submitted crossbow builds: ursacomputing/crossbow @ actions-5001db49ca
TaskStatus
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-install-local-minsizerelGithub Actions
test-r-library-r-base-latestAzure
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
crossbow submit conda-linux-_-cpu-r_ -g r
is _ the placeholder here? And what's the difference between before -g and after?
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
is _ the placeholder here?
_ isn't a placeholder. The real crossbow command what I used is @github-actions crossbow submit conda-linux-*-cpu-r* -g r. * is a glob pattern. If the command is processed as a Markdown text, *...* is replaced with <em>...</em>. This is the trick. :-)
And what's the difference between before -g and after?
Without -g: Find tasks from tasks: in dev/tasks/tasks.yml
With -g: Find groups from groups: in dev/tasks/tasks.yml`. Found groups are expanded to tasks.
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
We can use @github-actions crossbow submit conda-*-r for them.
@h-vetinari
h-vetinari
commented
Dec 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@kou, I think this would be good to merge (as all the conda builds now pass)? I have other changes lined up, but those would be better in a separate PR IMO.
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
OK. I merge this.
@kou
kou
merged commit 4e9b65a
into
apache:masterDec 20, 2022
@h-vetinari
h-vetinari
deleted the

conda_ci

branch
December 20, 2022 03:26
@h-vetinarih-vetinari
mentioned this pull request
Dec 20, 2022
 Closed

@ursabot
ursabot
commented
Dec 20, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 23a7a15 and contender = 4e9b65a. 4e9b65a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.42% ⬆️0.07%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.14% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4e9b65a4 ec2-t3-xlarge-us-east-2

[Finished] 4e9b65a4 test-mac-arm

[Finished] 4e9b65a4 ursa-i9-9960x

[Finished] 4e9b65a4 ursa-thinkcentre-m75q

[Finished] 23a7a159 ec2-t3-xlarge-us-east-2

[Finished] 23a7a159 test-mac-arm

[Finished] 23a7a159 ursa-i9-9960x

[Finished] 23a7a159 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@h-vetinarih-vetinari
mentioned this pull request
Jun 12, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@xhochyxhochyxhochy left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[CI][Conda] conda-linux-aarch64-* are failing


4 participants

@h-vetinari@xhochy@kou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build - #15014
Merged
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Dec 20, 2022
Merged
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build#15014
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Conversation
@h-vetinari
@h-vetinarih-vetinari
commented
Dec 18, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Thanks for opening a pull request!
If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or
MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:
ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:
@h-vetinarih-vetinari
changed the title
fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: fix missing RECIPE_ROOT variable now expected by conda buildDec 18, 2022
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g conda
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: f3b77cc
Submitted crossbow builds: ursacomputing/crossbow @ actions-ccb0a7fe84
TaskStatus
conda-cleanAzure
conda-linux-aarch64-cpu-py3Azure
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-ppc64le-cpu-py3Azure
conda-linux-x64-cpu-py3Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-linux-x64-cuda-py3Azure
conda-osx-arm64-cpu-py3Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-py3Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-py3Azure
conda-win-x64-cpu-r41Azure
conda-win-x64-cuda-py3Azure
@h-vetinarih-vetinari
mentioned this pull request
Dec 18, 2022

Closed

@h-vetinari
h-vetinari
commented
Dec 18, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So, the R-builds for aarch are still failing with:
> library('arrow')
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '[...]lib/R/library/arrow/libs/arrow.so':
[...]/lib/R/library/arrow/libs/arrow.so: undefined symbol: _ZTIN5arrow17RecordBatchReaderE
Execution halted

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
CC @xhochy
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
Though on the other hand, the build.sh for r-arrow is calling straight into the top-level r/-folder:
${R} CMD INSTALL --build r/. ${R_ARGS}

so something broke there in the last couple of days. For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
CC @thisisnic
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
This is OK, arrow.so is the R module. libarrow.so is the pure C++ shared library.
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@h-vetinari This looks problematic:
2022-12-18T05:51:13.5618933Z *** Found local C++ source: '../cpp'
2022-12-18T05:51:13.5619835Z *** Building libarrow from source
2022-12-18T05:51:13.5620314Z For build options and troubleshooting, see the install guide:
2022-12-18T05:51:13.5621188Z https://arrow.apache.org/docs/r/articles/install.html
2022-12-18T05:51:13.8434741Z **** cmake
2022-12-18T05:51:18.7191251Z **** arrow 2022-12-18T05:51:20.8624297Z **** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information. 2022-12-18T05:51:21.5582869Z PKG_CFLAGS= -std=c++17
2022-12-18T05:51:21.5589264Z PKG_LIBS= 
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: 6efeeec
Submitted crossbow builds: ursacomputing/crossbow @ actions-8a6b714265
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
Oh, the change was by me. I'll look into this.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: e04c9dc
Submitted crossbow builds: ursacomputing/crossbow @ actions-297ce68126
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: b26892d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2723bac4
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
"pkg-config --cflags" may be empty
3b9c72d
For example, Apache Arrow C++ is installed in system directory.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: 3b9c72d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5e596172d1
TaskStatus
conda-linux-aarch64-cpu-r41Azure

This was referenced Dec 19, 2022

Closed

 Merged

@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
Success! 🥳
Well done @kou & @xhochy
xhochy
xhochy
reviewed
Dec 19, 2022
View reviewed changes
Comment threaddev/tasks/conda-recipes/r-arrow/build.sh
Outdated

fi

export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
@xhochyxhochyDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. BUILD_PREFIX is the build system, not host. It has been failing in the cross-compiling case and this change makes me suspicious whether we then link to the wrong libraries.
@koukouDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. This is not related to fix the R problem.

We may be able remove this line entirely. I'll try it.
@koukou
changed the title
GH-14993: fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda buildDec 19, 2022
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux--cpu-r -g r
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: f018c90
Submitted crossbow builds: ursacomputing/crossbow @ actions-5001db49ca
TaskStatus
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-install-local-minsizerelGithub Actions
test-r-library-r-base-latestAzure
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
crossbow submit conda-linux-_-cpu-r_ -g r
is _ the placeholder here? And what's the difference between before -g and after?
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
is _ the placeholder here?
_ isn't a placeholder. The real crossbow command what I used is @github-actions crossbow submit conda-linux-*-cpu-r* -g r. * is a glob pattern. If the command is processed as a Markdown text, *...* is replaced with <em>...</em>. This is the trick. :-)
And what's the difference between before -g and after?
Without -g: Find tasks from tasks: in dev/tasks/tasks.yml
With -g: Find groups from groups: in dev/tasks/tasks.yml`. Found groups are expanded to tasks.
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
We can use @github-actions crossbow submit conda-*-r for them.
@h-vetinari
h-vetinari
commented
Dec 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@kou, I think this would be good to merge (as all the conda builds now pass)? I have other changes lined up, but those would be better in a separate PR IMO.
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
OK. I merge this.
@kou
kou
merged commit 4e9b65a
into
apache:masterDec 20, 2022
@h-vetinari
h-vetinari
deleted the

conda_ci

branch
December 20, 2022 03:26
@h-vetinarih-vetinari
mentioned this pull request
Dec 20, 2022
 Closed

@ursabot
ursabot
commented
Dec 20, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 23a7a15 and contender = 4e9b65a. 4e9b65a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.42% ⬆️0.07%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.14% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4e9b65a4 ec2-t3-xlarge-us-east-2

[Finished] 4e9b65a4 test-mac-arm

[Finished] 4e9b65a4 ursa-i9-9960x

[Finished] 4e9b65a4 ursa-thinkcentre-m75q

[Finished] 23a7a159 ec2-t3-xlarge-us-east-2

[Finished] 23a7a159 test-mac-arm

[Finished] 23a7a159 ursa-i9-9960x

[Finished] 23a7a159 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@h-vetinarih-vetinari
mentioned this pull request
Jun 12, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@xhochyxhochyxhochy left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[CI][Conda] conda-linux-aarch64-* are failing


4 participants

@h-vetinari@xhochy@kou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build - #15014
Merged
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Dec 20, 2022
Merged
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build#15014
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Conversation
@h-vetinari
@h-vetinarih-vetinari
commented
Dec 18, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Thanks for opening a pull request!
If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or
MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:
ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:
@h-vetinarih-vetinari
changed the title
fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: fix missing RECIPE_ROOT variable now expected by conda buildDec 18, 2022
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g conda
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: f3b77cc
Submitted crossbow builds: ursacomputing/crossbow @ actions-ccb0a7fe84
TaskStatus
conda-cleanAzure
conda-linux-aarch64-cpu-py3Azure
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-ppc64le-cpu-py3Azure
conda-linux-x64-cpu-py3Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-linux-x64-cuda-py3Azure
conda-osx-arm64-cpu-py3Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-py3Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-py3Azure
conda-win-x64-cpu-r41Azure
conda-win-x64-cuda-py3Azure
@h-vetinarih-vetinari
mentioned this pull request
Dec 18, 2022

Closed

@h-vetinari
h-vetinari
commented
Dec 18, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So, the R-builds for aarch are still failing with:
> library('arrow')
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '[...]lib/R/library/arrow/libs/arrow.so':
[...]/lib/R/library/arrow/libs/arrow.so: undefined symbol: _ZTIN5arrow17RecordBatchReaderE
Execution halted

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
CC @xhochy
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
Though on the other hand, the build.sh for r-arrow is calling straight into the top-level r/-folder:
${R} CMD INSTALL --build r/. ${R_ARGS}

so something broke there in the last couple of days. For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
CC @thisisnic
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
This is OK, arrow.so is the R module. libarrow.so is the pure C++ shared library.
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@h-vetinari This looks problematic:
2022-12-18T05:51:13.5618933Z *** Found local C++ source: '../cpp'
2022-12-18T05:51:13.5619835Z *** Building libarrow from source
2022-12-18T05:51:13.5620314Z For build options and troubleshooting, see the install guide:
2022-12-18T05:51:13.5621188Z https://arrow.apache.org/docs/r/articles/install.html
2022-12-18T05:51:13.8434741Z **** cmake
2022-12-18T05:51:18.7191251Z **** arrow 2022-12-18T05:51:20.8624297Z **** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information. 2022-12-18T05:51:21.5582869Z PKG_CFLAGS= -std=c++17
2022-12-18T05:51:21.5589264Z PKG_LIBS= 
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: 6efeeec
Submitted crossbow builds: ursacomputing/crossbow @ actions-8a6b714265
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
Oh, the change was by me. I'll look into this.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: e04c9dc
Submitted crossbow builds: ursacomputing/crossbow @ actions-297ce68126
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: b26892d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2723bac4
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
"pkg-config --cflags" may be empty
3b9c72d
For example, Apache Arrow C++ is installed in system directory.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: 3b9c72d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5e596172d1
TaskStatus
conda-linux-aarch64-cpu-r41Azure

This was referenced Dec 19, 2022

Closed

 Merged

@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
Success! 🥳
Well done @kou & @xhochy
xhochy
xhochy
reviewed
Dec 19, 2022
View reviewed changes
Comment threaddev/tasks/conda-recipes/r-arrow/build.sh
Outdated

fi

export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
@xhochyxhochyDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. BUILD_PREFIX is the build system, not host. It has been failing in the cross-compiling case and this change makes me suspicious whether we then link to the wrong libraries.
@koukouDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. This is not related to fix the R problem.

We may be able remove this line entirely. I'll try it.
@koukou
changed the title
GH-14993: fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda buildDec 19, 2022
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux--cpu-r -g r
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: f018c90
Submitted crossbow builds: ursacomputing/crossbow @ actions-5001db49ca
TaskStatus
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-install-local-minsizerelGithub Actions
test-r-library-r-base-latestAzure
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
crossbow submit conda-linux-_-cpu-r_ -g r
is _ the placeholder here? And what's the difference between before -g and after?
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
is _ the placeholder here?
_ isn't a placeholder. The real crossbow command what I used is @github-actions crossbow submit conda-linux-*-cpu-r* -g r. * is a glob pattern. If the command is processed as a Markdown text, *...* is replaced with <em>...</em>. This is the trick. :-)
And what's the difference between before -g and after?
Without -g: Find tasks from tasks: in dev/tasks/tasks.yml
With -g: Find groups from groups: in dev/tasks/tasks.yml`. Found groups are expanded to tasks.
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
We can use @github-actions crossbow submit conda-*-r for them.
@h-vetinari
h-vetinari
commented
Dec 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@kou, I think this would be good to merge (as all the conda builds now pass)? I have other changes lined up, but those would be better in a separate PR IMO.
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
OK. I merge this.
@kou
kou
merged commit 4e9b65a
into
apache:masterDec 20, 2022
@h-vetinari
h-vetinari
deleted the

conda_ci

branch
December 20, 2022 03:26
@h-vetinarih-vetinari
mentioned this pull request
Dec 20, 2022
 Closed

@ursabot
ursabot
commented
Dec 20, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 23a7a15 and contender = 4e9b65a. 4e9b65a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.42% ⬆️0.07%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.14% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4e9b65a4 ec2-t3-xlarge-us-east-2

[Finished] 4e9b65a4 test-mac-arm

[Finished] 4e9b65a4 ursa-i9-9960x

[Finished] 4e9b65a4 ursa-thinkcentre-m75q

[Finished] 23a7a159 ec2-t3-xlarge-us-east-2

[Finished] 23a7a159 test-mac-arm

[Finished] 23a7a159 ursa-i9-9960x

[Finished] 23a7a159 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@h-vetinarih-vetinari
mentioned this pull request
Jun 12, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@xhochyxhochyxhochy left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[CI][Conda] conda-linux-aarch64-* are failing


4 participants

@h-vetinari@xhochy@kou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build - #15014
Merged
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Dec 20, 2022
Merged
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build#15014
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Conversation
@h-vetinari
@h-vetinarih-vetinari
commented
Dec 18, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Thanks for opening a pull request!
If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or
MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:
ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:
@h-vetinarih-vetinari
changed the title
fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: fix missing RECIPE_ROOT variable now expected by conda buildDec 18, 2022
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g conda
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: f3b77cc
Submitted crossbow builds: ursacomputing/crossbow @ actions-ccb0a7fe84
TaskStatus
conda-cleanAzure
conda-linux-aarch64-cpu-py3Azure
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-ppc64le-cpu-py3Azure
conda-linux-x64-cpu-py3Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-linux-x64-cuda-py3Azure
conda-osx-arm64-cpu-py3Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-py3Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-py3Azure
conda-win-x64-cpu-r41Azure
conda-win-x64-cuda-py3Azure
@h-vetinarih-vetinari
mentioned this pull request
Dec 18, 2022

Closed

@h-vetinari
h-vetinari
commented
Dec 18, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So, the R-builds for aarch are still failing with:
> library('arrow')
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '[...]lib/R/library/arrow/libs/arrow.so':
[...]/lib/R/library/arrow/libs/arrow.so: undefined symbol: _ZTIN5arrow17RecordBatchReaderE
Execution halted

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
CC @xhochy
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
Though on the other hand, the build.sh for r-arrow is calling straight into the top-level r/-folder:
${R} CMD INSTALL --build r/. ${R_ARGS}

so something broke there in the last couple of days. For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
CC @thisisnic
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
This is OK, arrow.so is the R module. libarrow.so is the pure C++ shared library.
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@h-vetinari This looks problematic:
2022-12-18T05:51:13.5618933Z *** Found local C++ source: '../cpp'
2022-12-18T05:51:13.5619835Z *** Building libarrow from source
2022-12-18T05:51:13.5620314Z For build options and troubleshooting, see the install guide:
2022-12-18T05:51:13.5621188Z https://arrow.apache.org/docs/r/articles/install.html
2022-12-18T05:51:13.8434741Z **** cmake
2022-12-18T05:51:18.7191251Z **** arrow 2022-12-18T05:51:20.8624297Z **** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information. 2022-12-18T05:51:21.5582869Z PKG_CFLAGS= -std=c++17
2022-12-18T05:51:21.5589264Z PKG_LIBS= 
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: 6efeeec
Submitted crossbow builds: ursacomputing/crossbow @ actions-8a6b714265
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
Oh, the change was by me. I'll look into this.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: e04c9dc
Submitted crossbow builds: ursacomputing/crossbow @ actions-297ce68126
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: b26892d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2723bac4
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
"pkg-config --cflags" may be empty
3b9c72d
For example, Apache Arrow C++ is installed in system directory.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: 3b9c72d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5e596172d1
TaskStatus
conda-linux-aarch64-cpu-r41Azure

This was referenced Dec 19, 2022

Closed

 Merged

@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
Success! 🥳
Well done @kou & @xhochy
xhochy
xhochy
reviewed
Dec 19, 2022
View reviewed changes
Comment threaddev/tasks/conda-recipes/r-arrow/build.sh
Outdated

fi

export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
@xhochyxhochyDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. BUILD_PREFIX is the build system, not host. It has been failing in the cross-compiling case and this change makes me suspicious whether we then link to the wrong libraries.
@koukouDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. This is not related to fix the R problem.

We may be able remove this line entirely. I'll try it.
@koukou
changed the title
GH-14993: fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda buildDec 19, 2022
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux--cpu-r -g r
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: f018c90
Submitted crossbow builds: ursacomputing/crossbow @ actions-5001db49ca
TaskStatus
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-install-local-minsizerelGithub Actions
test-r-library-r-base-latestAzure
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
crossbow submit conda-linux-_-cpu-r_ -g r
is _ the placeholder here? And what's the difference between before -g and after?
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
is _ the placeholder here?
_ isn't a placeholder. The real crossbow command what I used is @github-actions crossbow submit conda-linux-*-cpu-r* -g r. * is a glob pattern. If the command is processed as a Markdown text, *...* is replaced with <em>...</em>. This is the trick. :-)
And what's the difference between before -g and after?
Without -g: Find tasks from tasks: in dev/tasks/tasks.yml
With -g: Find groups from groups: in dev/tasks/tasks.yml`. Found groups are expanded to tasks.
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
We can use @github-actions crossbow submit conda-*-r for them.
@h-vetinari
h-vetinari
commented
Dec 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@kou, I think this would be good to merge (as all the conda builds now pass)? I have other changes lined up, but those would be better in a separate PR IMO.
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
OK. I merge this.
@kou
kou
merged commit 4e9b65a
into
apache:masterDec 20, 2022
@h-vetinari
h-vetinari
deleted the

conda_ci

branch
December 20, 2022 03:26
@h-vetinarih-vetinari
mentioned this pull request
Dec 20, 2022
 Closed

@ursabot
ursabot
commented
Dec 20, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 23a7a15 and contender = 4e9b65a. 4e9b65a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.42% ⬆️0.07%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.14% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4e9b65a4 ec2-t3-xlarge-us-east-2

[Finished] 4e9b65a4 test-mac-arm

[Finished] 4e9b65a4 ursa-i9-9960x

[Finished] 4e9b65a4 ursa-thinkcentre-m75q

[Finished] 23a7a159 ec2-t3-xlarge-us-east-2

[Finished] 23a7a159 test-mac-arm

[Finished] 23a7a159 ursa-i9-9960x

[Finished] 23a7a159 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@h-vetinarih-vetinari
mentioned this pull request
Jun 12, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@xhochyxhochyxhochy left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[CI][Conda] conda-linux-aarch64-* are failing


4 participants

@h-vetinari@xhochy@kou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build - #15014
Merged
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Dec 20, 2022
Merged
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build#15014
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Conversation
@h-vetinari
@h-vetinarih-vetinari
commented
Dec 18, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Thanks for opening a pull request!
If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or
MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:
ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:
@h-vetinarih-vetinari
changed the title
fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: fix missing RECIPE_ROOT variable now expected by conda buildDec 18, 2022
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g conda
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: f3b77cc
Submitted crossbow builds: ursacomputing/crossbow @ actions-ccb0a7fe84
TaskStatus
conda-cleanAzure
conda-linux-aarch64-cpu-py3Azure
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-ppc64le-cpu-py3Azure
conda-linux-x64-cpu-py3Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-linux-x64-cuda-py3Azure
conda-osx-arm64-cpu-py3Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-py3Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-py3Azure
conda-win-x64-cpu-r41Azure
conda-win-x64-cuda-py3Azure
@h-vetinarih-vetinari
mentioned this pull request
Dec 18, 2022

Closed

@h-vetinari
h-vetinari
commented
Dec 18, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So, the R-builds for aarch are still failing with:
> library('arrow')
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '[...]lib/R/library/arrow/libs/arrow.so':
[...]/lib/R/library/arrow/libs/arrow.so: undefined symbol: _ZTIN5arrow17RecordBatchReaderE
Execution halted

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
CC @xhochy
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
Though on the other hand, the build.sh for r-arrow is calling straight into the top-level r/-folder:
${R} CMD INSTALL --build r/. ${R_ARGS}

so something broke there in the last couple of days. For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
CC @thisisnic
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
This is OK, arrow.so is the R module. libarrow.so is the pure C++ shared library.
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@h-vetinari This looks problematic:
2022-12-18T05:51:13.5618933Z *** Found local C++ source: '../cpp'
2022-12-18T05:51:13.5619835Z *** Building libarrow from source
2022-12-18T05:51:13.5620314Z For build options and troubleshooting, see the install guide:
2022-12-18T05:51:13.5621188Z https://arrow.apache.org/docs/r/articles/install.html
2022-12-18T05:51:13.8434741Z **** cmake
2022-12-18T05:51:18.7191251Z **** arrow 2022-12-18T05:51:20.8624297Z **** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information. 2022-12-18T05:51:21.5582869Z PKG_CFLAGS= -std=c++17
2022-12-18T05:51:21.5589264Z PKG_LIBS= 
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: 6efeeec
Submitted crossbow builds: ursacomputing/crossbow @ actions-8a6b714265
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
Oh, the change was by me. I'll look into this.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: e04c9dc
Submitted crossbow builds: ursacomputing/crossbow @ actions-297ce68126
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: b26892d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2723bac4
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
"pkg-config --cflags" may be empty
3b9c72d
For example, Apache Arrow C++ is installed in system directory.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: 3b9c72d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5e596172d1
TaskStatus
conda-linux-aarch64-cpu-r41Azure

This was referenced Dec 19, 2022

Closed

 Merged

@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
Success! 🥳
Well done @kou & @xhochy
xhochy
xhochy
reviewed
Dec 19, 2022
View reviewed changes
Comment threaddev/tasks/conda-recipes/r-arrow/build.sh
Outdated

fi

export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
@xhochyxhochyDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. BUILD_PREFIX is the build system, not host. It has been failing in the cross-compiling case and this change makes me suspicious whether we then link to the wrong libraries.
@koukouDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. This is not related to fix the R problem.

We may be able remove this line entirely. I'll try it.
@koukou
changed the title
GH-14993: fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda buildDec 19, 2022
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux--cpu-r -g r
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: f018c90
Submitted crossbow builds: ursacomputing/crossbow @ actions-5001db49ca
TaskStatus
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-install-local-minsizerelGithub Actions
test-r-library-r-base-latestAzure
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
crossbow submit conda-linux-_-cpu-r_ -g r
is _ the placeholder here? And what's the difference between before -g and after?
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
is _ the placeholder here?
_ isn't a placeholder. The real crossbow command what I used is @github-actions crossbow submit conda-linux-*-cpu-r* -g r. * is a glob pattern. If the command is processed as a Markdown text, *...* is replaced with <em>...</em>. This is the trick. :-)
And what's the difference between before -g and after?
Without -g: Find tasks from tasks: in dev/tasks/tasks.yml
With -g: Find groups from groups: in dev/tasks/tasks.yml`. Found groups are expanded to tasks.
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
We can use @github-actions crossbow submit conda-*-r for them.
@h-vetinari
h-vetinari
commented
Dec 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@kou, I think this would be good to merge (as all the conda builds now pass)? I have other changes lined up, but those would be better in a separate PR IMO.
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
OK. I merge this.
@kou
kou
merged commit 4e9b65a
into
apache:masterDec 20, 2022
@h-vetinari
h-vetinari
deleted the

conda_ci

branch
December 20, 2022 03:26
@h-vetinarih-vetinari
mentioned this pull request
Dec 20, 2022
 Closed

@ursabot
ursabot
commented
Dec 20, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 23a7a15 and contender = 4e9b65a. 4e9b65a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.42% ⬆️0.07%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.14% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4e9b65a4 ec2-t3-xlarge-us-east-2

[Finished] 4e9b65a4 test-mac-arm

[Finished] 4e9b65a4 ursa-i9-9960x

[Finished] 4e9b65a4 ursa-thinkcentre-m75q

[Finished] 23a7a159 ec2-t3-xlarge-us-east-2

[Finished] 23a7a159 test-mac-arm

[Finished] 23a7a159 ursa-i9-9960x

[Finished] 23a7a159 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@h-vetinarih-vetinari
mentioned this pull request
Jun 12, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@xhochyxhochyxhochy left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[CI][Conda] conda-linux-aarch64-* are failing


4 participants

@h-vetinari@xhochy@kou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build - #15014
Merged
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Dec 20, 2022
Merged
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build#15014
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Conversation
@h-vetinari
@h-vetinarih-vetinari
commented
Dec 18, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Thanks for opening a pull request!
If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or
MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:
ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:
@h-vetinarih-vetinari
changed the title
fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: fix missing RECIPE_ROOT variable now expected by conda buildDec 18, 2022
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g conda
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: f3b77cc
Submitted crossbow builds: ursacomputing/crossbow @ actions-ccb0a7fe84
TaskStatus
conda-cleanAzure
conda-linux-aarch64-cpu-py3Azure
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-ppc64le-cpu-py3Azure
conda-linux-x64-cpu-py3Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-linux-x64-cuda-py3Azure
conda-osx-arm64-cpu-py3Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-py3Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-py3Azure
conda-win-x64-cpu-r41Azure
conda-win-x64-cuda-py3Azure
@h-vetinarih-vetinari
mentioned this pull request
Dec 18, 2022

Closed

@h-vetinari
h-vetinari
commented
Dec 18, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So, the R-builds for aarch are still failing with:
> library('arrow')
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '[...]lib/R/library/arrow/libs/arrow.so':
[...]/lib/R/library/arrow/libs/arrow.so: undefined symbol: _ZTIN5arrow17RecordBatchReaderE
Execution halted

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
CC @xhochy
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
Though on the other hand, the build.sh for r-arrow is calling straight into the top-level r/-folder:
${R} CMD INSTALL --build r/. ${R_ARGS}

so something broke there in the last couple of days. For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
CC @thisisnic
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
This is OK, arrow.so is the R module. libarrow.so is the pure C++ shared library.
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@h-vetinari This looks problematic:
2022-12-18T05:51:13.5618933Z *** Found local C++ source: '../cpp'
2022-12-18T05:51:13.5619835Z *** Building libarrow from source
2022-12-18T05:51:13.5620314Z For build options and troubleshooting, see the install guide:
2022-12-18T05:51:13.5621188Z https://arrow.apache.org/docs/r/articles/install.html
2022-12-18T05:51:13.8434741Z **** cmake
2022-12-18T05:51:18.7191251Z **** arrow 2022-12-18T05:51:20.8624297Z **** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information. 2022-12-18T05:51:21.5582869Z PKG_CFLAGS= -std=c++17
2022-12-18T05:51:21.5589264Z PKG_LIBS= 
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: 6efeeec
Submitted crossbow builds: ursacomputing/crossbow @ actions-8a6b714265
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
Oh, the change was by me. I'll look into this.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: e04c9dc
Submitted crossbow builds: ursacomputing/crossbow @ actions-297ce68126
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: b26892d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2723bac4
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
"pkg-config --cflags" may be empty
3b9c72d
For example, Apache Arrow C++ is installed in system directory.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: 3b9c72d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5e596172d1
TaskStatus
conda-linux-aarch64-cpu-r41Azure

This was referenced Dec 19, 2022

Closed

 Merged

@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
Success! 🥳
Well done @kou & @xhochy
xhochy
xhochy
reviewed
Dec 19, 2022
View reviewed changes
Comment threaddev/tasks/conda-recipes/r-arrow/build.sh
Outdated

fi

export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
@xhochyxhochyDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. BUILD_PREFIX is the build system, not host. It has been failing in the cross-compiling case and this change makes me suspicious whether we then link to the wrong libraries.
@koukouDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. This is not related to fix the R problem.

We may be able remove this line entirely. I'll try it.
@koukou
changed the title
GH-14993: fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda buildDec 19, 2022
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux--cpu-r -g r
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: f018c90
Submitted crossbow builds: ursacomputing/crossbow @ actions-5001db49ca
TaskStatus
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-install-local-minsizerelGithub Actions
test-r-library-r-base-latestAzure
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
crossbow submit conda-linux-_-cpu-r_ -g r
is _ the placeholder here? And what's the difference between before -g and after?
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
is _ the placeholder here?
_ isn't a placeholder. The real crossbow command what I used is @github-actions crossbow submit conda-linux-*-cpu-r* -g r. * is a glob pattern. If the command is processed as a Markdown text, *...* is replaced with <em>...</em>. This is the trick. :-)
And what's the difference between before -g and after?
Without -g: Find tasks from tasks: in dev/tasks/tasks.yml
With -g: Find groups from groups: in dev/tasks/tasks.yml`. Found groups are expanded to tasks.
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
We can use @github-actions crossbow submit conda-*-r for them.
@h-vetinari
h-vetinari
commented
Dec 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@kou, I think this would be good to merge (as all the conda builds now pass)? I have other changes lined up, but those would be better in a separate PR IMO.
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
OK. I merge this.
@kou
kou
merged commit 4e9b65a
into
apache:masterDec 20, 2022
@h-vetinari
h-vetinari
deleted the

conda_ci

branch
December 20, 2022 03:26
@h-vetinarih-vetinari
mentioned this pull request
Dec 20, 2022
 Closed

@ursabot
ursabot
commented
Dec 20, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 23a7a15 and contender = 4e9b65a. 4e9b65a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.42% ⬆️0.07%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.14% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4e9b65a4 ec2-t3-xlarge-us-east-2

[Finished] 4e9b65a4 test-mac-arm

[Finished] 4e9b65a4 ursa-i9-9960x

[Finished] 4e9b65a4 ursa-thinkcentre-m75q

[Finished] 23a7a159 ec2-t3-xlarge-us-east-2

[Finished] 23a7a159 test-mac-arm

[Finished] 23a7a159 ursa-i9-9960x

[Finished] 23a7a159 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@h-vetinarih-vetinari
mentioned this pull request
Jun 12, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@xhochyxhochyxhochy left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[CI][Conda] conda-linux-aarch64-* are failing


4 participants

@h-vetinari@xhochy@kou@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build - #15014
Merged
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Dec 20, 2022
Merged
GH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda build#15014
kou merged 6 commits into
apache:masterfrom 
h-vetinari:conda_ci
Conversation
@h-vetinari
@h-vetinarih-vetinari
commented
Dec 18, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Thanks for opening a pull request!
If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or
MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:
ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:
@h-vetinarih-vetinari
changed the title
fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: fix missing RECIPE_ROOT variable now expected by conda buildDec 18, 2022
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g conda
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: f3b77cc
Submitted crossbow builds: ursacomputing/crossbow @ actions-ccb0a7fe84
TaskStatus
conda-cleanAzure
conda-linux-aarch64-cpu-py3Azure
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-ppc64le-cpu-py3Azure
conda-linux-x64-cpu-py3Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-linux-x64-cuda-py3Azure
conda-osx-arm64-cpu-py3Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-py3Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-py3Azure
conda-win-x64-cpu-r41Azure
conda-win-x64-cuda-py3Azure
@h-vetinarih-vetinari
mentioned this pull request
Dec 18, 2022

Closed

@h-vetinari
h-vetinari
commented
Dec 18, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So, the R-builds for aarch are still failing with:
> library('arrow')
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '[...]lib/R/library/arrow/libs/arrow.so':
[...]/lib/R/library/arrow/libs/arrow.so: undefined symbol: _ZTIN5arrow17RecordBatchReaderE
Execution halted

I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
CC @xhochy
@h-vetinari
h-vetinari
commented
Dec 18, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
Though on the other hand, the build.sh for r-arrow is calling straight into the top-level r/-folder:
${R} CMD INSTALL --build r/. ${R_ARGS}

so something broke there in the last couple of days. For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
CC @thisisnic
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
I don't understand why this is looking for arrow.so instead of libarrow.so - the recipe hasn't changed.
This is OK, arrow.so is the R module. libarrow.so is the pure C++ shared library.
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@h-vetinari This looks problematic:
2022-12-18T05:51:13.5618933Z *** Found local C++ source: '../cpp'
2022-12-18T05:51:13.5619835Z *** Building libarrow from source
2022-12-18T05:51:13.5620314Z For build options and troubleshooting, see the install guide:
2022-12-18T05:51:13.5621188Z https://arrow.apache.org/docs/r/articles/install.html
2022-12-18T05:51:13.8434741Z **** cmake
2022-12-18T05:51:18.7191251Z **** arrow 2022-12-18T05:51:20.8624297Z **** Error building Arrow C++. Re-run with ARROW_R_DEV=true for debug information. 2022-12-18T05:51:21.5582869Z PKG_CFLAGS= -std=c++17
2022-12-18T05:51:21.5589264Z PKG_LIBS= 
@xhochy
xhochy
commented
Dec 18, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 18, 2022

Copy link


Copy Markdown

Revision: 6efeeec
Submitted crossbow builds: ursacomputing/crossbow @ actions-8a6b714265
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
For example, dca8c07 changed r/configure quite a bit, which could explain why now the libs are being built differently or not linked correctly anymore.
Oh, the change was by me. I'll look into this.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: e04c9dc
Submitted crossbow builds: ursacomputing/crossbow @ actions-297ce68126
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: b26892d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2723bac4
TaskStatus
conda-linux-aarch64-cpu-r41Azure
@kou
"pkg-config --cflags" may be empty
3b9c72d
For example, Apache Arrow C++ is installed in system directory.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux-aarch64-cpu-r41
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: 3b9c72d
Submitted crossbow builds: ursacomputing/crossbow @ actions-5e596172d1
TaskStatus
conda-linux-aarch64-cpu-r41Azure

This was referenced Dec 19, 2022

Closed

 Merged

@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
Success! 🥳
Well done @kou & @xhochy
xhochy
xhochy
reviewed
Dec 19, 2022
View reviewed changes
Comment threaddev/tasks/conda-recipes/r-arrow/build.sh
Outdated

fi

export PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
@xhochyxhochyDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. BUILD_PREFIX is the build system, not host. It has been failing in the cross-compiling case and this change makes me suspicious whether we then link to the wrong libraries.
@koukouDec 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. This is not related to fix the R problem.

We may be able remove this line entirely. I'll try it.
@koukou
changed the title
GH-14993: fix missing RECIPE_ROOT variable now expected by conda buildGH-14993: [CI][Conda] Fix missing RECIPE_ROOT variable now expected by conda buildDec 19, 2022
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

⚠️ GitHub issue #14993has been automatically assigned in GitHub to PR creator.
@kou
kou
commented
Dec 19, 2022

Copy link


Copy Markdown

Member
@github-actions crossbow submit conda-linux--cpu-r -g r
@github-actions
github-actionsBot
commented
Dec 19, 2022

Copy link


Copy Markdown

Revision: f018c90
Submitted crossbow builds: ursacomputing/crossbow @ actions-5001db49ca
TaskStatus
conda-linux-aarch64-cpu-r41Azure
conda-linux-aarch64-cpu-r42Azure
conda-linux-x64-cpu-r41Azure
conda-linux-x64-cpu-r42Azure
conda-osx-arm64-cpu-r41Azure
conda-osx-arm64-cpu-r42Azure
conda-osx-x64-cpu-r41Azure
conda-osx-x64-cpu-r42Azure
conda-win-x64-cpu-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-install-local-minsizerelGithub Actions
test-r-library-r-base-latestAzure
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@h-vetinari
h-vetinari
commented
Dec 19, 2022

Copy link


Copy Markdown

ContributorAuthor
crossbow submit conda-linux-_-cpu-r_ -g r
is _ the placeholder here? And what's the difference between before -g and after?
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
is _ the placeholder here?
_ isn't a placeholder. The real crossbow command what I used is @github-actions crossbow submit conda-linux-*-cpu-r* -g r. * is a glob pattern. If the command is processed as a Markdown text, *...* is replaced with <em>...</em>. This is the trick. :-)
And what's the difference between before -g and after?
Without -g: Find tasks from tasks: in dev/tasks/tasks.yml
With -g: Find groups from groups: in dev/tasks/tasks.yml`. Found groups are expanded to tasks.
Extrapolating from crossbow submit -g conda, I would have naïvely expected to be able to run all conda-r builds as
crossbow submit - g conda-*-r
We can use @github-actions crossbow submit conda-*-r for them.
@h-vetinari
h-vetinari
commented
Dec 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@kou, I think this would be good to merge (as all the conda builds now pass)? I have other changes lined up, but those would be better in a separate PR IMO.
@kou
kou
commented
Dec 20, 2022

Copy link


Copy Markdown

Member
OK. I merge this.
@kou
kou
merged commit 4e9b65a
into
apache:masterDec 20, 2022
@h-vetinari
h-vetinari
deleted the

conda_ci

branch
December 20, 2022 03:26
@h-vetinarih-vetinari
mentioned this pull request
Dec 20, 2022
 Closed

@ursabot
ursabot
commented
Dec 20, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 23a7a15 and contender = 4e9b65a. 4e9b65a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.42% ⬆️0.07%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.14% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4e9b65a4 ec2-t3-xlarge-us-east-2

[Finished] 4e9b65a4 test-mac-arm

[Finished] 4e9b65a4 ursa-i9-9960x

[Finished] 4e9b65a4 ursa-thinkcentre-m75q

[Finished] 23a7a159 ec2-t3-xlarge-us-east-2

[Finished] 23a7a159 test-mac-arm

[Finished] 23a7a159 ursa-i9-9960x

[Finished] 23a7a159 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@h-vetinarih-vetinari
mentioned this pull request
Jun 12, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@xhochyxhochyxhochy left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[CI][Conda] conda-linux-aarch64-* are failing


4 participants

@h-vetinari@xhochy@kou@ursabot