Skip to content

ARROW-2214: [JS] add nullBitmap getter to DictionaryData that proxies to its indices' nullBitmap - #1659

Closed
trxcllnt wants to merge 1 commit into
apache:masterfrom
trxcllnt:ARROW-2214
Closed

ARROW-2214: [JS] add nullBitmap getter to DictionaryData that proxies to its indices' nullBitmap#1659
trxcllnt wants to merge 1 commit into
apache:masterfrom
trxcllnt:ARROW-2214

Conversation

@trxcllnt

Copy link
Copy Markdown
Contributor

@xhochyxhochy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@trxcllnt
trxcllnt deleted the ARROW-2214 branch February 26, 2018 13:18
@nmichaud

Copy link
Copy Markdown

Was this actually merged?

@xhochy

Copy link
Copy Markdown
Member

@nmichaud yes this is merged as a squashed commit in 27d8339 As there was no merge commit, this does look different in the GitHub UI

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@trxcllnt@nmichaud@xhochy