Uh oh!
There was an error while loading. Please reload this page.
ARROW-1491: [C++] Add casting from strings to numbers and booleans - #2362
ARROW-1491: [C++] Add casting from strings to numbers and booleans#2362pitrou wants to merge 3 commits into
Conversation
Codecov Report
@@ Coverage Diff @@## master #2362 +/- ##
==========================================
+ Coverage 84.66% 86.87% +2.21%
==========================================
Files 293 237 -56 Lines 45324 42705 -2619 ==========================================
- Hits 38372 37099 -1273 + Misses 6911 5606 -1305 + Partials 41 0 -41Continue to review full report at Codecov.
|
433f513 to
79cc17aCompareThere was a problem hiding this comment.
I sometimes wonder what the meeting was like that decided names like this.
There was a problem hiding this comment.
Can we make this a little more readable by use tolower?
wesm
left a comment
There was a problem hiding this comment.
Thanks for this. Made a small comment about reusing type traits but otherwise OK by me
There was a problem hiding this comment.
You could use enable_if_number<O> here from arrow/type_traits.h
79cc17a to
4ce3000Comparepitrou
commented
Aug 6, 2018
Some weird failure occurred on the AppVeyor build that didn't occur on my AppVeyor account: |
4ce3000 to
3297aa1Comparepitrou
commented
Aug 6, 2018
I want to make sure the AppVeyor failure was sporadic so I've triggered another build by pushing again. |
The implementation for numbers uses the C standard strto* functions. This makes casting a bit lenient (it will accept whitespace).
3297aa1 to
c7db1b0Comparewesm
commented
Aug 6, 2018
rebased |
The implementation for numbers uses C++
istringstream. This makes casting a bit lenient (it will probably accept whitespace).This is a rewrite of #1387