Uh oh!
There was an error while loading. Please reload this page.
ARROW-1949: [Python/C++] Add option to Array.from_pandas and pyarrow.array to perform unsafe casts - #2497
Closed
kszucs wants to merge 6 commits into
Closed
ARROW-1949: [Python/C++] Add option to Array.from_pandas and pyarrow.array to perform unsafe casts#2497kszucs wants to merge 6 commits into
kszucs wants to merge 6 commits into
Conversation
kszucs
commented
Sep 1, 2018
| DataType type, | ||
| CMemoryPool* pool, c_bool from_pandas): | ||
| DataType type, CMemoryPool* pool, c_bool from_pandas, | ||
| c_bool safe): |
MemberAuthor
There was a problem hiding this comment.
TODO: Implementation is missing from here
MemberAuthor
There was a problem hiding this comment.
ConvertPySequence assumes strict conversion if datatype is explicitly passed.
codecov-io
commented
Sep 2, 2018
Codecov Report
@@ Coverage Diff @@## master #2497 +/- ##
==========================================
+ Coverage 86.17% 87.44% +1.27%
==========================================
Files 308 246 -62 Lines 47102 43433 -3669 ==========================================
- Hits 40589 37980 -2609 + Misses 6439 5453 -986 + Partials 74 0 -74
Continue to review full report at Codecov.
|
kszucs
commented
Sep 4, 2018
MemberAuthor
Thanks Uwe! |
wesm pushed a commit
that referenced
this pull request
Sep 8, 2018
…safe casts Depends on both #2497 and #2503 Author: Krisztián Szűcs <szucs.krisztian@gmail.com> Closes#2504 from kszucs/ARROW-2799 and squashes the following commits: 7bf9efd <Krisztián Szűcs> unsafe table creation during parquet dataset partitioning 38dfea3 <Krisztián Szűcs> disallow float truncation by default 515a393 <Krisztián Szűcs> Table.from_pandas safe option 2c82074 <Krisztián Szűcs> check-format 80e1478 <Krisztián Szűcs> lint e0838ce <Krisztián Szűcs> wire CastOptions through the API 2961094 <Krisztián Szűcs> set allow_float_truncate true by default 194e476 <Krisztián Szűcs> allow truncate float option and its implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.