Uh oh!
There was an error while loading. Please reload this page.
PARQUET-1300: [C++] Implement encrypted Parquet read and write support - #2555
PARQUET-1300: [C++] Implement encrypted Parquet read and write support#2555thamht4190 wants to merge 125 commits into
Conversation
wesm
commented
Sep 17, 2018
Plan to get the examples migrated this week. Will also review this patch when I can. @ggershinsky@majetideepak there may have been some unaddressed comments from the parquet-cpp PR, so some additional review may be necessary |
nguoithichkhampha
commented
Oct 23, 2018
@wesm@ggershinsky@majetideepak . Can you help us review this code ? We are planing to use this feature on our product. We want to make sure the file which is generated by C++ code can decrypt by java code. |
ggershinsky
commented
Oct 23, 2018
@nguoithichkhampha The encryption design is currently being voted by the community. The process seems to be converging, but it is not over yet. Once the design is signed off, we'll resume the work on Java and C++ versions. Today, the C++ lags behind a bit, as there were recent changes in the spec and Java code (eg support for legacy readers). I keep the track of these - after the voting is finished, I'll get in touch with @thamht4190 and other C++ community members to get this going. |
nguoithichkhampha
commented
Oct 23, 2018
@ggershinsky , thanks for quick reply. Can you please tell me the moment will have final design for encryption ? |
ggershinsky
commented
Oct 23, 2018
@nguoithichkhampha , no problem, our timezones are not that different :). |
4d24209 to
9844b98Comparemajetideepak
commented
Jan 28, 2019
This PR needs to be rebased. @thamht4190 do you want to do this? |
thamht4190
commented
Jan 28, 2019
Yes, I'll do it @majetideepak |
ggershinsky
commented
Jan 29, 2019
@thamht4190 I've updated the crypto package to match the signed-off specification. Please check out the changes at |
0c5a7aa to
ba984eaComparethamht4190
commented
Jan 31, 2019
Thanks @ggershinsky. I've just pushed my code change to adapt your change at #3520. |
67bcd1f to
cef9dafCompare061624f to
cef9dafCompare70ee283 to
603eefaCompareggershinsky
commented
Jul 8, 2019
@thamht4190 , thanks for handling the rebase. |
thamht4190
commented
Jul 9, 2019
@wes@majetideepak since this pull has grown too much, should I close it and open a fresh one from the same branch? |
wesm
commented
Jul 9, 2019
Yes, can you open a new PR so I can review again with less GitHub UI lag? Thanks |
thamht4190
commented
Jul 9, 2019
Thanks @wesm. Will do it now. |
I've just move from patch from apache/parquet-cpp PR #475 with @wesm's great help. Will update CMakeLists.txt and example for encryption later.