Skip to content

ARROW-3925: [Python] Add autoconf to conda install instructions - #2836

Closed
fjetter wants to merge 5 commits into
apache:masterfrom
fjetter:patch-1
Closed

ARROW-3925: [Python] Add autoconf to conda install instructions#2836
fjetter wants to merge 5 commits into
apache:masterfrom
fjetter:patch-1

Conversation

@fjetter

Copy link
Copy Markdown
Contributor

autoconf is required by the jemalloc build

@kszucs

kszucs commented Oct 25, 2018

Copy link
Copy Markdown
Member

On long term we might want to prefer:

conda create -y -n pyarrow-dev -c conda-forge
--file arrow/ci/conda_env_cpp.yml
--file arrow/ci/conda_env_python.yml
python=3.6

which will be tested by the docker containers.

Comment threadpython/doc/source/development.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jemalloc is not needed anymore

@fjetter

Copy link
Copy Markdown
ContributorAuthor

There are cases for packages which I would like to install via conda, e.g. autoconf which are installed by the docker containers using apt-get. What should our approach be in these cases?

  1. Add autoconf to the conda_env_cpp.yml and install it twice in the docker container?
  2. Add autoconf to the conda_env_cpp.yml but don't install it using apt-get?
  3. Don't put it in the file but on the cmd line, e.g. conda create -n pyarrow-dev autoconf --file ...?

@kszucs Do you have any preferences?

@kszucs

Copy link
Copy Markdown
Member

@fjetter nice summary :) Go with the second.

@wesm

wesm commented Nov 9, 2018

Copy link
Copy Markdown
Member

@fjetter ping on this

@kszucs

Copy link
Copy Markdown
Member

@wesm I'll finalize this PR.

What do You think about using

conda create -y -n pyarrow-dev -c conda-forge
--file arrow/ci/conda_env_cpp.yml
--file arrow/ci/conda_env_python.yml
python=3.6

in the development documentation?

@wesm

wesm commented Nov 10, 2018

Copy link
Copy Markdown
Member

That's fine with me. Fewer things to maintain

@wesm

wesm commented Nov 10, 2018

Copy link
Copy Markdown
Member

May have to use backslashes in the Windows version :)

@wesm

wesm commented Nov 16, 2018

Copy link
Copy Markdown
Member

Pinging about this

@kszucs

kszucs commented Nov 16, 2018

Copy link
Copy Markdown
Member

@wesm pong

Dockerfile works cpp tests pass, pyarrow-dev install instruction works and pyarrow compiles (on OSX)

@kszucs
kszucs requested a review from wesmNovember 20, 2018 15:33
Comment threadpython/doc/source/development.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think just single backslashes is OK? I will try it out on Windows before merging

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll render the docs, because I put those to escape the single backslash.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@wesmwesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks everyone!

@wesm

wesm commented Nov 21, 2018

Copy link
Copy Markdown
Member

Argh so one problem: autoconf is not cross-platform. Does this cause issues on Windows? I can test it out today if no one else has time

@kszucs

kszucs commented Nov 26, 2018

Copy link
Copy Markdown
Member

@wesm I don't have a windows VM to test it

@wesm

wesm commented Nov 30, 2018

Copy link
Copy Markdown
Member

I will try it out on my Windows machine and merge if no issues

@wesm

wesm commented Dec 2, 2018

Copy link
Copy Markdown
Member

So we'll have to omit autoconf from conda_env_cpp.yml

(pyarrow-dev) λ conda create -n conda-env-test --file=ci\conda_env_cpp.yml python=3.6 Solving environment: failed PackagesNotFoundError: The following packages are not available from current channels: - autoconf Current channels: - https://conda.anaconda.org/conda-forge/win-64 - https://conda.anaconda.org/conda-forge/noarch - https://repo.anaconda.com/pkgs/main/win-64 - https://repo.anaconda.com/pkgs/main/noarch - https://repo.anaconda.com/pkgs/free/win-64 - https://repo.anaconda.com/pkgs/free/noarch - https://repo.anaconda.com/pkgs/r/win-64 - https://repo.anaconda.com/pkgs/r/noarch - https://repo.anaconda.com/pkgs/pro/win-64 - https://repo.anaconda.com/pkgs/pro/noarch - https://repo.anaconda.com/pkgs/msys2/win-64 - https://repo.anaconda.com/pkgs/msys2/noarch To search for alternate channels that may provide the conda package you're looking for, navigate to https://anaconda.org and use the search bar at the top of the page. 

@wesmwesm changed the title [Python] DOC: Add autoconf to conda install instructionsARROW-3925: [Python] Add autoconf to conda install instructionsDec 2, 2018
Comment threadcpp/Dockerfile
conda install -c conda-forge \
--file arrow/ci/conda_env_cpp.yml && \
--file arrow/ci/conda_env_cpp.yml \
--file arrow/ci/conda_env_unix.yml && \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda_env_unix.yml is missing, will resolve in #3059

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@fjetter@kszucs@wesm