Uh oh!
There was an error while loading. Please reload this page.
ARROW-3761: [R] Bindings for CompressedInputStream, CompressedOutputStream - #2962
ARROW-3761: [R] Bindings for CompressedInputStream, CompressedOutputStream#2962romainfrancois wants to merge 8 commits into
Conversation
Codecov Report
@@ Coverage Diff @@## master #2962 +/- ##
===========================================
+ Coverage 74.31% 89.45% +15.14%
===========================================
Files 68 12 -56 Lines 5423 1811 -3612 ===========================================
- Hits 4030 1620 -2410 + Misses 1297 191 -1106 + Partials 96 0 -96Continue to review full report at Codecov.
|
8ccc977 to
633d1ccCompare633d1cc to
1013a1dComparewesm
commented
Nov 26, 2018
Are you working on this somewhere else? |
romainfrancois
commented
Nov 26, 2018
I'm not. |
romainfrancois
commented
Nov 26, 2018
I don't know what happened, but it looks I've lost some commits in that branch. this is thankfully minor. |
wesm
commented
Nov 26, 2018
Looks like you may need to |
romainfrancois
commented
Nov 26, 2018
Thanks @wesm |
wesm
commented
Nov 28, 2018
There are no tests here. What would you like to do? |
romainfrancois
commented
Nov 28, 2018
I’m still unsure how to test this. I’ll look around in pyarrow next time i look at this branch |
wesm
commented
Nov 28, 2018
Got it. I think we just generate random bytes and write them to a compressed file, then read them back in and compare |
romainfrancois
commented
Nov 28, 2018
Makes sense. IIRC I tried to serialize a record batch but that did not work out well. |
wesm
commented
Nov 28, 2018
Yeah, that requires random access. It should at least not crash, though |
wesm
commented
Nov 28, 2018
Well, to read using the *StreamReader should work. If it does not, that's buggy |
romainfrancois
commented
Nov 29, 2018
Thanks. I’ll use that in testing. |
6002218 to
efe4ae8Compareromainfrancois
commented
Dec 3, 2018
This will likely need to be rebased once #3043 is merged |
0ba65a0 to
14a7ef1Comparecd5e8c9 to
6c8907cCompare6c8907c to
feb948aComparefeb948a to
397bacaCompare
No description provided.