Uh oh!
There was an error while loading. Please reload this page.
ARROW-3941: [R] RecordBatchStreamReader$schema - #3104
Closed
romainfrancois wants to merge 2 commits into
Closed
Conversation
codecov-io
commented
Dec 5, 2018
Codecov Report
@@ Coverage Diff @@## master #3104 +/- ##
=========================================
+ Coverage 87.04% 88.15% +1.1%
=========================================
Files 492 434 -58 Lines 69104 65339 -3765 =========================================
- Hits 60154 57601 -2553 + Misses 8849 7738 -1111 + Partials 101 0 -101Continue to review full report at Codecov.
|
wesm
approved these changes
Dec 5, 2018
wesm
left a comment
Member
There was a problem hiding this comment.
+1, but see comment re: removing deprecated API
| public = list( | ||
| schema = function() shared_ptr(`arrow::Schema`, RecordBatchReader__schema(self)), | ||
| ReadNext = function() { | ||
| get_next_batch = function() { |
Member
There was a problem hiding this comment.
get_next_batch is deprecated, can you remove?
| expect_is(batch1, "arrow::RecordBatch") | ||
| expect_equal(batch, batch1) | ||
| expect_null(reader$get_next_batch()) |
wesm
commented
Dec 6, 2018
Member
Test failure was transient. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARROW-3941
follow up to #3043 to fix api of classes RecordBatchFileReader, RecordBatchStreamReader, RecordBatchFileWriter, RecordBatchStreamWriter