Uh oh!
There was an error while loading. Please reload this page.
ARROW-3943: [R] vignette - #3107
Closed
romainfrancois wants to merge 11 commits into
Closed
Conversation
xhochy
commented
Dec 5, 2018
Member
@romainfrancois I wondering whether we could combine this into the general Sphinx documentation. We are currently merging the Python and C++ infrastructure with the general Arrow format documentation over at #2856 Disclaimer: As I'm not an R expert, I have no idea how well this plays with the R ecosystem. |
romainfrancois
commented
Dec 5, 2018
ContributorAuthor
Could be interesting. I have the opposite disclaimer though. |
xhochy
commented
Dec 5, 2018
Member
@wesm As you know both worlds, can you help us here? |
wesm
commented
Dec 5, 2018
Member
It's customary to include a vignette with CRAN packages. See https://cran.r-project.org/web/packages/dplyr/index.html. So even if we publish this on arrow.apache.org, we still would probably need to have a vignette. |
xhochy
commented
Dec 5, 2018
Member
So a vignette is a something between a TL;DR paragraph and the fully fledged package documentation? This means we would probably have the vignette and would write a fully featured documentation somewhere else? That sounds good to me. |
wesm
commented
Dec 5, 2018
Member
Right, the vignette is something akin to a "getting started" guide |
Codecov Report
@@ Coverage Diff @@## master #3107 +/- ##
===========================================
- Coverage 87.78% 67.73% -20.05%
===========================================
Files 710 410 -300 Lines 86837 54672 -32165 Branches 1252 1252 ===========================================
- Hits 76226 37034 -39192 - Misses 10498 17630 +7132 + Partials 113 8 -105
Continue to review full report at Codecov.
|
romainfrancoisforce-pushed
the
vignette
branch
from
December 10, 2018 18:16
3ade376 to
b21db62Compareromainfrancoisforce-pushed
the
vignette
branch
2 times, most recently
from
January 7, 2019 15:08
ee1099d to
3fe4311Compareromainfrancoisforce-pushed
the
vignette
branch
from
February 13, 2019 09:03
3fe4311 to
6026a48Compareromainfrancoisforce-pushed
the
vignette
branch
3 times, most recently
from
February 26, 2019 08:41
97254c3 to
a64fcf0CompareI encounter the following build error when I built the tarball of 0.13.0 RC. ``` [38/597] Performing configure step for 'grpc_ep' FAILED: grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure cd /Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/build/grpc_ep-prefix/src/grpc_ep-build && /opt/brew/Cellar/cmake/3.13.3/bin/cmake -P /Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/build/grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure-RELEASE.cmake && /opt/brew/Cellar/c make/3.13.3/bin/cmake -E touch /Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/build/grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure CMake Error at /Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/build/grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure-RELEASE.cmake:16 (message): Command failed: 1 '/opt/brew/Cellar/cmake/3.13.3/bin/cmake' '-DCMAKE_BUILD_TYPE=RELEASE' '-DCMAKE_PREFIX_PATH=';/opt/brew;/Users/mrkn/src/github.com/apache/arrow/cpp/build/gflags_ep-prefix/src/gflags_ep;/Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/thirdparty/cares_ep-install;'' '-DgRPC _CARES_PROVIDER=package' '-DgRPC_GFLAGS_PROVIDER=package' '-DgRPC_PROTOBUF_PROVIDER=package' '-DgRPC_SSL_PROVIDER=package' '-DgRPC_ZLIB_PROVIDER=package' '-DCMAKE_CXX_FLAGS= -Qunused-arguments -fcolor-diagnostics -O3 -DNDEBUG -O3 -DNDEBUG -fPIC' '-DCMAKE_C_FLAGS= -Qunused-arguments -O3 -DNDEBUG -O3 -DNDEBUG -fPIC' '-DCMAKE_INSTALL_PREFIX=/Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/thirdparty/grpc_ep-install' '-DCMAKE_INSTALL_LIBDIR=lib' '-DProtobuf_PROTOC_LIBRARY=/opt/brew/lib/libprotoc.dylib' '-DBUILD_SHARED_LIBS=OFF' '-GNinja' '/Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/build/grpc_ep-prefix/src/grpc_ep' See also /Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/build/grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure-*.log ``` grpc_ep's build log is given below: ``` $ cat /Users/mrkn/Downloads/apache-arrow-0.13.0/cpp/build/grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure-*.log CMake Error at cmake/cares.cmake:38 (find_package): Could not find a package configuration file provided by "c-ares" with any of the following names: c-aresConfig.cmake c-ares-config.cmake Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or set "c-ares_DIR" to a directory containing one of the above files. If "c-ares" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): CMakeLists.txt:139 (include) (snip) ``` This build log says that grpc_ep couldn't find cares_ep. In this case, grpc_ep was built before cares_ep. This pull-request could fix this dependency error on my environment. Author: Kenta Murata <mrkn@mrkn.jp> Closesapache#4064 from mrkn/cpp_grpc_depends_on_cares and squashes the following commits: 1a37054 <Kenta Murata> Specify dependencies of grpc_ep
Author: Kouhei Sutou <kou@clear-code.com> Closesapache#4069 from kou/release-fix-typo-in-mail-template and squashes the following commits: 15dc3c8 <Kouhei Sutou> Fix typos in vote e-mail template
* Use jq in local * Ensure making variables for "for" function local for parallel processing Author: Kouhei Sutou <kou@clear-code.com> Closesapache#4070 from kou/release-improve-binary-upload-performance and squashes the following commits: 2463d3c <Kouhei Sutou> Improve 03-binary performance
nealrichardson
commented
May 30, 2019
Member
This PR is stale and I think we should close it. The vignette content is a good start, and I'd be happy to help contribute to it on a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.