Uh oh!
There was an error while loading. Please reload this page.
GH-33801: [Python] Expose C++ ExtensionTypes/ExtensionArrays in pyarrow - #33802
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR! (and sorry for the slow feedback)
Looking good, added some comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jorisvandenbossche
commented
Feb 3, 2023
@sjperkins FYI I also opened an issue about having custom subclasses for extension types implemented in C++ (instead of using the base class BaseExtensionType/ExtensionArray): #33997 |
sjperkins
commented
Feb 3, 2023
Thanks @jorisvandenbossche for mentioning this, as well as the review. I'm intending to address your review comments next week. |
sjperkins
commented
Feb 16, 2023
Is there anything else needed from me on this PR? |
jorisvandenbossche
left a comment
There was a problem hiding this comment.
No, nothing else needed, this looks good! (and thanks for the ping :))
sjperkins
commented
Feb 16, 2023
Thanks for the review and merging @jorisvandenbossche |
ursabot
commented
Feb 16, 2023
Benchmark runs are scheduled for baseline = b40fb2c and contender = 1333545. 1333545 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
ursabot
commented
Feb 16, 2023
['Python', 'R'] benchmarks have high level of regressions. |
Rationale for this change
C++ Extension Types are not correctly exposed in pyarrow
What changes are included in this PR?
__arrow_ext_class__and__arrow_ext_scalar_class__have been moved fromExtensionTypetoBaseExtensionTypein types.pxi.Are these changes tested?
Yes, a test has been added to
test_cython.py. There may be better locations for this, but the existing cython testing machinery here is useful for generating a C++ extension type on the fly.Are there any user-facing changes?
I don't believe there are any user-facing changes as
__arrow_ext_class__and__arrow_ext_scalar_class__are moved into a base class.