Uh oh!
There was an error while loading. Please reload this page.
GH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_ARRAY - #34336
GH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_ARRAY#34336mapleFU wants to merge 4 commits into
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
mapleFU
commented
Feb 24, 2023
This patch is currently for poc and fast verification. If it works and #34323 is merged, I'll making code for it better :) |
mapleFU
commented
Feb 24, 2023
for (int i = 0; i < max_values; ++i) {
buffer[i].ptr = data_ptr;
data_ptr += buffer[i].len;
}By the way, I don't know would this code cause cache problem or prevent from optimization, causing pipeline hazard or compiler do not optimize here. I'd do some survey. |
Rationale for this change
According to #34323 . DELTA_LENGTH_BYTE_ARRAY is much more slower. So do some optimizations.
What changes are included in this PR?
Some tiny changes
Are these changes tested?
No more tests included, these code are already tested
Are there any user-facing changes?
No