GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE - #34617

Merged
kou merged 6 commits into
apache:mainfrom
benibus:GH-34615-minimal-cpp-ci-job
Mar 23, 2023
Merged

GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE#34617
kou merged 6 commits into
apache:mainfrom
benibus:GH-34615-minimal-cpp-ci-job

Conversation

@benibus

@benibusbenibus commented Mar 17, 2023•
edited by raulcd
Loading

Copy link
Copy Markdown
Contributor

This adds a crossbow job for ARROW_IPC, ARROW_PARQUET, and ARROW_CSV - based on a minimal Ubuntu image.

The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by ARROW_COMPUTE. Note that ARROW_JSON is implicitly enabled as well, since it's a dependency of ARROW_TESTING.

@github-actions

github-actionsBot commented Mar 17, 2023

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Mar 17, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #34615has been automatically assigned in GitHub to PR creator.

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Mar 17, 2023
@benibus
benibusforce-pushed the GH-34615-minimal-cpp-ci-job branch 2 times, most recently from 5510338 to eee9253CompareMarch 19, 2023 00:25
@benibus
benibusforce-pushed the GH-34615-minimal-cpp-ci-job branch from eee9253 to e3d60b9CompareMarch 19, 2023 19:13
@benibus
benibus marked this pull request as ready for review March 19, 2023 21:06
@kou

kou commented Mar 19, 2023

Copy link
Copy Markdown
Member

There are still some enabled components:

https://github.com/apache/arrow/actions/runs/4462272725/jobs/7836694435?pr=34617#step:6:1866

-- ARROW_BUILD_UTILITIES=ON [default=OFF]
-- Build Arrow commandline utilities
-- ARROW_CSV=ON [default=OFF]
-- Build the Arrow CSV Parser Module
-- ARROW_FILESYSTEM=ON [default=OFF]
-- Build the Arrow Filesystem Layer
-- ARROW_IPC=ON [default=ON]
-- Build the Arrow IPC extensions
-- ARROW_JSON=ON [default=OFF]
-- Build Arrow with JSON support (requires RapidJSON)
-- ARROW_PARQUET=ON [default=OFF]
-- Build the Parquet libraries

Are they intentional?

@benibus

benibus commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

Are they intentional?

ARROW_BUILD_UTILITIES and ARROW_FILESYSTEM are unintentional (I think the latter is being enabled by PARQUET_REQUIRE_ENCRYPTION=ON). Regarding the others, see my edit to the body message (I attempted to clarify my intent as well).

@benibus

benibus commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

Also, fair warning: I've never actually messed with CI system before so there may be a better way to do this. I just went with one of the preexisting Ubuntu images since it seemed like a reasonable base (to me, at least).

@kou

kou commented Mar 20, 2023

Copy link
Copy Markdown
Member

OK. Then "minimal" may be misleading. For example, we use "minimal" as "all components are disabled" in https://github.com/apache/arrow/blob/main/cpp/CMakePresets.json#L49 . Can we use other label for this job?

If we enable Parquet, CI time isn't short. How about running this as a nightly CI job instead like test-*-cpp-* in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L1171-L1256 ?

@benibus

benibus commented Mar 20, 2023

Copy link
Copy Markdown
ContributorAuthor

I agree that it's misleading.

We could also handle both cases pretty easily, I think. The "minimal" image I have here could disable everything as it implies. Then, the nightly task would use that image but enable CSV/Parquet.

@benibus
benibusforce-pushed the GH-34615-minimal-cpp-ci-job branch from e3d60b9 to aa7cb5bCompareMarch 20, 2023 16:58
@benibus

benibus commented Mar 20, 2023•
edited by kou
Loading

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats

@github-actions

github-actionsBot commented Mar 20, 2023

Copy link
Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd

Submitted crossbow builds: ursacomputing/crossbow @ actions-7a8059874a

TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions

@github-actions

github-actionsBot commented Mar 20, 2023

Copy link
Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd

Submitted crossbow builds: ursacomputing/crossbow @ actions-89628f20c6

TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions

kou
kou reviewed Mar 21, 2023
View reviewed changes
Comment thread.github/workflows/cpp.yml Outdated
Comment threaddev/tasks/tasks.yml Outdated
@kou

kou commented Mar 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Could you also update "minimal" in the title and the description of this PR and GH-34615?

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Mar 21, 2023
@benibusbenibus mentioned this pull request Mar 21, 2023
Closed
@benibus
benibusforce-pushed the GH-34615-minimal-cpp-ci-job branch from aa7cb5b to 9147c15CompareMarch 21, 2023 16:08
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 21, 2023
@benibusbenibus changed the title GH-34615: [CI][C++] Add CI job for minimal C++ buildGH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTEMar 21, 2023
@benibus
benibus requested a review from kouMarch 21, 2023 16:44
@kou

kou commented Mar 21, 2023

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats

@github-actions

github-actionsBot commented Mar 21, 2023

Copy link
Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7

Submitted crossbow builds: ursacomputing/crossbow @ actions-b9824dee1c

TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions

@raulcd

raulcd commented Mar 22, 2023

Copy link
Copy Markdown
Member

I've updated the body to include the closes #34655 as suggested.

@raulcd

raulcd commented Mar 22, 2023

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-cuda-cpp

@github-actions

github-actionsBot commented Mar 22, 2023

Copy link
Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7

Submitted crossbow builds: ursacomputing/crossbow @ actions-2e55c6dbfe

TaskStatus
test-cuda-cppGithub Actions

@raulcd

raulcd commented Mar 22, 2023

Copy link
Copy Markdown
Member

The test-cuda-cpp seems to fail with a similar error to the one reported on #34655 :

 '_error_or_value25.status()' failed with Key error: No function registered with name: sort_indices
/arrow/cpp/src/arrow/compute/exec/order_by_node_test.cc:61: Failure
Failed

@benibus let me know if I should open a different issue for that or should be fixed here. Thanks!

@benibus

benibus commented Mar 22, 2023

Copy link
Copy Markdown
ContributorAuthor

@raulcd Yeah, I saw that last night. Probably best to handle it here as well.

I'll do a light CMake refactor to hopefully prevent more of these issues since it's too easy to make mistakes ATM.

@benibus
Add CI image ubuntu-cpp-minimal
3f7f99a
@benibus
Install tzdata in ubuntu docker images
9a0ad0b
Some temporal casts will fail without timezone info
@benibus
Separate compute-expression-test
a1bea2e
compute-expression-test was recently merged into compute-internals-test
as part of a larger refactor. However, the expression tests depend on
additional kernels (i.e. equal) so I re-separated them.
@benibus
Add Crossbow job with additional formats
b59c35a
@benibus
Use params.flags to enable components
67df515
@benibus
benibusforce-pushed the GH-34615-minimal-cpp-ci-job branch from 9147c15 to 42e52beCompareMarch 22, 2023 14:16
@benibus
benibusforce-pushed the GH-34615-minimal-cpp-ci-job branch from 42e52be to 0a79eb3CompareMarch 22, 2023 14:18
@benibus

benibus commented Mar 22, 2023

Copy link
Copy Markdown
ContributorAuthor

@kou@raulcd test-ubuntu-20.04-cpp-minimal-with-formats and test-cuda-cpp should pass on this branch now.

@benibus

benibus commented Mar 22, 2023

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test-cuda-cpp

@github-actions

github-actionsBot commented Mar 22, 2023

Copy link
Copy Markdown

Revision: 0a79eb3

Submitted crossbow builds: ursacomputing/crossbow @ actions-53125ee05c

TaskStatus
test-cuda-cppGithub Actions

@benibus

benibus commented Mar 22, 2023

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats

@github-actions

github-actionsBot commented Mar 22, 2023

Copy link
Copy Markdown

Revision: 0a79eb3

Submitted crossbow builds: ursacomputing/crossbow @ actions-a36f0bd26a

TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions

kou
kou approved these changes Mar 23, 2023
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 4487be0 into apache:mainMar 23, 2023
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Mar 23, 2023
@ursabot

ursabot commented Mar 23, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 3600bd8 and contender = 4487be0. 4487be0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.18% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4487be02 ec2-t3-xlarge-us-east-2
[Finished] 4487be02 test-mac-arm
[Finished] 4487be02 ursa-i9-9960x
[Finished] 4487be02 ursa-thinkcentre-m75q
[Finished] 3600bd80 ec2-t3-xlarge-us-east-2
[Finished] 3600bd80 test-mac-arm
[Finished] 3600bd80 ursa-i9-9960x
[Finished] 3600bd80 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@benibus@ArgusLi
apacheGH-34615: [CI][C++] Add CI job for basic format support without…
01a94a4
… ARROW_COMPUTE (apache#34617)
This adds a crossbow job for `ARROW_IPC`, `ARROW_PARQUET`, and `ARROW_CSV` - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by `ARROW_COMPUTE`. Note that `ARROW_JSON` is implicitly enabled as well, since it's a dependency of `ARROW_TESTING`.
* Closes: apache#34615
* Closes: apache#34655 Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@koukou mentioned this pull request Sep 18, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@westonpacewestonpaceAwaiting requested review from westonpace

Assignees

No one assigned

Labels

awaiting mergeAwaiting mergeComponent: C++

Projects

None yet

Milestone

No milestone

4 participants

@benibus@kou@raulcd@ursabot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE - #34617
Merged
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Mar 23, 2023
Merged
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE#34617
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Conversation
@benibus
@benibusbenibus
commented
Mar 17, 2023•

edited by raulcd

Loading

Copy link


Copy Markdown

Contributor
This adds a crossbow job for ARROW_IPC, ARROW_PARQUET, and ARROW_CSV - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by ARROW_COMPUTE. Note that ARROW_JSON is implicitly enabled as well, since it's a dependency of ARROW_TESTING.
@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #34615has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 17, 2023
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
2 times, most recently
from
5510338 to
eee9253CompareMarch 19, 2023 00:25
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
eee9253 to
e3d60b9CompareMarch 19, 2023 19:13
@benibus
benibus
marked this pull request as ready for review
March 19, 2023 21:06
@kou
kou
commented
Mar 19, 2023

Copy link


Copy Markdown

Member
There are still some enabled components:
https://github.com/apache/arrow/actions/runs/4462272725/jobs/7836694435?pr=34617#step:6:1866
-- ARROW_BUILD_UTILITIES=ON [default=OFF]
-- Build Arrow commandline utilities
-- ARROW_CSV=ON [default=OFF]
-- Build the Arrow CSV Parser Module
-- ARROW_FILESYSTEM=ON [default=OFF]
-- Build the Arrow Filesystem Layer
-- ARROW_IPC=ON [default=ON]
-- Build the Arrow IPC extensions
-- ARROW_JSON=ON [default=OFF]
-- Build Arrow with JSON support (requires RapidJSON)
-- ARROW_PARQUET=ON [default=OFF]
-- Build the Parquet libraries

Are they intentional?
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Are they intentional?
ARROW_BUILD_UTILITIES and ARROW_FILESYSTEM are unintentional (I think the latter is being enabled by PARQUET_REQUIRE_ENCRYPTION=ON). Regarding the others, see my edit to the body message (I attempted to clarify my intent as well).
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Also, fair warning: I've never actually messed with CI system before so there may be a better way to do this. I just went with one of the preexisting Ubuntu images since it seemed like a reasonable base (to me, at least).
@kou
kou
commented
Mar 20, 2023

Copy link


Copy Markdown

Member
OK. Then "minimal" may be misleading. For example, we use "minimal" as "all components are disabled" in https://github.com/apache/arrow/blob/main/cpp/CMakePresets.json#L49 . Can we use other label for this job?
If we enable Parquet, CI time isn't short. How about running this as a nightly CI job instead like test-*-cpp-* in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L1171-L1256 ?
@benibus
benibus
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
I agree that it's misleading.
We could also handle both cases pretty easily, I think. The "minimal" image I have here could disable everything as it implies. Then, the nightly task would use that image but enable CSV/Parquet.
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
e3d60b9 to
aa7cb5bCompareMarch 20, 2023 16:58
@benibus
benibus
commented
Mar 20, 2023•

edited by kou

Loading

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-7a8059874a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-89628f20c6
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
reviewed
Mar 21, 2023
View reviewed changes
Comment thread.github/workflows/cpp.yml
Outdated

Comment threaddev/tasks/tasks.yml
Outdated

@kou
kou
commented
Mar 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Could you also update "minimal" in the title and the description of this PR and GH-34615?
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Mar 21, 2023
@benibusbenibus
mentioned this pull request
Mar 21, 2023

Closed

@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
aa7cb5b to
9147c15CompareMarch 21, 2023 16:08
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Mar 21, 2023
@benibusbenibus
changed the title
GH-34615: [CI][C++] Add CI job for minimal C++ buildGH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTEMar 21, 2023
@benibus
benibus
requested a review
from kouMarch 21, 2023 16:44
@kou
kou
commented
Mar 21, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 21, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-b9824dee1c
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
I've updated the body to include the closes #34655 as suggested.
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-2e55c6dbfe
TaskStatus
test-cuda-cppGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
The test-cuda-cpp seems to fail with a similar error to the one reported on #34655 :
 '_error_or_value25.status()' failed with Key error: No function registered with name: sort_indices
/arrow/cpp/src/arrow/compute/exec/order_by_node_test.cc:61: Failure
Failed

@benibus let me know if I should open a different issue for that or should be fixed here. Thanks!
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@raulcd Yeah, I saw that last night. Probably best to handle it here as well.
I'll do a light CMake refactor to hopefully prevent more of these issues since it's too easy to make mistakes ATM.
@benibus
Add CI image ubuntu-cpp-minimal
3f7f99a
@benibus
Install tzdata in ubuntu docker images
9a0ad0b
Some temporal casts will fail without timezone info
@benibus
Separate compute-expression-test
a1bea2e
compute-expression-test was recently merged into compute-internals-test
as part of a larger refactor. However, the expression tests depend on
additional kernels (i.e. equal) so I re-separated them.
@benibus
Add Crossbow job with additional formats
b59c35a
@benibus
Use params.flags to enable components
67df515
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
9147c15 to
42e52beCompareMarch 22, 2023 14:16
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
42e52be to
0a79eb3CompareMarch 22, 2023 14:18
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@kou@raulcd test-ubuntu-20.04-cpp-minimal-with-formats and test-cuda-cpp should pass on this branch now.
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-53125ee05c
TaskStatus
test-cuda-cppGithub Actions
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-a36f0bd26a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
approved these changes
Mar 23, 2023
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 4487be0
into
apache:mainMar 23, 2023
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
Mar 23, 2023
@ursabot
ursabot
commented
Mar 23, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 3600bd8 and contender = 4487be0. 4487be0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.18% ⬆️0.0%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.09% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4487be02 ec2-t3-xlarge-us-east-2

[Finished] 4487be02 test-mac-arm

[Finished] 4487be02 ursa-i9-9960x

[Finished] 4487be02 ursa-thinkcentre-m75q

[Finished] 3600bd80 ec2-t3-xlarge-us-east-2

[Finished] 3600bd80 test-mac-arm

[Finished] 3600bd80 ursa-i9-9960x

[Finished] 3600bd80 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@benibus@ArgusLi
apacheGH-34615: [CI][C++] Add CI job for basic format support without…
01a94a4
… ARROW_COMPUTE (apache#34617)
This adds a crossbow job for `ARROW_IPC`, `ARROW_PARQUET`, and `ARROW_CSV` - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by `ARROW_COMPUTE`. Note that `ARROW_JSON` is implicitly enabled as well, since it's a dependency of `ARROW_TESTING`.
* Closes: apache#34615
* Closes: apache#34655 Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@koukou
mentioned this pull request
Sep 18, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@westonpacewestonpaceAwaiting requested review from westonpace

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: C++

Projects


None yet


Milestone


No milestone


4 participants

@benibus@kou@raulcd@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE - #34617
Merged
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Mar 23, 2023
Merged
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE#34617
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Conversation
@benibus
@benibusbenibus
commented
Mar 17, 2023•

edited by raulcd

Loading

Copy link


Copy Markdown

Contributor
This adds a crossbow job for ARROW_IPC, ARROW_PARQUET, and ARROW_CSV - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by ARROW_COMPUTE. Note that ARROW_JSON is implicitly enabled as well, since it's a dependency of ARROW_TESTING.
@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #34615has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 17, 2023
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
2 times, most recently
from
5510338 to
eee9253CompareMarch 19, 2023 00:25
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
eee9253 to
e3d60b9CompareMarch 19, 2023 19:13
@benibus
benibus
marked this pull request as ready for review
March 19, 2023 21:06
@kou
kou
commented
Mar 19, 2023

Copy link


Copy Markdown

Member
There are still some enabled components:
https://github.com/apache/arrow/actions/runs/4462272725/jobs/7836694435?pr=34617#step:6:1866
-- ARROW_BUILD_UTILITIES=ON [default=OFF]
-- Build Arrow commandline utilities
-- ARROW_CSV=ON [default=OFF]
-- Build the Arrow CSV Parser Module
-- ARROW_FILESYSTEM=ON [default=OFF]
-- Build the Arrow Filesystem Layer
-- ARROW_IPC=ON [default=ON]
-- Build the Arrow IPC extensions
-- ARROW_JSON=ON [default=OFF]
-- Build Arrow with JSON support (requires RapidJSON)
-- ARROW_PARQUET=ON [default=OFF]
-- Build the Parquet libraries

Are they intentional?
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Are they intentional?
ARROW_BUILD_UTILITIES and ARROW_FILESYSTEM are unintentional (I think the latter is being enabled by PARQUET_REQUIRE_ENCRYPTION=ON). Regarding the others, see my edit to the body message (I attempted to clarify my intent as well).
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Also, fair warning: I've never actually messed with CI system before so there may be a better way to do this. I just went with one of the preexisting Ubuntu images since it seemed like a reasonable base (to me, at least).
@kou
kou
commented
Mar 20, 2023

Copy link


Copy Markdown

Member
OK. Then "minimal" may be misleading. For example, we use "minimal" as "all components are disabled" in https://github.com/apache/arrow/blob/main/cpp/CMakePresets.json#L49 . Can we use other label for this job?
If we enable Parquet, CI time isn't short. How about running this as a nightly CI job instead like test-*-cpp-* in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L1171-L1256 ?
@benibus
benibus
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
I agree that it's misleading.
We could also handle both cases pretty easily, I think. The "minimal" image I have here could disable everything as it implies. Then, the nightly task would use that image but enable CSV/Parquet.
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
e3d60b9 to
aa7cb5bCompareMarch 20, 2023 16:58
@benibus
benibus
commented
Mar 20, 2023•

edited by kou

Loading

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-7a8059874a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-89628f20c6
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
reviewed
Mar 21, 2023
View reviewed changes
Comment thread.github/workflows/cpp.yml
Outdated

Comment threaddev/tasks/tasks.yml
Outdated

@kou
kou
commented
Mar 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Could you also update "minimal" in the title and the description of this PR and GH-34615?
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Mar 21, 2023
@benibusbenibus
mentioned this pull request
Mar 21, 2023

Closed

@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
aa7cb5b to
9147c15CompareMarch 21, 2023 16:08
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Mar 21, 2023
@benibusbenibus
changed the title
GH-34615: [CI][C++] Add CI job for minimal C++ buildGH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTEMar 21, 2023
@benibus
benibus
requested a review
from kouMarch 21, 2023 16:44
@kou
kou
commented
Mar 21, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 21, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-b9824dee1c
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
I've updated the body to include the closes #34655 as suggested.
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-2e55c6dbfe
TaskStatus
test-cuda-cppGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
The test-cuda-cpp seems to fail with a similar error to the one reported on #34655 :
 '_error_or_value25.status()' failed with Key error: No function registered with name: sort_indices
/arrow/cpp/src/arrow/compute/exec/order_by_node_test.cc:61: Failure
Failed

@benibus let me know if I should open a different issue for that or should be fixed here. Thanks!
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@raulcd Yeah, I saw that last night. Probably best to handle it here as well.
I'll do a light CMake refactor to hopefully prevent more of these issues since it's too easy to make mistakes ATM.
@benibus
Add CI image ubuntu-cpp-minimal
3f7f99a
@benibus
Install tzdata in ubuntu docker images
9a0ad0b
Some temporal casts will fail without timezone info
@benibus
Separate compute-expression-test
a1bea2e
compute-expression-test was recently merged into compute-internals-test
as part of a larger refactor. However, the expression tests depend on
additional kernels (i.e. equal) so I re-separated them.
@benibus
Add Crossbow job with additional formats
b59c35a
@benibus
Use params.flags to enable components
67df515
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
9147c15 to
42e52beCompareMarch 22, 2023 14:16
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
42e52be to
0a79eb3CompareMarch 22, 2023 14:18
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@kou@raulcd test-ubuntu-20.04-cpp-minimal-with-formats and test-cuda-cpp should pass on this branch now.
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-53125ee05c
TaskStatus
test-cuda-cppGithub Actions
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-a36f0bd26a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
approved these changes
Mar 23, 2023
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 4487be0
into
apache:mainMar 23, 2023
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
Mar 23, 2023
@ursabot
ursabot
commented
Mar 23, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 3600bd8 and contender = 4487be0. 4487be0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.18% ⬆️0.0%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.09% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4487be02 ec2-t3-xlarge-us-east-2

[Finished] 4487be02 test-mac-arm

[Finished] 4487be02 ursa-i9-9960x

[Finished] 4487be02 ursa-thinkcentre-m75q

[Finished] 3600bd80 ec2-t3-xlarge-us-east-2

[Finished] 3600bd80 test-mac-arm

[Finished] 3600bd80 ursa-i9-9960x

[Finished] 3600bd80 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@benibus@ArgusLi
apacheGH-34615: [CI][C++] Add CI job for basic format support without…
01a94a4
… ARROW_COMPUTE (apache#34617)
This adds a crossbow job for `ARROW_IPC`, `ARROW_PARQUET`, and `ARROW_CSV` - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by `ARROW_COMPUTE`. Note that `ARROW_JSON` is implicitly enabled as well, since it's a dependency of `ARROW_TESTING`.
* Closes: apache#34615
* Closes: apache#34655 Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@koukou
mentioned this pull request
Sep 18, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@westonpacewestonpaceAwaiting requested review from westonpace

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: C++

Projects


None yet


Milestone


No milestone


4 participants

@benibus@kou@raulcd@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE - #34617
Merged
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Mar 23, 2023
Merged
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE#34617
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Conversation
@benibus
@benibusbenibus
commented
Mar 17, 2023•

edited by raulcd

Loading

Copy link


Copy Markdown

Contributor
This adds a crossbow job for ARROW_IPC, ARROW_PARQUET, and ARROW_CSV - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by ARROW_COMPUTE. Note that ARROW_JSON is implicitly enabled as well, since it's a dependency of ARROW_TESTING.
@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #34615has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 17, 2023
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
2 times, most recently
from
5510338 to
eee9253CompareMarch 19, 2023 00:25
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
eee9253 to
e3d60b9CompareMarch 19, 2023 19:13
@benibus
benibus
marked this pull request as ready for review
March 19, 2023 21:06
@kou
kou
commented
Mar 19, 2023

Copy link


Copy Markdown

Member
There are still some enabled components:
https://github.com/apache/arrow/actions/runs/4462272725/jobs/7836694435?pr=34617#step:6:1866
-- ARROW_BUILD_UTILITIES=ON [default=OFF]
-- Build Arrow commandline utilities
-- ARROW_CSV=ON [default=OFF]
-- Build the Arrow CSV Parser Module
-- ARROW_FILESYSTEM=ON [default=OFF]
-- Build the Arrow Filesystem Layer
-- ARROW_IPC=ON [default=ON]
-- Build the Arrow IPC extensions
-- ARROW_JSON=ON [default=OFF]
-- Build Arrow with JSON support (requires RapidJSON)
-- ARROW_PARQUET=ON [default=OFF]
-- Build the Parquet libraries

Are they intentional?
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Are they intentional?
ARROW_BUILD_UTILITIES and ARROW_FILESYSTEM are unintentional (I think the latter is being enabled by PARQUET_REQUIRE_ENCRYPTION=ON). Regarding the others, see my edit to the body message (I attempted to clarify my intent as well).
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Also, fair warning: I've never actually messed with CI system before so there may be a better way to do this. I just went with one of the preexisting Ubuntu images since it seemed like a reasonable base (to me, at least).
@kou
kou
commented
Mar 20, 2023

Copy link


Copy Markdown

Member
OK. Then "minimal" may be misleading. For example, we use "minimal" as "all components are disabled" in https://github.com/apache/arrow/blob/main/cpp/CMakePresets.json#L49 . Can we use other label for this job?
If we enable Parquet, CI time isn't short. How about running this as a nightly CI job instead like test-*-cpp-* in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L1171-L1256 ?
@benibus
benibus
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
I agree that it's misleading.
We could also handle both cases pretty easily, I think. The "minimal" image I have here could disable everything as it implies. Then, the nightly task would use that image but enable CSV/Parquet.
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
e3d60b9 to
aa7cb5bCompareMarch 20, 2023 16:58
@benibus
benibus
commented
Mar 20, 2023•

edited by kou

Loading

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-7a8059874a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-89628f20c6
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
reviewed
Mar 21, 2023
View reviewed changes
Comment thread.github/workflows/cpp.yml
Outdated

Comment threaddev/tasks/tasks.yml
Outdated

@kou
kou
commented
Mar 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Could you also update "minimal" in the title and the description of this PR and GH-34615?
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Mar 21, 2023
@benibusbenibus
mentioned this pull request
Mar 21, 2023

Closed

@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
aa7cb5b to
9147c15CompareMarch 21, 2023 16:08
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Mar 21, 2023
@benibusbenibus
changed the title
GH-34615: [CI][C++] Add CI job for minimal C++ buildGH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTEMar 21, 2023
@benibus
benibus
requested a review
from kouMarch 21, 2023 16:44
@kou
kou
commented
Mar 21, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 21, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-b9824dee1c
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
I've updated the body to include the closes #34655 as suggested.
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-2e55c6dbfe
TaskStatus
test-cuda-cppGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
The test-cuda-cpp seems to fail with a similar error to the one reported on #34655 :
 '_error_or_value25.status()' failed with Key error: No function registered with name: sort_indices
/arrow/cpp/src/arrow/compute/exec/order_by_node_test.cc:61: Failure
Failed

@benibus let me know if I should open a different issue for that or should be fixed here. Thanks!
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@raulcd Yeah, I saw that last night. Probably best to handle it here as well.
I'll do a light CMake refactor to hopefully prevent more of these issues since it's too easy to make mistakes ATM.
@benibus
Add CI image ubuntu-cpp-minimal
3f7f99a
@benibus
Install tzdata in ubuntu docker images
9a0ad0b
Some temporal casts will fail without timezone info
@benibus
Separate compute-expression-test
a1bea2e
compute-expression-test was recently merged into compute-internals-test
as part of a larger refactor. However, the expression tests depend on
additional kernels (i.e. equal) so I re-separated them.
@benibus
Add Crossbow job with additional formats
b59c35a
@benibus
Use params.flags to enable components
67df515
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
9147c15 to
42e52beCompareMarch 22, 2023 14:16
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
42e52be to
0a79eb3CompareMarch 22, 2023 14:18
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@kou@raulcd test-ubuntu-20.04-cpp-minimal-with-formats and test-cuda-cpp should pass on this branch now.
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-53125ee05c
TaskStatus
test-cuda-cppGithub Actions
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-a36f0bd26a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
approved these changes
Mar 23, 2023
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 4487be0
into
apache:mainMar 23, 2023
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
Mar 23, 2023
@ursabot
ursabot
commented
Mar 23, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 3600bd8 and contender = 4487be0. 4487be0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.18% ⬆️0.0%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.09% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4487be02 ec2-t3-xlarge-us-east-2

[Finished] 4487be02 test-mac-arm

[Finished] 4487be02 ursa-i9-9960x

[Finished] 4487be02 ursa-thinkcentre-m75q

[Finished] 3600bd80 ec2-t3-xlarge-us-east-2

[Finished] 3600bd80 test-mac-arm

[Finished] 3600bd80 ursa-i9-9960x

[Finished] 3600bd80 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@benibus@ArgusLi
apacheGH-34615: [CI][C++] Add CI job for basic format support without…
01a94a4
… ARROW_COMPUTE (apache#34617)
This adds a crossbow job for `ARROW_IPC`, `ARROW_PARQUET`, and `ARROW_CSV` - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by `ARROW_COMPUTE`. Note that `ARROW_JSON` is implicitly enabled as well, since it's a dependency of `ARROW_TESTING`.
* Closes: apache#34615
* Closes: apache#34655 Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@koukou
mentioned this pull request
Sep 18, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@westonpacewestonpaceAwaiting requested review from westonpace

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: C++

Projects


None yet


Milestone


No milestone


4 participants

@benibus@kou@raulcd@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE - #34617
Merged
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Mar 23, 2023
Merged
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE#34617
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Conversation
@benibus
@benibusbenibus
commented
Mar 17, 2023•

edited by raulcd

Loading

Copy link


Copy Markdown

Contributor
This adds a crossbow job for ARROW_IPC, ARROW_PARQUET, and ARROW_CSV - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by ARROW_COMPUTE. Note that ARROW_JSON is implicitly enabled as well, since it's a dependency of ARROW_TESTING.
@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #34615has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 17, 2023
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
2 times, most recently
from
5510338 to
eee9253CompareMarch 19, 2023 00:25
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
eee9253 to
e3d60b9CompareMarch 19, 2023 19:13
@benibus
benibus
marked this pull request as ready for review
March 19, 2023 21:06
@kou
kou
commented
Mar 19, 2023

Copy link


Copy Markdown

Member
There are still some enabled components:
https://github.com/apache/arrow/actions/runs/4462272725/jobs/7836694435?pr=34617#step:6:1866
-- ARROW_BUILD_UTILITIES=ON [default=OFF]
-- Build Arrow commandline utilities
-- ARROW_CSV=ON [default=OFF]
-- Build the Arrow CSV Parser Module
-- ARROW_FILESYSTEM=ON [default=OFF]
-- Build the Arrow Filesystem Layer
-- ARROW_IPC=ON [default=ON]
-- Build the Arrow IPC extensions
-- ARROW_JSON=ON [default=OFF]
-- Build Arrow with JSON support (requires RapidJSON)
-- ARROW_PARQUET=ON [default=OFF]
-- Build the Parquet libraries

Are they intentional?
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Are they intentional?
ARROW_BUILD_UTILITIES and ARROW_FILESYSTEM are unintentional (I think the latter is being enabled by PARQUET_REQUIRE_ENCRYPTION=ON). Regarding the others, see my edit to the body message (I attempted to clarify my intent as well).
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Also, fair warning: I've never actually messed with CI system before so there may be a better way to do this. I just went with one of the preexisting Ubuntu images since it seemed like a reasonable base (to me, at least).
@kou
kou
commented
Mar 20, 2023

Copy link


Copy Markdown

Member
OK. Then "minimal" may be misleading. For example, we use "minimal" as "all components are disabled" in https://github.com/apache/arrow/blob/main/cpp/CMakePresets.json#L49 . Can we use other label for this job?
If we enable Parquet, CI time isn't short. How about running this as a nightly CI job instead like test-*-cpp-* in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L1171-L1256 ?
@benibus
benibus
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
I agree that it's misleading.
We could also handle both cases pretty easily, I think. The "minimal" image I have here could disable everything as it implies. Then, the nightly task would use that image but enable CSV/Parquet.
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
e3d60b9 to
aa7cb5bCompareMarch 20, 2023 16:58
@benibus
benibus
commented
Mar 20, 2023•

edited by kou

Loading

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-7a8059874a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-89628f20c6
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
reviewed
Mar 21, 2023
View reviewed changes
Comment thread.github/workflows/cpp.yml
Outdated

Comment threaddev/tasks/tasks.yml
Outdated

@kou
kou
commented
Mar 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Could you also update "minimal" in the title and the description of this PR and GH-34615?
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Mar 21, 2023
@benibusbenibus
mentioned this pull request
Mar 21, 2023

Closed

@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
aa7cb5b to
9147c15CompareMarch 21, 2023 16:08
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Mar 21, 2023
@benibusbenibus
changed the title
GH-34615: [CI][C++] Add CI job for minimal C++ buildGH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTEMar 21, 2023
@benibus
benibus
requested a review
from kouMarch 21, 2023 16:44
@kou
kou
commented
Mar 21, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 21, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-b9824dee1c
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
I've updated the body to include the closes #34655 as suggested.
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-2e55c6dbfe
TaskStatus
test-cuda-cppGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
The test-cuda-cpp seems to fail with a similar error to the one reported on #34655 :
 '_error_or_value25.status()' failed with Key error: No function registered with name: sort_indices
/arrow/cpp/src/arrow/compute/exec/order_by_node_test.cc:61: Failure
Failed

@benibus let me know if I should open a different issue for that or should be fixed here. Thanks!
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@raulcd Yeah, I saw that last night. Probably best to handle it here as well.
I'll do a light CMake refactor to hopefully prevent more of these issues since it's too easy to make mistakes ATM.
@benibus
Add CI image ubuntu-cpp-minimal
3f7f99a
@benibus
Install tzdata in ubuntu docker images
9a0ad0b
Some temporal casts will fail without timezone info
@benibus
Separate compute-expression-test
a1bea2e
compute-expression-test was recently merged into compute-internals-test
as part of a larger refactor. However, the expression tests depend on
additional kernels (i.e. equal) so I re-separated them.
@benibus
Add Crossbow job with additional formats
b59c35a
@benibus
Use params.flags to enable components
67df515
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
9147c15 to
42e52beCompareMarch 22, 2023 14:16
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
42e52be to
0a79eb3CompareMarch 22, 2023 14:18
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@kou@raulcd test-ubuntu-20.04-cpp-minimal-with-formats and test-cuda-cpp should pass on this branch now.
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-53125ee05c
TaskStatus
test-cuda-cppGithub Actions
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-a36f0bd26a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
approved these changes
Mar 23, 2023
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 4487be0
into
apache:mainMar 23, 2023
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
Mar 23, 2023
@ursabot
ursabot
commented
Mar 23, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 3600bd8 and contender = 4487be0. 4487be0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.18% ⬆️0.0%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.09% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4487be02 ec2-t3-xlarge-us-east-2

[Finished] 4487be02 test-mac-arm

[Finished] 4487be02 ursa-i9-9960x

[Finished] 4487be02 ursa-thinkcentre-m75q

[Finished] 3600bd80 ec2-t3-xlarge-us-east-2

[Finished] 3600bd80 test-mac-arm

[Finished] 3600bd80 ursa-i9-9960x

[Finished] 3600bd80 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@benibus@ArgusLi
apacheGH-34615: [CI][C++] Add CI job for basic format support without…
01a94a4
… ARROW_COMPUTE (apache#34617)
This adds a crossbow job for `ARROW_IPC`, `ARROW_PARQUET`, and `ARROW_CSV` - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by `ARROW_COMPUTE`. Note that `ARROW_JSON` is implicitly enabled as well, since it's a dependency of `ARROW_TESTING`.
* Closes: apache#34615
* Closes: apache#34655 Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@koukou
mentioned this pull request
Sep 18, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@westonpacewestonpaceAwaiting requested review from westonpace

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: C++

Projects


None yet


Milestone


No milestone


4 participants

@benibus@kou@raulcd@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE - #34617
Merged
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Mar 23, 2023
Merged
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE#34617
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Conversation
@benibus
@benibusbenibus
commented
Mar 17, 2023•

edited by raulcd

Loading

Copy link


Copy Markdown

Contributor
This adds a crossbow job for ARROW_IPC, ARROW_PARQUET, and ARROW_CSV - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by ARROW_COMPUTE. Note that ARROW_JSON is implicitly enabled as well, since it's a dependency of ARROW_TESTING.
@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #34615has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 17, 2023
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
2 times, most recently
from
5510338 to
eee9253CompareMarch 19, 2023 00:25
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
eee9253 to
e3d60b9CompareMarch 19, 2023 19:13
@benibus
benibus
marked this pull request as ready for review
March 19, 2023 21:06
@kou
kou
commented
Mar 19, 2023

Copy link


Copy Markdown

Member
There are still some enabled components:
https://github.com/apache/arrow/actions/runs/4462272725/jobs/7836694435?pr=34617#step:6:1866
-- ARROW_BUILD_UTILITIES=ON [default=OFF]
-- Build Arrow commandline utilities
-- ARROW_CSV=ON [default=OFF]
-- Build the Arrow CSV Parser Module
-- ARROW_FILESYSTEM=ON [default=OFF]
-- Build the Arrow Filesystem Layer
-- ARROW_IPC=ON [default=ON]
-- Build the Arrow IPC extensions
-- ARROW_JSON=ON [default=OFF]
-- Build Arrow with JSON support (requires RapidJSON)
-- ARROW_PARQUET=ON [default=OFF]
-- Build the Parquet libraries

Are they intentional?
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Are they intentional?
ARROW_BUILD_UTILITIES and ARROW_FILESYSTEM are unintentional (I think the latter is being enabled by PARQUET_REQUIRE_ENCRYPTION=ON). Regarding the others, see my edit to the body message (I attempted to clarify my intent as well).
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Also, fair warning: I've never actually messed with CI system before so there may be a better way to do this. I just went with one of the preexisting Ubuntu images since it seemed like a reasonable base (to me, at least).
@kou
kou
commented
Mar 20, 2023

Copy link


Copy Markdown

Member
OK. Then "minimal" may be misleading. For example, we use "minimal" as "all components are disabled" in https://github.com/apache/arrow/blob/main/cpp/CMakePresets.json#L49 . Can we use other label for this job?
If we enable Parquet, CI time isn't short. How about running this as a nightly CI job instead like test-*-cpp-* in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L1171-L1256 ?
@benibus
benibus
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
I agree that it's misleading.
We could also handle both cases pretty easily, I think. The "minimal" image I have here could disable everything as it implies. Then, the nightly task would use that image but enable CSV/Parquet.
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
e3d60b9 to
aa7cb5bCompareMarch 20, 2023 16:58
@benibus
benibus
commented
Mar 20, 2023•

edited by kou

Loading

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-7a8059874a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-89628f20c6
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
reviewed
Mar 21, 2023
View reviewed changes
Comment thread.github/workflows/cpp.yml
Outdated

Comment threaddev/tasks/tasks.yml
Outdated

@kou
kou
commented
Mar 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Could you also update "minimal" in the title and the description of this PR and GH-34615?
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Mar 21, 2023
@benibusbenibus
mentioned this pull request
Mar 21, 2023

Closed

@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
aa7cb5b to
9147c15CompareMarch 21, 2023 16:08
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Mar 21, 2023
@benibusbenibus
changed the title
GH-34615: [CI][C++] Add CI job for minimal C++ buildGH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTEMar 21, 2023
@benibus
benibus
requested a review
from kouMarch 21, 2023 16:44
@kou
kou
commented
Mar 21, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 21, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-b9824dee1c
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
I've updated the body to include the closes #34655 as suggested.
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-2e55c6dbfe
TaskStatus
test-cuda-cppGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
The test-cuda-cpp seems to fail with a similar error to the one reported on #34655 :
 '_error_or_value25.status()' failed with Key error: No function registered with name: sort_indices
/arrow/cpp/src/arrow/compute/exec/order_by_node_test.cc:61: Failure
Failed

@benibus let me know if I should open a different issue for that or should be fixed here. Thanks!
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@raulcd Yeah, I saw that last night. Probably best to handle it here as well.
I'll do a light CMake refactor to hopefully prevent more of these issues since it's too easy to make mistakes ATM.
@benibus
Add CI image ubuntu-cpp-minimal
3f7f99a
@benibus
Install tzdata in ubuntu docker images
9a0ad0b
Some temporal casts will fail without timezone info
@benibus
Separate compute-expression-test
a1bea2e
compute-expression-test was recently merged into compute-internals-test
as part of a larger refactor. However, the expression tests depend on
additional kernels (i.e. equal) so I re-separated them.
@benibus
Add Crossbow job with additional formats
b59c35a
@benibus
Use params.flags to enable components
67df515
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
9147c15 to
42e52beCompareMarch 22, 2023 14:16
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
42e52be to
0a79eb3CompareMarch 22, 2023 14:18
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@kou@raulcd test-ubuntu-20.04-cpp-minimal-with-formats and test-cuda-cpp should pass on this branch now.
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-53125ee05c
TaskStatus
test-cuda-cppGithub Actions
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-a36f0bd26a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
approved these changes
Mar 23, 2023
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 4487be0
into
apache:mainMar 23, 2023
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
Mar 23, 2023
@ursabot
ursabot
commented
Mar 23, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 3600bd8 and contender = 4487be0. 4487be0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.18% ⬆️0.0%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.09% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4487be02 ec2-t3-xlarge-us-east-2

[Finished] 4487be02 test-mac-arm

[Finished] 4487be02 ursa-i9-9960x

[Finished] 4487be02 ursa-thinkcentre-m75q

[Finished] 3600bd80 ec2-t3-xlarge-us-east-2

[Finished] 3600bd80 test-mac-arm

[Finished] 3600bd80 ursa-i9-9960x

[Finished] 3600bd80 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@benibus@ArgusLi
apacheGH-34615: [CI][C++] Add CI job for basic format support without…
01a94a4
… ARROW_COMPUTE (apache#34617)
This adds a crossbow job for `ARROW_IPC`, `ARROW_PARQUET`, and `ARROW_CSV` - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by `ARROW_COMPUTE`. Note that `ARROW_JSON` is implicitly enabled as well, since it's a dependency of `ARROW_TESTING`.
* Closes: apache#34615
* Closes: apache#34655 Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@koukou
mentioned this pull request
Sep 18, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@westonpacewestonpaceAwaiting requested review from westonpace

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: C++

Projects


None yet


Milestone


No milestone


4 participants

@benibus@kou@raulcd@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE - #34617
Merged
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Mar 23, 2023
Merged
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE#34617
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Conversation
@benibus
@benibusbenibus
commented
Mar 17, 2023•

edited by raulcd

Loading

Copy link


Copy Markdown

Contributor
This adds a crossbow job for ARROW_IPC, ARROW_PARQUET, and ARROW_CSV - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by ARROW_COMPUTE. Note that ARROW_JSON is implicitly enabled as well, since it's a dependency of ARROW_TESTING.
@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #34615has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 17, 2023
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
2 times, most recently
from
5510338 to
eee9253CompareMarch 19, 2023 00:25
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
eee9253 to
e3d60b9CompareMarch 19, 2023 19:13
@benibus
benibus
marked this pull request as ready for review
March 19, 2023 21:06
@kou
kou
commented
Mar 19, 2023

Copy link


Copy Markdown

Member
There are still some enabled components:
https://github.com/apache/arrow/actions/runs/4462272725/jobs/7836694435?pr=34617#step:6:1866
-- ARROW_BUILD_UTILITIES=ON [default=OFF]
-- Build Arrow commandline utilities
-- ARROW_CSV=ON [default=OFF]
-- Build the Arrow CSV Parser Module
-- ARROW_FILESYSTEM=ON [default=OFF]
-- Build the Arrow Filesystem Layer
-- ARROW_IPC=ON [default=ON]
-- Build the Arrow IPC extensions
-- ARROW_JSON=ON [default=OFF]
-- Build Arrow with JSON support (requires RapidJSON)
-- ARROW_PARQUET=ON [default=OFF]
-- Build the Parquet libraries

Are they intentional?
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Are they intentional?
ARROW_BUILD_UTILITIES and ARROW_FILESYSTEM are unintentional (I think the latter is being enabled by PARQUET_REQUIRE_ENCRYPTION=ON). Regarding the others, see my edit to the body message (I attempted to clarify my intent as well).
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Also, fair warning: I've never actually messed with CI system before so there may be a better way to do this. I just went with one of the preexisting Ubuntu images since it seemed like a reasonable base (to me, at least).
@kou
kou
commented
Mar 20, 2023

Copy link


Copy Markdown

Member
OK. Then "minimal" may be misleading. For example, we use "minimal" as "all components are disabled" in https://github.com/apache/arrow/blob/main/cpp/CMakePresets.json#L49 . Can we use other label for this job?
If we enable Parquet, CI time isn't short. How about running this as a nightly CI job instead like test-*-cpp-* in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L1171-L1256 ?
@benibus
benibus
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
I agree that it's misleading.
We could also handle both cases pretty easily, I think. The "minimal" image I have here could disable everything as it implies. Then, the nightly task would use that image but enable CSV/Parquet.
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
e3d60b9 to
aa7cb5bCompareMarch 20, 2023 16:58
@benibus
benibus
commented
Mar 20, 2023•

edited by kou

Loading

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-7a8059874a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-89628f20c6
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
reviewed
Mar 21, 2023
View reviewed changes
Comment thread.github/workflows/cpp.yml
Outdated

Comment threaddev/tasks/tasks.yml
Outdated

@kou
kou
commented
Mar 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Could you also update "minimal" in the title and the description of this PR and GH-34615?
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Mar 21, 2023
@benibusbenibus
mentioned this pull request
Mar 21, 2023

Closed

@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
aa7cb5b to
9147c15CompareMarch 21, 2023 16:08
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Mar 21, 2023
@benibusbenibus
changed the title
GH-34615: [CI][C++] Add CI job for minimal C++ buildGH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTEMar 21, 2023
@benibus
benibus
requested a review
from kouMarch 21, 2023 16:44
@kou
kou
commented
Mar 21, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 21, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-b9824dee1c
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
I've updated the body to include the closes #34655 as suggested.
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-2e55c6dbfe
TaskStatus
test-cuda-cppGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
The test-cuda-cpp seems to fail with a similar error to the one reported on #34655 :
 '_error_or_value25.status()' failed with Key error: No function registered with name: sort_indices
/arrow/cpp/src/arrow/compute/exec/order_by_node_test.cc:61: Failure
Failed

@benibus let me know if I should open a different issue for that or should be fixed here. Thanks!
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@raulcd Yeah, I saw that last night. Probably best to handle it here as well.
I'll do a light CMake refactor to hopefully prevent more of these issues since it's too easy to make mistakes ATM.
@benibus
Add CI image ubuntu-cpp-minimal
3f7f99a
@benibus
Install tzdata in ubuntu docker images
9a0ad0b
Some temporal casts will fail without timezone info
@benibus
Separate compute-expression-test
a1bea2e
compute-expression-test was recently merged into compute-internals-test
as part of a larger refactor. However, the expression tests depend on
additional kernels (i.e. equal) so I re-separated them.
@benibus
Add Crossbow job with additional formats
b59c35a
@benibus
Use params.flags to enable components
67df515
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
9147c15 to
42e52beCompareMarch 22, 2023 14:16
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
42e52be to
0a79eb3CompareMarch 22, 2023 14:18
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@kou@raulcd test-ubuntu-20.04-cpp-minimal-with-formats and test-cuda-cpp should pass on this branch now.
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-53125ee05c
TaskStatus
test-cuda-cppGithub Actions
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-a36f0bd26a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
approved these changes
Mar 23, 2023
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 4487be0
into
apache:mainMar 23, 2023
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
Mar 23, 2023
@ursabot
ursabot
commented
Mar 23, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 3600bd8 and contender = 4487be0. 4487be0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.18% ⬆️0.0%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.09% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4487be02 ec2-t3-xlarge-us-east-2

[Finished] 4487be02 test-mac-arm

[Finished] 4487be02 ursa-i9-9960x

[Finished] 4487be02 ursa-thinkcentre-m75q

[Finished] 3600bd80 ec2-t3-xlarge-us-east-2

[Finished] 3600bd80 test-mac-arm

[Finished] 3600bd80 ursa-i9-9960x

[Finished] 3600bd80 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@benibus@ArgusLi
apacheGH-34615: [CI][C++] Add CI job for basic format support without…
01a94a4
… ARROW_COMPUTE (apache#34617)
This adds a crossbow job for `ARROW_IPC`, `ARROW_PARQUET`, and `ARROW_CSV` - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by `ARROW_COMPUTE`. Note that `ARROW_JSON` is implicitly enabled as well, since it's a dependency of `ARROW_TESTING`.
* Closes: apache#34615
* Closes: apache#34655 Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@koukou
mentioned this pull request
Sep 18, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@westonpacewestonpaceAwaiting requested review from westonpace

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: C++

Projects


None yet


Milestone


No milestone


4 participants

@benibus@kou@raulcd@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE - #34617
Merged
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Mar 23, 2023
Merged
GH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTE#34617
kou merged 6 commits into
apache:mainfrom 
benibus:GH-34615-minimal-cpp-ci-job
Conversation
@benibus
@benibusbenibus
commented
Mar 17, 2023•

edited by raulcd

Loading

Copy link


Copy Markdown

Contributor
This adds a crossbow job for ARROW_IPC, ARROW_PARQUET, and ARROW_CSV - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by ARROW_COMPUTE. Note that ARROW_JSON is implicitly enabled as well, since it's a dependency of ARROW_TESTING.
@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

@github-actions
github-actionsBot
commented
Mar 17, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #34615has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 17, 2023
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
2 times, most recently
from
5510338 to
eee9253CompareMarch 19, 2023 00:25
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
eee9253 to
e3d60b9CompareMarch 19, 2023 19:13
@benibus
benibus
marked this pull request as ready for review
March 19, 2023 21:06
@kou
kou
commented
Mar 19, 2023

Copy link


Copy Markdown

Member
There are still some enabled components:
https://github.com/apache/arrow/actions/runs/4462272725/jobs/7836694435?pr=34617#step:6:1866
-- ARROW_BUILD_UTILITIES=ON [default=OFF]
-- Build Arrow commandline utilities
-- ARROW_CSV=ON [default=OFF]
-- Build the Arrow CSV Parser Module
-- ARROW_FILESYSTEM=ON [default=OFF]
-- Build the Arrow Filesystem Layer
-- ARROW_IPC=ON [default=ON]
-- Build the Arrow IPC extensions
-- ARROW_JSON=ON [default=OFF]
-- Build Arrow with JSON support (requires RapidJSON)
-- ARROW_PARQUET=ON [default=OFF]
-- Build the Parquet libraries

Are they intentional?
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Are they intentional?
ARROW_BUILD_UTILITIES and ARROW_FILESYSTEM are unintentional (I think the latter is being enabled by PARQUET_REQUIRE_ENCRYPTION=ON). Regarding the others, see my edit to the body message (I attempted to clarify my intent as well).
@benibus
benibus
commented
Mar 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Also, fair warning: I've never actually messed with CI system before so there may be a better way to do this. I just went with one of the preexisting Ubuntu images since it seemed like a reasonable base (to me, at least).
@kou
kou
commented
Mar 20, 2023

Copy link


Copy Markdown

Member
OK. Then "minimal" may be misleading. For example, we use "minimal" as "all components are disabled" in https://github.com/apache/arrow/blob/main/cpp/CMakePresets.json#L49 . Can we use other label for this job?
If we enable Parquet, CI time isn't short. How about running this as a nightly CI job instead like test-*-cpp-* in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L1171-L1256 ?
@benibus
benibus
commented
Mar 20, 2023

Copy link


Copy Markdown

ContributorAuthor
I agree that it's misleading.
We could also handle both cases pretty easily, I think. The "minimal" image I have here could disable everything as it implies. Then, the nightly task would use that image but enable CSV/Parquet.
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
e3d60b9 to
aa7cb5bCompareMarch 20, 2023 16:58
@benibus
benibus
commented
Mar 20, 2023•

edited by kou

Loading

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-7a8059874a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@github-actions
github-actionsBot
commented
Mar 20, 2023

Copy link


Copy Markdown

Revision: aa7cb5b4fae7bd3505c8f6dbc976ae5131028bfd
Submitted crossbow builds: ursacomputing/crossbow @ actions-89628f20c6
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
reviewed
Mar 21, 2023
View reviewed changes
Comment thread.github/workflows/cpp.yml
Outdated

Comment threaddev/tasks/tasks.yml
Outdated

@kou
kou
commented
Mar 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Could you also update "minimal" in the title and the description of this PR and GH-34615?
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Mar 21, 2023
@benibusbenibus
mentioned this pull request
Mar 21, 2023

Closed

@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
aa7cb5b to
9147c15CompareMarch 21, 2023 16:08
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Mar 21, 2023
@benibusbenibus
changed the title
GH-34615: [CI][C++] Add CI job for minimal C++ buildGH-34615: [CI][C++] Add CI job for basic format support without ARROW_COMPUTEMar 21, 2023
@benibus
benibus
requested a review
from kouMarch 21, 2023 16:44
@kou
kou
commented
Mar 21, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 21, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-b9824dee1c
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
I've updated the body to include the closes #34655 as suggested.
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 9147c15ce4120b9b6fc0d9b233d50d7bc1d1d2a7
Submitted crossbow builds: ursacomputing/crossbow @ actions-2e55c6dbfe
TaskStatus
test-cuda-cppGithub Actions
@raulcd
raulcd
commented
Mar 22, 2023

Copy link


Copy Markdown

Member
The test-cuda-cpp seems to fail with a similar error to the one reported on #34655 :
 '_error_or_value25.status()' failed with Key error: No function registered with name: sort_indices
/arrow/cpp/src/arrow/compute/exec/order_by_node_test.cc:61: Failure
Failed

@benibus let me know if I should open a different issue for that or should be fixed here. Thanks!
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@raulcd Yeah, I saw that last night. Probably best to handle it here as well.
I'll do a light CMake refactor to hopefully prevent more of these issues since it's too easy to make mistakes ATM.
@benibus
Add CI image ubuntu-cpp-minimal
3f7f99a
@benibus
Install tzdata in ubuntu docker images
9a0ad0b
Some temporal casts will fail without timezone info
@benibus
Separate compute-expression-test
a1bea2e
compute-expression-test was recently merged into compute-internals-test
as part of a larger refactor. However, the expression tests depend on
additional kernels (i.e. equal) so I re-separated them.
@benibus
Add Crossbow job with additional formats
b59c35a
@benibus
Use params.flags to enable components
67df515
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
9147c15 to
42e52beCompareMarch 22, 2023 14:16
@benibus
benibusforce-pushed
the
GH-34615-minimal-cpp-ci-job
branch
from
42e52be to
0a79eb3CompareMarch 22, 2023 14:18
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@kou@raulcd test-ubuntu-20.04-cpp-minimal-with-formats and test-cuda-cpp should pass on this branch now.
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-cuda-cpp
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-53125ee05c
TaskStatus
test-cuda-cppGithub Actions
@benibus
benibus
commented
Mar 22, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp-minimal-with-formats
@github-actions
github-actionsBot
commented
Mar 22, 2023

Copy link


Copy Markdown

Revision: 0a79eb3
Submitted crossbow builds: ursacomputing/crossbow @ actions-a36f0bd26a
TaskStatus
test-ubuntu-20.04-cpp-minimal-with-formatsGithub Actions
kou
kou
approved these changes
Mar 23, 2023
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 4487be0
into
apache:mainMar 23, 2023
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
Mar 23, 2023
@ursabot
ursabot
commented
Mar 23, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 3600bd8 and contender = 4487be0. 4487be0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.18% ⬆️0.0%] test-mac-arm

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.09% ⬆️0.03%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 4487be02 ec2-t3-xlarge-us-east-2

[Finished] 4487be02 test-mac-arm

[Finished] 4487be02 ursa-i9-9960x

[Finished] 4487be02 ursa-thinkcentre-m75q

[Finished] 3600bd80 ec2-t3-xlarge-us-east-2

[Finished] 3600bd80 test-mac-arm

[Finished] 3600bd80 ursa-i9-9960x

[Finished] 3600bd80 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@benibus@ArgusLi
apacheGH-34615: [CI][C++] Add CI job for basic format support without…
01a94a4
… ARROW_COMPUTE (apache#34617)
This adds a crossbow job for `ARROW_IPC`, `ARROW_PARQUET`, and `ARROW_CSV` - based on a minimal Ubuntu image.
The job primarily aims to test the core Arrow library + basic format support without the full kernel registry provided by `ARROW_COMPUTE`. Note that `ARROW_JSON` is implicitly enabled as well, since it's a dependency of `ARROW_TESTING`.
* Closes: apache#34615
* Closes: apache#34655 Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@koukou
mentioned this pull request
Sep 18, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@westonpacewestonpaceAwaiting requested review from westonpace

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: C++

Projects


None yet


Milestone


No milestone


4 participants

@benibus@kou@raulcd@ursabot