') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); })(); GH-34768: [C++][Gandiva] Accept LLVM 16 by kou · Pull Request #34916 · apache/arrow · GitHub
Skip to content

GH-34768: [C++][Gandiva] Accept LLVM 16 - #34916

Merged
kou merged 1 commit into
apache:mainfrom
kou:cpp-llvm-16
Apr 6, 2023
Merged

GH-34768: [C++][Gandiva] Accept LLVM 16#34916
kou merged 1 commit into
apache:mainfrom
kou:cpp-llvm-16

Conversation

@kou

@koukou commented Apr 6, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Rationale for this change

LLVM 16 has been released.

What changes are included in this PR?

Accept LLVM 16.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions

github-actionsBot commented Apr 6, 2023

Copy link
Copy Markdown

@kou

kou commented Apr 6, 2023

Copy link
Copy Markdown
MemberAuthor

+1

@kou
kou merged commit 6530b01 into apache:mainApr 6, 2023
@kou
kou deleted the cpp-llvm-16 branch April 6, 2023 05:36
@jorisvandenbosschejorisvandenbossche mentioned this pull request Apr 6, 2023
Merged
jorisvandenbossche added a commit that referenced this pull request Apr 6, 2023
@jorisvandenbossche
GH-34768: [C++][Gandiva] Remove LLVM<16 pin (#34922)
1c19650
Small follow-up on #34916 to remove this temporary pin now LLVM 16 is accepted
* Closes: #34768
Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot

ursabot commented Apr 6, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 8d8d21f and contender = 6530b01. 6530b01 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.26%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6530b019 ec2-t3-xlarge-us-east-2
[Failed] 6530b019 test-mac-arm
[Finished] 6530b019 ursa-i9-9960x
[Failed] 6530b019 ursa-thinkcentre-m75q
[Finished] 8d8d21ff ec2-t3-xlarge-us-east-2
[Failed] 8d8d21ff test-mac-arm
[Failed] 8d8d21ff ursa-i9-9960x
[Failed] 8d8d21ff ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@kou@liujiacheng777
apacheGH-34768: [C++][Gandiva] Accept LLVM 16 (apache#34916)
986f001
### Rationale for this change
LLVM 16 has been released.
### What changes are included in this PR?
Accept LLVM 16.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
* Closes: apache#34768
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@jorisvandenbossche@liujiacheng777
apacheGH-34768: [C++][Gandiva] Remove LLVM<16 pin (apache#34922)
81966a0
Small follow-up on apache#34916 to remove this temporary pin now LLVM 16 is accepted
* Closes: apache#34768
Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@kou@ArgusLi
apacheGH-34768: [C++][Gandiva] Accept LLVM 16 (apache#34916)
e4f9393
### Rationale for this change
LLVM 16 has been released.
### What changes are included in this PR?
Accept LLVM 16.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
* Closes: apache#34768
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@jorisvandenbossche@ArgusLi
apacheGH-34768: [C++][Gandiva] Remove LLVM<16 pin (apache#34922)
f603e45
Small follow-up on apache#34916 to remove this temporary pin now LLVM 16 is accepted
* Closes: apache#34768
Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@dkavdkav mentioned this pull request Oct 27, 2023
Closed
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees

No one assigned

Labels

awaiting committer reviewAwaiting committer reviewComponent: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++][Gandiva] Accept LLVM 16

2 participants

@kou@ursabot