Skip to content

GH-34966: [Go] Add InsertField and FieldIndex to Schema object - #34967

Closed
yevgenypats wants to merge 2 commits into
apache:mainfrom
cloudquery:feat/schema
Closed

GH-34966: [Go] Add InsertField and FieldIndex to Schema object#34967
yevgenypats wants to merge 2 commits into
apache:mainfrom
cloudquery:feat/schema

Conversation

@yevgenypats

@yevgenypatsyevgenypats commented Apr 7, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions

github-actionsBot commented Apr 7, 2023

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Apr 7, 2023

Copy link
Copy Markdown

⚠️ GitHub issue apache/arrow-go#60has been automatically assigned in GitHub to PR creator.

@yevgenypatsyevgenypats changed the title GH-34966: Add InsertField and FieldIndex to Schema objectGH-34966: [Go] Add InsertField and FieldIndex to Schema objectApr 7, 2023
zeroshade
zeroshade requested changes Apr 11, 2023
View reviewed changes

@zeroshadezeroshade left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's the InsertField method? 😄

Comment threadgo/arrow/schema.go
return sc.index[n]
}

// FieldIndex return index of the unique field with the given name.

@zeroshadezeroshadeApr 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: returns the index

Also, is there a reason to have this in addition to the existing FieldIndices method? A consumer could just do the same length check and use index 0 themselves.

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 11, 2023
@vibhatha

vibhatha commented Apr 22, 2023

Copy link
Copy Markdown
Contributor

@zeroshade I also took a look at the PR and built locally too. FieldIndex looks right to me. Also, the InsertField function is not available.

@candiduslynx
candiduslynx deleted the feat/schema branch June 2, 2023 11:59
@zeroshade

zeroshade commented Jul 17, 2023

Copy link
Copy Markdown
Member

No activity since April, I'm going to close this for now. Feel free to reopen if this is still needed. Thanks!

@github-actions

github-actionsBot commented Aug 30, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #34966 has no components, please add labels for components.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeroshadezeroshadezeroshade requested changes

Assignees

No one assigned

Labels

awaiting changesAwaiting changesComponent: Go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Go]: Add IndexField and InsertField for Schema

3 participants

@yevgenypats@vibhatha@zeroshade