GH-35490: [Python] Interchange protocol: update tests for string and large_string - #35504

Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom
AlenkaF:gh-35490-interchange-large-string
May 11, 2023
Merged

GH-35490: [Python] Interchange protocol: update tests for string and large_string#35504
jorisvandenbossche merged 4 commits into
apache:mainfrom
AlenkaF:gh-35490-interchange-large-string

Conversation

@AlenkaF

@AlenkaFAlenkaF commented May 9, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Rationale for this change

In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.

What changes are included in this PR?

Changes in tests:

  • test_pandas_assertion_error_large_string removed
  • test_roundtrip_pandas_string updated

@github-actions

github-actionsBot commented May 9, 2023

Copy link
Copy Markdown

jorisvandenbossche
jorisvandenbossche reviewed May 9, 2023
View reviewed changes

@jorisvandenbosschejorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to test normal string for older pandas? (because now the test combines both, and so doesn't test it for older versions?)

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels May 9, 2023
@AlenkaF

AlenkaF commented May 9, 2023

Copy link
Copy Markdown
MemberAuthor

Oh yes, of course! Will correct 👍

@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels May 9, 2023
jorisvandenbossche
jorisvandenbossche reviewed May 10, 2023
View reviewed changes
Comment threadpython/pyarrow/tests/interchange/test_conversion.py Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels May 10, 2023
@AlenkaF

AlenkaF commented May 10, 2023

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python--pandas-

@github-actions

github-actionsBot commented May 10, 2023

Copy link
Copy Markdown

Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec

Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268

TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

@AlenkaF
AlenkaFforce-pushed the gh-35490-interchange-large-string branch from 0179e1c to 5f05027CompareMay 10, 2023 10:27
@AlenkaF

AlenkaF commented May 10, 2023

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python--pandas-

@github-actions

github-actionsBot commented May 10, 2023

Copy link
Copy Markdown

Revision: 5f05027

Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313

TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

This was referenced May 10, 2023
Closed
Merged
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels May 11, 2023
@jorisvandenbossche

jorisvandenbossche commented May 11, 2023

Copy link
Copy Markdown
Member

Nightly failure is unrelated (but something else we should fix)

@jorisvandenbossche
jorisvandenbossche merged commit dec4453 into apache:mainMay 11, 2023
@AlenkaF
AlenkaF deleted the gh-35490-interchange-large-string branch May 11, 2023 08:00
@AlenkaF

AlenkaF commented May 11, 2023

Copy link
Copy Markdown
MemberAuthor

Nightly failure is unrelated (but something else we should fix)

I think this failure is connected to #34789?

@jorisvandenbossche

jorisvandenbossche commented May 11, 2023

Copy link
Copy Markdown
Member

Yes, indeed, I am looking at that

jorisvandenbossche pushed a commit that referenced this pull request May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot

ursabot commented May 11, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.21% ⬆️0.0%] test-mac-arm
[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.63% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] dec44537 ec2-t3-xlarge-us-east-2
[Finished] dec44537 test-mac-arm
[Finished] dec44537 ursa-i9-9960x
[Finished] dec44537 ursa-thinkcentre-m75q
[Finished] 11780b96 ec2-t3-xlarge-us-east-2
[Finished] 11780b96 test-mac-arm
[Finished] 11780b96 ursa-i9-9960x
[Finished] 11780b96 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented May 11, 2023

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35490: [Python] Interchange protocol: update tests for strin…
d7573d4
…g and large_string (apache#35504)
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
* Closes: apache#35490
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff
…35530)
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees

No one assigned

Labels

awaiting mergeAwaiting mergeComponent: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python] Interchange - test failing on MacOS builds

3 participants

@AlenkaF@jorisvandenbossche@ursabot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-35490: [Python] Interchange protocol: update tests for string and large_string - #35504
Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
May 11, 2023
Merged
GH-35490: [Python] Interchange protocol: update tests for string and large_string#35504
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
Conversation
@AlenkaF
@AlenkaFAlenkaF
commented
May 9, 2023•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
What changes are included in this PR?
Changes in tests:
  • test_pandas_assertion_error_large_string removed
  • test_roundtrip_pandas_string  updated
@github-actions
github-actionsBot
commented
May 9, 2023

Copy link


Copy Markdown

jorisvandenbossche
jorisvandenbossche
reviewed
May 9, 2023
View reviewed changes
@jorisvandenbosschejorisvandenbossche
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to test normal string for older pandas? (because now the test combines both, and so doesn't test it for older versions?)
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
May 9, 2023
@AlenkaF
AlenkaF
commented
May 9, 2023

Copy link


Copy Markdown

MemberAuthor
Oh yes, of course! Will correct 👍
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
May 9, 2023
jorisvandenbossche
jorisvandenbossche
reviewed
May 10, 2023
View reviewed changes
Comment threadpython/pyarrow/tests/interchange/test_conversion.py
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
awaiting change review
Awaiting change review
and removed

awaiting change review
Awaiting change review
awaiting changes
Awaiting changes
labels
May 10, 2023
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec
Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions
@AlenkaF
AlenkaFforce-pushed
the
gh-35490-interchange-large-string
branch
from
0179e1c to
5f05027CompareMay 10, 2023 10:27
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 5f05027
Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

This was referenced May 10, 2023

Closed

 Merged

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
May 11, 2023
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Nightly failure is unrelated (but something else we should fix)
@jorisvandenbossche
jorisvandenbossche
merged commit dec4453
into
apache:mainMay 11, 2023
@AlenkaF
AlenkaF
deleted the

gh-35490-interchange-large-string

branch
May 11, 2023 08:00
@AlenkaF
AlenkaF
commented
May 11, 2023

Copy link


Copy Markdown

MemberAuthor
Nightly failure is unrelated (but something else we should fix)
I think this failure is connected to #34789?
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Yes, indeed, I am looking at that
jorisvandenbossche pushed a commit
that referenced
this pull request
May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️2.21% ⬆️0.0%] test-mac-arm

[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.63% ⬆️0.06%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] dec44537 ec2-t3-xlarge-us-east-2

[Finished] dec44537 test-mac-arm

[Finished] dec44537 ursa-i9-9960x

[Finished] dec44537 ursa-thinkcentre-m75q

[Finished] 11780b96 ec2-t3-xlarge-us-east-2

[Finished] 11780b96 test-mac-arm

[Finished] 11780b96 ursa-i9-9960x

[Finished] 11780b96 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35490: [Python] Interchange protocol: update tests for strin…
d7573d4
…g and large_string (apache#35504)
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
* Closes: apache#35490
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff
…35530)
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python] Interchange - test failing on MacOS builds


3 participants

@AlenkaF@jorisvandenbossche@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-35490: [Python] Interchange protocol: update tests for string and large_string - #35504
Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
May 11, 2023
Merged
GH-35490: [Python] Interchange protocol: update tests for string and large_string#35504
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
Conversation
@AlenkaF
@AlenkaFAlenkaF
commented
May 9, 2023•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
What changes are included in this PR?
Changes in tests:
  • test_pandas_assertion_error_large_string removed
  • test_roundtrip_pandas_string  updated
@github-actions
github-actionsBot
commented
May 9, 2023

Copy link


Copy Markdown

jorisvandenbossche
jorisvandenbossche
reviewed
May 9, 2023
View reviewed changes
@jorisvandenbosschejorisvandenbossche
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to test normal string for older pandas? (because now the test combines both, and so doesn't test it for older versions?)
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
May 9, 2023
@AlenkaF
AlenkaF
commented
May 9, 2023

Copy link


Copy Markdown

MemberAuthor
Oh yes, of course! Will correct 👍
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
May 9, 2023
jorisvandenbossche
jorisvandenbossche
reviewed
May 10, 2023
View reviewed changes
Comment threadpython/pyarrow/tests/interchange/test_conversion.py
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
awaiting change review
Awaiting change review
and removed

awaiting change review
Awaiting change review
awaiting changes
Awaiting changes
labels
May 10, 2023
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec
Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions
@AlenkaF
AlenkaFforce-pushed
the
gh-35490-interchange-large-string
branch
from
0179e1c to
5f05027CompareMay 10, 2023 10:27
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 5f05027
Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

This was referenced May 10, 2023

Closed

 Merged

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
May 11, 2023
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Nightly failure is unrelated (but something else we should fix)
@jorisvandenbossche
jorisvandenbossche
merged commit dec4453
into
apache:mainMay 11, 2023
@AlenkaF
AlenkaF
deleted the

gh-35490-interchange-large-string

branch
May 11, 2023 08:00
@AlenkaF
AlenkaF
commented
May 11, 2023

Copy link


Copy Markdown

MemberAuthor
Nightly failure is unrelated (but something else we should fix)
I think this failure is connected to #34789?
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Yes, indeed, I am looking at that
jorisvandenbossche pushed a commit
that referenced
this pull request
May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️2.21% ⬆️0.0%] test-mac-arm

[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.63% ⬆️0.06%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] dec44537 ec2-t3-xlarge-us-east-2

[Finished] dec44537 test-mac-arm

[Finished] dec44537 ursa-i9-9960x

[Finished] dec44537 ursa-thinkcentre-m75q

[Finished] 11780b96 ec2-t3-xlarge-us-east-2

[Finished] 11780b96 test-mac-arm

[Finished] 11780b96 ursa-i9-9960x

[Finished] 11780b96 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35490: [Python] Interchange protocol: update tests for strin…
d7573d4
…g and large_string (apache#35504)
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
* Closes: apache#35490
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff
…35530)
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python] Interchange - test failing on MacOS builds


3 participants

@AlenkaF@jorisvandenbossche@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-35490: [Python] Interchange protocol: update tests for string and large_string - #35504
Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
May 11, 2023
Merged
GH-35490: [Python] Interchange protocol: update tests for string and large_string#35504
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
Conversation
@AlenkaF
@AlenkaFAlenkaF
commented
May 9, 2023•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
What changes are included in this PR?
Changes in tests:
  • test_pandas_assertion_error_large_string removed
  • test_roundtrip_pandas_string  updated
@github-actions
github-actionsBot
commented
May 9, 2023

Copy link


Copy Markdown

jorisvandenbossche
jorisvandenbossche
reviewed
May 9, 2023
View reviewed changes
@jorisvandenbosschejorisvandenbossche
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to test normal string for older pandas? (because now the test combines both, and so doesn't test it for older versions?)
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
May 9, 2023
@AlenkaF
AlenkaF
commented
May 9, 2023

Copy link


Copy Markdown

MemberAuthor
Oh yes, of course! Will correct 👍
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
May 9, 2023
jorisvandenbossche
jorisvandenbossche
reviewed
May 10, 2023
View reviewed changes
Comment threadpython/pyarrow/tests/interchange/test_conversion.py
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
awaiting change review
Awaiting change review
and removed

awaiting change review
Awaiting change review
awaiting changes
Awaiting changes
labels
May 10, 2023
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec
Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions
@AlenkaF
AlenkaFforce-pushed
the
gh-35490-interchange-large-string
branch
from
0179e1c to
5f05027CompareMay 10, 2023 10:27
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 5f05027
Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

This was referenced May 10, 2023

Closed

 Merged

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
May 11, 2023
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Nightly failure is unrelated (but something else we should fix)
@jorisvandenbossche
jorisvandenbossche
merged commit dec4453
into
apache:mainMay 11, 2023
@AlenkaF
AlenkaF
deleted the

gh-35490-interchange-large-string

branch
May 11, 2023 08:00
@AlenkaF
AlenkaF
commented
May 11, 2023

Copy link


Copy Markdown

MemberAuthor
Nightly failure is unrelated (but something else we should fix)
I think this failure is connected to #34789?
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Yes, indeed, I am looking at that
jorisvandenbossche pushed a commit
that referenced
this pull request
May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️2.21% ⬆️0.0%] test-mac-arm

[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.63% ⬆️0.06%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] dec44537 ec2-t3-xlarge-us-east-2

[Finished] dec44537 test-mac-arm

[Finished] dec44537 ursa-i9-9960x

[Finished] dec44537 ursa-thinkcentre-m75q

[Finished] 11780b96 ec2-t3-xlarge-us-east-2

[Finished] 11780b96 test-mac-arm

[Finished] 11780b96 ursa-i9-9960x

[Finished] 11780b96 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35490: [Python] Interchange protocol: update tests for strin…
d7573d4
…g and large_string (apache#35504)
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
* Closes: apache#35490
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff
…35530)
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python] Interchange - test failing on MacOS builds


3 participants

@AlenkaF@jorisvandenbossche@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-35490: [Python] Interchange protocol: update tests for string and large_string - #35504
Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
May 11, 2023
Merged
GH-35490: [Python] Interchange protocol: update tests for string and large_string#35504
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
Conversation
@AlenkaF
@AlenkaFAlenkaF
commented
May 9, 2023•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
What changes are included in this PR?
Changes in tests:
  • test_pandas_assertion_error_large_string removed
  • test_roundtrip_pandas_string  updated
@github-actions
github-actionsBot
commented
May 9, 2023

Copy link


Copy Markdown

jorisvandenbossche
jorisvandenbossche
reviewed
May 9, 2023
View reviewed changes
@jorisvandenbosschejorisvandenbossche
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to test normal string for older pandas? (because now the test combines both, and so doesn't test it for older versions?)
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
May 9, 2023
@AlenkaF
AlenkaF
commented
May 9, 2023

Copy link


Copy Markdown

MemberAuthor
Oh yes, of course! Will correct 👍
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
May 9, 2023
jorisvandenbossche
jorisvandenbossche
reviewed
May 10, 2023
View reviewed changes
Comment threadpython/pyarrow/tests/interchange/test_conversion.py
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
awaiting change review
Awaiting change review
and removed

awaiting change review
Awaiting change review
awaiting changes
Awaiting changes
labels
May 10, 2023
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec
Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions
@AlenkaF
AlenkaFforce-pushed
the
gh-35490-interchange-large-string
branch
from
0179e1c to
5f05027CompareMay 10, 2023 10:27
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 5f05027
Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

This was referenced May 10, 2023

Closed

 Merged

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
May 11, 2023
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Nightly failure is unrelated (but something else we should fix)
@jorisvandenbossche
jorisvandenbossche
merged commit dec4453
into
apache:mainMay 11, 2023
@AlenkaF
AlenkaF
deleted the

gh-35490-interchange-large-string

branch
May 11, 2023 08:00
@AlenkaF
AlenkaF
commented
May 11, 2023

Copy link


Copy Markdown

MemberAuthor
Nightly failure is unrelated (but something else we should fix)
I think this failure is connected to #34789?
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Yes, indeed, I am looking at that
jorisvandenbossche pushed a commit
that referenced
this pull request
May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️2.21% ⬆️0.0%] test-mac-arm

[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.63% ⬆️0.06%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] dec44537 ec2-t3-xlarge-us-east-2

[Finished] dec44537 test-mac-arm

[Finished] dec44537 ursa-i9-9960x

[Finished] dec44537 ursa-thinkcentre-m75q

[Finished] 11780b96 ec2-t3-xlarge-us-east-2

[Finished] 11780b96 test-mac-arm

[Finished] 11780b96 ursa-i9-9960x

[Finished] 11780b96 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35490: [Python] Interchange protocol: update tests for strin…
d7573d4
…g and large_string (apache#35504)
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
* Closes: apache#35490
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff
…35530)
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python] Interchange - test failing on MacOS builds


3 participants

@AlenkaF@jorisvandenbossche@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-35490: [Python] Interchange protocol: update tests for string and large_string - #35504
Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
May 11, 2023
Merged
GH-35490: [Python] Interchange protocol: update tests for string and large_string#35504
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
Conversation
@AlenkaF
@AlenkaFAlenkaF
commented
May 9, 2023•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
What changes are included in this PR?
Changes in tests:
  • test_pandas_assertion_error_large_string removed
  • test_roundtrip_pandas_string  updated
@github-actions
github-actionsBot
commented
May 9, 2023

Copy link


Copy Markdown

jorisvandenbossche
jorisvandenbossche
reviewed
May 9, 2023
View reviewed changes
@jorisvandenbosschejorisvandenbossche
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to test normal string for older pandas? (because now the test combines both, and so doesn't test it for older versions?)
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
May 9, 2023
@AlenkaF
AlenkaF
commented
May 9, 2023

Copy link


Copy Markdown

MemberAuthor
Oh yes, of course! Will correct 👍
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
May 9, 2023
jorisvandenbossche
jorisvandenbossche
reviewed
May 10, 2023
View reviewed changes
Comment threadpython/pyarrow/tests/interchange/test_conversion.py
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
awaiting change review
Awaiting change review
and removed

awaiting change review
Awaiting change review
awaiting changes
Awaiting changes
labels
May 10, 2023
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec
Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions
@AlenkaF
AlenkaFforce-pushed
the
gh-35490-interchange-large-string
branch
from
0179e1c to
5f05027CompareMay 10, 2023 10:27
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 5f05027
Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

This was referenced May 10, 2023

Closed

 Merged

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
May 11, 2023
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Nightly failure is unrelated (but something else we should fix)
@jorisvandenbossche
jorisvandenbossche
merged commit dec4453
into
apache:mainMay 11, 2023
@AlenkaF
AlenkaF
deleted the

gh-35490-interchange-large-string

branch
May 11, 2023 08:00
@AlenkaF
AlenkaF
commented
May 11, 2023

Copy link


Copy Markdown

MemberAuthor
Nightly failure is unrelated (but something else we should fix)
I think this failure is connected to #34789?
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Yes, indeed, I am looking at that
jorisvandenbossche pushed a commit
that referenced
this pull request
May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️2.21% ⬆️0.0%] test-mac-arm

[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.63% ⬆️0.06%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] dec44537 ec2-t3-xlarge-us-east-2

[Finished] dec44537 test-mac-arm

[Finished] dec44537 ursa-i9-9960x

[Finished] dec44537 ursa-thinkcentre-m75q

[Finished] 11780b96 ec2-t3-xlarge-us-east-2

[Finished] 11780b96 test-mac-arm

[Finished] 11780b96 ursa-i9-9960x

[Finished] 11780b96 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35490: [Python] Interchange protocol: update tests for strin…
d7573d4
…g and large_string (apache#35504)
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
* Closes: apache#35490
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff
…35530)
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python] Interchange - test failing on MacOS builds


3 participants

@AlenkaF@jorisvandenbossche@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-35490: [Python] Interchange protocol: update tests for string and large_string - #35504
Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
May 11, 2023
Merged
GH-35490: [Python] Interchange protocol: update tests for string and large_string#35504
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
Conversation
@AlenkaF
@AlenkaFAlenkaF
commented
May 9, 2023•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
What changes are included in this PR?
Changes in tests:
  • test_pandas_assertion_error_large_string removed
  • test_roundtrip_pandas_string  updated
@github-actions
github-actionsBot
commented
May 9, 2023

Copy link


Copy Markdown

jorisvandenbossche
jorisvandenbossche
reviewed
May 9, 2023
View reviewed changes
@jorisvandenbosschejorisvandenbossche
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to test normal string for older pandas? (because now the test combines both, and so doesn't test it for older versions?)
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
May 9, 2023
@AlenkaF
AlenkaF
commented
May 9, 2023

Copy link


Copy Markdown

MemberAuthor
Oh yes, of course! Will correct 👍
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
May 9, 2023
jorisvandenbossche
jorisvandenbossche
reviewed
May 10, 2023
View reviewed changes
Comment threadpython/pyarrow/tests/interchange/test_conversion.py
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
awaiting change review
Awaiting change review
and removed

awaiting change review
Awaiting change review
awaiting changes
Awaiting changes
labels
May 10, 2023
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec
Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions
@AlenkaF
AlenkaFforce-pushed
the
gh-35490-interchange-large-string
branch
from
0179e1c to
5f05027CompareMay 10, 2023 10:27
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 5f05027
Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

This was referenced May 10, 2023

Closed

 Merged

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
May 11, 2023
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Nightly failure is unrelated (but something else we should fix)
@jorisvandenbossche
jorisvandenbossche
merged commit dec4453
into
apache:mainMay 11, 2023
@AlenkaF
AlenkaF
deleted the

gh-35490-interchange-large-string

branch
May 11, 2023 08:00
@AlenkaF
AlenkaF
commented
May 11, 2023

Copy link


Copy Markdown

MemberAuthor
Nightly failure is unrelated (but something else we should fix)
I think this failure is connected to #34789?
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Yes, indeed, I am looking at that
jorisvandenbossche pushed a commit
that referenced
this pull request
May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️2.21% ⬆️0.0%] test-mac-arm

[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.63% ⬆️0.06%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] dec44537 ec2-t3-xlarge-us-east-2

[Finished] dec44537 test-mac-arm

[Finished] dec44537 ursa-i9-9960x

[Finished] dec44537 ursa-thinkcentre-m75q

[Finished] 11780b96 ec2-t3-xlarge-us-east-2

[Finished] 11780b96 test-mac-arm

[Finished] 11780b96 ursa-i9-9960x

[Finished] 11780b96 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35490: [Python] Interchange protocol: update tests for strin…
d7573d4
…g and large_string (apache#35504)
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
* Closes: apache#35490
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff
…35530)
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python] Interchange - test failing on MacOS builds


3 participants

@AlenkaF@jorisvandenbossche@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-35490: [Python] Interchange protocol: update tests for string and large_string - #35504
Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
May 11, 2023
Merged
GH-35490: [Python] Interchange protocol: update tests for string and large_string#35504
jorisvandenbossche merged 4 commits into
apache:mainfrom 
AlenkaF:gh-35490-interchange-large-string
Conversation
@AlenkaF
@AlenkaFAlenkaF
commented
May 9, 2023•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
What changes are included in this PR?
Changes in tests:
  • test_pandas_assertion_error_large_string removed
  • test_roundtrip_pandas_string  updated
@github-actions
github-actionsBot
commented
May 9, 2023

Copy link


Copy Markdown

jorisvandenbossche
jorisvandenbossche
reviewed
May 9, 2023
View reviewed changes
@jorisvandenbosschejorisvandenbossche
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to test normal string for older pandas? (because now the test combines both, and so doesn't test it for older versions?)
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
May 9, 2023
@AlenkaF
AlenkaF
commented
May 9, 2023

Copy link


Copy Markdown

MemberAuthor
Oh yes, of course! Will correct 👍
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
May 9, 2023
jorisvandenbossche
jorisvandenbossche
reviewed
May 10, 2023
View reviewed changes
Comment threadpython/pyarrow/tests/interchange/test_conversion.py
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
awaiting change review
Awaiting change review
and removed

awaiting change review
Awaiting change review
awaiting changes
Awaiting changes
labels
May 10, 2023
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec
Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions
@AlenkaF
AlenkaFforce-pushed
the
gh-35490-interchange-large-string
branch
from
0179e1c to
5f05027CompareMay 10, 2023 10:27
@AlenkaF
AlenkaF
commented
May 10, 2023

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-conda-python--pandas-
@github-actions
github-actionsBot
commented
May 10, 2023

Copy link


Copy Markdown

Revision: 5f05027
Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313
TaskStatus
test-conda-python-3.7-pandas-1.0Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.9-pandas-upstream_develGithub Actions

This was referenced May 10, 2023

Closed

 Merged

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting change review
Awaiting change review
labels
May 11, 2023
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Nightly failure is unrelated (but something else we should fix)
@jorisvandenbossche
jorisvandenbossche
merged commit dec4453
into
apache:mainMay 11, 2023
@AlenkaF
AlenkaF
deleted the

gh-35490-interchange-large-string

branch
May 11, 2023 08:00
@AlenkaF
AlenkaF
commented
May 11, 2023

Copy link


Copy Markdown

MemberAuthor
Nightly failure is unrelated (but something else we should fix)
I think this failure is connected to #34789?
@jorisvandenbossche
jorisvandenbossche
commented
May 11, 2023

Copy link


Copy Markdown

Member
Yes, indeed, I am looking at that
jorisvandenbossche pushed a commit
that referenced
this pull request
May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️2.21% ⬆️0.0%] test-mac-arm

[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.63% ⬆️0.06%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] dec44537 ec2-t3-xlarge-us-east-2

[Finished] dec44537 test-mac-arm

[Finished] dec44537 ursa-i9-9960x

[Finished] dec44537 ursa-thinkcentre-m75q

[Finished] 11780b96 ec2-t3-xlarge-us-east-2

[Finished] 11780b96 test-mac-arm

[Finished] 11780b96 ursa-i9-9960x

[Finished] 11780b96 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
May 11, 2023

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35490: [Python] Interchange protocol: update tests for strin…
d7573d4
…g and large_string (apache#35504)
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
* Closes: apache#35490
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
@AlenkaF@ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff
…35530)
The diff is a bit confusing so I will add some notes here:
- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264
Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees


No one assigned


Labels

awaiting mergeAwaiting mergeComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python] Interchange - test failing on MacOS builds


3 participants

@AlenkaF@jorisvandenbossche@ursabot