Skip to content

GH-35503: [CI][Packaging][C++] Snappy patch fails to apply on arm64 windows wheel builds - #35509

Merged
assignUser merged 6 commits into
apache:mainfrom
raulcd:GH-35503
May 10, 2023
Merged

GH-35503: [CI][Packaging][C++] Snappy patch fails to apply on arm64 windows wheel builds#35509
assignUser merged 6 commits into
apache:mainfrom
raulcd:GH-35503

Conversation

@raulcd

@raulcdraulcd commented May 9, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Nightly Windows wheels have been failing for the last days.

What changes are included in this PR?

Fix wrong snappy patch

Are these changes tested?

Tested on crossbow

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35503has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-*

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label May 9, 2023
@github-actions

Copy link
Copy Markdown

Revision: a3042953076fbcb8b97c79f79f8ab7eb762fe8c4

Submitted crossbow builds: ursacomputing/crossbow @ actions-7f34a005c3

TaskStatus
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp311-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-*

@github-actions

Copy link
Copy Markdown

Revision: 828e3094bfd1efc6fcec862c7569a87d1023f24f

Submitted crossbow builds: ursacomputing/crossbow @ actions-5b7fb9ac3c

TaskStatus
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp311-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp310-amd64

@github-actions

Copy link
Copy Markdown

Revision: bcd3e306cf5a6f2addf6156cb279a95831732279

Submitted crossbow builds: ursacomputing/crossbow @ actions-19db15ad53

TaskStatus
wheel-windows-cp310-amd64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp310-amd64

@github-actions

Copy link
Copy Markdown

Revision: 7066dfd42a89cc2a4494ff4a2f49b159ee03b611

Submitted crossbow builds: ursacomputing/crossbow @ actions-7b5f53dfbc

TaskStatus
wheel-windows-cp310-amd64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp310-amd64

@github-actions

Copy link
Copy Markdown

Revision: da6bc95d3ed3bb1e80f6169eb98f5346e55b974d

Submitted crossbow builds: ursacomputing/crossbow @ actions-a8809a4f9c

TaskStatus
wheel-windows-cp310-amd64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp310-amd64

@github-actions

Copy link
Copy Markdown

Revision: f0b5b45a2ef7342f47a9d9a161af40e899a189b7

Submitted crossbow builds: ursacomputing/crossbow @ actions-586720ae29

TaskStatus
wheel-windows-cp310-amd64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-*

@github-actions

Copy link
Copy Markdown

Revision: f0b5b45a2ef7342f47a9d9a161af40e899a189b7

Submitted crossbow builds: ursacomputing/crossbow @ actions-0e5d9b97b6

TaskStatus
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp311-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@raulcd
raulcd marked this pull request as ready for review May 10, 2023 08:20
@raulcd
raulcd requested review from assignUser and kou as code ownersMay 10, 2023 08:20
@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-*

@github-actions

Copy link
Copy Markdown

Revision: 165a257

Submitted crossbow builds: ursacomputing/crossbow @ actions-8328c33fda

TaskStatus
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp311-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@sjperkins

Copy link
Copy Markdown
Contributor

@raulcd Thanks for fixing this and apologies for introducing it here https://github.com/apache/arrow/pull/35430/files#r1184737729

@raulcd

Copy link
Copy Markdown
MemberAuthor

@raulcd Thanks for fixing this and apologies for introducing it here https://github.com/apache/arrow/pull/35430/files#r1184737729

No worries at all, it took me more tries than expected :)

@sjperkins

Copy link
Copy Markdown
Contributor

@raulcd Thanks for fixing this and apologies for introducing it here https://github.com/apache/arrow/pull/35430/files#r1184737729

No worries at all, it took me more tries than expected :)

OK, I felt a bit bad because I'd forgotten I'd changed the patch (context switching), and ended up creating the issue based on kou's investigation.

@assignUserassignUser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@assignUser
assignUser merged commit 3948c42 into apache:mainMay 10, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
…rm64 windows wheel builds (apache#35509)
### Rationale for this change
Nightly Windows wheels have been failing for the last days.
### What changes are included in this PR?
Fix wrong snappy patch
### Are these changes tested?
Tested on crossbow
### Are there any user-facing changes?
No
* Closes: apache#35503
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = df5f67d and contender = 3948c42. 3948c42 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.44% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.48% ⬆️0.54%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3948c426 ec2-t3-xlarge-us-east-2
[Finished] 3948c426 test-mac-arm
[Finished] 3948c426 ursa-i9-9960x
[Finished] 3948c426 ursa-thinkcentre-m75q
[Finished] df5f67d5 ec2-t3-xlarge-us-east-2
[Finished] df5f67d5 test-mac-arm
[Finished] df5f67d5 ursa-i9-9960x
[Finished] df5f67d5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
…rm64 windows wheel builds (apache#35509)
### Rationale for this change
Nightly Windows wheels have been failing for the last days.
### What changes are included in this PR?
Fix wrong snappy patch
### Are these changes tested?
Tested on crossbow
### Are there any user-facing changes?
No
* Closes: apache#35503
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committer reviewAwaiting committer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI][Packaging][C++][Windows] Snappy patch fails to apply on arm64 windows wheel builds

4 participants

@raulcd@sjperkins@ursabot@assignUser