ARROW-4479: [Plasma] Add S3 as external store for Plasma#3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anuragkh wants to merge 3 commits into from
Closed

ARROW-4479: [Plasma] Add S3 as external store for Plasma #3559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c7a207
Add s3 as external store to plasma
Feb 5, 2019
bde28c7
Fix cpplint issues
Feb 5, 2019
a37d180
Added CMake build for awssdk
Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,10 @@ static|shared (default shared)")
"Build the plasma object store java client"
OFF)

option(ARROW_PLASMA_S3
"Build S3 external store bindings for the plasma object store"
OFF)

#----------------------------------------------------------------------
# Thirdparty toolchain options

Expand Down
9 changes: 9 additions & 0 deletions cpp/cmake_modules/BuildUtils.cmake
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -629,3 +629,12 @@ function(ARROW_ADD_PKG_CONFIG MODULE)
FILES "${CMAKE_CURRENT_BINARY_DIR}/${MODULE}.pc"
DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
endfunction()

function(AWSSDK_TARGETS MODULE_LIST TARGETS)
# We will always link against these targets
set(awssdk_targets "curl_static" "awssdk_core_static")
foreach(MODULE IN LISTS MODULE_LIST)
list(APPEND awssdk_targets "awssdk_${MODULE}_static")
endforeach()
set(${TARGETS} ${awssdk_targets} PARENT_SCOPE)
endfunction(AWSSDK_TARGETS)
95 changes: 95 additions & 0 deletions cpp/cmake_modules/FindAWSSDK.cmake
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find AWSSDK headers and libraries.
#
# Usage of this module as follows:
#
# find_package(AWSSDK COMPONENTS service1 service2 ...)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# AWSSDK_HOME - When set, this path is inspected instead of standard library
# locations as the root of the AWSSDK installation.
# The environment variable AWSSDK_HOME overrides this veriable.
#
# This module defines
# AWSSDK_INCLUDE_DIR, directory containing headers
# AWSSDK_LIBRARY_DIR, directory containing libraries
# AWSSDK_STATIC_LIBS, static AWS SDK libraries
# AWSSDK_FOUND, whether AWS SDK has been found

if( NOT "${AWSSDK_HOME}" STREQUAL "")
file( TO_CMAKE_PATH "${AWSSDK_HOME}" _native_path )
list( APPEND _awssdk_roots ${_native_path} )
elseif ( AWSSDK_HOME )
list( APPEND _awssdk_roots ${AWSSDK_HOME} )
endif()

set(AWSSDK_MODULES ${AWSSDK_FIND_COMPONENTS})
set(AWSSDK_STATIC_LIBS)

find_path(AWSSDK_INCLUDE_DIR NAMES aws/core/Aws.h
PATHS ${_awssdk_roots}
NO_DEFAULT_PATH
PATH_SUFFIXES "include")

foreach(MODULE ${AWSSDK_MODULES})
string(TOUPPER ${MODULE} MODULE_UPPERCASE)
find_library( AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-${MODULE}${CMAKE_STATIC_LIBRARY_SUFFIX}
PATHS ${_awssdk_roots}
NO_DEFAULT_PATH
PATH_SUFFIXES "lib/${CMAKE_LIBRARY_ARCHITECTURE}" "lib" )
# Fail if any module library is missing
if (NOT AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB)
set(LIBRARY_NOT_FOUND "YES")
else()
list(APPEND AWSSDK_STATIC_LIBS ${AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB})
endif()
endforeach()

if (AWSSDK_INCLUDE_DIR AND NOT LIBRARY_NOT_FOUND)
set(AWSSDK_FOUND TRUE)
get_filename_component(AWSSDK_LIBRARY_DIR ${AWSSDK_STATIC_CORE_LIB} PATH)
else ()
set(AWSSDK_FOUND FALSE)
endif ()

if (AWSSDK_FOUND)
if (NOT AWSSDK_FIND_QUIETLY)
message(STATUS "Found the AWSSDK libraries: ${AWSSDK_STATIC_LIBS}")
endif ()
else ()
set(AWSSDK_STATIC_LIBS)
if (NOT AWSSDK_FIND_QUIETLY)
set(AWSSDK_ERR_MSG "Could not find the AWSSDK library. Looked")
if ( _awssdk_roots )
set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in ${_awssdk_roots}.")
else ()
set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in system search paths.")
endif ()
if (AWSSDK_FIND_REQUIRED)
message(FATAL_ERROR "${AWSSDK_ERR_MSG}")
else (AWSSDK_FIND_REQUIRED)
message(STATUS "${AWSSDK_ERR_MSG}")
endif (AWSSDK_FIND_REQUIRED)
endif ()
endif ()

mark_as_advanced(
AWSSDK_INCLUDE_DIR
AWSSDK_LIBRARY_DIR
AWSSDK_STATIC_LIBS
AWSSDK_FOUND
)
102 changes: 102 additions & 0 deletions cpp/cmake_modules/FindCURL.cmake
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find CURL headers and libraries.
#
# Usage of this module as follows:
#
# find_package(CURL)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# CURL_HOME - When set, this path is inspected instead of standard library
# locations as the root of the CURL installation.
# The environment variable CURL_HOME overrides this variable.
#
# - Find CURL (curl/curl.h, libcurl.a)
# This module defines
# CURL_INCLUDE_DIR, directory containing headers
# CURL_STATIC_LIB, path to curl's static library
# CURL_FOUND, whether curl has been found

if( NOT "${CURL_HOME}" STREQUAL "")
file( TO_CMAKE_PATH "${CURL_HOME}" _native_path )
list( APPEND _curl_roots ${_native_path} )
elseif ( CURL_HOME )
list( APPEND _curl_roots ${CURL_HOME} )
endif()

if (MSVC)
# curl uses curl.lib for Windows.
set(CURL_LIB_NAME curllib)
else ()
# curl uses libcurl.a for non Windows.
set(CURL_LIB_NAME
${CMAKE_SHARED_LIBRARY_PREFIX}curl${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()

# Try the parameterized roots, if they exist
if (_curl_roots)
find_path(CURL_INCLUDE_DIR NAMES curl/curl.h
PATHS ${_curl_roots} NO_DEFAULT_PATH
PATH_SUFFIXES "include")
find_library(CURL_STATIC_LIB
NAMES ${CURL_LIB_NAME}
PATHS ${_curl_roots} NO_DEFAULT_PATH
PATH_SUFFIXES "lib")
else ()
pkg_check_modules(PKG_CURL libcurl)
if (PKG_CURL_FOUND)
set(CURL_INCLUDE_DIR ${PKG_CURL_INCLUDEDIR})
find_library(CURL_STATIC_LIB
NAMES ${CURL_LIB_NAME}
PATHS ${PKG_CURL_LIBDIR} NO_DEFAULT_PATH)
else ()
find_path(CURL_INCLUDE_DIR NAMES curl/curl.h)
find_library(CURL_STATIC_LIB NAMES ${CURL_LIB_NAME})
endif ()
endif ()

if (CURL_INCLUDE_DIR AND CURL_STATIC_LIB)
set(CURL_FOUND TRUE)
else ()
set(CURL_FOUND FALSE)
endif ()

if (CURL_FOUND)
if (NOT CURL_FIND_QUIETLY)
if (CURL_STATIC_LIB)
message(STATUS "Found the CURL static library: ${CURL_STATIC_LIB}")
endif ()
endif ()
else ()
if (NOT CURL_FIND_QUIETLY)
set(CURL_ERR_MSG "Could not find the CURL library. Looked in")
if ( _curl_roots )
set(CURL_ERR_MSG "${CURL_ERR_MSG} ${_curl_roots}.")
else ()
set(CURL_ERR_MSG "${CURL_ERR_MSG} system search paths.")
endif ()
if (CURL_FIND_REQUIRED)
message(FATAL_ERROR "${CURL_ERR_MSG}")
else (CURL_FIND_REQUIRED)
message(STATUS "${CURL_ERR_MSG}")
endif (CURL_FIND_REQUIRED)
endif ()
endif ()

mark_as_advanced(
CURL_INCLUDE_DIR
CURL_STATIC_LIB
)
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-4479: [Plasma] Add S3 as external store for Plasma#3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

anuragkh
wants to merge
3
commits into

from

 Closed


ARROW-4479: [Plasma] Add S3 as external store for Plasma
#3559
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
9c7a207

Add s3 as external store to plasma

Feb 5, 2019
bde28c7

Fix cpplint issues

Feb 5, 2019
a37d180

Added CMake build for awssdk

Feb 8, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 4 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,10 @@ static|shared (default shared)")
 "Build the plasma object store java client"
 OFF)

 option(ARROW_PLASMA_S3
 "Build S3 external store bindings for the plasma object store"
 OFF)

 #----------------------------------------------------------------------
 # Thirdparty toolchain options

Expand Down

9 changes: 9 additions & 0 deletions
cpp/cmake_modules/BuildUtils.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -629,3 +629,12 @@ function(ARROW_ADD_PKG_CONFIG MODULE)
 FILES "${CMAKE_CURRENT_BINARY_DIR}/${MODULE}.pc"
 DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
endfunction()

function(AWSSDK_TARGETS MODULE_LIST TARGETS)
 # We will always link against these targets
 set(awssdk_targets "curl_static" "awssdk_core_static")
 foreach(MODULE IN LISTS MODULE_LIST)
 list(APPEND awssdk_targets "awssdk_${MODULE}_static")
 endforeach()
 set(${TARGETS} ${awssdk_targets} PARENT_SCOPE)
endfunction(AWSSDK_TARGETS)

95 changes: 95 additions & 0 deletions
cpp/cmake_modules/FindAWSSDK.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find AWSSDK headers and libraries.
#
# Usage of this module as follows:
#
# find_package(AWSSDK COMPONENTS service1 service2 ...)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# AWSSDK_HOME - When set, this path is inspected instead of standard library
# locations as the root of the AWSSDK installation.
# The environment variable AWSSDK_HOME overrides this veriable.
#
# This module defines
# AWSSDK_INCLUDE_DIR, directory containing headers
# AWSSDK_LIBRARY_DIR, directory containing libraries
# AWSSDK_STATIC_LIBS, static AWS SDK libraries
# AWSSDK_FOUND, whether AWS SDK has been found

if( NOT "${AWSSDK_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${AWSSDK_HOME}" _native_path )
 list( APPEND _awssdk_roots ${_native_path} )
elseif ( AWSSDK_HOME )
 list( APPEND _awssdk_roots ${AWSSDK_HOME} )
endif()

set(AWSSDK_MODULES ${AWSSDK_FIND_COMPONENTS})
set(AWSSDK_STATIC_LIBS)

find_path(AWSSDK_INCLUDE_DIR NAMES aws/core/Aws.h
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "include")

foreach(MODULE ${AWSSDK_MODULES})
 string(TOUPPER ${MODULE} MODULE_UPPERCASE)
 find_library( AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-${MODULE}${CMAKE_STATIC_LIBRARY_SUFFIX}
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "lib/${CMAKE_LIBRARY_ARCHITECTURE}" "lib" )
 # Fail if any module library is missing
 if (NOT AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB)
 set(LIBRARY_NOT_FOUND "YES")
 else()
 list(APPEND AWSSDK_STATIC_LIBS ${AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB})
 endif()
endforeach()

if (AWSSDK_INCLUDE_DIR AND NOT LIBRARY_NOT_FOUND)
 set(AWSSDK_FOUND TRUE)
 get_filename_component(AWSSDK_LIBRARY_DIR ${AWSSDK_STATIC_CORE_LIB} PATH)
else ()
 set(AWSSDK_FOUND FALSE)
endif ()

if (AWSSDK_FOUND)
 if (NOT AWSSDK_FIND_QUIETLY)
 message(STATUS "Found the AWSSDK libraries: ${AWSSDK_STATIC_LIBS}")
 endif ()
else ()
 set(AWSSDK_STATIC_LIBS)
 if (NOT AWSSDK_FIND_QUIETLY)
 set(AWSSDK_ERR_MSG "Could not find the AWSSDK library. Looked")
 if ( _awssdk_roots )
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in ${_awssdk_roots}.")
 else ()
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in system search paths.")
 endif ()
 if (AWSSDK_FIND_REQUIRED)
 message(FATAL_ERROR "${AWSSDK_ERR_MSG}")
 else (AWSSDK_FIND_REQUIRED)
 message(STATUS "${AWSSDK_ERR_MSG}")
 endif (AWSSDK_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 AWSSDK_INCLUDE_DIR
 AWSSDK_LIBRARY_DIR
 AWSSDK_STATIC_LIBS
 AWSSDK_FOUND
)

102 changes: 102 additions & 0 deletions
cpp/cmake_modules/FindCURL.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find CURL headers and libraries.
#
# Usage of this module as follows:
#
# find_package(CURL)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# CURL_HOME - When set, this path is inspected instead of standard library
# locations as the root of the CURL installation.
# The environment variable CURL_HOME overrides this variable.
#
# - Find CURL (curl/curl.h, libcurl.a)
# This module defines
# CURL_INCLUDE_DIR, directory containing headers
# CURL_STATIC_LIB, path to curl's static library
# CURL_FOUND, whether curl has been found

if( NOT "${CURL_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${CURL_HOME}" _native_path )
 list( APPEND _curl_roots ${_native_path} )
elseif ( CURL_HOME )
 list( APPEND _curl_roots ${CURL_HOME} )
endif()

if (MSVC)
 # curl uses curl.lib for Windows.
 set(CURL_LIB_NAME curllib)
else ()
 # curl uses libcurl.a for non Windows.
 set(CURL_LIB_NAME
 ${CMAKE_SHARED_LIBRARY_PREFIX}curl${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()

# Try the parameterized roots, if they exist
if (_curl_roots)
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "include")
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "lib")
else ()
 pkg_check_modules(PKG_CURL libcurl)
 if (PKG_CURL_FOUND)
 set(CURL_INCLUDE_DIR ${PKG_CURL_INCLUDEDIR})
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${PKG_CURL_LIBDIR} NO_DEFAULT_PATH)
 else ()
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h)
 find_library(CURL_STATIC_LIB NAMES ${CURL_LIB_NAME})
 endif ()
endif ()

if (CURL_INCLUDE_DIR AND CURL_STATIC_LIB)
 set(CURL_FOUND TRUE)
else ()
 set(CURL_FOUND FALSE)
endif ()

if (CURL_FOUND)
 if (NOT CURL_FIND_QUIETLY)
 if (CURL_STATIC_LIB)
 message(STATUS "Found the CURL static library: ${CURL_STATIC_LIB}")
 endif ()
 endif ()
else ()
 if (NOT CURL_FIND_QUIETLY)
 set(CURL_ERR_MSG "Could not find the CURL library. Looked in")
 if ( _curl_roots )
 set(CURL_ERR_MSG "${CURL_ERR_MSG} ${_curl_roots}.")
 else ()
 set(CURL_ERR_MSG "${CURL_ERR_MSG} system search paths.")
 endif ()
 if (CURL_FIND_REQUIRED)
 message(FATAL_ERROR "${CURL_ERR_MSG}")
 else (CURL_FIND_REQUIRED)
 message(STATUS "${CURL_ERR_MSG}")
 endif (CURL_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 CURL_INCLUDE_DIR
 CURL_STATIC_LIB
)
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4479: [Plasma] Add S3 as external store for Plasma#3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

anuragkh
wants to merge
3
commits into

from

 Closed


ARROW-4479: [Plasma] Add S3 as external store for Plasma
#3559
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
9c7a207

Add s3 as external store to plasma

Feb 5, 2019
bde28c7

Fix cpplint issues

Feb 5, 2019
a37d180

Added CMake build for awssdk

Feb 8, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 4 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,10 @@ static|shared (default shared)")
 "Build the plasma object store java client"
 OFF)

 option(ARROW_PLASMA_S3
 "Build S3 external store bindings for the plasma object store"
 OFF)

 #----------------------------------------------------------------------
 # Thirdparty toolchain options

Expand Down

9 changes: 9 additions & 0 deletions
cpp/cmake_modules/BuildUtils.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -629,3 +629,12 @@ function(ARROW_ADD_PKG_CONFIG MODULE)
 FILES "${CMAKE_CURRENT_BINARY_DIR}/${MODULE}.pc"
 DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
endfunction()

function(AWSSDK_TARGETS MODULE_LIST TARGETS)
 # We will always link against these targets
 set(awssdk_targets "curl_static" "awssdk_core_static")
 foreach(MODULE IN LISTS MODULE_LIST)
 list(APPEND awssdk_targets "awssdk_${MODULE}_static")
 endforeach()
 set(${TARGETS} ${awssdk_targets} PARENT_SCOPE)
endfunction(AWSSDK_TARGETS)

95 changes: 95 additions & 0 deletions
cpp/cmake_modules/FindAWSSDK.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find AWSSDK headers and libraries.
#
# Usage of this module as follows:
#
# find_package(AWSSDK COMPONENTS service1 service2 ...)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# AWSSDK_HOME - When set, this path is inspected instead of standard library
# locations as the root of the AWSSDK installation.
# The environment variable AWSSDK_HOME overrides this veriable.
#
# This module defines
# AWSSDK_INCLUDE_DIR, directory containing headers
# AWSSDK_LIBRARY_DIR, directory containing libraries
# AWSSDK_STATIC_LIBS, static AWS SDK libraries
# AWSSDK_FOUND, whether AWS SDK has been found

if( NOT "${AWSSDK_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${AWSSDK_HOME}" _native_path )
 list( APPEND _awssdk_roots ${_native_path} )
elseif ( AWSSDK_HOME )
 list( APPEND _awssdk_roots ${AWSSDK_HOME} )
endif()

set(AWSSDK_MODULES ${AWSSDK_FIND_COMPONENTS})
set(AWSSDK_STATIC_LIBS)

find_path(AWSSDK_INCLUDE_DIR NAMES aws/core/Aws.h
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "include")

foreach(MODULE ${AWSSDK_MODULES})
 string(TOUPPER ${MODULE} MODULE_UPPERCASE)
 find_library( AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-${MODULE}${CMAKE_STATIC_LIBRARY_SUFFIX}
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "lib/${CMAKE_LIBRARY_ARCHITECTURE}" "lib" )
 # Fail if any module library is missing
 if (NOT AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB)
 set(LIBRARY_NOT_FOUND "YES")
 else()
 list(APPEND AWSSDK_STATIC_LIBS ${AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB})
 endif()
endforeach()

if (AWSSDK_INCLUDE_DIR AND NOT LIBRARY_NOT_FOUND)
 set(AWSSDK_FOUND TRUE)
 get_filename_component(AWSSDK_LIBRARY_DIR ${AWSSDK_STATIC_CORE_LIB} PATH)
else ()
 set(AWSSDK_FOUND FALSE)
endif ()

if (AWSSDK_FOUND)
 if (NOT AWSSDK_FIND_QUIETLY)
 message(STATUS "Found the AWSSDK libraries: ${AWSSDK_STATIC_LIBS}")
 endif ()
else ()
 set(AWSSDK_STATIC_LIBS)
 if (NOT AWSSDK_FIND_QUIETLY)
 set(AWSSDK_ERR_MSG "Could not find the AWSSDK library. Looked")
 if ( _awssdk_roots )
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in ${_awssdk_roots}.")
 else ()
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in system search paths.")
 endif ()
 if (AWSSDK_FIND_REQUIRED)
 message(FATAL_ERROR "${AWSSDK_ERR_MSG}")
 else (AWSSDK_FIND_REQUIRED)
 message(STATUS "${AWSSDK_ERR_MSG}")
 endif (AWSSDK_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 AWSSDK_INCLUDE_DIR
 AWSSDK_LIBRARY_DIR
 AWSSDK_STATIC_LIBS
 AWSSDK_FOUND
)

102 changes: 102 additions & 0 deletions
cpp/cmake_modules/FindCURL.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find CURL headers and libraries.
#
# Usage of this module as follows:
#
# find_package(CURL)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# CURL_HOME - When set, this path is inspected instead of standard library
# locations as the root of the CURL installation.
# The environment variable CURL_HOME overrides this variable.
#
# - Find CURL (curl/curl.h, libcurl.a)
# This module defines
# CURL_INCLUDE_DIR, directory containing headers
# CURL_STATIC_LIB, path to curl's static library
# CURL_FOUND, whether curl has been found

if( NOT "${CURL_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${CURL_HOME}" _native_path )
 list( APPEND _curl_roots ${_native_path} )
elseif ( CURL_HOME )
 list( APPEND _curl_roots ${CURL_HOME} )
endif()

if (MSVC)
 # curl uses curl.lib for Windows.
 set(CURL_LIB_NAME curllib)
else ()
 # curl uses libcurl.a for non Windows.
 set(CURL_LIB_NAME
 ${CMAKE_SHARED_LIBRARY_PREFIX}curl${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()

# Try the parameterized roots, if they exist
if (_curl_roots)
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "include")
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "lib")
else ()
 pkg_check_modules(PKG_CURL libcurl)
 if (PKG_CURL_FOUND)
 set(CURL_INCLUDE_DIR ${PKG_CURL_INCLUDEDIR})
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${PKG_CURL_LIBDIR} NO_DEFAULT_PATH)
 else ()
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h)
 find_library(CURL_STATIC_LIB NAMES ${CURL_LIB_NAME})
 endif ()
endif ()

if (CURL_INCLUDE_DIR AND CURL_STATIC_LIB)
 set(CURL_FOUND TRUE)
else ()
 set(CURL_FOUND FALSE)
endif ()

if (CURL_FOUND)
 if (NOT CURL_FIND_QUIETLY)
 if (CURL_STATIC_LIB)
 message(STATUS "Found the CURL static library: ${CURL_STATIC_LIB}")
 endif ()
 endif ()
else ()
 if (NOT CURL_FIND_QUIETLY)
 set(CURL_ERR_MSG "Could not find the CURL library. Looked in")
 if ( _curl_roots )
 set(CURL_ERR_MSG "${CURL_ERR_MSG} ${_curl_roots}.")
 else ()
 set(CURL_ERR_MSG "${CURL_ERR_MSG} system search paths.")
 endif ()
 if (CURL_FIND_REQUIRED)
 message(FATAL_ERROR "${CURL_ERR_MSG}")
 else (CURL_FIND_REQUIRED)
 message(STATUS "${CURL_ERR_MSG}")
 endif (CURL_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 CURL_INCLUDE_DIR
 CURL_STATIC_LIB
)
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4479: [Plasma] Add S3 as external store for Plasma#3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

anuragkh
wants to merge
3
commits into

from

 Closed


ARROW-4479: [Plasma] Add S3 as external store for Plasma
#3559
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
9c7a207

Add s3 as external store to plasma

Feb 5, 2019
bde28c7

Fix cpplint issues

Feb 5, 2019
a37d180

Added CMake build for awssdk

Feb 8, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 4 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,10 @@ static|shared (default shared)")
 "Build the plasma object store java client"
 OFF)

 option(ARROW_PLASMA_S3
 "Build S3 external store bindings for the plasma object store"
 OFF)

 #----------------------------------------------------------------------
 # Thirdparty toolchain options

Expand Down

9 changes: 9 additions & 0 deletions
cpp/cmake_modules/BuildUtils.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -629,3 +629,12 @@ function(ARROW_ADD_PKG_CONFIG MODULE)
 FILES "${CMAKE_CURRENT_BINARY_DIR}/${MODULE}.pc"
 DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
endfunction()

function(AWSSDK_TARGETS MODULE_LIST TARGETS)
 # We will always link against these targets
 set(awssdk_targets "curl_static" "awssdk_core_static")
 foreach(MODULE IN LISTS MODULE_LIST)
 list(APPEND awssdk_targets "awssdk_${MODULE}_static")
 endforeach()
 set(${TARGETS} ${awssdk_targets} PARENT_SCOPE)
endfunction(AWSSDK_TARGETS)

95 changes: 95 additions & 0 deletions
cpp/cmake_modules/FindAWSSDK.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find AWSSDK headers and libraries.
#
# Usage of this module as follows:
#
# find_package(AWSSDK COMPONENTS service1 service2 ...)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# AWSSDK_HOME - When set, this path is inspected instead of standard library
# locations as the root of the AWSSDK installation.
# The environment variable AWSSDK_HOME overrides this veriable.
#
# This module defines
# AWSSDK_INCLUDE_DIR, directory containing headers
# AWSSDK_LIBRARY_DIR, directory containing libraries
# AWSSDK_STATIC_LIBS, static AWS SDK libraries
# AWSSDK_FOUND, whether AWS SDK has been found

if( NOT "${AWSSDK_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${AWSSDK_HOME}" _native_path )
 list( APPEND _awssdk_roots ${_native_path} )
elseif ( AWSSDK_HOME )
 list( APPEND _awssdk_roots ${AWSSDK_HOME} )
endif()

set(AWSSDK_MODULES ${AWSSDK_FIND_COMPONENTS})
set(AWSSDK_STATIC_LIBS)

find_path(AWSSDK_INCLUDE_DIR NAMES aws/core/Aws.h
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "include")

foreach(MODULE ${AWSSDK_MODULES})
 string(TOUPPER ${MODULE} MODULE_UPPERCASE)
 find_library( AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-${MODULE}${CMAKE_STATIC_LIBRARY_SUFFIX}
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "lib/${CMAKE_LIBRARY_ARCHITECTURE}" "lib" )
 # Fail if any module library is missing
 if (NOT AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB)
 set(LIBRARY_NOT_FOUND "YES")
 else()
 list(APPEND AWSSDK_STATIC_LIBS ${AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB})
 endif()
endforeach()

if (AWSSDK_INCLUDE_DIR AND NOT LIBRARY_NOT_FOUND)
 set(AWSSDK_FOUND TRUE)
 get_filename_component(AWSSDK_LIBRARY_DIR ${AWSSDK_STATIC_CORE_LIB} PATH)
else ()
 set(AWSSDK_FOUND FALSE)
endif ()

if (AWSSDK_FOUND)
 if (NOT AWSSDK_FIND_QUIETLY)
 message(STATUS "Found the AWSSDK libraries: ${AWSSDK_STATIC_LIBS}")
 endif ()
else ()
 set(AWSSDK_STATIC_LIBS)
 if (NOT AWSSDK_FIND_QUIETLY)
 set(AWSSDK_ERR_MSG "Could not find the AWSSDK library. Looked")
 if ( _awssdk_roots )
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in ${_awssdk_roots}.")
 else ()
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in system search paths.")
 endif ()
 if (AWSSDK_FIND_REQUIRED)
 message(FATAL_ERROR "${AWSSDK_ERR_MSG}")
 else (AWSSDK_FIND_REQUIRED)
 message(STATUS "${AWSSDK_ERR_MSG}")
 endif (AWSSDK_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 AWSSDK_INCLUDE_DIR
 AWSSDK_LIBRARY_DIR
 AWSSDK_STATIC_LIBS
 AWSSDK_FOUND
)

102 changes: 102 additions & 0 deletions
cpp/cmake_modules/FindCURL.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find CURL headers and libraries.
#
# Usage of this module as follows:
#
# find_package(CURL)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# CURL_HOME - When set, this path is inspected instead of standard library
# locations as the root of the CURL installation.
# The environment variable CURL_HOME overrides this variable.
#
# - Find CURL (curl/curl.h, libcurl.a)
# This module defines
# CURL_INCLUDE_DIR, directory containing headers
# CURL_STATIC_LIB, path to curl's static library
# CURL_FOUND, whether curl has been found

if( NOT "${CURL_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${CURL_HOME}" _native_path )
 list( APPEND _curl_roots ${_native_path} )
elseif ( CURL_HOME )
 list( APPEND _curl_roots ${CURL_HOME} )
endif()

if (MSVC)
 # curl uses curl.lib for Windows.
 set(CURL_LIB_NAME curllib)
else ()
 # curl uses libcurl.a for non Windows.
 set(CURL_LIB_NAME
 ${CMAKE_SHARED_LIBRARY_PREFIX}curl${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()

# Try the parameterized roots, if they exist
if (_curl_roots)
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "include")
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "lib")
else ()
 pkg_check_modules(PKG_CURL libcurl)
 if (PKG_CURL_FOUND)
 set(CURL_INCLUDE_DIR ${PKG_CURL_INCLUDEDIR})
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${PKG_CURL_LIBDIR} NO_DEFAULT_PATH)
 else ()
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h)
 find_library(CURL_STATIC_LIB NAMES ${CURL_LIB_NAME})
 endif ()
endif ()

if (CURL_INCLUDE_DIR AND CURL_STATIC_LIB)
 set(CURL_FOUND TRUE)
else ()
 set(CURL_FOUND FALSE)
endif ()

if (CURL_FOUND)
 if (NOT CURL_FIND_QUIETLY)
 if (CURL_STATIC_LIB)
 message(STATUS "Found the CURL static library: ${CURL_STATIC_LIB}")
 endif ()
 endif ()
else ()
 if (NOT CURL_FIND_QUIETLY)
 set(CURL_ERR_MSG "Could not find the CURL library. Looked in")
 if ( _curl_roots )
 set(CURL_ERR_MSG "${CURL_ERR_MSG} ${_curl_roots}.")
 else ()
 set(CURL_ERR_MSG "${CURL_ERR_MSG} system search paths.")
 endif ()
 if (CURL_FIND_REQUIRED)
 message(FATAL_ERROR "${CURL_ERR_MSG}")
 else (CURL_FIND_REQUIRED)
 message(STATUS "${CURL_ERR_MSG}")
 endif (CURL_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 CURL_INCLUDE_DIR
 CURL_STATIC_LIB
)
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-4479: [Plasma] Add S3 as external store for Plasma#3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

anuragkh
wants to merge
3
commits into

from

 Closed


ARROW-4479: [Plasma] Add S3 as external store for Plasma
#3559
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
9c7a207

Add s3 as external store to plasma

Feb 5, 2019
bde28c7

Fix cpplint issues

Feb 5, 2019
a37d180

Added CMake build for awssdk

Feb 8, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 4 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,10 @@ static|shared (default shared)")
 "Build the plasma object store java client"
 OFF)

 option(ARROW_PLASMA_S3
 "Build S3 external store bindings for the plasma object store"
 OFF)

 #----------------------------------------------------------------------
 # Thirdparty toolchain options

Expand Down

9 changes: 9 additions & 0 deletions
cpp/cmake_modules/BuildUtils.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -629,3 +629,12 @@ function(ARROW_ADD_PKG_CONFIG MODULE)
 FILES "${CMAKE_CURRENT_BINARY_DIR}/${MODULE}.pc"
 DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
endfunction()

function(AWSSDK_TARGETS MODULE_LIST TARGETS)
 # We will always link against these targets
 set(awssdk_targets "curl_static" "awssdk_core_static")
 foreach(MODULE IN LISTS MODULE_LIST)
 list(APPEND awssdk_targets "awssdk_${MODULE}_static")
 endforeach()
 set(${TARGETS} ${awssdk_targets} PARENT_SCOPE)
endfunction(AWSSDK_TARGETS)

95 changes: 95 additions & 0 deletions
cpp/cmake_modules/FindAWSSDK.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find AWSSDK headers and libraries.
#
# Usage of this module as follows:
#
# find_package(AWSSDK COMPONENTS service1 service2 ...)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# AWSSDK_HOME - When set, this path is inspected instead of standard library
# locations as the root of the AWSSDK installation.
# The environment variable AWSSDK_HOME overrides this veriable.
#
# This module defines
# AWSSDK_INCLUDE_DIR, directory containing headers
# AWSSDK_LIBRARY_DIR, directory containing libraries
# AWSSDK_STATIC_LIBS, static AWS SDK libraries
# AWSSDK_FOUND, whether AWS SDK has been found

if( NOT "${AWSSDK_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${AWSSDK_HOME}" _native_path )
 list( APPEND _awssdk_roots ${_native_path} )
elseif ( AWSSDK_HOME )
 list( APPEND _awssdk_roots ${AWSSDK_HOME} )
endif()

set(AWSSDK_MODULES ${AWSSDK_FIND_COMPONENTS})
set(AWSSDK_STATIC_LIBS)

find_path(AWSSDK_INCLUDE_DIR NAMES aws/core/Aws.h
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "include")

foreach(MODULE ${AWSSDK_MODULES})
 string(TOUPPER ${MODULE} MODULE_UPPERCASE)
 find_library( AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-${MODULE}${CMAKE_STATIC_LIBRARY_SUFFIX}
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "lib/${CMAKE_LIBRARY_ARCHITECTURE}" "lib" )
 # Fail if any module library is missing
 if (NOT AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB)
 set(LIBRARY_NOT_FOUND "YES")
 else()
 list(APPEND AWSSDK_STATIC_LIBS ${AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB})
 endif()
endforeach()

if (AWSSDK_INCLUDE_DIR AND NOT LIBRARY_NOT_FOUND)
 set(AWSSDK_FOUND TRUE)
 get_filename_component(AWSSDK_LIBRARY_DIR ${AWSSDK_STATIC_CORE_LIB} PATH)
else ()
 set(AWSSDK_FOUND FALSE)
endif ()

if (AWSSDK_FOUND)
 if (NOT AWSSDK_FIND_QUIETLY)
 message(STATUS "Found the AWSSDK libraries: ${AWSSDK_STATIC_LIBS}")
 endif ()
else ()
 set(AWSSDK_STATIC_LIBS)
 if (NOT AWSSDK_FIND_QUIETLY)
 set(AWSSDK_ERR_MSG "Could not find the AWSSDK library. Looked")
 if ( _awssdk_roots )
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in ${_awssdk_roots}.")
 else ()
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in system search paths.")
 endif ()
 if (AWSSDK_FIND_REQUIRED)
 message(FATAL_ERROR "${AWSSDK_ERR_MSG}")
 else (AWSSDK_FIND_REQUIRED)
 message(STATUS "${AWSSDK_ERR_MSG}")
 endif (AWSSDK_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 AWSSDK_INCLUDE_DIR
 AWSSDK_LIBRARY_DIR
 AWSSDK_STATIC_LIBS
 AWSSDK_FOUND
)

102 changes: 102 additions & 0 deletions
cpp/cmake_modules/FindCURL.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find CURL headers and libraries.
#
# Usage of this module as follows:
#
# find_package(CURL)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# CURL_HOME - When set, this path is inspected instead of standard library
# locations as the root of the CURL installation.
# The environment variable CURL_HOME overrides this variable.
#
# - Find CURL (curl/curl.h, libcurl.a)
# This module defines
# CURL_INCLUDE_DIR, directory containing headers
# CURL_STATIC_LIB, path to curl's static library
# CURL_FOUND, whether curl has been found

if( NOT "${CURL_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${CURL_HOME}" _native_path )
 list( APPEND _curl_roots ${_native_path} )
elseif ( CURL_HOME )
 list( APPEND _curl_roots ${CURL_HOME} )
endif()

if (MSVC)
 # curl uses curl.lib for Windows.
 set(CURL_LIB_NAME curllib)
else ()
 # curl uses libcurl.a for non Windows.
 set(CURL_LIB_NAME
 ${CMAKE_SHARED_LIBRARY_PREFIX}curl${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()

# Try the parameterized roots, if they exist
if (_curl_roots)
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "include")
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "lib")
else ()
 pkg_check_modules(PKG_CURL libcurl)
 if (PKG_CURL_FOUND)
 set(CURL_INCLUDE_DIR ${PKG_CURL_INCLUDEDIR})
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${PKG_CURL_LIBDIR} NO_DEFAULT_PATH)
 else ()
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h)
 find_library(CURL_STATIC_LIB NAMES ${CURL_LIB_NAME})
 endif ()
endif ()

if (CURL_INCLUDE_DIR AND CURL_STATIC_LIB)
 set(CURL_FOUND TRUE)
else ()
 set(CURL_FOUND FALSE)
endif ()

if (CURL_FOUND)
 if (NOT CURL_FIND_QUIETLY)
 if (CURL_STATIC_LIB)
 message(STATUS "Found the CURL static library: ${CURL_STATIC_LIB}")
 endif ()
 endif ()
else ()
 if (NOT CURL_FIND_QUIETLY)
 set(CURL_ERR_MSG "Could not find the CURL library. Looked in")
 if ( _curl_roots )
 set(CURL_ERR_MSG "${CURL_ERR_MSG} ${_curl_roots}.")
 else ()
 set(CURL_ERR_MSG "${CURL_ERR_MSG} system search paths.")
 endif ()
 if (CURL_FIND_REQUIRED)
 message(FATAL_ERROR "${CURL_ERR_MSG}")
 else (CURL_FIND_REQUIRED)
 message(STATUS "${CURL_ERR_MSG}")
 endif (CURL_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 CURL_INCLUDE_DIR
 CURL_STATIC_LIB
)
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4479: [Plasma] Add S3 as external store for Plasma#3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

anuragkh
wants to merge
3
commits into

from

 Closed


ARROW-4479: [Plasma] Add S3 as external store for Plasma
#3559
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
9c7a207

Add s3 as external store to plasma

Feb 5, 2019
bde28c7

Fix cpplint issues

Feb 5, 2019
a37d180

Added CMake build for awssdk

Feb 8, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 4 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,10 @@ static|shared (default shared)")
 "Build the plasma object store java client"
 OFF)

 option(ARROW_PLASMA_S3
 "Build S3 external store bindings for the plasma object store"
 OFF)

 #----------------------------------------------------------------------
 # Thirdparty toolchain options

Expand Down

9 changes: 9 additions & 0 deletions
cpp/cmake_modules/BuildUtils.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -629,3 +629,12 @@ function(ARROW_ADD_PKG_CONFIG MODULE)
 FILES "${CMAKE_CURRENT_BINARY_DIR}/${MODULE}.pc"
 DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
endfunction()

function(AWSSDK_TARGETS MODULE_LIST TARGETS)
 # We will always link against these targets
 set(awssdk_targets "curl_static" "awssdk_core_static")
 foreach(MODULE IN LISTS MODULE_LIST)
 list(APPEND awssdk_targets "awssdk_${MODULE}_static")
 endforeach()
 set(${TARGETS} ${awssdk_targets} PARENT_SCOPE)
endfunction(AWSSDK_TARGETS)

95 changes: 95 additions & 0 deletions
cpp/cmake_modules/FindAWSSDK.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find AWSSDK headers and libraries.
#
# Usage of this module as follows:
#
# find_package(AWSSDK COMPONENTS service1 service2 ...)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# AWSSDK_HOME - When set, this path is inspected instead of standard library
# locations as the root of the AWSSDK installation.
# The environment variable AWSSDK_HOME overrides this veriable.
#
# This module defines
# AWSSDK_INCLUDE_DIR, directory containing headers
# AWSSDK_LIBRARY_DIR, directory containing libraries
# AWSSDK_STATIC_LIBS, static AWS SDK libraries
# AWSSDK_FOUND, whether AWS SDK has been found

if( NOT "${AWSSDK_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${AWSSDK_HOME}" _native_path )
 list( APPEND _awssdk_roots ${_native_path} )
elseif ( AWSSDK_HOME )
 list( APPEND _awssdk_roots ${AWSSDK_HOME} )
endif()

set(AWSSDK_MODULES ${AWSSDK_FIND_COMPONENTS})
set(AWSSDK_STATIC_LIBS)

find_path(AWSSDK_INCLUDE_DIR NAMES aws/core/Aws.h
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "include")

foreach(MODULE ${AWSSDK_MODULES})
 string(TOUPPER ${MODULE} MODULE_UPPERCASE)
 find_library( AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-${MODULE}${CMAKE_STATIC_LIBRARY_SUFFIX}
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "lib/${CMAKE_LIBRARY_ARCHITECTURE}" "lib" )
 # Fail if any module library is missing
 if (NOT AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB)
 set(LIBRARY_NOT_FOUND "YES")
 else()
 list(APPEND AWSSDK_STATIC_LIBS ${AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB})
 endif()
endforeach()

if (AWSSDK_INCLUDE_DIR AND NOT LIBRARY_NOT_FOUND)
 set(AWSSDK_FOUND TRUE)
 get_filename_component(AWSSDK_LIBRARY_DIR ${AWSSDK_STATIC_CORE_LIB} PATH)
else ()
 set(AWSSDK_FOUND FALSE)
endif ()

if (AWSSDK_FOUND)
 if (NOT AWSSDK_FIND_QUIETLY)
 message(STATUS "Found the AWSSDK libraries: ${AWSSDK_STATIC_LIBS}")
 endif ()
else ()
 set(AWSSDK_STATIC_LIBS)
 if (NOT AWSSDK_FIND_QUIETLY)
 set(AWSSDK_ERR_MSG "Could not find the AWSSDK library. Looked")
 if ( _awssdk_roots )
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in ${_awssdk_roots}.")
 else ()
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in system search paths.")
 endif ()
 if (AWSSDK_FIND_REQUIRED)
 message(FATAL_ERROR "${AWSSDK_ERR_MSG}")
 else (AWSSDK_FIND_REQUIRED)
 message(STATUS "${AWSSDK_ERR_MSG}")
 endif (AWSSDK_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 AWSSDK_INCLUDE_DIR
 AWSSDK_LIBRARY_DIR
 AWSSDK_STATIC_LIBS
 AWSSDK_FOUND
)

102 changes: 102 additions & 0 deletions
cpp/cmake_modules/FindCURL.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find CURL headers and libraries.
#
# Usage of this module as follows:
#
# find_package(CURL)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# CURL_HOME - When set, this path is inspected instead of standard library
# locations as the root of the CURL installation.
# The environment variable CURL_HOME overrides this variable.
#
# - Find CURL (curl/curl.h, libcurl.a)
# This module defines
# CURL_INCLUDE_DIR, directory containing headers
# CURL_STATIC_LIB, path to curl's static library
# CURL_FOUND, whether curl has been found

if( NOT "${CURL_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${CURL_HOME}" _native_path )
 list( APPEND _curl_roots ${_native_path} )
elseif ( CURL_HOME )
 list( APPEND _curl_roots ${CURL_HOME} )
endif()

if (MSVC)
 # curl uses curl.lib for Windows.
 set(CURL_LIB_NAME curllib)
else ()
 # curl uses libcurl.a for non Windows.
 set(CURL_LIB_NAME
 ${CMAKE_SHARED_LIBRARY_PREFIX}curl${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()

# Try the parameterized roots, if they exist
if (_curl_roots)
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "include")
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "lib")
else ()
 pkg_check_modules(PKG_CURL libcurl)
 if (PKG_CURL_FOUND)
 set(CURL_INCLUDE_DIR ${PKG_CURL_INCLUDEDIR})
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${PKG_CURL_LIBDIR} NO_DEFAULT_PATH)
 else ()
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h)
 find_library(CURL_STATIC_LIB NAMES ${CURL_LIB_NAME})
 endif ()
endif ()

if (CURL_INCLUDE_DIR AND CURL_STATIC_LIB)
 set(CURL_FOUND TRUE)
else ()
 set(CURL_FOUND FALSE)
endif ()

if (CURL_FOUND)
 if (NOT CURL_FIND_QUIETLY)
 if (CURL_STATIC_LIB)
 message(STATUS "Found the CURL static library: ${CURL_STATIC_LIB}")
 endif ()
 endif ()
else ()
 if (NOT CURL_FIND_QUIETLY)
 set(CURL_ERR_MSG "Could not find the CURL library. Looked in")
 if ( _curl_roots )
 set(CURL_ERR_MSG "${CURL_ERR_MSG} ${_curl_roots}.")
 else ()
 set(CURL_ERR_MSG "${CURL_ERR_MSG} system search paths.")
 endif ()
 if (CURL_FIND_REQUIRED)
 message(FATAL_ERROR "${CURL_ERR_MSG}")
 else (CURL_FIND_REQUIRED)
 message(STATUS "${CURL_ERR_MSG}")
 endif (CURL_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 CURL_INCLUDE_DIR
 CURL_STATIC_LIB
)
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4479: [Plasma] Add S3 as external store for Plasma#3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

anuragkh
wants to merge
3
commits into

from

 Closed


ARROW-4479: [Plasma] Add S3 as external store for Plasma
#3559
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
9c7a207

Add s3 as external store to plasma

Feb 5, 2019
bde28c7

Fix cpplint issues

Feb 5, 2019
a37d180

Added CMake build for awssdk

Feb 8, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 4 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,10 @@ static|shared (default shared)")
 "Build the plasma object store java client"
 OFF)

 option(ARROW_PLASMA_S3
 "Build S3 external store bindings for the plasma object store"
 OFF)

 #----------------------------------------------------------------------
 # Thirdparty toolchain options

Expand Down

9 changes: 9 additions & 0 deletions
cpp/cmake_modules/BuildUtils.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -629,3 +629,12 @@ function(ARROW_ADD_PKG_CONFIG MODULE)
 FILES "${CMAKE_CURRENT_BINARY_DIR}/${MODULE}.pc"
 DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
endfunction()

function(AWSSDK_TARGETS MODULE_LIST TARGETS)
 # We will always link against these targets
 set(awssdk_targets "curl_static" "awssdk_core_static")
 foreach(MODULE IN LISTS MODULE_LIST)
 list(APPEND awssdk_targets "awssdk_${MODULE}_static")
 endforeach()
 set(${TARGETS} ${awssdk_targets} PARENT_SCOPE)
endfunction(AWSSDK_TARGETS)

95 changes: 95 additions & 0 deletions
cpp/cmake_modules/FindAWSSDK.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find AWSSDK headers and libraries.
#
# Usage of this module as follows:
#
# find_package(AWSSDK COMPONENTS service1 service2 ...)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# AWSSDK_HOME - When set, this path is inspected instead of standard library
# locations as the root of the AWSSDK installation.
# The environment variable AWSSDK_HOME overrides this veriable.
#
# This module defines
# AWSSDK_INCLUDE_DIR, directory containing headers
# AWSSDK_LIBRARY_DIR, directory containing libraries
# AWSSDK_STATIC_LIBS, static AWS SDK libraries
# AWSSDK_FOUND, whether AWS SDK has been found

if( NOT "${AWSSDK_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${AWSSDK_HOME}" _native_path )
 list( APPEND _awssdk_roots ${_native_path} )
elseif ( AWSSDK_HOME )
 list( APPEND _awssdk_roots ${AWSSDK_HOME} )
endif()

set(AWSSDK_MODULES ${AWSSDK_FIND_COMPONENTS})
set(AWSSDK_STATIC_LIBS)

find_path(AWSSDK_INCLUDE_DIR NAMES aws/core/Aws.h
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "include")

foreach(MODULE ${AWSSDK_MODULES})
 string(TOUPPER ${MODULE} MODULE_UPPERCASE)
 find_library( AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-${MODULE}${CMAKE_STATIC_LIBRARY_SUFFIX}
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "lib/${CMAKE_LIBRARY_ARCHITECTURE}" "lib" )
 # Fail if any module library is missing
 if (NOT AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB)
 set(LIBRARY_NOT_FOUND "YES")
 else()
 list(APPEND AWSSDK_STATIC_LIBS ${AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB})
 endif()
endforeach()

if (AWSSDK_INCLUDE_DIR AND NOT LIBRARY_NOT_FOUND)
 set(AWSSDK_FOUND TRUE)
 get_filename_component(AWSSDK_LIBRARY_DIR ${AWSSDK_STATIC_CORE_LIB} PATH)
else ()
 set(AWSSDK_FOUND FALSE)
endif ()

if (AWSSDK_FOUND)
 if (NOT AWSSDK_FIND_QUIETLY)
 message(STATUS "Found the AWSSDK libraries: ${AWSSDK_STATIC_LIBS}")
 endif ()
else ()
 set(AWSSDK_STATIC_LIBS)
 if (NOT AWSSDK_FIND_QUIETLY)
 set(AWSSDK_ERR_MSG "Could not find the AWSSDK library. Looked")
 if ( _awssdk_roots )
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in ${_awssdk_roots}.")
 else ()
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in system search paths.")
 endif ()
 if (AWSSDK_FIND_REQUIRED)
 message(FATAL_ERROR "${AWSSDK_ERR_MSG}")
 else (AWSSDK_FIND_REQUIRED)
 message(STATUS "${AWSSDK_ERR_MSG}")
 endif (AWSSDK_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 AWSSDK_INCLUDE_DIR
 AWSSDK_LIBRARY_DIR
 AWSSDK_STATIC_LIBS
 AWSSDK_FOUND
)

102 changes: 102 additions & 0 deletions
cpp/cmake_modules/FindCURL.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find CURL headers and libraries.
#
# Usage of this module as follows:
#
# find_package(CURL)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# CURL_HOME - When set, this path is inspected instead of standard library
# locations as the root of the CURL installation.
# The environment variable CURL_HOME overrides this variable.
#
# - Find CURL (curl/curl.h, libcurl.a)
# This module defines
# CURL_INCLUDE_DIR, directory containing headers
# CURL_STATIC_LIB, path to curl's static library
# CURL_FOUND, whether curl has been found

if( NOT "${CURL_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${CURL_HOME}" _native_path )
 list( APPEND _curl_roots ${_native_path} )
elseif ( CURL_HOME )
 list( APPEND _curl_roots ${CURL_HOME} )
endif()

if (MSVC)
 # curl uses curl.lib for Windows.
 set(CURL_LIB_NAME curllib)
else ()
 # curl uses libcurl.a for non Windows.
 set(CURL_LIB_NAME
 ${CMAKE_SHARED_LIBRARY_PREFIX}curl${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()

# Try the parameterized roots, if they exist
if (_curl_roots)
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "include")
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "lib")
else ()
 pkg_check_modules(PKG_CURL libcurl)
 if (PKG_CURL_FOUND)
 set(CURL_INCLUDE_DIR ${PKG_CURL_INCLUDEDIR})
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${PKG_CURL_LIBDIR} NO_DEFAULT_PATH)
 else ()
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h)
 find_library(CURL_STATIC_LIB NAMES ${CURL_LIB_NAME})
 endif ()
endif ()

if (CURL_INCLUDE_DIR AND CURL_STATIC_LIB)
 set(CURL_FOUND TRUE)
else ()
 set(CURL_FOUND FALSE)
endif ()

if (CURL_FOUND)
 if (NOT CURL_FIND_QUIETLY)
 if (CURL_STATIC_LIB)
 message(STATUS "Found the CURL static library: ${CURL_STATIC_LIB}")
 endif ()
 endif ()
else ()
 if (NOT CURL_FIND_QUIETLY)
 set(CURL_ERR_MSG "Could not find the CURL library. Looked in")
 if ( _curl_roots )
 set(CURL_ERR_MSG "${CURL_ERR_MSG} ${_curl_roots}.")
 else ()
 set(CURL_ERR_MSG "${CURL_ERR_MSG} system search paths.")
 endif ()
 if (CURL_FIND_REQUIRED)
 message(FATAL_ERROR "${CURL_ERR_MSG}")
 else (CURL_FIND_REQUIRED)
 message(STATUS "${CURL_ERR_MSG}")
 endif (CURL_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 CURL_INCLUDE_DIR
 CURL_STATIC_LIB
)
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-4479: [Plasma] Add S3 as external store for Plasma#3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

anuragkh
wants to merge
3
commits into

from

 Closed


ARROW-4479: [Plasma] Add S3 as external store for Plasma
#3559
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
9c7a207

Add s3 as external store to plasma

Feb 5, 2019
bde28c7

Fix cpplint issues

Feb 5, 2019
a37d180

Added CMake build for awssdk

Feb 8, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 4 additions & 0 deletions
cpp/CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,10 @@ static|shared (default shared)")
 "Build the plasma object store java client"
 OFF)

 option(ARROW_PLASMA_S3
 "Build S3 external store bindings for the plasma object store"
 OFF)

 #----------------------------------------------------------------------
 # Thirdparty toolchain options

Expand Down

9 changes: 9 additions & 0 deletions
cpp/cmake_modules/BuildUtils.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -629,3 +629,12 @@ function(ARROW_ADD_PKG_CONFIG MODULE)
 FILES "${CMAKE_CURRENT_BINARY_DIR}/${MODULE}.pc"
 DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
endfunction()

function(AWSSDK_TARGETS MODULE_LIST TARGETS)
 # We will always link against these targets
 set(awssdk_targets "curl_static" "awssdk_core_static")
 foreach(MODULE IN LISTS MODULE_LIST)
 list(APPEND awssdk_targets "awssdk_${MODULE}_static")
 endforeach()
 set(${TARGETS} ${awssdk_targets} PARENT_SCOPE)
endfunction(AWSSDK_TARGETS)

95 changes: 95 additions & 0 deletions
cpp/cmake_modules/FindAWSSDK.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find AWSSDK headers and libraries.
#
# Usage of this module as follows:
#
# find_package(AWSSDK COMPONENTS service1 service2 ...)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# AWSSDK_HOME - When set, this path is inspected instead of standard library
# locations as the root of the AWSSDK installation.
# The environment variable AWSSDK_HOME overrides this veriable.
#
# This module defines
# AWSSDK_INCLUDE_DIR, directory containing headers
# AWSSDK_LIBRARY_DIR, directory containing libraries
# AWSSDK_STATIC_LIBS, static AWS SDK libraries
# AWSSDK_FOUND, whether AWS SDK has been found

if( NOT "${AWSSDK_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${AWSSDK_HOME}" _native_path )
 list( APPEND _awssdk_roots ${_native_path} )
elseif ( AWSSDK_HOME )
 list( APPEND _awssdk_roots ${AWSSDK_HOME} )
endif()

set(AWSSDK_MODULES ${AWSSDK_FIND_COMPONENTS})
set(AWSSDK_STATIC_LIBS)

find_path(AWSSDK_INCLUDE_DIR NAMES aws/core/Aws.h
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "include")

foreach(MODULE ${AWSSDK_MODULES})
 string(TOUPPER ${MODULE} MODULE_UPPERCASE)
 find_library( AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-${MODULE}${CMAKE_STATIC_LIBRARY_SUFFIX}
 PATHS ${_awssdk_roots}
 NO_DEFAULT_PATH
 PATH_SUFFIXES "lib/${CMAKE_LIBRARY_ARCHITECTURE}" "lib" )
 # Fail if any module library is missing
 if (NOT AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB)
 set(LIBRARY_NOT_FOUND "YES")
 else()
 list(APPEND AWSSDK_STATIC_LIBS ${AWSSDK_STATIC_${MODULE_UPPERCASE}_LIB})
 endif()
endforeach()

if (AWSSDK_INCLUDE_DIR AND NOT LIBRARY_NOT_FOUND)
 set(AWSSDK_FOUND TRUE)
 get_filename_component(AWSSDK_LIBRARY_DIR ${AWSSDK_STATIC_CORE_LIB} PATH)
else ()
 set(AWSSDK_FOUND FALSE)
endif ()

if (AWSSDK_FOUND)
 if (NOT AWSSDK_FIND_QUIETLY)
 message(STATUS "Found the AWSSDK libraries: ${AWSSDK_STATIC_LIBS}")
 endif ()
else ()
 set(AWSSDK_STATIC_LIBS)
 if (NOT AWSSDK_FIND_QUIETLY)
 set(AWSSDK_ERR_MSG "Could not find the AWSSDK library. Looked")
 if ( _awssdk_roots )
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in ${_awssdk_roots}.")
 else ()
 set(AWSSDK_ERR_MSG "${AWSSDK_ERR_MSG} in system search paths.")
 endif ()
 if (AWSSDK_FIND_REQUIRED)
 message(FATAL_ERROR "${AWSSDK_ERR_MSG}")
 else (AWSSDK_FIND_REQUIRED)
 message(STATUS "${AWSSDK_ERR_MSG}")
 endif (AWSSDK_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 AWSSDK_INCLUDE_DIR
 AWSSDK_LIBRARY_DIR
 AWSSDK_STATIC_LIBS
 AWSSDK_FOUND
)

102 changes: 102 additions & 0 deletions
cpp/cmake_modules/FindCURL.cmake

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Tries to find CURL headers and libraries.
#
# Usage of this module as follows:
#
# find_package(CURL)
#
# Variables used by this module, they can change the default behaviour and need
# to be set before calling find_package:
#
# CURL_HOME - When set, this path is inspected instead of standard library
# locations as the root of the CURL installation.
# The environment variable CURL_HOME overrides this variable.
#
# - Find CURL (curl/curl.h, libcurl.a)
# This module defines
# CURL_INCLUDE_DIR, directory containing headers
# CURL_STATIC_LIB, path to curl's static library
# CURL_FOUND, whether curl has been found

if( NOT "${CURL_HOME}" STREQUAL "")
 file( TO_CMAKE_PATH "${CURL_HOME}" _native_path )
 list( APPEND _curl_roots ${_native_path} )
elseif ( CURL_HOME )
 list( APPEND _curl_roots ${CURL_HOME} )
endif()

if (MSVC)
 # curl uses curl.lib for Windows.
 set(CURL_LIB_NAME curllib)
else ()
 # curl uses libcurl.a for non Windows.
 set(CURL_LIB_NAME
 ${CMAKE_SHARED_LIBRARY_PREFIX}curl${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()

# Try the parameterized roots, if they exist
if (_curl_roots)
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "include")
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${_curl_roots} NO_DEFAULT_PATH
 PATH_SUFFIXES "lib")
else ()
 pkg_check_modules(PKG_CURL libcurl)
 if (PKG_CURL_FOUND)
 set(CURL_INCLUDE_DIR ${PKG_CURL_INCLUDEDIR})
 find_library(CURL_STATIC_LIB
 NAMES ${CURL_LIB_NAME}
 PATHS ${PKG_CURL_LIBDIR} NO_DEFAULT_PATH)
 else ()
 find_path(CURL_INCLUDE_DIR NAMES curl/curl.h)
 find_library(CURL_STATIC_LIB NAMES ${CURL_LIB_NAME})
 endif ()
endif ()

if (CURL_INCLUDE_DIR AND CURL_STATIC_LIB)
 set(CURL_FOUND TRUE)
else ()
 set(CURL_FOUND FALSE)
endif ()

if (CURL_FOUND)
 if (NOT CURL_FIND_QUIETLY)
 if (CURL_STATIC_LIB)
 message(STATUS "Found the CURL static library: ${CURL_STATIC_LIB}")
 endif ()
 endif ()
else ()
 if (NOT CURL_FIND_QUIETLY)
 set(CURL_ERR_MSG "Could not find the CURL library. Looked in")
 if ( _curl_roots )
 set(CURL_ERR_MSG "${CURL_ERR_MSG} ${_curl_roots}.")
 else ()
 set(CURL_ERR_MSG "${CURL_ERR_MSG} system search paths.")
 endif ()
 if (CURL_FIND_REQUIRED)
 message(FATAL_ERROR "${CURL_ERR_MSG}")
 else (CURL_FIND_REQUIRED)
 message(STATUS "${CURL_ERR_MSG}")
 endif (CURL_FIND_REQUIRED)
 endif ()
endif ()

mark_as_advanced(
 CURL_INCLUDE_DIR
 CURL_STATIC_LIB
)
Loading