') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); GH-35539: [C++] Remove use of internal header files from public header file by ildipo · Pull Request #35592 · apache/arrow · GitHub
Skip to content

GH-35539: [C++] Remove use of internal header files from public header file - #35592

Merged
pitrou merged 2 commits into
apache:mainfrom
ildipo:issue-35539
May 16, 2023
Merged

GH-35539: [C++] Remove use of internal header files from public header file#35592
pitrou merged 2 commits into
apache:mainfrom
ildipo:issue-35539

Conversation

@ildipo

@ildipoildipo commented May 15, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

What changes are included in this PR?

Remove use of compute/util_internal.h in compute/key_map.h

@ildipo
ildipo requested a review from westonpace as a code ownerMay 15, 2023 15:50
@github-actions

github-actionsBot commented May 15, 2023

Copy link
Copy Markdown

@github-actions

github-actionsBot commented May 15, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #35539has been automatically assigned in GitHub to PR creator.

@github-actions

github-actionsBot commented May 15, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #35539has no components, please add labels for components.

@pitrou

pitrou commented May 16, 2023

Copy link
Copy Markdown
Member

Thanks @ildipo . I also removed use of arrow/util/logging.h which should be avoided in public headers.

@pitroupitrou changed the title GH-35539: [C++] remove use of _internal.h header file from public header fileGH-35539: [C++] Remove use of internal header files from public header fileMay 16, 2023
@github-actions

github-actionsBot commented May 16, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #35539has no components, please add labels for components.

@pitrou
pitrou merged commit 505a2e4 into apache:mainMay 16, 2023
@ursabot

ursabot commented May 19, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = af38263 and contender = 505a2e4. 505a2e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.1% ⬆️0.12%] test-mac-arm
[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.45% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 505a2e45 ec2-t3-xlarge-us-east-2
[Finished] 505a2e45 test-mac-arm
[Finished] 505a2e45 ursa-i9-9960x
[Finished] 505a2e45 ursa-thinkcentre-m75q
[Finished] af382630 ec2-t3-xlarge-us-east-2
[Finished] af382630 test-mac-arm
[Finished] af382630 ursa-i9-9960x
[Finished] af382630 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented May 19, 2023

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonpacewestonpaceAwaiting requested review from westonpace

Assignees

No one assigned

Labels

awaiting reviewAwaiting reviewComponent: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Arrow 12.0.0-1 cpp exposes internal headers

3 participants

@ildipo@pitrou@ursabot