Uh oh!
There was an error while loading. Please reload this page.
GH-36038: [Python] Implement __reduce__ on ExtensionType class - #36170
Conversation
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Looks good!
Do you know if we have test coverage for the array itself also being pickleable?
AlenkaF
commented
Jun 20, 2023
I don't think so. Will check and add if necessary 👍 |
AlenkaF
commented
Jun 21, 2023
There is a test for |
AlenkaF
commented
Jun 26, 2023
@jorisvandenbossche I plan to merge this unless there is some issue with changes from the last commit 7d72817. |
Conbench analyzed the 6 benchmark runs on commit There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Rationale for this change
ExtensionTypesubclasses can't be pickled if__reduce__method isn't implemented separately.What changes are included in this PR?
Add
__reduce__method toExtensionTypeclass.Are these changes tested?
Yes, test is added to python/pyarrow/tests/test_extension_type.py.
Are there any user-facing changes?
No.