GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability - #36355

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728
Jun 29, 2023
Merged

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability#36355
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728

Conversation

@raulcd

@raulcdraulcd commented Jun 28, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Currently some conda and wheels jobs are failing due to this error:

 =================================== FAILURES ===================================
__________________________ test_total_bytes_allocated __________________________
def test_total_bytes_allocated():
> assert pa.total_allocated_bytes() == 0
E assert 1216 == 0
E + where 1216 = <built-in function total_allocated_bytes>()
E + where <built-in function total_allocated_bytes> = pa.total_allocated_bytes

What changes are included in this PR?

As suggested on the issue trying to move this test to a subprocess to see if it improves reliabilit.

Are these changes tested?

Archery and CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35728has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-*

@github-actions

Copy link
Copy Markdown

Revision: 0806a80

Submitted crossbow builds: ursacomputing/crossbow @ actions-020f7043d9

TaskStatus
wheel-manylinux-2-28-cp310-amd64Github Actions
wheel-manylinux-2-28-cp310-arm64Github Actions
wheel-manylinux-2-28-cp311-amd64Github Actions
wheel-manylinux-2-28-cp311-arm64Github Actions
wheel-manylinux-2-28-cp38-amd64Github Actions
wheel-manylinux-2-28-cp38-arm64Github Actions
wheel-manylinux-2-28-cp39-amd64Github Actions
wheel-manylinux-2-28-cp39-arm64Github Actions
wheel-manylinux-2014-cp310-amd64Github Actions
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-amd64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-amd64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-amd64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-*-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8d319d3cbd

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp310-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5976a03430

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

the flaky failures seem unrelated to this test now but to s3

 Timeout (0:05:00)!
Thread 0x0000ffff8fcca420 (most recent call first):
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pyarrow/tests/test_fs.py", line 1122 in test_s3_options
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 194 in pytest_pyfunc_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 1788 in runtest
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 169 in pytest_runtest_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 133 in runtestprotocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 324 in _main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 166 in main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 189 in console_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.8/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.8/runpy.py", line 194 in _run_module_as_main

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-b168c1dadc

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@raulcd
raulcd marked this pull request as ready for review June 28, 2023 15:36
@raulcd
raulcd requested a review from AlenkaF as a code ownerJune 28, 2023 15:36
@raulcdraulcd added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 28, 2023
@raulcd

Copy link
Copy Markdown
MemberAuthor

@pitrou are you ok merging this? All the failures are known unrelated nightly failures

@pitrou

Copy link
Copy Markdown
Member

@raulcd Yes, please merge!

@raulcd
raulcd merged commit fa4e27a into apache:mainJun 29, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jun 29, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit fa4e27a6.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] test_total_bytes_allocated failing on CI

2 participants

@raulcd@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability - #36355

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728
Jun 29, 2023
Merged

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability#36355
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728

Conversation

@raulcd

@raulcdraulcd commented Jun 28, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Currently some conda and wheels jobs are failing due to this error:

 =================================== FAILURES ===================================
__________________________ test_total_bytes_allocated __________________________
def test_total_bytes_allocated():
> assert pa.total_allocated_bytes() == 0
E assert 1216 == 0
E + where 1216 = <built-in function total_allocated_bytes>()
E + where <built-in function total_allocated_bytes> = pa.total_allocated_bytes

What changes are included in this PR?

As suggested on the issue trying to move this test to a subprocess to see if it improves reliabilit.

Are these changes tested?

Archery and CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35728has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-*

@github-actions

Copy link
Copy Markdown

Revision: 0806a80

Submitted crossbow builds: ursacomputing/crossbow @ actions-020f7043d9

TaskStatus
wheel-manylinux-2-28-cp310-amd64Github Actions
wheel-manylinux-2-28-cp310-arm64Github Actions
wheel-manylinux-2-28-cp311-amd64Github Actions
wheel-manylinux-2-28-cp311-arm64Github Actions
wheel-manylinux-2-28-cp38-amd64Github Actions
wheel-manylinux-2-28-cp38-arm64Github Actions
wheel-manylinux-2-28-cp39-amd64Github Actions
wheel-manylinux-2-28-cp39-arm64Github Actions
wheel-manylinux-2014-cp310-amd64Github Actions
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-amd64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-amd64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-amd64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-*-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8d319d3cbd

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp310-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5976a03430

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

the flaky failures seem unrelated to this test now but to s3

 Timeout (0:05:00)!
Thread 0x0000ffff8fcca420 (most recent call first):
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pyarrow/tests/test_fs.py", line 1122 in test_s3_options
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 194 in pytest_pyfunc_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 1788 in runtest
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 169 in pytest_runtest_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 133 in runtestprotocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 324 in _main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 166 in main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 189 in console_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.8/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.8/runpy.py", line 194 in _run_module_as_main

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-b168c1dadc

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@raulcd
raulcd marked this pull request as ready for review June 28, 2023 15:36
@raulcd
raulcd requested a review from AlenkaF as a code ownerJune 28, 2023 15:36
@raulcdraulcd added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 28, 2023
@raulcd

Copy link
Copy Markdown
MemberAuthor

@pitrou are you ok merging this? All the failures are known unrelated nightly failures

@pitrou

Copy link
Copy Markdown
Member

@raulcd Yes, please merge!

@raulcd
raulcd merged commit fa4e27a into apache:mainJun 29, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jun 29, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit fa4e27a6.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] test_total_bytes_allocated failing on CI

2 participants

@raulcd@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability - #36355

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728
Jun 29, 2023
Merged

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability#36355
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728

Conversation

@raulcd

@raulcdraulcd commented Jun 28, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Currently some conda and wheels jobs are failing due to this error:

 =================================== FAILURES ===================================
__________________________ test_total_bytes_allocated __________________________
def test_total_bytes_allocated():
> assert pa.total_allocated_bytes() == 0
E assert 1216 == 0
E + where 1216 = <built-in function total_allocated_bytes>()
E + where <built-in function total_allocated_bytes> = pa.total_allocated_bytes

What changes are included in this PR?

As suggested on the issue trying to move this test to a subprocess to see if it improves reliabilit.

Are these changes tested?

Archery and CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35728has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-*

@github-actions

Copy link
Copy Markdown

Revision: 0806a80

Submitted crossbow builds: ursacomputing/crossbow @ actions-020f7043d9

TaskStatus
wheel-manylinux-2-28-cp310-amd64Github Actions
wheel-manylinux-2-28-cp310-arm64Github Actions
wheel-manylinux-2-28-cp311-amd64Github Actions
wheel-manylinux-2-28-cp311-arm64Github Actions
wheel-manylinux-2-28-cp38-amd64Github Actions
wheel-manylinux-2-28-cp38-arm64Github Actions
wheel-manylinux-2-28-cp39-amd64Github Actions
wheel-manylinux-2-28-cp39-arm64Github Actions
wheel-manylinux-2014-cp310-amd64Github Actions
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-amd64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-amd64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-amd64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-*-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8d319d3cbd

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp310-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5976a03430

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

the flaky failures seem unrelated to this test now but to s3

 Timeout (0:05:00)!
Thread 0x0000ffff8fcca420 (most recent call first):
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pyarrow/tests/test_fs.py", line 1122 in test_s3_options
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 194 in pytest_pyfunc_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 1788 in runtest
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 169 in pytest_runtest_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 133 in runtestprotocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 324 in _main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 166 in main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 189 in console_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.8/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.8/runpy.py", line 194 in _run_module_as_main

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-b168c1dadc

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@raulcd
raulcd marked this pull request as ready for review June 28, 2023 15:36
@raulcd
raulcd requested a review from AlenkaF as a code ownerJune 28, 2023 15:36
@raulcdraulcd added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 28, 2023
@raulcd

Copy link
Copy Markdown
MemberAuthor

@pitrou are you ok merging this? All the failures are known unrelated nightly failures

@pitrou

Copy link
Copy Markdown
Member

@raulcd Yes, please merge!

@raulcd
raulcd merged commit fa4e27a into apache:mainJun 29, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jun 29, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit fa4e27a6.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] test_total_bytes_allocated failing on CI

2 participants

@raulcd@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability - #36355

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728
Jun 29, 2023
Merged

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability#36355
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728

Conversation

@raulcd

@raulcdraulcd commented Jun 28, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Currently some conda and wheels jobs are failing due to this error:

 =================================== FAILURES ===================================
__________________________ test_total_bytes_allocated __________________________
def test_total_bytes_allocated():
> assert pa.total_allocated_bytes() == 0
E assert 1216 == 0
E + where 1216 = <built-in function total_allocated_bytes>()
E + where <built-in function total_allocated_bytes> = pa.total_allocated_bytes

What changes are included in this PR?

As suggested on the issue trying to move this test to a subprocess to see if it improves reliabilit.

Are these changes tested?

Archery and CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35728has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-*

@github-actions

Copy link
Copy Markdown

Revision: 0806a80

Submitted crossbow builds: ursacomputing/crossbow @ actions-020f7043d9

TaskStatus
wheel-manylinux-2-28-cp310-amd64Github Actions
wheel-manylinux-2-28-cp310-arm64Github Actions
wheel-manylinux-2-28-cp311-amd64Github Actions
wheel-manylinux-2-28-cp311-arm64Github Actions
wheel-manylinux-2-28-cp38-amd64Github Actions
wheel-manylinux-2-28-cp38-arm64Github Actions
wheel-manylinux-2-28-cp39-amd64Github Actions
wheel-manylinux-2-28-cp39-arm64Github Actions
wheel-manylinux-2014-cp310-amd64Github Actions
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-amd64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-amd64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-amd64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-*-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8d319d3cbd

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp310-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5976a03430

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

the flaky failures seem unrelated to this test now but to s3

 Timeout (0:05:00)!
Thread 0x0000ffff8fcca420 (most recent call first):
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pyarrow/tests/test_fs.py", line 1122 in test_s3_options
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 194 in pytest_pyfunc_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 1788 in runtest
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 169 in pytest_runtest_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 133 in runtestprotocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 324 in _main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 166 in main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 189 in console_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.8/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.8/runpy.py", line 194 in _run_module_as_main

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-b168c1dadc

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@raulcd
raulcd marked this pull request as ready for review June 28, 2023 15:36
@raulcd
raulcd requested a review from AlenkaF as a code ownerJune 28, 2023 15:36
@raulcdraulcd added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 28, 2023
@raulcd

Copy link
Copy Markdown
MemberAuthor

@pitrou are you ok merging this? All the failures are known unrelated nightly failures

@pitrou

Copy link
Copy Markdown
Member

@raulcd Yes, please merge!

@raulcd
raulcd merged commit fa4e27a into apache:mainJun 29, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jun 29, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit fa4e27a6.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] test_total_bytes_allocated failing on CI

2 participants

@raulcd@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability - #36355

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728
Jun 29, 2023
Merged

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability#36355
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728

Conversation

@raulcd

@raulcdraulcd commented Jun 28, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Currently some conda and wheels jobs are failing due to this error:

 =================================== FAILURES ===================================
__________________________ test_total_bytes_allocated __________________________
def test_total_bytes_allocated():
> assert pa.total_allocated_bytes() == 0
E assert 1216 == 0
E + where 1216 = <built-in function total_allocated_bytes>()
E + where <built-in function total_allocated_bytes> = pa.total_allocated_bytes

What changes are included in this PR?

As suggested on the issue trying to move this test to a subprocess to see if it improves reliabilit.

Are these changes tested?

Archery and CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35728has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-*

@github-actions

Copy link
Copy Markdown

Revision: 0806a80

Submitted crossbow builds: ursacomputing/crossbow @ actions-020f7043d9

TaskStatus
wheel-manylinux-2-28-cp310-amd64Github Actions
wheel-manylinux-2-28-cp310-arm64Github Actions
wheel-manylinux-2-28-cp311-amd64Github Actions
wheel-manylinux-2-28-cp311-arm64Github Actions
wheel-manylinux-2-28-cp38-amd64Github Actions
wheel-manylinux-2-28-cp38-arm64Github Actions
wheel-manylinux-2-28-cp39-amd64Github Actions
wheel-manylinux-2-28-cp39-arm64Github Actions
wheel-manylinux-2014-cp310-amd64Github Actions
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-amd64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-amd64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-amd64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-*-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8d319d3cbd

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp310-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5976a03430

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

the flaky failures seem unrelated to this test now but to s3

 Timeout (0:05:00)!
Thread 0x0000ffff8fcca420 (most recent call first):
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pyarrow/tests/test_fs.py", line 1122 in test_s3_options
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 194 in pytest_pyfunc_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 1788 in runtest
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 169 in pytest_runtest_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 133 in runtestprotocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 324 in _main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 166 in main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 189 in console_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.8/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.8/runpy.py", line 194 in _run_module_as_main

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-b168c1dadc

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@raulcd
raulcd marked this pull request as ready for review June 28, 2023 15:36
@raulcd
raulcd requested a review from AlenkaF as a code ownerJune 28, 2023 15:36
@raulcdraulcd added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 28, 2023
@raulcd

Copy link
Copy Markdown
MemberAuthor

@pitrou are you ok merging this? All the failures are known unrelated nightly failures

@pitrou

Copy link
Copy Markdown
Member

@raulcd Yes, please merge!

@raulcd
raulcd merged commit fa4e27a into apache:mainJun 29, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jun 29, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit fa4e27a6.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] test_total_bytes_allocated failing on CI

2 participants

@raulcd@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability - #36355

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728
Jun 29, 2023
Merged

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability#36355
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728

Conversation

@raulcd

@raulcdraulcd commented Jun 28, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Currently some conda and wheels jobs are failing due to this error:

 =================================== FAILURES ===================================
__________________________ test_total_bytes_allocated __________________________
def test_total_bytes_allocated():
> assert pa.total_allocated_bytes() == 0
E assert 1216 == 0
E + where 1216 = <built-in function total_allocated_bytes>()
E + where <built-in function total_allocated_bytes> = pa.total_allocated_bytes

What changes are included in this PR?

As suggested on the issue trying to move this test to a subprocess to see if it improves reliabilit.

Are these changes tested?

Archery and CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35728has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-*

@github-actions

Copy link
Copy Markdown

Revision: 0806a80

Submitted crossbow builds: ursacomputing/crossbow @ actions-020f7043d9

TaskStatus
wheel-manylinux-2-28-cp310-amd64Github Actions
wheel-manylinux-2-28-cp310-arm64Github Actions
wheel-manylinux-2-28-cp311-amd64Github Actions
wheel-manylinux-2-28-cp311-arm64Github Actions
wheel-manylinux-2-28-cp38-amd64Github Actions
wheel-manylinux-2-28-cp38-arm64Github Actions
wheel-manylinux-2-28-cp39-amd64Github Actions
wheel-manylinux-2-28-cp39-arm64Github Actions
wheel-manylinux-2014-cp310-amd64Github Actions
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-amd64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-amd64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-amd64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-*-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8d319d3cbd

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp310-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5976a03430

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

the flaky failures seem unrelated to this test now but to s3

 Timeout (0:05:00)!
Thread 0x0000ffff8fcca420 (most recent call first):
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pyarrow/tests/test_fs.py", line 1122 in test_s3_options
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 194 in pytest_pyfunc_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 1788 in runtest
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 169 in pytest_runtest_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 133 in runtestprotocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 324 in _main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 166 in main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 189 in console_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.8/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.8/runpy.py", line 194 in _run_module_as_main

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-b168c1dadc

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@raulcd
raulcd marked this pull request as ready for review June 28, 2023 15:36
@raulcd
raulcd requested a review from AlenkaF as a code ownerJune 28, 2023 15:36
@raulcdraulcd added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 28, 2023
@raulcd

Copy link
Copy Markdown
MemberAuthor

@pitrou are you ok merging this? All the failures are known unrelated nightly failures

@pitrou

Copy link
Copy Markdown
Member

@raulcd Yes, please merge!

@raulcd
raulcd merged commit fa4e27a into apache:mainJun 29, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jun 29, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit fa4e27a6.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] test_total_bytes_allocated failing on CI

2 participants

@raulcd@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability - #36355

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728
Jun 29, 2023
Merged

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability#36355
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728

Conversation

@raulcd

@raulcdraulcd commented Jun 28, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Currently some conda and wheels jobs are failing due to this error:

 =================================== FAILURES ===================================
__________________________ test_total_bytes_allocated __________________________
def test_total_bytes_allocated():
> assert pa.total_allocated_bytes() == 0
E assert 1216 == 0
E + where 1216 = <built-in function total_allocated_bytes>()
E + where <built-in function total_allocated_bytes> = pa.total_allocated_bytes

What changes are included in this PR?

As suggested on the issue trying to move this test to a subprocess to see if it improves reliabilit.

Are these changes tested?

Archery and CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35728has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-*

@github-actions

Copy link
Copy Markdown

Revision: 0806a80

Submitted crossbow builds: ursacomputing/crossbow @ actions-020f7043d9

TaskStatus
wheel-manylinux-2-28-cp310-amd64Github Actions
wheel-manylinux-2-28-cp310-arm64Github Actions
wheel-manylinux-2-28-cp311-amd64Github Actions
wheel-manylinux-2-28-cp311-arm64Github Actions
wheel-manylinux-2-28-cp38-amd64Github Actions
wheel-manylinux-2-28-cp38-arm64Github Actions
wheel-manylinux-2-28-cp39-amd64Github Actions
wheel-manylinux-2-28-cp39-arm64Github Actions
wheel-manylinux-2014-cp310-amd64Github Actions
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-amd64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-amd64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-amd64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-*-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8d319d3cbd

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp310-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5976a03430

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

the flaky failures seem unrelated to this test now but to s3

 Timeout (0:05:00)!
Thread 0x0000ffff8fcca420 (most recent call first):
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pyarrow/tests/test_fs.py", line 1122 in test_s3_options
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 194 in pytest_pyfunc_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 1788 in runtest
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 169 in pytest_runtest_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 133 in runtestprotocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 324 in _main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 166 in main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 189 in console_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.8/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.8/runpy.py", line 194 in _run_module_as_main

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-b168c1dadc

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@raulcd
raulcd marked this pull request as ready for review June 28, 2023 15:36
@raulcd
raulcd requested a review from AlenkaF as a code ownerJune 28, 2023 15:36
@raulcdraulcd added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 28, 2023
@raulcd

Copy link
Copy Markdown
MemberAuthor

@pitrou are you ok merging this? All the failures are known unrelated nightly failures

@pitrou

Copy link
Copy Markdown
Member

@raulcd Yes, please merge!

@raulcd
raulcd merged commit fa4e27a into apache:mainJun 29, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jun 29, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit fa4e27a6.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] test_total_bytes_allocated failing on CI

2 participants

@raulcd@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability - #36355

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728
Jun 29, 2023
Merged

GH-35728: [CI][Python] Move test_total_bytes_allocated to a subprocess to improve reliability#36355
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-35728

Conversation

@raulcd

@raulcdraulcd commented Jun 28, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Currently some conda and wheels jobs are failing due to this error:

 =================================== FAILURES ===================================
__________________________ test_total_bytes_allocated __________________________
def test_total_bytes_allocated():
> assert pa.total_allocated_bytes() == 0
E assert 1216 == 0
E + where 1216 = <built-in function total_allocated_bytes>()
E + where <built-in function total_allocated_bytes> = pa.total_allocated_bytes

What changes are included in this PR?

As suggested on the issue trying to move this test to a subprocess to see if it improves reliabilit.

Are these changes tested?

Archery and CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #35728has been automatically assigned in GitHub to PR creator.

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-*

@github-actions

Copy link
Copy Markdown

Revision: 0806a80

Submitted crossbow builds: ursacomputing/crossbow @ actions-020f7043d9

TaskStatus
wheel-manylinux-2-28-cp310-amd64Github Actions
wheel-manylinux-2-28-cp310-arm64Github Actions
wheel-manylinux-2-28-cp311-amd64Github Actions
wheel-manylinux-2-28-cp311-arm64Github Actions
wheel-manylinux-2-28-cp38-amd64Github Actions
wheel-manylinux-2-28-cp38-arm64Github Actions
wheel-manylinux-2-28-cp39-amd64Github Actions
wheel-manylinux-2-28-cp39-arm64Github Actions
wheel-manylinux-2014-cp310-amd64Github Actions
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-amd64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-amd64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-amd64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-*-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8d319d3cbd

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions
wheel-manylinux-2014-cp311-arm64Github Actions
wheel-manylinux-2014-cp38-arm64Github Actions
wheel-manylinux-2014-cp39-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp310-arm64

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5976a03430

TaskStatus
wheel-manylinux-2014-cp310-arm64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

the flaky failures seem unrelated to this test now but to s3

 Timeout (0:05:00)!
Thread 0x0000ffff8fcca420 (most recent call first):
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pyarrow/tests/test_fs.py", line 1122 in test_s3_options
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 194 in pytest_pyfunc_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/python.py", line 1788 in runtest
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 169 in pytest_runtest_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 133 in runtestprotocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 324 in _main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_callers.py", line 80 in _multicall
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_manager.py", line 112 in _hookexec
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pluggy/_hooks.py", line 433 in __call__
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 166 in main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/_pytest/config/__init__.py", line 189 in console_main
File "/tmp/arrow-HEAD.1rhW8/venv-wheel-3.8-manylinux_2_17_aarch64.manylinux2014_aarch64/lib64/python3.8/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.8/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.8/runpy.py", line 194 in _run_module_as_main

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 4d3d57e

Submitted crossbow builds: ursacomputing/crossbow @ actions-b168c1dadc

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@raulcd
raulcd marked this pull request as ready for review June 28, 2023 15:36
@raulcd
raulcd requested a review from AlenkaF as a code ownerJune 28, 2023 15:36
@raulcdraulcd added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 28, 2023
@raulcd

Copy link
Copy Markdown
MemberAuthor

@pitrou are you ok merging this? All the failures are known unrelated nightly failures

@pitrou

Copy link
Copy Markdown
Member

@raulcd Yes, please merge!

@raulcd
raulcd merged commit fa4e27a into apache:mainJun 29, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jun 29, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit fa4e27a6.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] test_total_bytes_allocated failing on CI

2 participants

@raulcd@pitrou