Skip to content

GH-36449: [C++][CI] Don't use -g1 for Python jobs - #36453

Merged
pitrou merged 2 commits into
apache:mainfrom
kou:ci-python-gdb-cuda
Jul 4, 2023
Merged

GH-36449: [C++][CI] Don't use -g1 for Python jobs#36453
pitrou merged 2 commits into
apache:mainfrom
kou:ci-python-gdb-cuda

Conversation

@kou

@koukou commented Jul 4, 2023

Copy link
Copy Markdown
Member

Rationale for this change

Python jobs have tests for GDB plugin. We can't use -g1 for GDB plugin because -g1 doesn't provide enough debug information.

What changes are included in this PR?

Don't use -g1 for Python jobs.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
kou requested review from assignUser and raulcd as code ownersJuly 4, 2023 12:46
@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Jul 4, 2023
Python jobs have tests for GDB plugin. We can't use -g1 for GDB
plugin because -g1 doesn't provide enough debug information.
@kou
kouforce-pushed the ci-python-gdb-cuda branch from 88cb268 to ed0f944CompareJuly 4, 2023 12:48
@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@kou

kou commented Jul 4, 2023

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-cuda-python test-debian--python-3 test-ubuntu--python-3 test-fedora-*-python-3

@pitrou

This comment was marked as outdated.

@github-actions

Copy link
Copy Markdown

Revision: ed0f944

Submitted crossbow builds: ursacomputing/crossbow @ actions-aa45e1a934

TaskStatus
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@github-actions

Copy link
Copy Markdown

Revision: ed0f944

Submitted crossbow builds: ursacomputing/crossbow @ actions-6858417986

TaskStatus
test-conda-python-3.10Github Actions
test-conda-python-3.10-hdfs-2.9.2Github Actions
test-conda-python-3.10-hdfs-3.2.1Github Actions
test-conda-python-3.10-pandas-latestGithub Actions
test-conda-python-3.10-pandas-nightlyGithub Actions
test-conda-python-3.10-spark-masterGithub Actions
test-conda-python-3.10-substraitGithub Actions
test-conda-python-3.11Github Actions
test-conda-python-3.11-dask-latestGithub Actions
test-conda-python-3.11-dask-upstream_develGithub Actions
test-conda-python-3.11-hypothesisGithub Actions
test-conda-python-3.11-pandas-upstream_develGithub Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-pandas-1.0Github Actions
test-conda-python-3.8-spark-v3.1.2Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-latestGithub Actions
test-conda-python-3.9-spark-v3.2.0Github Actions
test-cuda-pythonGithub Actions
test-debian-11-python-3Azure
test-fedora-35-python-3Azure
test-ubuntu-20.04-python-3Azure

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-cuda-python

@github-actions

Copy link
Copy Markdown

Revision: 3c2f5e9

Submitted crossbow builds: ursacomputing/crossbow @ actions-3579df7be8

TaskStatus
test-cuda-pythonGithub Actions

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, will merge if CI is green

@pitrou
pitrou merged commit 6f05288 into apache:mainJul 4, 2023
@pitroupitrou removed the awaiting committer review Awaiting committer review label Jul 4, 2023
@kou
kou deleted the ci-python-gdb-cuda branch July 4, 2023 23:30
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit 6f05288e.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI][Python] NumPy deprecation warnings in test_cuda.py (test-cuda-python nightly build) [C++][CI] test_gdb fails on nightly job test-cuda-python

2 participants

@kou@pitrou