Skip to content

GH-36469: [Java][Packaging] Distribute linux aarch64 libs with mavencentral jars - #36487

Merged
raulcd merged 15 commits into
apache:mainfrom
jonathanswenson:java/dist-linux-aarch64-libs
Jul 12, 2023
Merged

GH-36469: [Java][Packaging] Distribute linux aarch64 libs with mavencentral jars#36487
raulcd merged 15 commits into
apache:mainfrom
jonathanswenson:java/dist-linux-aarch64-libs

Conversation

@jonathanswenson

@jonathanswensonjonathanswenson commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

My primary concern here is whether or not I need to avoid pushing the docker image when using aarch64.

Perhaps with a conditional check on arch line 52 of dev/tasks/java-jars/github.yml

Rationale for this change

The java libraries distributed on maven central do not include native libraries build for linux/aarch64, this change should build and include those native libraries in the distribution.

Are these changes tested?

No additional tests are added, but only introduces changes for the build process.

Are there any user-facing changes?

Should not be any user-facing change except for support for the linux/arm64 architecture when pulling java libs from mavencentral.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #36469has been automatically assigned in GitHub to PR creator.

Comment threaddev/tasks/java-jars/github.yml Outdated
@raulcd

Copy link
Copy Markdown
Member

@github-actions crossbow submit java-jars

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jul 6, 2023
@raulcd

Copy link
Copy Markdown
Member

I don't expect the job for java-jars to succeed as it is currently failing on main but seeing the logs might helps us move forward the PR. Thanks for the PR @jonathanswenson !

@github-actions

This comment was marked as outdated.

@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 6, 2023
@jonathanswenson

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit java-jars

@jonathanswenson

jonathanswenson commented Jul 7, 2023

Copy link
Copy Markdown
ContributorAuthor

^^ not sure If i'm allowed to do that (or if github-actions will listen to me here), but want to see if the env variables I set worked here.

Edit: looks like no.

@github-actions

Copy link
Copy Markdown
Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/5488559949

@assignUser

Copy link
Copy Markdown
Member

@github-actions crossbow submit java-jars

@github-actions

This comment was marked as outdated.

Comment threaddev/tasks/java-jars/github.yml Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Jul 9, 2023
Comment threaddev/tasks/java-jars/github.yml Outdated
@kou

kou commented Jul 9, 2023

Copy link
Copy Markdown
Member

@github-actions crossbow submit java-jars

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jul 9, 2023
@github-actions

This comment was marked as outdated.

@koukou changed the title GH-36469: [Java] distribute linux aarch64 libs with mavencentral jars.GH-36469: [Java] distribute linux aarch64 libs with mavencentral jarsJul 10, 2023
@kou

kou commented Jul 10, 2023

Copy link
Copy Markdown
Member

@github-actions crossbow submit java-jars

@github-actions

This comment was marked as outdated.

@kou

kou commented Jul 11, 2023

Copy link
Copy Markdown
Member

@github-actions crossbow submit java-jars

@github-actions

This comment was marked as outdated.

@kou

kou commented Jul 11, 2023

Copy link
Copy Markdown
Member

@github-actions crossbow submit java-jars

@github-actions

This comment was marked as outdated.

@kou

kou commented Jul 11, 2023

Copy link
Copy Markdown
Member

@github-actions crossbow submit java-jars

@github-actions

Copy link
Copy Markdown

Revision: 2d0f8eb

Submitted crossbow builds: ursacomputing/crossbow @ actions-5a980405bf

TaskStatus
java-jarsGithub Actions

@kou

kou commented Jul 11, 2023

Copy link
Copy Markdown
Member

This is ready now.

@assignUser

Copy link
Copy Markdown
Member

IIRC this should not require any changes to the release scripts for the new binaries to be included in the upload to maven right?

Otherwise +1 from me :D

@kou

kou commented Jul 12, 2023

Copy link
Copy Markdown
Member

Right. Existing packages just include binaries created by this PR. No new packages.

@raulcdraulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonathanswenson and @kou !
I'll create an issue to review the test exclusions once #36482 is merged

edit: link to the issue except of PR

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jul 12, 2023
@raulcd

Copy link
Copy Markdown
Member

I've created this issue to follow the removal of the excluded tests here: apache/arrow-java#183

@raulcdraulcd changed the title GH-36469: [Java] distribute linux aarch64 libs with mavencentral jarsGH-36469: [Java][Packaging] Distribute linux aarch64 libs with mavencentral jarsJul 12, 2023
@raulcd
raulcd merged commit 6f6d9ff into apache:mainJul 12, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Jul 12, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6f6d9ff.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] mavencentral jars do not ship with libarrow_cdata_jni binding for linux/aarch64

4 participants

@jonathanswenson@raulcd@assignUser@kou