Skip to content

GH-37803: [CI][Dev][Python] Release and merge script errors - #37819

Merged
raulcd merged 3 commits into
apache:mainfrom
AlenkaF:gh-37803-setuptools_scm-CI-failure
Sep 21, 2023
Merged

GH-37803: [CI][Dev][Python] Release and merge script errors#37819
raulcd merged 3 commits into
apache:mainfrom
AlenkaF:gh-37803-setuptools_scm-CI-failure

Conversation

@AlenkaF

@AlenkaFAlenkaF commented Sep 21, 2023

Copy link
Copy Markdown
Member

What changes are included in this PR?

Pin the version of setuptools_scm to <8.0.0.

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.10

@raulcdraulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlenkaF is this still a draft? I am fine with merging this as is to fix the merge script + archery crossbow tasks, etcetera and maybe opening an issue to follow up to either fix it for setuptools_scm > 8.0.0 or change how we manage the version.

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Sep 21, 2023
@github-actions

Copy link
Copy Markdown
parse() missing 1 required positional argument: 'config'
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/6259636256

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

@AlenkaF is this still a draft? I am fine with merging this as is to fix the merge script + archery crossbow tasks, etcetera and maybe opening an issue to follow up to either fix it for setuptools_scm > 8.0.0 or change how we manage the version.

There are two files where I didn't pin setuptools_scm so I need to run the tests first, to see if they also need to be pinned. Then I will merge 👍

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.10

@github-actions

Copy link
Copy Markdown
parse() missing 1 required positional argument: 'config'
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/6259681246

@raulcd

Copy link
Copy Markdown
Member

There are two files where I didn't pin setuptools_scm so I need to run the tests first, to see if they also need to be pinned. Then I will merge 👍

Sorry you are correct, we have to pin it on archery too: https://github.com/apache/arrow/blob/main/dev/archery/setup.py#L33

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.10

@github-actions

Copy link
Copy Markdown
parse() missing 1 required positional argument: 'config'
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/6259766715

@raulcd

Copy link
Copy Markdown
Member

I just validated we do the checkout from apache/arrow from main for the comment bot. The crossbow task won't work until we merge :(

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

I just validated we do the checkout from apache/arrow from main for the comment bot. The crossbow task won't work until we merge :(

Got it. Let's give it a go 👍

@AlenkaF
AlenkaF marked this pull request as ready for review September 21, 2023 09:30
@raulcd
raulcd merged commit 79e49db into apache:mainSep 21, 2023
@raulcdraulcd removed the awaiting merge Awaiting merge label Sep 21, 2023
@AlenkaF
AlenkaF deleted the gh-37803-setuptools_scm-CI-failure branch September 21, 2023 09:32
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 79e49db.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

@jorisvandenbossche

Copy link
Copy Markdown
Member

This might already be fixed in the meantime: pypa/setuptools-scm#919 (the same error message is mentioned on that issue, but didn't check if it actually fixed it)

@cwegener

Copy link
Copy Markdown

opening an issue to follow up to either fix it for setuptools_scm > 8.0.0 or change how we manage the version.

A permanent fix to make pyarrow build on latest setuptools + setuptools_scm would be highly desirable. I had to resort to the exact same version constraint myself in an emergency fix to unblock some automated build system failures.

@jorisvandenbossche

Copy link
Copy Markdown
Member

@cwegener I am not sure there is something to fix on our side. As far as I understand, it's a regression in setuptools_scm that will be fixed there (pypa/setuptools-scm#925, pypa/setuptools-scm#935). Ideally we would update old releases to add this upper pin for setuptools_scm in the meantime. But our release process is quite heavy, and hopefully a release of setuptools_scm fixing this issue will be released more quickly.

Now, it seems that nowadays it is recommended to configure setuptools_scm throught pyproject.toml instead of use_scm_version in setup() in setup.py. So that's something that we should update on our side (but that's also something we will only do for a future release, I think)

@jorisvandenbossche

Copy link
Copy Markdown
Member

I opened a new issue about the problem of having to upper pin setuptools_scm right now with existing releases, so we have an open issue about this that users can find if they run into this -> #37931

And also opened an issue to track that we should move our setuptools_scm configuration to pyproject.toml -> #37929

kou pushed a commit that referenced this pull request Sep 28, 2023
… scripts (#37930)
Follow-up on #37819, which missed one place to add a pin for the release verification scripts
* Closes: #37803
Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@cwegener

Copy link
Copy Markdown

@jorisvandenbossche

Thanks so much for the detailed explanation!

I was in a rush to fix the breakage and the huge amount of code in setup.py, plus the distractions of there also being a pyproject.toml that doesn't seem to be used yet was causing a lot of confusion for me.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…ache#37819)
### What changes are included in this PR?
Pin the version of `setuptools_scm` to `<8.0.0`.
* Closes: apache#37803
Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…cation scripts (apache#37930)
Follow-up on apache#37819, which missed one place to add a pin for the release verification scripts
* Closes: apache#37803
Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…ache#37819)
### What changes are included in this PR?
Pin the version of `setuptools_scm` to `<8.0.0`.
* Closes: apache#37803
Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…cation scripts (apache#37930)
Follow-up on apache#37819, which missed one place to add a pin for the release verification scripts
* Closes: apache#37803
Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
h-vetinari added a commit to h-vetinari/arrow that referenced this pull request Feb 20, 2024
raulcd pushed a commit that referenced this pull request Feb 20, 2024
…rge script errors (#37819)" (#40150)
This reverts commit 79e49db.
#37931 should have been fixed as of pypa/setuptools-scm@056584b in setuptools_scm 8.0.4; I tested that this works in conda-forge/arrow-cpp-feedstock#1314.
CC @ AlenkaF @ raulcd * Closes: #37931
Authored-by: H. Vetinari <h.vetinari@gmx.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI][Dev][Python] Release and merge script errors

4 participants

@AlenkaF@raulcd@jorisvandenbossche@cwegener