Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 4.3k
GH-23221: [C++] Add support for building with Emscripten#37821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
5503984331aaa33e4156e80b21d1908abf96effae531ca7f9c26d68cf5ec4443c2f179aec8a790db01d70daa670ff58481008b3dc20f9f05b777f69d93d8cc831715d3fd8a1c28f675d97e58f9a00f068bda2b2614b4968834b5a3ff2a7c945ece1e28ccba97a8d71aadc68e87cb0da9e3f1a81123813f9fff2ce0b5cc3bb5fedaa76d464bb2dd85b8d3b2558b7d2e484867d29c7ad2e275c08a22ace85527e477a96f7935e8ee70ae1c579688d1abda548e6b457d7c92ead7c2a1d67f58fbdfee9e1988ddbcf561d4cc2ce3631fd8b8f8d063d497a6124d53b10b41509bffa0c9a79cc4980d48d6026f9fed543948c795b4f2ebfb7b01717f780784d23f1a1bdd051df79e49f232d7f55b65a3672481cf57e1b659506ca5617ba51dd2c662b1050f5145426f064659c8cc5ae32429261370b1ffd0fa881da176ad5f058c951705de225cef43179e57d3e0770abcd7dfcc0c1d5701d5af0064fa091a6e3607f2268028682ed36fca2ee99e5eb73740a4dc3d038b07ebfc0692dad3bc3b41307910File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -65,6 +65,7 @@ RUN latest_system_llvm=14 && \ | ||
| RUN apt-get update -y -q && \ | ||
| apt-get install -y -q --no-install-recommends \ | ||
| autoconf \ | ||
| bzip2 \ | ||
| ca-certificates \ | ||
| ccache \ | ||
| cmake \ | ||
| @@ -115,10 +116,20 @@ RUN apt-get update -y -q && \ | ||
| rapidjson-dev \ | ||
| rsync \ | ||
| tzdata \ | ||
| wget && \ | ||
| wget \ | ||
| xz-utils && \ | ||
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists* | ||
| # install emscripten using EMSDK | ||
| ARG emscripten_version="3.1.45" | ||
| RUN cd ~ && git clone https://github.com/emscripten-core/emsdk.git && \ | ||
| cd emsdk && \ | ||
| ./emsdk install ${emscripten_version} && \ | ||
| ./emsdk activate ${emscripten_version} && \ | ||
| echo "Installed emsdk to:" ~/emsdk | ||
| ARG gcc_version="" | ||
| RUN if [ "${gcc_version}" = "" ]; then \ | ||
| apt-get update -y -q && \ | ||
| @@ -151,6 +162,9 @@ RUN if [ "${gcc_version}" = "" ]; then \ | ||
| update-alternatives --set c++ /usr/bin/g++; \ | ||
| fi | ||
| # make sure zlib is cached in the EMSDK folder | ||
| RUN source ~/emsdk/emsdk_env.sh && embuilder --pic build zlib | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason why this isn't together with the install step above? | ||
| COPY ci/scripts/install_minio.sh /arrow/ci/scripts/ | ||
| RUN /arrow/ci/scripts/install_minio.sh latest /usr/local | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| var Module = { | ||
| }; | ||
| // make sure tests can access the current parquet test data files | ||
| Module.preRun = () => {ENV.PARQUET_TEST_DATA = process.env.PARQUET_TEST_DATA; | ||
| ENV.ARROW_TEST_DATA = process.env.ARROW_TEST_DATA; | ||
| }; |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, two things: