Uh oh!
There was an error while loading. Please reload this page.
GH-38088: [R] Remove outdated references to brew and autobrew - #38089
Merged
Conversation
paleolimbotforce-pushed
the
r-remove-brew-jobs
branch
from
October 7, 2023 00:44
6ac28a5 to
305cf9eComparepaleolimbot
commented
Oct 7, 2023
MemberAuthor
@github-actions crossbow-submit --group r |
|
paleolimbot
commented
Oct 7, 2023
MemberAuthor
@github-actions crossbow submit --group r |
Revision: 305cf9e Submitted crossbow builds: ursacomputing/crossbow @ actions-2039736566
|
paleolimbot
marked this pull request as ready for review
October 8, 2023 02:32
paleolimbot
requested review from
assignUser, kou, raulcd and zeroshade
as code ownersOctober 8, 2023 02:32
paleolimbot
commented
Oct 9, 2023
MemberAuthor
@assignUser could you give this a review? I don't believe any of these failures are new as a result of these changes. |
assignUser
approved these changes
Oct 9, 2023
assignUser
commented
Oct 9, 2023
Member
I'll merge this so we get rid of the failing nightlies to reduce the noise for the release prep. |
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9df80fd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#38089) ### Rationale for this change We no longer use autobrew to install on MacOS, so we no longer need CI jobs or helper scripts that had previously been referenced from this install path. ### What changes are included in this PR? This PR removes references to autobrew that are no longer needed. It also removes the R homebrew CI job, which has been failing for several months. We had supported homebrew because `brew install apache-arrow --HEAD` was one method of avoiding a full binary install for potential MacOS contributors; however, downloading nightly static libraries (e.g., apache#38080) is an even faster way to get a compatible libarrow built for the R package and works on MacOS, Windows, and Linux. ### Are these changes tested? These changes remove tests and infrastructure that are no longer relevant. ### Are there any user-facing changes? No. * Closes: apache#38088 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#38089) ### Rationale for this change We no longer use autobrew to install on MacOS, so we no longer need CI jobs or helper scripts that had previously been referenced from this install path. ### What changes are included in this PR? This PR removes references to autobrew that are no longer needed. It also removes the R homebrew CI job, which has been failing for several months. We had supported homebrew because `brew install apache-arrow --HEAD` was one method of avoiding a full binary install for potential MacOS contributors; however, downloading nightly static libraries (e.g., apache#38080) is an even faster way to get a compatible libarrow built for the R package and works on MacOS, Windows, and Linux. ### Are these changes tested? These changes remove tests and infrastructure that are no longer relevant. ### Are there any user-facing changes? No. * Closes: apache#38088 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We no longer use autobrew to install on MacOS, so we no longer need CI jobs or helper scripts that had previously been referenced from this install path.
What changes are included in this PR?
This PR removes references to autobrew that are no longer needed. It also removes the R homebrew CI job, which has been failing for several months. We had supported homebrew because
brew install apache-arrow --HEADwas one method of avoiding a full binary install for potential MacOS contributors; however, downloading nightly static libraries (e.g., #38080) is an even faster way to get a compatible libarrow built for the R package and works on MacOS, Windows, and Linux.Are these changes tested?
These changes remove tests and infrastructure that are no longer relevant.
Are there any user-facing changes?
No.