Uh oh!
There was an error while loading. Please reload this page.
MINOR: [R] Avoid stray output from expr when checking for 10.13 - #38303
Conversation
@github-actions crossbow submit r-binary-packages |
This comment was marked as outdated.
This comment was marked as outdated.
The fix actually doesn't work^^ https://github.com/ursacomputing/crossbow/actions/runs/6541502691/job/17763126329#step:13:74 (the error is due to the missing flag that is set when the check is successfull) Edit: |
This reverts commit a56ce03.
Revision: 1780fe4 Submitted crossbow builds: ursacomputing/crossbow @ actions-49d5b1c7dd
|
assignUser
commented
Oct 17, 2023
Works, no flag on arm build and no output https://github.com/ursacomputing/crossbow/actions/runs/6541940759/job/17764730231#step:17:61 |
jonkeane
left a comment
There was a problem hiding this comment.
Would you mind adding a comment here so future-us knows why we're using expr + dumping the output?
| fi | ||
| if [ "$UNAME" = "Darwin" ] && expr $(sw_vers -productVersion) : '10\.13'; then | ||
| if [ "$UNAME" = "Darwin" ] && expr $(sw_vers -productVersion) : '10\.13' >/dev/null 2>&1; then |
There was a problem hiding this comment.
Could you add a comment here about why expr + why >/dev/null 2>&1 ?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Add both the rationale behind using expr
### Rationale for this change `expr` was printing the number of matching chars which showed up as noise in the log (which we want to avoid as much as possible to avoid any false positive checks) See #38236 (comment) for @ jonkeane's investigation. ### What changes are included in this PR? Replace use of expr with test. ### Are these changes tested? Crossbow Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 40571db. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…he#38303) ### Rationale for this change `expr` was printing the number of matching chars which showed up as noise in the log (which we want to avoid as much as possible to avoid any false positive checks) See apache#38236 (comment) for @ jonkeane's investigation. ### What changes are included in this PR? Replace use of expr with test. ### Are these changes tested? Crossbow Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
…he#38303) ### Rationale for this change `expr` was printing the number of matching chars which showed up as noise in the log (which we want to avoid as much as possible to avoid any false positive checks) See apache#38236 (comment) for @ jonkeane's investigation. ### What changes are included in this PR? Replace use of expr with test. ### Are these changes tested? Crossbow Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Rationale for this change
exprwas printing the number of matching chars which showed up as noise in the log (which we want to avoid as much as possible to avoid any false positive checks)See #38236 (comment) for @jonkeane's investigation.
What changes are included in this PR?
Replace use of expr with test.
Are these changes tested?
Crossbow