Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 4.3k
GH-39013: [Go][Integration] Support cABI import/export of StringView#39019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
56f71345dd6ea59766f85a276351b89bd698e80f5ac6563380c3318433a679f44d8f738e4a09c25059717005868067815814fe8ec12dd7ea062dade623c9f96f142206d3c69b952001f97edc7503a12f9b923766e10341acb6a4ef297f456e3467e9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -193,6 +193,8 @@ def _run_test_cases(self, | ||
| ``case_runner`` ran against ``test_cases`` | ||
| """ | ||
| def case_wrapper(test_case): | ||
| if serial: | ||
| return case_runner(test_case) | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this addition deliberate? MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes: printer.cork() was failing to dump output when the test segfaulted. In any case, corking the printer adds no value when we're running in serial. | ||
| with printer.cork(): | ||
| return case_runner(test_case) | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, we don't need
OrderedDictanymore as regular dicts are now ordered by default.