GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary - #39234

Merged
pitrou merged 3 commits into
apache:mainfrom
zanmato1984:fix-arrow-32570
Dec 21, 2023
Merged

GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary#39234
pitrou merged 3 commits into
apache:mainfrom
zanmato1984:fix-arrow-32570

Conversation

@zanmato1984

@zanmato1984zanmato1984 commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Rationale for this change

Addressed in #32570 (comment)

What changes are included in this PR?

  1. Skip consecutive rows with the same id when calculating rows to skip when appending to ExecBatchBuilder.
  2. Fix the bug that column offset is neglected when calculating rows to skip.

Are these changes tested?

Yes. New UT included and the change is also protected by the existing case mentioned in the issue.

Are there any user-facing changes?

No.

This PR contains a "Critical Fix".

Because #32570 is labeled critical, and causes a crash even when the API contract is upheld.

@zanmato1984
Fix the issue of ExecBatchBuilder when appending consecutive tail r…
8edc1d1
…ows with the same id may exceed buffer boundary
@github-actions

github-actionsBot commented Dec 14, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #32570has been automatically assigned in GitHub to PR creator.

@zanmato1984zanmato1984 mentioned this pull request Dec 14, 2023
Closed
@zanmato1984

zanmato1984 commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test-ubuntu-20.04-cpp

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown

Revision: 8edc1d1

Submitted crossbow builds: ursacomputing/crossbow @ actions-d19754bb45

TaskStatus
test-ubuntu-20.04-cppGitHub Actions

@zanmato1984

zanmato1984 commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test-macos-12-cpp

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown 
Unable to match any tasks for `test-macos-12-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225815149

@zanmato1984

zanmato1984 commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test-macos-cpp

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown 
Unable to match any tasks for `test-macos-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225892739

@zanmato1984

zanmato1984 commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit cpp

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown 
Unable to match any tasks for `cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226222452

@zanmato1984

zanmato1984 commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown 
Unable to match any tasks for `test`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226270964

@zanmato1984

zanmato1984 commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit -g cpp

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown

Revision: 8edc1d1

Submitted crossbow builds: ursacomputing/crossbow @ actions-ac27092881

TaskStatus
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindAzure
test-cuda-cppGitHub Actions
test-debian-11-cpp-amd64GitHub Actions
test-debian-11-cpp-i386GitHub Actions
test-fedora-35-cppGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-20GitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions

@assignUserassignUser added the Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. label Dec 15, 2023
@zanmato1984

zanmato1984 commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

I wanted to retry the CI because the failures don't seem to be related to my change. I don't know how so I tried some commands but obviously they are not what I wanted :(

@pitrou

pitrou commented Dec 20, 2023

Copy link
Copy Markdown
Member

cc @bkietz

pitrou
pitrou reviewed Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc Outdated
@github-actionsgithub-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 21, 2023
pitrou
pitrou reviewed Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
pitrou
pitrou reviewed Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array_test.cc
@pitrou
pitrou merged commit 2abb3fb into apache:mainDec 21, 2023
@pitroupitrou removed the awaiting committer review Awaiting committer review label Dec 21, 2023
@conbench-apache-arrow

conbench-apache-arrowBot commented Dec 22, 2023

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2abb3fb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Jan 12, 2024
Closed
Merged
pitrou pushed a commit that referenced this pull request Jan 17, 2024
@zanmato1984
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
1dc3b81
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-32570: [C++] Fix the issue ofExecBatchBuilderwhen append…
c204ba8
…ing consecutive tail rows with the same id may exceed buffer boundary (apache#39234)
### Rationale for this change
Addressed in apache#32570 (comment)
### What changes are included in this PR?
1. Skip consecutive rows with the same id when calculating rows to skip when appending to `ExecBatchBuilder`.
2. Fix the bug that column offset is neglected when calculating rows to skip.
### Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
Because apache#32570 is labeled critical, and causes a crash even when the API contract is upheld.
* Closes: apache#32570
Authored-by: zanmato <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-39583: [C++] Fix the issue of ExecBatchBuilder when appendin…
be6dbff
…g consecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (apache#39585)
### Rationale for this change
apache#39583 is a subsequent issue of apache#32570 (fixed by apache#39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of apache#39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: apache#39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit that referenced this pull request Feb 20, 2024
@zanmato1984@raulcd
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
ef4b4de
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees

No one assigned

Labels

Component: C++Critical FixBugfixes for security vulnerabilities, crashes, or invalid data.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies

3 participants

@zanmato1984@pitrou@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary - #39234
Merged
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Dec 21, 2023
Merged
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary#39234
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Conversation
@zanmato1984
@zanmato1984zanmato1984
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
Addressed in #32570 (comment)
What changes are included in this PR?
  1. Skip consecutive rows with the same id when calculating rows to skip when appending to ExecBatchBuilder.
  2. Fix the bug that column offset is neglected when calculating rows to skip.
Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
Because #32570 is labeled critical, and causes a crash even when the API contract is upheld.
@zanmato1984
Fix the issue of ExecBatchBuilder when appending consecutive tail r…
8edc1d1
…ows with the same id may exceed buffer boundary
@github-actions
github-actionsBot
commented
Dec 14, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #32570has been automatically assigned in GitHub to PR creator.
@zanmato1984zanmato1984
mentioned this pull request
Dec 14, 2023

Closed

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-d19754bb45
TaskStatus
test-ubuntu-20.04-cppGitHub Actions
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-12-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-12-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225815149

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225892739

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226222452

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226270964

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-ac27092881
TaskStatus
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindAzure
test-cuda-cppGitHub Actions
test-debian-11-cpp-amd64GitHub Actions
test-debian-11-cpp-i386GitHub Actions
test-fedora-35-cppGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-20GitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
@assignUserassignUser
added
the 
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Dec 15, 2023
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
I wanted to retry the CI because the failures don't seem to be related to my change. I don't know how so I tried some commands but obviously they are not what I wanted :(
@pitrou
pitrou
commented
Dec 20, 2023

Copy link


Copy Markdown

Member
cc @bkietz
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
Outdated

@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Dec 21, 2023
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array_test.cc
@pitrou
pitrou
merged commit 2abb3fb
into
apache:mainDec 21, 2023
@pitroupitrou
removed
the 
awaiting committer review
Awaiting committer review
label
Dec 21, 2023
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Dec 22, 2023

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2abb3fb.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Jan 12, 2024

Closed

 Merged

pitrou pushed a commit
that referenced
this pull request
Jan 17, 2024
@zanmato1984
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
1dc3b81
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-32570: [C++] Fix the issue ofExecBatchBuilderwhen append…
c204ba8
…ing consecutive tail rows with the same id may exceed buffer boundary (apache#39234)
### Rationale for this change
Addressed in apache#32570 (comment)
### What changes are included in this PR?
1. Skip consecutive rows with the same id when calculating rows to skip when appending to `ExecBatchBuilder`.
2. Fix the bug that column offset is neglected when calculating rows to skip.
### Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
Because apache#32570 is labeled critical, and causes a crash even when the API contract is upheld.
* Closes: apache#32570
Authored-by: zanmato <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-39583: [C++] Fix the issue of ExecBatchBuilder when appendin…
be6dbff
…g consecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (apache#39585)
### Rationale for this change
apache#39583 is a subsequent issue of apache#32570 (fixed by apache#39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of apache#39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: apache#39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit
that referenced
this pull request
Feb 20, 2024
@zanmato1984@raulcd
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
ef4b4de
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++Critical FixBugfixes for security vulnerabilities, crashes, or invalid data.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies


3 participants

@zanmato1984@pitrou@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary - #39234
Merged
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Dec 21, 2023
Merged
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary#39234
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Conversation
@zanmato1984
@zanmato1984zanmato1984
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
Addressed in #32570 (comment)
What changes are included in this PR?
  1. Skip consecutive rows with the same id when calculating rows to skip when appending to ExecBatchBuilder.
  2. Fix the bug that column offset is neglected when calculating rows to skip.
Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
Because #32570 is labeled critical, and causes a crash even when the API contract is upheld.
@zanmato1984
Fix the issue of ExecBatchBuilder when appending consecutive tail r…
8edc1d1
…ows with the same id may exceed buffer boundary
@github-actions
github-actionsBot
commented
Dec 14, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #32570has been automatically assigned in GitHub to PR creator.
@zanmato1984zanmato1984
mentioned this pull request
Dec 14, 2023

Closed

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-d19754bb45
TaskStatus
test-ubuntu-20.04-cppGitHub Actions
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-12-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-12-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225815149

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225892739

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226222452

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226270964

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-ac27092881
TaskStatus
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindAzure
test-cuda-cppGitHub Actions
test-debian-11-cpp-amd64GitHub Actions
test-debian-11-cpp-i386GitHub Actions
test-fedora-35-cppGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-20GitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
@assignUserassignUser
added
the 
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Dec 15, 2023
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
I wanted to retry the CI because the failures don't seem to be related to my change. I don't know how so I tried some commands but obviously they are not what I wanted :(
@pitrou
pitrou
commented
Dec 20, 2023

Copy link


Copy Markdown

Member
cc @bkietz
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
Outdated

@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Dec 21, 2023
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array_test.cc
@pitrou
pitrou
merged commit 2abb3fb
into
apache:mainDec 21, 2023
@pitroupitrou
removed
the 
awaiting committer review
Awaiting committer review
label
Dec 21, 2023
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Dec 22, 2023

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2abb3fb.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Jan 12, 2024

Closed

 Merged

pitrou pushed a commit
that referenced
this pull request
Jan 17, 2024
@zanmato1984
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
1dc3b81
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-32570: [C++] Fix the issue ofExecBatchBuilderwhen append…
c204ba8
…ing consecutive tail rows with the same id may exceed buffer boundary (apache#39234)
### Rationale for this change
Addressed in apache#32570 (comment)
### What changes are included in this PR?
1. Skip consecutive rows with the same id when calculating rows to skip when appending to `ExecBatchBuilder`.
2. Fix the bug that column offset is neglected when calculating rows to skip.
### Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
Because apache#32570 is labeled critical, and causes a crash even when the API contract is upheld.
* Closes: apache#32570
Authored-by: zanmato <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-39583: [C++] Fix the issue of ExecBatchBuilder when appendin…
be6dbff
…g consecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (apache#39585)
### Rationale for this change
apache#39583 is a subsequent issue of apache#32570 (fixed by apache#39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of apache#39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: apache#39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit
that referenced
this pull request
Feb 20, 2024
@zanmato1984@raulcd
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
ef4b4de
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++Critical FixBugfixes for security vulnerabilities, crashes, or invalid data.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies


3 participants

@zanmato1984@pitrou@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary - #39234
Merged
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Dec 21, 2023
Merged
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary#39234
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Conversation
@zanmato1984
@zanmato1984zanmato1984
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
Addressed in #32570 (comment)
What changes are included in this PR?
  1. Skip consecutive rows with the same id when calculating rows to skip when appending to ExecBatchBuilder.
  2. Fix the bug that column offset is neglected when calculating rows to skip.
Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
Because #32570 is labeled critical, and causes a crash even when the API contract is upheld.
@zanmato1984
Fix the issue of ExecBatchBuilder when appending consecutive tail r…
8edc1d1
…ows with the same id may exceed buffer boundary
@github-actions
github-actionsBot
commented
Dec 14, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #32570has been automatically assigned in GitHub to PR creator.
@zanmato1984zanmato1984
mentioned this pull request
Dec 14, 2023

Closed

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-d19754bb45
TaskStatus
test-ubuntu-20.04-cppGitHub Actions
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-12-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-12-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225815149

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225892739

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226222452

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226270964

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-ac27092881
TaskStatus
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindAzure
test-cuda-cppGitHub Actions
test-debian-11-cpp-amd64GitHub Actions
test-debian-11-cpp-i386GitHub Actions
test-fedora-35-cppGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-20GitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
@assignUserassignUser
added
the 
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Dec 15, 2023
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
I wanted to retry the CI because the failures don't seem to be related to my change. I don't know how so I tried some commands but obviously they are not what I wanted :(
@pitrou
pitrou
commented
Dec 20, 2023

Copy link


Copy Markdown

Member
cc @bkietz
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
Outdated

@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Dec 21, 2023
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array_test.cc
@pitrou
pitrou
merged commit 2abb3fb
into
apache:mainDec 21, 2023
@pitroupitrou
removed
the 
awaiting committer review
Awaiting committer review
label
Dec 21, 2023
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Dec 22, 2023

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2abb3fb.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Jan 12, 2024

Closed

 Merged

pitrou pushed a commit
that referenced
this pull request
Jan 17, 2024
@zanmato1984
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
1dc3b81
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-32570: [C++] Fix the issue ofExecBatchBuilderwhen append…
c204ba8
…ing consecutive tail rows with the same id may exceed buffer boundary (apache#39234)
### Rationale for this change
Addressed in apache#32570 (comment)
### What changes are included in this PR?
1. Skip consecutive rows with the same id when calculating rows to skip when appending to `ExecBatchBuilder`.
2. Fix the bug that column offset is neglected when calculating rows to skip.
### Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
Because apache#32570 is labeled critical, and causes a crash even when the API contract is upheld.
* Closes: apache#32570
Authored-by: zanmato <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-39583: [C++] Fix the issue of ExecBatchBuilder when appendin…
be6dbff
…g consecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (apache#39585)
### Rationale for this change
apache#39583 is a subsequent issue of apache#32570 (fixed by apache#39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of apache#39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: apache#39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit
that referenced
this pull request
Feb 20, 2024
@zanmato1984@raulcd
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
ef4b4de
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++Critical FixBugfixes for security vulnerabilities, crashes, or invalid data.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies


3 participants

@zanmato1984@pitrou@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary - #39234
Merged
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Dec 21, 2023
Merged
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary#39234
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Conversation
@zanmato1984
@zanmato1984zanmato1984
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
Addressed in #32570 (comment)
What changes are included in this PR?
  1. Skip consecutive rows with the same id when calculating rows to skip when appending to ExecBatchBuilder.
  2. Fix the bug that column offset is neglected when calculating rows to skip.
Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
Because #32570 is labeled critical, and causes a crash even when the API contract is upheld.
@zanmato1984
Fix the issue of ExecBatchBuilder when appending consecutive tail r…
8edc1d1
…ows with the same id may exceed buffer boundary
@github-actions
github-actionsBot
commented
Dec 14, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #32570has been automatically assigned in GitHub to PR creator.
@zanmato1984zanmato1984
mentioned this pull request
Dec 14, 2023

Closed

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-d19754bb45
TaskStatus
test-ubuntu-20.04-cppGitHub Actions
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-12-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-12-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225815149

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225892739

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226222452

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226270964

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-ac27092881
TaskStatus
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindAzure
test-cuda-cppGitHub Actions
test-debian-11-cpp-amd64GitHub Actions
test-debian-11-cpp-i386GitHub Actions
test-fedora-35-cppGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-20GitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
@assignUserassignUser
added
the 
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Dec 15, 2023
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
I wanted to retry the CI because the failures don't seem to be related to my change. I don't know how so I tried some commands but obviously they are not what I wanted :(
@pitrou
pitrou
commented
Dec 20, 2023

Copy link


Copy Markdown

Member
cc @bkietz
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
Outdated

@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Dec 21, 2023
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array_test.cc
@pitrou
pitrou
merged commit 2abb3fb
into
apache:mainDec 21, 2023
@pitroupitrou
removed
the 
awaiting committer review
Awaiting committer review
label
Dec 21, 2023
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Dec 22, 2023

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2abb3fb.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Jan 12, 2024

Closed

 Merged

pitrou pushed a commit
that referenced
this pull request
Jan 17, 2024
@zanmato1984
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
1dc3b81
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-32570: [C++] Fix the issue ofExecBatchBuilderwhen append…
c204ba8
…ing consecutive tail rows with the same id may exceed buffer boundary (apache#39234)
### Rationale for this change
Addressed in apache#32570 (comment)
### What changes are included in this PR?
1. Skip consecutive rows with the same id when calculating rows to skip when appending to `ExecBatchBuilder`.
2. Fix the bug that column offset is neglected when calculating rows to skip.
### Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
Because apache#32570 is labeled critical, and causes a crash even when the API contract is upheld.
* Closes: apache#32570
Authored-by: zanmato <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-39583: [C++] Fix the issue of ExecBatchBuilder when appendin…
be6dbff
…g consecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (apache#39585)
### Rationale for this change
apache#39583 is a subsequent issue of apache#32570 (fixed by apache#39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of apache#39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: apache#39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit
that referenced
this pull request
Feb 20, 2024
@zanmato1984@raulcd
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
ef4b4de
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++Critical FixBugfixes for security vulnerabilities, crashes, or invalid data.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies


3 participants

@zanmato1984@pitrou@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary - #39234
Merged
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Dec 21, 2023
Merged
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary#39234
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Conversation
@zanmato1984
@zanmato1984zanmato1984
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
Addressed in #32570 (comment)
What changes are included in this PR?
  1. Skip consecutive rows with the same id when calculating rows to skip when appending to ExecBatchBuilder.
  2. Fix the bug that column offset is neglected when calculating rows to skip.
Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
Because #32570 is labeled critical, and causes a crash even when the API contract is upheld.
@zanmato1984
Fix the issue of ExecBatchBuilder when appending consecutive tail r…
8edc1d1
…ows with the same id may exceed buffer boundary
@github-actions
github-actionsBot
commented
Dec 14, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #32570has been automatically assigned in GitHub to PR creator.
@zanmato1984zanmato1984
mentioned this pull request
Dec 14, 2023

Closed

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-d19754bb45
TaskStatus
test-ubuntu-20.04-cppGitHub Actions
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-12-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-12-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225815149

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225892739

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226222452

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226270964

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-ac27092881
TaskStatus
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindAzure
test-cuda-cppGitHub Actions
test-debian-11-cpp-amd64GitHub Actions
test-debian-11-cpp-i386GitHub Actions
test-fedora-35-cppGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-20GitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
@assignUserassignUser
added
the 
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Dec 15, 2023
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
I wanted to retry the CI because the failures don't seem to be related to my change. I don't know how so I tried some commands but obviously they are not what I wanted :(
@pitrou
pitrou
commented
Dec 20, 2023

Copy link


Copy Markdown

Member
cc @bkietz
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
Outdated

@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Dec 21, 2023
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array_test.cc
@pitrou
pitrou
merged commit 2abb3fb
into
apache:mainDec 21, 2023
@pitroupitrou
removed
the 
awaiting committer review
Awaiting committer review
label
Dec 21, 2023
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Dec 22, 2023

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2abb3fb.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Jan 12, 2024

Closed

 Merged

pitrou pushed a commit
that referenced
this pull request
Jan 17, 2024
@zanmato1984
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
1dc3b81
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-32570: [C++] Fix the issue ofExecBatchBuilderwhen append…
c204ba8
…ing consecutive tail rows with the same id may exceed buffer boundary (apache#39234)
### Rationale for this change
Addressed in apache#32570 (comment)
### What changes are included in this PR?
1. Skip consecutive rows with the same id when calculating rows to skip when appending to `ExecBatchBuilder`.
2. Fix the bug that column offset is neglected when calculating rows to skip.
### Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
Because apache#32570 is labeled critical, and causes a crash even when the API contract is upheld.
* Closes: apache#32570
Authored-by: zanmato <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-39583: [C++] Fix the issue of ExecBatchBuilder when appendin…
be6dbff
…g consecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (apache#39585)
### Rationale for this change
apache#39583 is a subsequent issue of apache#32570 (fixed by apache#39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of apache#39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: apache#39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit
that referenced
this pull request
Feb 20, 2024
@zanmato1984@raulcd
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
ef4b4de
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++Critical FixBugfixes for security vulnerabilities, crashes, or invalid data.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies


3 participants

@zanmato1984@pitrou@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary - #39234
Merged
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Dec 21, 2023
Merged
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary#39234
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Conversation
@zanmato1984
@zanmato1984zanmato1984
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
Addressed in #32570 (comment)
What changes are included in this PR?
  1. Skip consecutive rows with the same id when calculating rows to skip when appending to ExecBatchBuilder.
  2. Fix the bug that column offset is neglected when calculating rows to skip.
Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
Because #32570 is labeled critical, and causes a crash even when the API contract is upheld.
@zanmato1984
Fix the issue of ExecBatchBuilder when appending consecutive tail r…
8edc1d1
…ows with the same id may exceed buffer boundary
@github-actions
github-actionsBot
commented
Dec 14, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #32570has been automatically assigned in GitHub to PR creator.
@zanmato1984zanmato1984
mentioned this pull request
Dec 14, 2023

Closed

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-d19754bb45
TaskStatus
test-ubuntu-20.04-cppGitHub Actions
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-12-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-12-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225815149

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225892739

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226222452

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226270964

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-ac27092881
TaskStatus
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindAzure
test-cuda-cppGitHub Actions
test-debian-11-cpp-amd64GitHub Actions
test-debian-11-cpp-i386GitHub Actions
test-fedora-35-cppGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-20GitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
@assignUserassignUser
added
the 
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Dec 15, 2023
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
I wanted to retry the CI because the failures don't seem to be related to my change. I don't know how so I tried some commands but obviously they are not what I wanted :(
@pitrou
pitrou
commented
Dec 20, 2023

Copy link


Copy Markdown

Member
cc @bkietz
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
Outdated

@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Dec 21, 2023
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array_test.cc
@pitrou
pitrou
merged commit 2abb3fb
into
apache:mainDec 21, 2023
@pitroupitrou
removed
the 
awaiting committer review
Awaiting committer review
label
Dec 21, 2023
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Dec 22, 2023

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2abb3fb.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Jan 12, 2024

Closed

 Merged

pitrou pushed a commit
that referenced
this pull request
Jan 17, 2024
@zanmato1984
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
1dc3b81
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-32570: [C++] Fix the issue ofExecBatchBuilderwhen append…
c204ba8
…ing consecutive tail rows with the same id may exceed buffer boundary (apache#39234)
### Rationale for this change
Addressed in apache#32570 (comment)
### What changes are included in this PR?
1. Skip consecutive rows with the same id when calculating rows to skip when appending to `ExecBatchBuilder`.
2. Fix the bug that column offset is neglected when calculating rows to skip.
### Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
Because apache#32570 is labeled critical, and causes a crash even when the API contract is upheld.
* Closes: apache#32570
Authored-by: zanmato <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-39583: [C++] Fix the issue of ExecBatchBuilder when appendin…
be6dbff
…g consecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (apache#39585)
### Rationale for this change
apache#39583 is a subsequent issue of apache#32570 (fixed by apache#39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of apache#39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: apache#39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit
that referenced
this pull request
Feb 20, 2024
@zanmato1984@raulcd
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
ef4b4de
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++Critical FixBugfixes for security vulnerabilities, crashes, or invalid data.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies


3 participants

@zanmato1984@pitrou@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary - #39234
Merged
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Dec 21, 2023
Merged
GH-32570: [C++] Fix the issue of ExecBatchBuilder when appending consecutive tail rows with the same id may exceed buffer boundary#39234
pitrou merged 3 commits into
apache:mainfrom 
zanmato1984:fix-arrow-32570
Conversation
@zanmato1984
@zanmato1984zanmato1984
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
Addressed in #32570 (comment)
What changes are included in this PR?
  1. Skip consecutive rows with the same id when calculating rows to skip when appending to ExecBatchBuilder.
  2. Fix the bug that column offset is neglected when calculating rows to skip.
Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
Because #32570 is labeled critical, and causes a crash even when the API contract is upheld.
@zanmato1984
Fix the issue of ExecBatchBuilder when appending consecutive tail r…
8edc1d1
…ows with the same id may exceed buffer boundary
@github-actions
github-actionsBot
commented
Dec 14, 2023

Copy link


Copy Markdown

⚠️ GitHub issue #32570has been automatically assigned in GitHub to PR creator.
@zanmato1984zanmato1984
mentioned this pull request
Dec 14, 2023

Closed

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-ubuntu-20.04-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-d19754bb45
TaskStatus
test-ubuntu-20.04-cppGitHub Actions
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-12-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-12-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225815149

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test-macos-cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test-macos-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7225892739

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226222452

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit test
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Unable to match any tasks for `test`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7226270964

@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@github-actions crossbow submit -g cpp
@github-actions
github-actionsBot
commented
Dec 15, 2023

Copy link


Copy Markdown

Revision: 8edc1d1
Submitted crossbow builds: ursacomputing/crossbow @ actions-ac27092881
TaskStatus
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindAzure
test-cuda-cppGitHub Actions
test-debian-11-cpp-amd64GitHub Actions
test-debian-11-cpp-i386GitHub Actions
test-fedora-35-cppGitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-20GitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-22.04-cppGitHub Actions
@assignUserassignUser
added
the 
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Dec 15, 2023
@zanmato1984
zanmato1984
commented
Dec 15, 2023

Copy link


Copy Markdown

ContributorAuthor
I wanted to retry the CI because the failures don't seem to be related to my change. I don't know how so I tried some commands but obviously they are not what I wanted :(
@pitrou
pitrou
commented
Dec 20, 2023

Copy link


Copy Markdown

Member
cc @bkietz
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
Outdated

@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Dec 21, 2023
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array.cc
pitrou
pitrou
reviewed
Dec 21, 2023
View reviewed changes
Comment threadcpp/src/arrow/compute/light_array_test.cc
@pitrou
pitrou
merged commit 2abb3fb
into
apache:mainDec 21, 2023
@pitroupitrou
removed
the 
awaiting committer review
Awaiting committer review
label
Dec 21, 2023
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Dec 22, 2023

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2abb3fb.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Jan 12, 2024

Closed

 Merged

pitrou pushed a commit
that referenced
this pull request
Jan 17, 2024
@zanmato1984
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
1dc3b81
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-32570: [C++] Fix the issue ofExecBatchBuilderwhen append…
c204ba8
…ing consecutive tail rows with the same id may exceed buffer boundary (apache#39234)
### Rationale for this change
Addressed in apache#32570 (comment)
### What changes are included in this PR?
1. Skip consecutive rows with the same id when calculating rows to skip when appending to `ExecBatchBuilder`.
2. Fix the bug that column offset is neglected when calculating rows to skip.
### Are these changes tested?
Yes. New UT included and the change is also protected by the existing case mentioned in the issue.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
Because apache#32570 is labeled critical, and causes a crash even when the API contract is upheld.
* Closes: apache#32570
Authored-by: zanmato <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@zanmato1984@dgreiss
apacheGH-39583: [C++] Fix the issue of ExecBatchBuilder when appendin…
be6dbff
…g consecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (apache#39585)
### Rationale for this change
apache#39583 is a subsequent issue of apache#32570 (fixed by apache#39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of apache#39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: apache#39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit
that referenced
this pull request
Feb 20, 2024
@zanmato1984@raulcd
GH-39583: [C++] Fix the issue of ExecBatchBuilder when appending cons…
ef4b4de
…ecutive tail rows with the same id may exceed buffer boundary (for fixed size types) (#39585)
### Rationale for this change
#39583 is a subsequent issue of #32570 (fixed by #39234). The last issue and fixed only resolved var length types. It turns out fixed size types have the same issue.
### What changes are included in this PR?
Do the same fix of #39234 for fixed size types.
### Are these changes tested?
UT included.
### Are there any user-facing changes?
* Closes: #39583
Authored-by: zanmato1984 <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++Critical FixBugfixes for security vulnerabilities, crashes, or invalid data.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies


3 participants

@zanmato1984@pitrou@assignUser