Uh oh!
There was an error while loading. Please reload this page.
GH-39656: [Release] Update platform tags for macOS wheels to macosx_10_15 - #39657
Merged
Conversation
kou
approved these changes
Jan 18, 2024
kou
left a comment
Member
There was a problem hiding this comment.
+1
We may want to use dev/release/veriry-release-candidate.sh for our wheel related nightly CI jobs.
FYI: We use dev/release/verify-{apt,yum}.sh for our .deb/.rpm related nightly CI jobs.
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1c49b9f. There were 2 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…cosx_10_15 (apache#39657) ### Rationale for this change Currently the binary verification for releases fails due to wrong macOS platform version. ### What changes are included in this PR? Update to the current generated platform tag. ### Are these changes tested? No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/ ### Are there any user-facing changes? Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue. * Closes: apache#39656 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
raulcd added a commit
that referenced
this pull request
Feb 20, 2024
…0_15 (#39657) ### Rationale for this change Currently the binary verification for releases fails due to wrong macOS platform version. ### What changes are included in this PR? Update to the current generated platform tag. ### Are these changes tested? No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/ ### Are there any user-facing changes? Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue. * Closes: #39656 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently the binary verification for releases fails due to wrong macOS platform version.
What changes are included in this PR?
Update to the current generated platform tag.
Are these changes tested?
No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/
Are there any user-facing changes?
Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.