GH-39649: [Java][CI] Fix or suppress spurious errorprone warnings stage 2 by vibhatha · Pull Request #39777 · apache/arrow

vibhatha · 2024-01-24T08:30:04Z

Rationale for this change

This PR is a continuation of errorprone warning fixes.

What changes are included in this PR?

Fixing warnings suggested by the errorpone module.

Are these changes tested?

The existing test cases will be covering them.

Are there any user-facing changes?

No

Closes: [Java][CI] Fix or suppress spurious errorprone warnings stage 2 #39649

github-actions · 2024-01-24T08:30:32Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

vibhatha · 2024-01-24T08:30:32Z

@github-actions crossbow submit java

github-actions · 2024-01-24T08:31:37Z

Unable to match any tasks for `java`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7637473180

vibhatha · 2024-01-24T09:14:59Z

@github-actions crossbow submit java

github-actions · 2024-01-24T09:17:20Z

Revision: 21153cc7391006228af04be72c3aee358b01009c

Submitted crossbow builds: ursacomputing/crossbow @ actions-724e7dd2a9

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-02-01T11:01:31Z

@github-actions crossbow submit java

github-actions · 2024-02-01T11:03:49Z

Revision: c61b12247c877c77508ed13fa9a6007585893421

Submitted crossbow builds: ursacomputing/crossbow @ actions-c8f1f841cb

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-02-01T11:19:34Z

@github-actions crossbow submit java

github-actions · 2024-02-01T11:20:39Z

Unable to match any tasks for `java`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7740416375

vibhatha · 2024-02-01T15:38:27Z

@github-actions crossbow submit java

github-actions · 2024-02-01T15:40:53Z

Revision: 0a7184b29f085e92deba080fd6505695aeaf5a17

Submitted crossbow builds: ursacomputing/crossbow @ actions-94794e1635

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-02-01T18:29:36Z

@github-actions crossbow submit java

github-actions · 2024-02-01T18:32:33Z

Revision: 04940bac7e13d9c49f6ba643fe49ef75324c8b30

Submitted crossbow builds: ursacomputing/crossbow @ actions-8eff7f2c06

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-02-02T01:38:50Z

@github-actions crossbow submit java

vibhatha · 2024-02-02T01:39:27Z

converting back to draft as the crossbow failure seems to be consistent 🙁

github-actions · 2024-02-02T01:41:12Z

Revision: 04940bac7e13d9c49f6ba643fe49ef75324c8b30

Submitted crossbow builds: ursacomputing/crossbow @ actions-b131234f41

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

pitrou · 2024-03-04T14:53:23Z

What is the status on this? Do you plan to push this PR to completion @vibhatha ?

Also cc @danepitkin

danepitkin · 2024-03-04T15:25:15Z

@github-actions crossbow submit -g java

github-actions · 2024-03-04T15:27:40Z

Revision: 3627b21cc3315dcac6e726dc10555e60ff819fad

Submitted crossbow builds: ursacomputing/crossbow @ actions-cb8acf8c4e

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

Co-authored-by: David Li <li.davidm96@gmail.com>

lidavidm · 2024-06-04T07:04:47Z

@github-actions crossbow submit -g java

github-actions · 2024-06-04T07:07:15Z

Revision: c1284f3

Submitted crossbow builds: ursacomputing/crossbow @ actions-ed00db6225

Task	Status
java-jars
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.11-spark-master
test-conda-python-3.8-spark-v3.5.0
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

conbench-apache-arrow · 2024-06-11T13:36:11Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 524a463.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…gs stage 2 (apache#39777) ### Rationale for this change This PR is a continuation of errorprone warning fixes. ### What changes are included in this PR? Fixing warnings suggested by the errorpone module. - [x] Adapter - [x] C - [x] Format - [x] Maven - [x] Memory - [x] Performance ### Are these changes tested? The existing test cases will be covering them. ### Are there any user-facing changes? No * Closes: apache#39649 Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com> Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Co-authored-by: vibhatha <vibhatha@gmail.com> Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@users.noreply.github.com> Co-authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>

github-actionsBot added Component: Java awaiting review Awaiting review labels Jan 24, 2024

vibhatha changed the title ~~[Java][CI] Fix or suppress spurious errorprone warnings stage 2~~GH-39649: [Java][CI] Fix or suppress spurious errorprone warnings stage 2Jan 24, 2024

vibhatha force-pushed the gh-39649 branch from bf11c52 to dbece2eCompare January 24, 2024 16:21

davisusanibar mentioned this pull request Jan 30, 2024
GH-39712: [Java] Enable code review and formatting code through Spotless Maven plugin #39713
Closed
2 tasks

vibhatha force-pushed the gh-39649 branch from dbece2e to a5ccc5aCompare February 1, 2024 10:12

vibhatha marked this pull request as ready for review February 2, 2024 01:10

vibhatha requested a review from lidavidm as a code owner February 2, 2024 01:10

vibhatha marked this pull request as draft February 2, 2024 01:39

vibhatha force-pushed the gh-39649 branch from 04940ba to 3627b21Compare February 6, 2024 11:01

vibhatha force-pushed the gh-39649 branch from 3627b21 to ab80fb7Compare May 29, 2024 00:08

vibhatha added 9 commits June 4, 2024 08:07

fix: memory-netty-buffer-patch module
bf02c42

fix: memory-netty module
c2da46c

fix: minor change
4a90cde

fix: addressing reviews
bf996ad

fix: reverting flatbuf changes
dfb05d9

fix: omitting error prone on format module
65aa1e5

fix: lint
966973c

fix: reverting changes on auto generated content
1de219b

fix: addressing warnings in memory-core
028e9d7

vibhatha mentioned this pull request Jun 4, 2024
[Java] ErrorProne Enhancements with @FormatMethod and @FormatString #41951
Closed

fix: addressing reviews latest v1
0f3a44a

vibhatha force-pushed the gh-39649 branch from d4184e5 to 0f3a44aCompare June 4, 2024 03:37

github-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 4, 2024

lidavidm reviewed Jun 4, 2024
View reviewed changes

Comment threaddocs/source/developers/java/development.rst Outdated

github-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 4, 2024

fix: addressing reviews latest v1
a70932a

github-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 4, 2024

fix(suggestions): Update docs/source/developers/java/development.rst
c1284f3
Co-authored-by: David Li <li.davidm96@gmail.com>

lidavidm approved these changes Jun 4, 2024
View reviewed changes

github-actionsBot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 4, 2024

lidavidm merged commit 524a463 into apache:mainJun 4, 2024

lidavidm removed the awaiting merge Awaiting merge label Jun 4, 2024

Uh oh!

Conversation

vibhatha commented Jan 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actionsBot commented Jan 24, 2024

Uh oh!

vibhatha commented Jan 24, 2024

Uh oh!

github-actionsBot commented Jan 24, 2024

Uh oh!

vibhatha commented Jan 24, 2024

Uh oh!

github-actionsBot commented Jan 24, 2024

Uh oh!

vibhatha commented Feb 1, 2024

Uh oh!

github-actionsBot commented Feb 1, 2024

Uh oh!

vibhatha commented Feb 1, 2024

Uh oh!

github-actionsBot commented Feb 1, 2024

Uh oh!

vibhatha commented Feb 1, 2024

Uh oh!

github-actionsBot commented Feb 1, 2024

Uh oh!

vibhatha commented Feb 1, 2024

Uh oh!

github-actionsBot commented Feb 1, 2024

Uh oh!

vibhatha commented Feb 2, 2024

Uh oh!

vibhatha commented Feb 2, 2024

Uh oh!

github-actionsBot commented Feb 2, 2024

Uh oh!

pitrou commented Mar 4, 2024

Uh oh!

danepitkin commented Mar 4, 2024

Uh oh!

github-actionsBot commented Mar 4, 2024

Uh oh!

Uh oh!

lidavidm commented Jun 4, 2024

Uh oh!

github-actionsBot commented Jun 4, 2024

Uh oh!

conbench-apache-arrowBot commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vibhatha commented Jan 24, 2024•
edited
Loading