Skip to content

MINOR: [Python][CI] Add upper bound on pytest version - #39827

Merged
pitrou merged 1 commit into
apache:mainfrom
pitrou:pytest-pin
Jan 29, 2024
Merged

MINOR: [Python][CI] Add upper bound on pytest version#39827
pitrou merged 1 commit into
apache:mainfrom
pitrou:pytest-pin

Conversation

@pitrou

Copy link
Copy Markdown
Member

Rationale for this change

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65

What changes are included in this PR?

Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.

Are these changes tested?

Yes, by construction.

Are there any user-facing changes?

No.

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0:
TvoroG/pytest-lazy-fixture#65
@pitrou

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g python -g wheel

@github-actions

Copy link
Copy Markdown

Revision: c91af6a

Submitted crossbow builds: ursacomputing/crossbow @ actions-13f2836a4e

TaskStatus
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-cython2GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latestGitHub Actions
test-conda-python-3.10-pandas-nightlyGitHub Actions
test-conda-python-3.10-spark-v3.5.0GitHub Actions
test-conda-python-3.10-substraitGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-upstream_develGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.8GitHub Actions
test-conda-python-3.8-pandas-1.0GitHub Actions
test-conda-python-3.8-spark-v3.5.0GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-latestGitHub Actions
test-cuda-pythonGitHub Actions
test-debian-11-python-3Azure
test-fedora-38-python-3Azure
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-python-3GitHub Actions
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions

@pitrou

Copy link
Copy Markdown
MemberAuthor

I'll merge this so as to improve the state of our CI.

@pitrou
pitrou merged commit 87dd4c4 into apache:mainJan 29, 2024
@pitroupitrou removed the awaiting review Awaiting review label Jan 29, 2024
@pitrou
pitrou deleted the pytest-pin branch January 29, 2024 16:41
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 87dd4c4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@raulcdraulcd added this to the 15.0.1 milestone Feb 14, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change
The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65
### What changes are included in this PR?
Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.
### Are these changes tested?
Yes, by construction.
### Are there any user-facing changes?
No.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit that referenced this pull request Feb 20, 2024
### Rationale for this change
The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65
### What changes are included in this PR?
Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.
### Are these changes tested?
Yes, by construction.
### Are there any user-facing changes?
No.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@raulcd@jorisvandenbossche