GH-39849: [Python] Remove the use of pytest-lazy-fixture by AlenkaF · Pull Request #39850 · apache/arrow

AlenkaF · 2024-01-30T10:12:47Z

Rationale for this change

Removing the use of pytest-lazy-fixture in our test suite as it is unmaintained.
Changes in this PR include:

Remove the use of pytest-lazy-fixture

Remove marks from fixtures to avoid future error, see

PytestRemovedIn9Warning: Marks applied to fixtures have no effect
See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function

Catch two different warnings in def test_legacy_int_type()

Are these changes tested?

The changes affect the tests so they must pass.

Are there any user-facing changes?

No.

Closes: [Python] Remove the use of pytest-lazy-fixture #39849

AlenkaF · 2024-01-30T11:44:26Z

The failures shouldn't be related, but I do not see them on any other build 🤷‍♀️

jorisvandenbossche · 2024-02-01T08:54:36Z

@github-actions crossbow submit python

github-actions · 2024-02-01T08:57:10Z

Revision: c740098

Submitted crossbow builds: ursacomputing/crossbow @ actions-34647c76a2

Task	Status
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
python-sdist
test-conda-python-3.10
test-conda-python-3.10-cython2
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest
test-conda-python-3.10-pandas-nightly
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.10-substrait
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-upstream_devel
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.8
test-conda-python-3.8-pandas-1.0
test-conda-python-3.8-spark-v3.5.0
test-conda-python-3.9
test-conda-python-3.9-pandas-latest
test-cuda-python
test-debian-11-python-3
test-fedora-38-python-3
test-ubuntu-20.04-python-3
test-ubuntu-22.04-python-3
verify-rc-source-python-linux-almalinux-8-amd64
verify-rc-source-python-linux-conda-latest-amd64
verify-rc-source-python-linux-ubuntu-20.04-amd64
verify-rc-source-python-linux-ubuntu-22.04-amd64
verify-rc-source-python-macos-amd64
verify-rc-source-python-macos-arm64
verify-rc-source-python-macos-conda-amd64

AlenkaF · 2024-02-01T09:18:31Z

Maybe the failures are connected to the new version of pytest. WIll pin it back to see if that is true.

jorisvandenbossche · 2024-02-01T09:28:11Z

@github-actions crossbow submit -g python

github-actions · 2024-02-01T09:30:52Z

Revision: e4146cb

Submitted crossbow builds: ursacomputing/crossbow @ actions-07f4a3b8ab

Task	Status
test-conda-python-3.10
test-conda-python-3.10-cython2
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest
test-conda-python-3.10-pandas-nightly
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.10-substrait
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-upstream_devel
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.8
test-conda-python-3.8-pandas-1.0
test-conda-python-3.8-spark-v3.5.0
test-conda-python-3.9
test-conda-python-3.9-pandas-latest
test-cuda-python
test-debian-11-python-3
test-fedora-38-python-3
test-ubuntu-20.04-python-3
test-ubuntu-22.04-python-3

conbench-apache-arrow · 2024-02-01T20:54:58Z

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 44d5597.

There were 2 benchmark results with an error:

Commit Run on ursa-i9-9960x at 2024-02-01 18:07:36Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-03, scale_factor=1
- dataframe-to-table (R) with dataset=chi_traffic_2020_Q1, language=R

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

…e#39850) ### Rationale for this change Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained. Changes in this PR include: - Remove the use of `pytest-lazy-fixture` - Remove marks from fixtures to avoid future error, see ``` PytestRemovedIn9Warning: Marks applied to fixtures have no effect See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function ``` - Catch two different warnings in `def test_legacy_int_type()` ### Are these changes tested? The changes affect the tests so they must pass. ### Are there any user-facing changes? No. * Closes: apache#39849 Lead-authored-by: AlenkaF <frim.alenka@gmail.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

### Rationale for this change Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained. Changes in this PR include: - Remove the use of `pytest-lazy-fixture` - Remove marks from fixtures to avoid future error, see ``` PytestRemovedIn9Warning: Marks applied to fixtures have no effect See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function ``` - Catch two different warnings in `def test_legacy_int_type()` ### Are these changes tested? The changes affect the tests so they must pass. ### Are there any user-facing changes? No. * Closes: #39849 Lead-authored-by: AlenkaF <frim.alenka@gmail.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

pytest-lazy-fixture is no longer used apache/arrow#39850

Initial commit
02d53c5

github-actionsBot added Component: Python awaiting review Awaiting review labels Jan 30, 2024

Fix long lines
a660f95

jorisvandenbossche reviewed Jan 30, 2024
View reviewed changes

Comment threadpython/pyarrow/tests/parquet/test_dataset.py Outdated

github-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jan 30, 2024

Move getfixturevalue to the pickle_module fixture
bf87bc5

github-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 30, 2024

jorisvandenbossche reviewed Jan 30, 2024
View reviewed changes

Comment threadpython/pyarrow/tests/test_dataset.py
Comment threadpython/pyarrow/tests/test_dataset.py Outdated
Comment threadpython/pyarrow/tests/test_ipc.py Outdated
Comment threadpython/pyarrow/tests/test_fs.py Outdated

github-actionsBot added awaiting changes Awaiting changes awaiting review Awaiting review awaiting committer review Awaiting committer review and removed awaiting change review Awaiting change review awaiting review Awaiting review awaiting changes Awaiting changes labels Jan 30, 2024

AlenkaF added 2 commits January 30, 2024 12:20

Add suggested changes
d0b8485

Remove minor leftover
c740098

AlenkaF marked this pull request as ready for review February 1, 2024 09:03

AlenkaF requested review from assignUser, kou and raulcd as code owners February 1, 2024 09:03

Keep the pin for pytest
e4146cb

jorisvandenbossche reviewed Feb 1, 2024
View reviewed changes

Comment threadpython/pyarrow/tests/test_array.py Outdated

Update python/pyarrow/tests/test_array.py
702b73f

github-actionsBot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Feb 1, 2024

jorisvandenbossche approved these changes Feb 1, 2024
View reviewed changes

jorisvandenbossche merged commit 44d5597 into apache:mainFeb 1, 2024

jorisvandenbossche removed the awaiting changes Awaiting changes label Feb 1, 2024

github-actionsBot added the awaiting merge Awaiting merge label Feb 1, 2024

AlenkaF deleted the remove-pytest-lazy-fixture branch February 1, 2024 14:13

This was referenced Feb 6, 2024
[Python][CI] S3 fixtures fail with Pytest 8.0.0 #39957
Closed
[Python][CI] Remove upper pin on pytest #39958
Closed

algitbot pushed a commit to alpinelinux/aports that referenced this pull request Mar 25, 2024
community/apache-arrow: remove unused dependency
c78db15
pytest-lazy-fixture is no longer used apache/arrow#39850

Navigation Menu

Uh oh!

GH-39849: [Python] Remove the use of pytest-lazy-fixture - #39850

GH-39849: [Python] Remove the use of pytest-lazy-fixture#39850
jorisvandenbossche merged 7 commits into
apache:mainfrom
AlenkaF:remove-pytest-lazy-fixture

AlenkaF commented Jan 30, 2024•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlenkaF commented Jan 30, 2024

Uh oh!

jorisvandenbossche commented Feb 1, 2024

Uh oh!

github-actionsBot commented Feb 1, 2024

Uh oh!

AlenkaF commented Feb 1, 2024

Uh oh!

jorisvandenbossche commented Feb 1, 2024

Uh oh!

github-actionsBot commented Feb 1, 2024

Uh oh!

Uh oh!

conbench-apache-arrowBot commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

AlenkaF commented Jan 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlenkaF commented Jan 30, 2024

Uh oh!

jorisvandenbossche commented Feb 1, 2024

Uh oh!

github-actionsBot commented Feb 1, 2024

Uh oh!

AlenkaF commented Feb 1, 2024

Uh oh!

jorisvandenbossche commented Feb 1, 2024

Uh oh!

github-actionsBot commented Feb 1, 2024

Uh oh!

Uh oh!

conbench-apache-arrowBot commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AlenkaF commented Jan 30, 2024•
edited
Loading