GH-39352: [FS][Azure] Enable azure in builds - #39971

Merged
kou merged 5 commits into
apache:mainfrom
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Feb 9, 2024
Merged

GH-39352: [FS][Azure] Enable azure in builds#39971
kou merged 5 commits into
apache:mainfrom
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352

Conversation

@Tom-Newton

@Tom-NewtonTom-Newton commented Feb 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Rationale for this change

What changes are included in this PR?

Enable Azure in linux and mac os wheel builds. Tried to copy GCS

Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.

Are these changes tested?

There is no new functionality to test.

Are there any user-facing changes?

No

@Tom-Newton
Tom-Newtonforce-pushed the tomnewton/enable_azure_in_wheel_builds/GH-39352 branch from 63806c2 to ebd8f3bCompareFebruary 7, 2024 10:58
@Tom-NewtonTom-Newton changed the title GH-39352: WIP [FS][Azure] Enable azure in buildsGH-39352: [FS][Azure] Enable azure in buildsFeb 7, 2024
@Tom-Newton
Tom-Newton marked this pull request as ready for review February 7, 2024 18:22
@Tom-Newton

Tom-Newton commented Feb 7, 2024

Copy link
Copy Markdown
ContributorAuthor

I think this is ready for review. I guess we also need to run some archery builds?

@Tom-Newton
Tom-Newtonforce-pushed the tomnewton/enable_azure_in_wheel_builds/GH-39352 branch from 56bb0ab to ebd8f3bCompareFebruary 7, 2024 18:26
kou
kou reviewed Feb 8, 2024
View reviewed changes
Comment threadci/scripts/python_wheel_unix_test.sh Outdated
: ${ARROW_SUBSTRAIT:=ON}
: ${ARROW_S3:=ON}
: ${ARROW_GCS:=ON}
: ${ARROW_AZURE:=ON}

@koukouFeb 8, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list in alphabetical order?
(including ARROW_GCS)

@kou

kou commented Feb 8, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g wheel

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Feb 8, 2024
@github-actions

github-actionsBot commented Feb 8, 2024

Copy link
Copy Markdown

Revision: ebd8f3b

Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6

TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions

@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 8, 2024
@Tom-Newton

Tom-Newton commented Feb 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Failures in normal CI are

97/97 Test #73: arrow-s3fs-test ..............................***Timeout 300.05 sec

and

--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:785: Error Trace:	/Users/runner/work/arrow/arrow/go/arrow/flight/flightsql/driver/driver_test.go:785
Error: Error "EOF" does not contain "parameter schema: unexpected"
Test: TestPreparedStatementNoSchema
FAIL
FAIL	github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver	1.370s

I'm pretty sure these are both unrelated.

@kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures.

@kou

kou commented Feb 8, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g wheel

@github-actions

github-actionsBot commented Feb 8, 2024

Copy link
Copy Markdown

Revision: fb78267

Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38

TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions

@Tom-Newton

Tom-Newton commented Feb 8, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now

@kou

kou commented Feb 8, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g wheel

@github-actions

github-actionsBot commented Feb 8, 2024

Copy link
Copy Markdown

Revision: 9c08e54

Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b

TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions

@Tom-Newton

Tom-Newton commented Feb 8, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds

kou
kou approved these changes Feb 9, 2024
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@kou
kou merged commit a0dec7f into apache:mainFeb 9, 2024
@koukou removed the awaiting change review Awaiting change review label Feb 9, 2024
@github-actionsgithub-actionsBot added the awaiting merge Awaiting merge label Feb 9, 2024
@conbench-apache-arrow

conbench-apache-arrowBot commented Feb 9, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Feb 10, 2024
Merged
Merged
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@Tom-Newton@dgreiss
apacheGH-39352: [FS][Azure] Enable azure in builds (apache#39971)
f86f122
### Rationale for this change
### What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested?
There is no new functionality to test. ### Are there any user-facing changes?
No
* Closes: apache#39352
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit that referenced this pull request Feb 22, 2024
@Tom-Newton
GH-40079: [CI][Packaging] Enable Azure in more tests and builds (#40080)
b089c6a
### Rationale for this change
We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR?
- Add missing `export` to enable Azure pyarrow tests
- Enable azure in sdist tests.
- Enable Azure on macos python builds
- Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite)
- Enable retries on C++ tests to mitigate #40121
Probably all of this should have been included in #39971
### Are these changes tested?
There is no new functionality to test
### Are there any user-facing changes?
No
* Closes: #40079
* GitHub Issue: #40079
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcdraulcd mentioned this pull request Nov 13, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees

No one assigned

Labels

awaiting mergeAwaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python][FS][Azure] Enable Azure in pyarrow wheel builds

2 participants

@Tom-Newton@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-39352: [FS][Azure] Enable azure in builds - #39971
Merged
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Feb 9, 2024
Merged
GH-39352: [FS][Azure] Enable azure in builds#39971
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Conversation
@Tom-Newton
@Tom-NewtonTom-Newton
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.
Are these changes tested?
There is no new functionality to test.
Are there any user-facing changes?
No
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
63806c2 to
ebd8f3bCompareFebruary 7, 2024 10:58
@Tom-NewtonTom-Newton
changed the title
GH-39352: WIP [FS][Azure] Enable azure in buildsGH-39352: [FS][Azure] Enable azure in buildsFeb 7, 2024
@Tom-Newton
Tom-Newton
marked this pull request as ready for review
February 7, 2024 18:22
@Tom-Newton
Tom-Newton
commented
Feb 7, 2024

Copy link


Copy Markdown

ContributorAuthor
I think this is ready for review. I guess we also need to run some archery builds?
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
56bb0ab to
ebd8f3bCompareFebruary 7, 2024 18:26
kou
kou
reviewed
Feb 8, 2024
View reviewed changes
Comment threadci/scripts/python_wheel_unix_test.sh
Outdated

: ${ARROW_SUBSTRAIT:=ON}
: ${ARROW_S3:=ON}
: ${ARROW_GCS:=ON}
: ${ARROW_AZURE:=ON}
@koukouFeb 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list in alphabetical order?

(including ARROW_GCS)
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Feb 8, 2024
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: ebd8f3b
Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Feb 8, 2024
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024

Copy link


Copy Markdown

ContributorAuthor
Failures in normal CI are
97/97 Test #73: arrow-s3fs-test ..............................***Timeout 300.05 sec

and
--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:785: Error Trace:	/Users/runner/work/arrow/arrow/go/arrow/flight/flightsql/driver/driver_test.go:785
Error: Error "EOF" does not contain "parameter schema: unexpected"
Test: TestPreparedStatementNoSchema
FAIL
FAIL	github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver	1.370s

I'm pretty sure these are both unrelated.
@kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures.
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: fb78267
Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: 9c08e54
Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds
kou
kou
approved these changes
Feb 9, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks!
@kou
kou
merged commit a0dec7f
into
apache:mainFeb 9, 2024
@koukou
removed
the 
awaiting change review
Awaiting change review
label
Feb 9, 2024
@github-actionsgithub-actionsBot
added
the 
awaiting merge
Awaiting merge
label
Feb 9, 2024
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Feb 9, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f.
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Feb 10, 2024
 Merged

 Merged

dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@Tom-Newton@dgreiss
apacheGH-39352: [FS][Azure] Enable azure in builds (apache#39971)
f86f122
### Rationale for this change
### What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested?
There is no new functionality to test. ### Are there any user-facing changes?
No
* Closes: apache#39352
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit
that referenced
this pull request
Feb 22, 2024
@Tom-Newton
GH-40079: [CI][Packaging] Enable Azure in more tests and builds (#40080)
b089c6a
### Rationale for this change
We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR?
- Add missing `export` to enable Azure pyarrow tests
- Enable azure in sdist tests.
- Enable Azure on macos python builds
- Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite)
- Enable retries on C++ tests to mitigate #40121
Probably all of this should have been included in #39971
### Are these changes tested?
There is no new functionality to test
### Are there any user-facing changes?
No
* Closes: #40079
* GitHub Issue: #40079
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcdraulcd
mentioned this pull request
Nov 13, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

awaiting mergeAwaiting merge

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python][FS][Azure] Enable Azure in pyarrow wheel builds


2 participants

@Tom-Newton@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-39352: [FS][Azure] Enable azure in builds - #39971
Merged
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Feb 9, 2024
Merged
GH-39352: [FS][Azure] Enable azure in builds#39971
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Conversation
@Tom-Newton
@Tom-NewtonTom-Newton
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.
Are these changes tested?
There is no new functionality to test.
Are there any user-facing changes?
No
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
63806c2 to
ebd8f3bCompareFebruary 7, 2024 10:58
@Tom-NewtonTom-Newton
changed the title
GH-39352: WIP [FS][Azure] Enable azure in buildsGH-39352: [FS][Azure] Enable azure in buildsFeb 7, 2024
@Tom-Newton
Tom-Newton
marked this pull request as ready for review
February 7, 2024 18:22
@Tom-Newton
Tom-Newton
commented
Feb 7, 2024

Copy link


Copy Markdown

ContributorAuthor
I think this is ready for review. I guess we also need to run some archery builds?
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
56bb0ab to
ebd8f3bCompareFebruary 7, 2024 18:26
kou
kou
reviewed
Feb 8, 2024
View reviewed changes
Comment threadci/scripts/python_wheel_unix_test.sh
Outdated

: ${ARROW_SUBSTRAIT:=ON}
: ${ARROW_S3:=ON}
: ${ARROW_GCS:=ON}
: ${ARROW_AZURE:=ON}
@koukouFeb 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list in alphabetical order?

(including ARROW_GCS)
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Feb 8, 2024
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: ebd8f3b
Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Feb 8, 2024
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024

Copy link


Copy Markdown

ContributorAuthor
Failures in normal CI are
97/97 Test #73: arrow-s3fs-test ..............................***Timeout 300.05 sec

and
--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:785: Error Trace:	/Users/runner/work/arrow/arrow/go/arrow/flight/flightsql/driver/driver_test.go:785
Error: Error "EOF" does not contain "parameter schema: unexpected"
Test: TestPreparedStatementNoSchema
FAIL
FAIL	github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver	1.370s

I'm pretty sure these are both unrelated.
@kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures.
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: fb78267
Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: 9c08e54
Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds
kou
kou
approved these changes
Feb 9, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks!
@kou
kou
merged commit a0dec7f
into
apache:mainFeb 9, 2024
@koukou
removed
the 
awaiting change review
Awaiting change review
label
Feb 9, 2024
@github-actionsgithub-actionsBot
added
the 
awaiting merge
Awaiting merge
label
Feb 9, 2024
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Feb 9, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f.
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Feb 10, 2024
 Merged

 Merged

dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@Tom-Newton@dgreiss
apacheGH-39352: [FS][Azure] Enable azure in builds (apache#39971)
f86f122
### Rationale for this change
### What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested?
There is no new functionality to test. ### Are there any user-facing changes?
No
* Closes: apache#39352
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit
that referenced
this pull request
Feb 22, 2024
@Tom-Newton
GH-40079: [CI][Packaging] Enable Azure in more tests and builds (#40080)
b089c6a
### Rationale for this change
We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR?
- Add missing `export` to enable Azure pyarrow tests
- Enable azure in sdist tests.
- Enable Azure on macos python builds
- Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite)
- Enable retries on C++ tests to mitigate #40121
Probably all of this should have been included in #39971
### Are these changes tested?
There is no new functionality to test
### Are there any user-facing changes?
No
* Closes: #40079
* GitHub Issue: #40079
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcdraulcd
mentioned this pull request
Nov 13, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

awaiting mergeAwaiting merge

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python][FS][Azure] Enable Azure in pyarrow wheel builds


2 participants

@Tom-Newton@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-39352: [FS][Azure] Enable azure in builds - #39971
Merged
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Feb 9, 2024
Merged
GH-39352: [FS][Azure] Enable azure in builds#39971
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Conversation
@Tom-Newton
@Tom-NewtonTom-Newton
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.
Are these changes tested?
There is no new functionality to test.
Are there any user-facing changes?
No
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
63806c2 to
ebd8f3bCompareFebruary 7, 2024 10:58
@Tom-NewtonTom-Newton
changed the title
GH-39352: WIP [FS][Azure] Enable azure in buildsGH-39352: [FS][Azure] Enable azure in buildsFeb 7, 2024
@Tom-Newton
Tom-Newton
marked this pull request as ready for review
February 7, 2024 18:22
@Tom-Newton
Tom-Newton
commented
Feb 7, 2024

Copy link


Copy Markdown

ContributorAuthor
I think this is ready for review. I guess we also need to run some archery builds?
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
56bb0ab to
ebd8f3bCompareFebruary 7, 2024 18:26
kou
kou
reviewed
Feb 8, 2024
View reviewed changes
Comment threadci/scripts/python_wheel_unix_test.sh
Outdated

: ${ARROW_SUBSTRAIT:=ON}
: ${ARROW_S3:=ON}
: ${ARROW_GCS:=ON}
: ${ARROW_AZURE:=ON}
@koukouFeb 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list in alphabetical order?

(including ARROW_GCS)
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Feb 8, 2024
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: ebd8f3b
Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Feb 8, 2024
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024

Copy link


Copy Markdown

ContributorAuthor
Failures in normal CI are
97/97 Test #73: arrow-s3fs-test ..............................***Timeout 300.05 sec

and
--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:785: Error Trace:	/Users/runner/work/arrow/arrow/go/arrow/flight/flightsql/driver/driver_test.go:785
Error: Error "EOF" does not contain "parameter schema: unexpected"
Test: TestPreparedStatementNoSchema
FAIL
FAIL	github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver	1.370s

I'm pretty sure these are both unrelated.
@kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures.
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: fb78267
Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: 9c08e54
Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds
kou
kou
approved these changes
Feb 9, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks!
@kou
kou
merged commit a0dec7f
into
apache:mainFeb 9, 2024
@koukou
removed
the 
awaiting change review
Awaiting change review
label
Feb 9, 2024
@github-actionsgithub-actionsBot
added
the 
awaiting merge
Awaiting merge
label
Feb 9, 2024
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Feb 9, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f.
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Feb 10, 2024
 Merged

 Merged

dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@Tom-Newton@dgreiss
apacheGH-39352: [FS][Azure] Enable azure in builds (apache#39971)
f86f122
### Rationale for this change
### What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested?
There is no new functionality to test. ### Are there any user-facing changes?
No
* Closes: apache#39352
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit
that referenced
this pull request
Feb 22, 2024
@Tom-Newton
GH-40079: [CI][Packaging] Enable Azure in more tests and builds (#40080)
b089c6a
### Rationale for this change
We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR?
- Add missing `export` to enable Azure pyarrow tests
- Enable azure in sdist tests.
- Enable Azure on macos python builds
- Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite)
- Enable retries on C++ tests to mitigate #40121
Probably all of this should have been included in #39971
### Are these changes tested?
There is no new functionality to test
### Are there any user-facing changes?
No
* Closes: #40079
* GitHub Issue: #40079
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcdraulcd
mentioned this pull request
Nov 13, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

awaiting mergeAwaiting merge

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python][FS][Azure] Enable Azure in pyarrow wheel builds


2 participants

@Tom-Newton@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-39352: [FS][Azure] Enable azure in builds - #39971
Merged
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Feb 9, 2024
Merged
GH-39352: [FS][Azure] Enable azure in builds#39971
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Conversation
@Tom-Newton
@Tom-NewtonTom-Newton
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.
Are these changes tested?
There is no new functionality to test.
Are there any user-facing changes?
No
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
63806c2 to
ebd8f3bCompareFebruary 7, 2024 10:58
@Tom-NewtonTom-Newton
changed the title
GH-39352: WIP [FS][Azure] Enable azure in buildsGH-39352: [FS][Azure] Enable azure in buildsFeb 7, 2024
@Tom-Newton
Tom-Newton
marked this pull request as ready for review
February 7, 2024 18:22
@Tom-Newton
Tom-Newton
commented
Feb 7, 2024

Copy link


Copy Markdown

ContributorAuthor
I think this is ready for review. I guess we also need to run some archery builds?
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
56bb0ab to
ebd8f3bCompareFebruary 7, 2024 18:26
kou
kou
reviewed
Feb 8, 2024
View reviewed changes
Comment threadci/scripts/python_wheel_unix_test.sh
Outdated

: ${ARROW_SUBSTRAIT:=ON}
: ${ARROW_S3:=ON}
: ${ARROW_GCS:=ON}
: ${ARROW_AZURE:=ON}
@koukouFeb 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list in alphabetical order?

(including ARROW_GCS)
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Feb 8, 2024
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: ebd8f3b
Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Feb 8, 2024
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024

Copy link


Copy Markdown

ContributorAuthor
Failures in normal CI are
97/97 Test #73: arrow-s3fs-test ..............................***Timeout 300.05 sec

and
--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:785: Error Trace:	/Users/runner/work/arrow/arrow/go/arrow/flight/flightsql/driver/driver_test.go:785
Error: Error "EOF" does not contain "parameter schema: unexpected"
Test: TestPreparedStatementNoSchema
FAIL
FAIL	github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver	1.370s

I'm pretty sure these are both unrelated.
@kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures.
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: fb78267
Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: 9c08e54
Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds
kou
kou
approved these changes
Feb 9, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks!
@kou
kou
merged commit a0dec7f
into
apache:mainFeb 9, 2024
@koukou
removed
the 
awaiting change review
Awaiting change review
label
Feb 9, 2024
@github-actionsgithub-actionsBot
added
the 
awaiting merge
Awaiting merge
label
Feb 9, 2024
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Feb 9, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f.
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Feb 10, 2024
 Merged

 Merged

dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@Tom-Newton@dgreiss
apacheGH-39352: [FS][Azure] Enable azure in builds (apache#39971)
f86f122
### Rationale for this change
### What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested?
There is no new functionality to test. ### Are there any user-facing changes?
No
* Closes: apache#39352
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit
that referenced
this pull request
Feb 22, 2024
@Tom-Newton
GH-40079: [CI][Packaging] Enable Azure in more tests and builds (#40080)
b089c6a
### Rationale for this change
We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR?
- Add missing `export` to enable Azure pyarrow tests
- Enable azure in sdist tests.
- Enable Azure on macos python builds
- Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite)
- Enable retries on C++ tests to mitigate #40121
Probably all of this should have been included in #39971
### Are these changes tested?
There is no new functionality to test
### Are there any user-facing changes?
No
* Closes: #40079
* GitHub Issue: #40079
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcdraulcd
mentioned this pull request
Nov 13, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

awaiting mergeAwaiting merge

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python][FS][Azure] Enable Azure in pyarrow wheel builds


2 participants

@Tom-Newton@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-39352: [FS][Azure] Enable azure in builds - #39971
Merged
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Feb 9, 2024
Merged
GH-39352: [FS][Azure] Enable azure in builds#39971
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Conversation
@Tom-Newton
@Tom-NewtonTom-Newton
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.
Are these changes tested?
There is no new functionality to test.
Are there any user-facing changes?
No
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
63806c2 to
ebd8f3bCompareFebruary 7, 2024 10:58
@Tom-NewtonTom-Newton
changed the title
GH-39352: WIP [FS][Azure] Enable azure in buildsGH-39352: [FS][Azure] Enable azure in buildsFeb 7, 2024
@Tom-Newton
Tom-Newton
marked this pull request as ready for review
February 7, 2024 18:22
@Tom-Newton
Tom-Newton
commented
Feb 7, 2024

Copy link


Copy Markdown

ContributorAuthor
I think this is ready for review. I guess we also need to run some archery builds?
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
56bb0ab to
ebd8f3bCompareFebruary 7, 2024 18:26
kou
kou
reviewed
Feb 8, 2024
View reviewed changes
Comment threadci/scripts/python_wheel_unix_test.sh
Outdated

: ${ARROW_SUBSTRAIT:=ON}
: ${ARROW_S3:=ON}
: ${ARROW_GCS:=ON}
: ${ARROW_AZURE:=ON}
@koukouFeb 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list in alphabetical order?

(including ARROW_GCS)
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Feb 8, 2024
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: ebd8f3b
Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Feb 8, 2024
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024

Copy link


Copy Markdown

ContributorAuthor
Failures in normal CI are
97/97 Test #73: arrow-s3fs-test ..............................***Timeout 300.05 sec

and
--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:785: Error Trace:	/Users/runner/work/arrow/arrow/go/arrow/flight/flightsql/driver/driver_test.go:785
Error: Error "EOF" does not contain "parameter schema: unexpected"
Test: TestPreparedStatementNoSchema
FAIL
FAIL	github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver	1.370s

I'm pretty sure these are both unrelated.
@kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures.
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: fb78267
Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: 9c08e54
Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds
kou
kou
approved these changes
Feb 9, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks!
@kou
kou
merged commit a0dec7f
into
apache:mainFeb 9, 2024
@koukou
removed
the 
awaiting change review
Awaiting change review
label
Feb 9, 2024
@github-actionsgithub-actionsBot
added
the 
awaiting merge
Awaiting merge
label
Feb 9, 2024
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Feb 9, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f.
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Feb 10, 2024
 Merged

 Merged

dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@Tom-Newton@dgreiss
apacheGH-39352: [FS][Azure] Enable azure in builds (apache#39971)
f86f122
### Rationale for this change
### What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested?
There is no new functionality to test. ### Are there any user-facing changes?
No
* Closes: apache#39352
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit
that referenced
this pull request
Feb 22, 2024
@Tom-Newton
GH-40079: [CI][Packaging] Enable Azure in more tests and builds (#40080)
b089c6a
### Rationale for this change
We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR?
- Add missing `export` to enable Azure pyarrow tests
- Enable azure in sdist tests.
- Enable Azure on macos python builds
- Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite)
- Enable retries on C++ tests to mitigate #40121
Probably all of this should have been included in #39971
### Are these changes tested?
There is no new functionality to test
### Are there any user-facing changes?
No
* Closes: #40079
* GitHub Issue: #40079
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcdraulcd
mentioned this pull request
Nov 13, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

awaiting mergeAwaiting merge

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python][FS][Azure] Enable Azure in pyarrow wheel builds


2 participants

@Tom-Newton@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-39352: [FS][Azure] Enable azure in builds - #39971
Merged
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Feb 9, 2024
Merged
GH-39352: [FS][Azure] Enable azure in builds#39971
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Conversation
@Tom-Newton
@Tom-NewtonTom-Newton
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.
Are these changes tested?
There is no new functionality to test.
Are there any user-facing changes?
No
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
63806c2 to
ebd8f3bCompareFebruary 7, 2024 10:58
@Tom-NewtonTom-Newton
changed the title
GH-39352: WIP [FS][Azure] Enable azure in buildsGH-39352: [FS][Azure] Enable azure in buildsFeb 7, 2024
@Tom-Newton
Tom-Newton
marked this pull request as ready for review
February 7, 2024 18:22
@Tom-Newton
Tom-Newton
commented
Feb 7, 2024

Copy link


Copy Markdown

ContributorAuthor
I think this is ready for review. I guess we also need to run some archery builds?
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
56bb0ab to
ebd8f3bCompareFebruary 7, 2024 18:26
kou
kou
reviewed
Feb 8, 2024
View reviewed changes
Comment threadci/scripts/python_wheel_unix_test.sh
Outdated

: ${ARROW_SUBSTRAIT:=ON}
: ${ARROW_S3:=ON}
: ${ARROW_GCS:=ON}
: ${ARROW_AZURE:=ON}
@koukouFeb 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list in alphabetical order?

(including ARROW_GCS)
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Feb 8, 2024
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: ebd8f3b
Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Feb 8, 2024
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024

Copy link


Copy Markdown

ContributorAuthor
Failures in normal CI are
97/97 Test #73: arrow-s3fs-test ..............................***Timeout 300.05 sec

and
--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:785: Error Trace:	/Users/runner/work/arrow/arrow/go/arrow/flight/flightsql/driver/driver_test.go:785
Error: Error "EOF" does not contain "parameter schema: unexpected"
Test: TestPreparedStatementNoSchema
FAIL
FAIL	github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver	1.370s

I'm pretty sure these are both unrelated.
@kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures.
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: fb78267
Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: 9c08e54
Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds
kou
kou
approved these changes
Feb 9, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks!
@kou
kou
merged commit a0dec7f
into
apache:mainFeb 9, 2024
@koukou
removed
the 
awaiting change review
Awaiting change review
label
Feb 9, 2024
@github-actionsgithub-actionsBot
added
the 
awaiting merge
Awaiting merge
label
Feb 9, 2024
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Feb 9, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f.
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Feb 10, 2024
 Merged

 Merged

dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@Tom-Newton@dgreiss
apacheGH-39352: [FS][Azure] Enable azure in builds (apache#39971)
f86f122
### Rationale for this change
### What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested?
There is no new functionality to test. ### Are there any user-facing changes?
No
* Closes: apache#39352
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit
that referenced
this pull request
Feb 22, 2024
@Tom-Newton
GH-40079: [CI][Packaging] Enable Azure in more tests and builds (#40080)
b089c6a
### Rationale for this change
We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR?
- Add missing `export` to enable Azure pyarrow tests
- Enable azure in sdist tests.
- Enable Azure on macos python builds
- Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite)
- Enable retries on C++ tests to mitigate #40121
Probably all of this should have been included in #39971
### Are these changes tested?
There is no new functionality to test
### Are there any user-facing changes?
No
* Closes: #40079
* GitHub Issue: #40079
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcdraulcd
mentioned this pull request
Nov 13, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

awaiting mergeAwaiting merge

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python][FS][Azure] Enable Azure in pyarrow wheel builds


2 participants

@Tom-Newton@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-39352: [FS][Azure] Enable azure in builds - #39971
Merged
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Feb 9, 2024
Merged
GH-39352: [FS][Azure] Enable azure in builds#39971
kou merged 5 commits into
apache:mainfrom 
Tom-Newton:tomnewton/enable_azure_in_wheel_builds/GH-39352
Conversation
@Tom-Newton
@Tom-NewtonTom-Newton
commented
Feb 7, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Rationale for this change
What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.
Are these changes tested?
There is no new functionality to test.
Are there any user-facing changes?
No
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
63806c2 to
ebd8f3bCompareFebruary 7, 2024 10:58
@Tom-NewtonTom-Newton
changed the title
GH-39352: WIP [FS][Azure] Enable azure in buildsGH-39352: [FS][Azure] Enable azure in buildsFeb 7, 2024
@Tom-Newton
Tom-Newton
marked this pull request as ready for review
February 7, 2024 18:22
@Tom-Newton
Tom-Newton
commented
Feb 7, 2024

Copy link


Copy Markdown

ContributorAuthor
I think this is ready for review. I guess we also need to run some archery builds?
@Tom-Newton
Tom-Newtonforce-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
56bb0ab to
ebd8f3bCompareFebruary 7, 2024 18:26
kou
kou
reviewed
Feb 8, 2024
View reviewed changes
Comment threadci/scripts/python_wheel_unix_test.sh
Outdated

: ${ARROW_SUBSTRAIT:=ON}
: ${ARROW_S3:=ON}
: ${ARROW_GCS:=ON}
: ${ARROW_AZURE:=ON}
@koukouFeb 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list in alphabetical order?

(including ARROW_GCS)
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting review
Awaiting review
labels
Feb 8, 2024
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: ebd8f3b
Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Feb 8, 2024
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024

Copy link


Copy Markdown

ContributorAuthor
Failures in normal CI are
97/97 Test #73: arrow-s3fs-test ..............................***Timeout 300.05 sec

and
--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:785: Error Trace:	/Users/runner/work/arrow/arrow/go/arrow/flight/flightsql/driver/driver_test.go:785
Error: Error "EOF" does not contain "parameter schema: unexpected"
Test: TestPreparedStatementNoSchema
FAIL
FAIL	github.com/apache/arrow/go/v16/arrow/flight/flightsql/driver	1.370s

I'm pretty sure these are both unrelated.
@kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures.
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: fb78267
Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now
@kou
kou
commented
Feb 8, 2024

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g wheel
@github-actions
github-actionsBot
commented
Feb 8, 2024

Copy link


Copy Markdown

Revision: 9c08e54
Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b
TaskStatus
wheel-macos-big-sur-cp310-arm64GitHub Actions
wheel-macos-big-sur-cp311-arm64GitHub Actions
wheel-macos-big-sur-cp312-arm64GitHub Actions
wheel-macos-big-sur-cp38-arm64GitHub Actions
wheel-macos-big-sur-cp39-arm64GitHub Actions
wheel-macos-catalina-cp310-amd64GitHub Actions
wheel-macos-catalina-cp311-amd64GitHub Actions
wheel-macos-catalina-cp312-amd64GitHub Actions
wheel-macos-catalina-cp38-amd64GitHub Actions
wheel-macos-catalina-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions
wheel-windows-cp310-amd64GitHub Actions
wheel-windows-cp311-amd64GitHub Actions
wheel-windows-cp312-amd64GitHub Actions
wheel-windows-cp38-amd64GitHub Actions
wheel-windows-cp39-amd64GitHub Actions
@Tom-Newton
Tom-Newton
commented
Feb 8, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds
kou
kou
approved these changes
Feb 9, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks!
@kou
kou
merged commit a0dec7f
into
apache:mainFeb 9, 2024
@koukou
removed
the 
awaiting change review
Awaiting change review
label
Feb 9, 2024
@github-actionsgithub-actionsBot
added
the 
awaiting merge
Awaiting merge
label
Feb 9, 2024
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Feb 9, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f.
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Feb 10, 2024
 Merged

 Merged

dgreiss pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
@Tom-Newton@dgreiss
apacheGH-39352: [FS][Azure] Enable azure in builds (apache#39971)
f86f122
### Rationale for this change
### What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested?
There is no new functionality to test. ### Are there any user-facing changes?
No
* Closes: apache#39352
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit
that referenced
this pull request
Feb 22, 2024
@Tom-Newton
GH-40079: [CI][Packaging] Enable Azure in more tests and builds (#40080)
b089c6a
### Rationale for this change
We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR?
- Add missing `export` to enable Azure pyarrow tests
- Enable azure in sdist tests.
- Enable Azure on macos python builds
- Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite)
- Enable retries on C++ tests to mitigate #40121
Probably all of this should have been included in #39971
### Are these changes tested?
There is no new functionality to test
### Are there any user-facing changes?
No
* Closes: #40079
* GitHub Issue: #40079
Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcdraulcd
mentioned this pull request
Nov 13, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

awaiting mergeAwaiting merge

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Python][FS][Azure] Enable Azure in pyarrow wheel builds


2 participants

@Tom-Newton@kou