Skip to content

GH-40428: [Python][CI] Fix dataset partition filter tests with pandas nightly - #40429

Merged
jorisvandenbossche merged 2 commits into
apache:mainfrom
jorisvandenbossche:gh-40428-pandas
Mar 13, 2024
Merged

GH-40428: [Python][CI] Fix dataset partition filter tests with pandas nightly#40429
jorisvandenbossche merged 2 commits into
apache:mainfrom
jorisvandenbossche:gh-40428-pandas

Conversation

@jorisvandenbossche

@jorisvandenbosschejorisvandenbossche commented Mar 8, 2024

Copy link
Copy Markdown
Member

Rationale for this change

From debugging the failure, it seems this is due to pandas changing a filter operation to sometimes preserve a RangeIndex now instead of returning an Integer64Index. And the conversion to Arrow changes based on that (RangeIndex is metadata only by default, integer index becomes a column)

Therefore making the tests more robust to ensure there is always at least one non-partition column in the DataFrame, so it doesn't depend on the index whether the result is empty or not.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #40428has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.10-pandas-nightly

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Mar 8, 2024
@github-actions

Copy link
Copy Markdown

Revision: 26c53c3

Submitted crossbow builds: ursacomputing/crossbow @ actions-3bc5d6c7a3

TaskStatus
test-conda-python-3.10-pandas-nightlyGitHub Actions

@jorisvandenbosschejorisvandenbossche changed the title GH-40428: [Python][CI] Fix dateset partition filter tests with pandas nightlyGH-40428: [Python][CI] Fix dataset partition filter tests with pandas nightlyMar 12, 2024
@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.10-pandas-nightly

@github-actions

Copy link
Copy Markdown

Revision: 62bf9dd

Submitted crossbow builds: ursacomputing/crossbow @ actions-a15ea740b7

TaskStatus
test-conda-python-3.10-pandas-nightlyGitHub Actions

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 788200a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jorisvandenbossche