Uh oh!
There was an error while loading. Please reload this page.
GH-39958: [Python][CI] Remove upper pin on pytest - #40487
Conversation
kou
commented
Mar 12, 2024
@github-actions crossbow submit -g python |
kou
left a comment
There was a problem hiding this comment.
+1 if CI is green
BTW, could you use our PR template instead of just listing related issue links?
Revision: 701807a Submitted crossbow builds: ursacomputing/crossbow @ actions-2dab689a54 |
AlenkaF
commented
Mar 13, 2024
Will do, thank you for reminding me! |
AlenkaF
commented
Mar 13, 2024
@jorisvandenbossche do you mind giving a quick look at this changes? |
jorisvandenbossche
commented
Mar 13, 2024
I would personally prefer keeping doctest-cython running on our CI. Is it urgent to remove the pytest pin? Or we could also leave the pin just for the docs build where the doctests are ran? |
jorisvandenbossche
commented
Mar 13, 2024
Do we have any understanding about why pytest 8 needs this change? |
AlenkaF
commented
Mar 13, 2024
We can also wait with merging this PR till pytest-cython/pytest-cython#58 is merged. I am OK with any of the proposed options.
No 😊 Will research. |
AlenkaF
commented
Mar 18, 2024
I have kept the As for the |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jorisvandenbossche
commented
Mar 19, 2024
@github-actions crossbow submit -g python |
Revision: d5b4d40 Submitted crossbow builds: ursacomputing/crossbow @ actions-3ecfe9f5ae |
jorisvandenbossche
commented
Mar 19, 2024
Thanks! |
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 6d5cfb2. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 6d5cfb2. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Rationale for this change
The latest version of pytest (
8.0.0) is breaking our CI:doctest-cythoncheck failsWhat changes are included in this PR?
allow_bucket_creation=Trueto thes3_example_fsfixtureAre these changes tested?
Yes.
Are there any user-facing changes?
No
Closes: