Skip to content

GH-39958: [Python][CI] Remove upper pin on pytest - #40487

Merged
jorisvandenbossche merged 6 commits into
apache:mainfrom
AlenkaF:gh-39957-unpin-pytest
Mar 19, 2024
Merged

GH-39958: [Python][CI] Remove upper pin on pytest#40487
jorisvandenbossche merged 6 commits into
apache:mainfrom
AlenkaF:gh-39957-unpin-pytest

Conversation

@AlenkaF

@AlenkaFAlenkaF commented Mar 12, 2024

Copy link
Copy Markdown
Member

Rationale for this change

The latest version of pytest (8.0.0) is breaking our CI:

  • S3 fixture from out test suite fails
  • doctest-cython check fails

What changes are included in this PR?

  • added allow_bucket_creation=True to the s3_example_fs fixture
  • removed the pin on pytest, except for the doc builds

Are these changes tested?

Yes.

Are there any user-facing changes?

No

Closes:

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #39958has been automatically assigned in GitHub to PR creator.

@kou

kou commented Mar 12, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

kou
kou approved these changes Mar 12, 2024

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if CI is green

BTW, could you use our PR template instead of just listing related issue links?

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 12, 2024
@github-actions

Copy link
Copy Markdown

Revision: 701807a

Submitted crossbow builds: ursacomputing/crossbow @ actions-2dab689a54

TaskStatus
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-cython2GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latestGitHub Actions
test-conda-python-3.10-pandas-nightlyGitHub Actions
test-conda-python-3.10-spark-v3.5.0GitHub Actions
test-conda-python-3.10-substraitGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-upstream_develGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.8GitHub Actions
test-conda-python-3.8-pandas-1.0GitHub Actions
test-conda-python-3.8-spark-v3.5.0GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-latestGitHub Actions
test-cuda-pythonGitHub Actions
test-debian-11-python-3-amd64Azure
test-debian-11-python-3-i386GitHub Actions
test-fedora-39-python-3Azure
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-python-3GitHub Actions

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

BTW, could you use our PR template instead of just listing related issue links?

Will do, thank you for reminding me!

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

@jorisvandenbossche do you mind giving a quick look at this changes?

@jorisvandenbossche

Copy link
Copy Markdown
Member

I would personally prefer keeping doctest-cython running on our CI. Is it urgent to remove the pytest pin? Or we could also leave the pin just for the docs build where the doctests are ran?

@jorisvandenbossche

Copy link
Copy Markdown
Member

added allow_bucket_creation=True to the s3_example_fs fixture

Do we have any understanding about why pytest 8 needs this change?

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

I would personally prefer keeping doctest-cython running on our CI. Is it urgent to remove the pytest pin? Or we could also leave the pin just for the docs build where the doctests are ran?

We can also wait with merging this PR till pytest-cython/pytest-cython#58 is merged. I am OK with any of the proposed options.

added allow_bucket_creation=True to the s3_example_fs fixture

Do we have any understanding about why pytest 8 needs this change?

No 😊 Will research.

@AlenkaF

Copy link
Copy Markdown
MemberAuthor

I have kept the doctest-cython command on our CI (conda-python-docs) and pinned pytest to lower than 8 in this case.

As for the allow_bucket_creation=True in the s3_example_fs fixture, we have agreed there is no point in spending too much time on researching why it is needed. Looking at the PR that added this argument in other cases where S3FileSystem is created from a URI (#13206) it makes sense to also add it to the s3_example_fs fixture.

Comment threaddocker-compose.yml Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Mar 19, 2024
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 19, 2024
Comment threaddocker-compose.yml Outdated
@jorisvandenbossche

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Mar 19, 2024
@github-actions

Copy link
Copy Markdown

Revision: d5b4d40

Submitted crossbow builds: ursacomputing/crossbow @ actions-3ecfe9f5ae

TaskStatus
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-cython2GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latestGitHub Actions
test-conda-python-3.10-pandas-nightlyGitHub Actions
test-conda-python-3.10-spark-v3.5.0GitHub Actions
test-conda-python-3.10-substraitGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-upstream_develGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.8GitHub Actions
test-conda-python-3.8-pandas-1.0GitHub Actions
test-conda-python-3.8-spark-v3.5.0GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-latestGitHub Actions
test-cuda-pythonGitHub Actions
test-debian-11-python-3-amd64Azure
test-debian-11-python-3-i386GitHub Actions
test-fedora-39-python-3Azure
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-python-3GitHub Actions

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Mar 19, 2024
@jorisvandenbossche
jorisvandenbossche merged commit 6d5cfb2 into apache:mainMar 19, 2024
@jorisvandenbosschejorisvandenbossche removed the awaiting merge Awaiting merge label Mar 19, 2024
@jorisvandenbossche

Copy link
Copy Markdown
Member

Thanks!

@AlenkaF
AlenkaF deleted the gh-39957-unpin-pytest branch March 19, 2024 15:24
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 6d5cfb2.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 6d5cfb2.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python][CI] Remove upper pin on pytest [Python][CI] S3 fixtures fail with Pytest 8.0.0

3 participants

@AlenkaF@kou@jorisvandenbossche