GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps - #41045

Merged
felipecrv merged 3 commits into
apache:mainfrom
felipecrv:timestamp_formatting
Apr 6, 2024
Merged

GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps#41045
felipecrv merged 3 commits into
apache:mainfrom
felipecrv:timestamp_formatting

Conversation

@felipecrv

@felipecrvfelipecrv commented Apr 5, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

What changes are included in this PR?

A test that reproduces an issue found by the fuzzer and a fix for it.

Are these changes tested?

  • A test
  • Comments clarifying somethings around formatting.h
  • Increasing the size of the local buffer used to format timestamps

The issue was introduced only recently (unreleased): #39272

@felipecrv
formatting.h: Clarify meaning of cursor in FormatOneChar
e9b04fe
@felipecrv
formatting_util_test.cc: Add a test case that uses all the bytes in f…
87c2d49
…ormatting buffer
With ASAN, this reproduces the issue.
[ RUN ] Formatting.Timestamp
=================================================================
==4191383==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff1804c48f at pc 0x5608edffe39d bp 0x7fff1804c110 sp 0x7fff1804c108
WRITE of size 1 at 0x7fff1804c48f thread T0
#0 0x5608edffe39c in arrow::internal::detail::FormatOneChar(char, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:132:67
apache#1 0x5608ee035c00 in arrow::internal::detail::FormatYYYY_MM_DD(arrow_vendored::date::year_month_day, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:351:5
apache#2 0x5608ee05e8a0 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:521:5
apache#3 0x5608ee05d60f in decltype(std::declval<arrow::internal::StringFormatter<arrow::TimestampType, void>&>()(std::chrono::duration<long, std::ratio<1l, 1l> >{}, std::declval<long&>(), std::declval<arrow::StringAppender&>())) arrow::util::VisitDuration<arrow::internal::StringFormatter<arrow::TimestampType, void>&, long&, arrow::StringAppender&>(arrow::TimeUnit::type, arrow::internal::StringFormatter<arrow::Timestam
pType, void>&, long&, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/time.h:60:14
apache#4 0x5608ee05d122 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<arrow::StringAppender&>(long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:527:12
apache#5 0x5608edfeffb3 in void arrow::AssertFormatting<arrow::internal::StringFormatter<arrow::TimestampType, void>, long>(arrow::internal::StringFormatter<arrow::TimestampType, void>&, long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:52:3
apache#6 0x5608edfece95 in arrow::Formatting_Timestamp_Test::TestBody() /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:540:5
apache#7 0x7fd95d7901de in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd901de) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#8 0x7fd95d784905 in testing::Test::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84905) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#9 0x7fd95d784a84 in testing::TestInfo::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84a84) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#10 0x7fd95d785038 in testing::TestSuite::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd85038) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#11 0x7fd95d78573e in testing::internal::UnitTestImpl::RunAllTests() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd8573e) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#12 0x7fd95d7907a6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd907a6) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#13 0x7fd95d784b4b in testing::UnitTest::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84b4b) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#14 0x5608ee54506d in RUN_ALL_TESTS() /usr/include/gtest/gtest.h:2490:46
apache#15 0x5608ee544fb9 in main /home/felipeo/code/arrow/cpp/src/arrow/util/logging_test.cc:129:10
apache#16 0x7fd93de29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
apache#17 0x7fd93de29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
apache#18 0x5608ed7b4f64 in _start (/home/felipeo/code/arrow/cpp/ninja/debug/arrow-utility-test+0x1224f64) (BuildId: 81cfdc36b7a960a7249ecd5884beaa869140ab89)
Address 0x7fff1804c48f is located in stack of thread T0 at offset 399 in frame
#0 0x5608ee05dc9f in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:486
@felipecrv
formatting.h: Make sure space is allocated for the 'Z' in formatted t…
d3afed7
…imestamp
@github-actions

github-actionsBot commented Apr 5, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #41044has been automatically assigned in GitHub to PR creator.

kou
kou approved these changes Apr 5, 2024
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 5, 2024
@felipecrv
felipecrv merged commit 6aa3321 into apache:mainApr 6, 2024
@felipecrvfelipecrv removed the awaiting merge Awaiting merge label Apr 6, 2024
@felipecrvfelipecrv mentioned this pull request Apr 6, 2024
Closed
@felipecrv
felipecrv deleted the timestamp_formatting branch April 6, 2024 02:08
@pitrou

pitrou commented Apr 6, 2024

Copy link
Copy Markdown
Member

Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).

@conbench-apache-arrow

conbench-apache-arrowBot commented Apr 6, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6aa3321.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@AlenkaF

AlenkaF commented Apr 6, 2024

Copy link
Copy Markdown
Member

Thank you for fixing this @felipecrv!

felipecrv added a commit to felipecrv/arrow-testing that referenced this pull request Apr 9, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h
cfdbea9
Bug was fixed here apache/arrow#41045
@felipecrvfelipecrv mentioned this pull request Apr 9, 2024
Merged
@felipecrv

felipecrv commented Apr 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).

Done here apache/arrow-testing#100

@pitrou is arrow-testing bumped automatically or I should do it as well once the PR above is merged?

@pitrou

pitrou commented Apr 10, 2024

Copy link
Copy Markdown
Member

It's a regular git submodule, so you should open a PR here to bump it.

pitrou pushed a commit to apache/arrow-testing that referenced this pull request Apr 10, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h (#…
735ae71
…100)
Bug was fixed here apache/arrow#41045
@felipecrv

felipecrv commented Apr 11, 2024

Copy link
Copy Markdown
ContributorAuthor

It's a regular git submodule, so you should open a PR here to bump it.

#41139

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
@felipecrv@vibhatha
apacheGH-41044: [C++] formatting.h: Make sure space is allocated for …
11918b4
…the 'Z' when formatting timestamps (apache#41045)
### What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
### Are these changes tested?
- A test
- Comments clarifying somethings around `formatting.h`
- Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): apache#39272
* GitHub Issue: apache#41044
Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@zeroshadezeroshadezeroshade approved these changes
@pitroupitrouAwaiting requested review from pitroupitrou is a code owner
@AlenkaFAlenkaFAwaiting requested review from AlenkaF
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felipecrv@pitrou@AlenkaF@kou@zeroshade
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps - #41045
Merged
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Apr 6, 2024
Merged
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps#41045
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Conversation
@felipecrv
@felipecrvfelipecrv
commented
Apr 5, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
Are these changes tested?
  • A test
  • Comments clarifying somethings around formatting.h
  • Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): #39272
@felipecrv
formatting.h: Clarify meaning of cursor in FormatOneChar
e9b04fe
@felipecrv
formatting_util_test.cc: Add a test case that uses all the bytes in f…
87c2d49
…ormatting buffer
With ASAN, this reproduces the issue.
[ RUN ] Formatting.Timestamp
=================================================================
==4191383==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff1804c48f at pc 0x5608edffe39d bp 0x7fff1804c110 sp 0x7fff1804c108
WRITE of size 1 at 0x7fff1804c48f thread T0
#0 0x5608edffe39c in arrow::internal::detail::FormatOneChar(char, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:132:67
apache#1 0x5608ee035c00 in arrow::internal::detail::FormatYYYY_MM_DD(arrow_vendored::date::year_month_day, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:351:5
apache#2 0x5608ee05e8a0 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:521:5
apache#3 0x5608ee05d60f in decltype(std::declval<arrow::internal::StringFormatter<arrow::TimestampType, void>&>()(std::chrono::duration<long, std::ratio<1l, 1l> >{}, std::declval<long&>(), std::declval<arrow::StringAppender&>())) arrow::util::VisitDuration<arrow::internal::StringFormatter<arrow::TimestampType, void>&, long&, arrow::StringAppender&>(arrow::TimeUnit::type, arrow::internal::StringFormatter<arrow::Timestam
pType, void>&, long&, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/time.h:60:14
apache#4 0x5608ee05d122 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<arrow::StringAppender&>(long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:527:12
apache#5 0x5608edfeffb3 in void arrow::AssertFormatting<arrow::internal::StringFormatter<arrow::TimestampType, void>, long>(arrow::internal::StringFormatter<arrow::TimestampType, void>&, long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:52:3
apache#6 0x5608edfece95 in arrow::Formatting_Timestamp_Test::TestBody() /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:540:5
apache#7 0x7fd95d7901de in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd901de) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#8 0x7fd95d784905 in testing::Test::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84905) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#9 0x7fd95d784a84 in testing::TestInfo::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84a84) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#10 0x7fd95d785038 in testing::TestSuite::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd85038) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#11 0x7fd95d78573e in testing::internal::UnitTestImpl::RunAllTests() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd8573e) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#12 0x7fd95d7907a6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd907a6) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#13 0x7fd95d784b4b in testing::UnitTest::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84b4b) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#14 0x5608ee54506d in RUN_ALL_TESTS() /usr/include/gtest/gtest.h:2490:46
apache#15 0x5608ee544fb9 in main /home/felipeo/code/arrow/cpp/src/arrow/util/logging_test.cc:129:10
apache#16 0x7fd93de29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
apache#17 0x7fd93de29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
apache#18 0x5608ed7b4f64 in _start (/home/felipeo/code/arrow/cpp/ninja/debug/arrow-utility-test+0x1224f64) (BuildId: 81cfdc36b7a960a7249ecd5884beaa869140ab89)
Address 0x7fff1804c48f is located in stack of thread T0 at offset 399 in frame
#0 0x5608ee05dc9f in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:486
@felipecrv
formatting.h: Make sure space is allocated for the 'Z' in formatted t…
d3afed7
…imestamp
@github-actions
github-actionsBot
commented
Apr 5, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #41044has been automatically assigned in GitHub to PR creator.
kou
kou
approved these changes
Apr 5, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Apr 5, 2024
@felipecrv
felipecrv
merged commit 6aa3321
into
apache:mainApr 6, 2024
@felipecrvfelipecrv
removed
the 
awaiting merge
Awaiting merge
label
Apr 6, 2024
@felipecrvfelipecrv
mentioned this pull request
Apr 6, 2024

Closed

@felipecrv
felipecrv
deleted the

timestamp_formatting

branch
April 6, 2024 02:08
@pitrou
pitrou
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Apr 6, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6aa3321.
There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@AlenkaF
AlenkaF
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thank you for fixing this @felipecrv!
felipecrv added a commit
to felipecrv/arrow-testing
that referenced
this pull request
Apr 9, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h
cfdbea9
Bug was fixed here apache/arrow#41045
@felipecrvfelipecrv
mentioned this pull request
Apr 9, 2024
 Merged

@felipecrv
felipecrv
commented
Apr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
Done here apache/arrow-testing#100
@pitrou is arrow-testing bumped automatically or I should do it as well once the PR above is merged?
@pitrou
pitrou
commented
Apr 10, 2024

Copy link


Copy Markdown

Member
It's a regular git submodule, so you should open a PR here to bump it.
pitrou pushed a commit
to apache/arrow-testing
that referenced
this pull request
Apr 10, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h (#…
735ae71
…100)
Bug was fixed here apache/arrow#41045
@felipecrv
felipecrv
commented
Apr 11, 2024

Copy link


Copy Markdown

ContributorAuthor
It's a regular git submodule, so you should open a PR here to bump it.
#41139
vibhatha pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
@felipecrv@vibhatha
apacheGH-41044: [C++] formatting.h: Make sure space is allocated for …
11918b4
…the 'Z' when formatting timestamps (apache#41045)
### What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
### Are these changes tested?
- A test
- Comments clarifying somethings around `formatting.h`
- Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): apache#39272
* GitHub Issue: apache#41044
Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@zeroshadezeroshadezeroshade approved these changes
@pitroupitrouAwaiting requested review from pitroupitrou is a code owner
@AlenkaFAlenkaFAwaiting requested review from AlenkaF
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@felipecrv@pitrou@AlenkaF@kou@zeroshade

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps - #41045
Merged
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Apr 6, 2024
Merged
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps#41045
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Conversation
@felipecrv
@felipecrvfelipecrv
commented
Apr 5, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
Are these changes tested?
  • A test
  • Comments clarifying somethings around formatting.h
  • Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): #39272
@felipecrv
formatting.h: Clarify meaning of cursor in FormatOneChar
e9b04fe
@felipecrv
formatting_util_test.cc: Add a test case that uses all the bytes in f…
87c2d49
…ormatting buffer
With ASAN, this reproduces the issue.
[ RUN ] Formatting.Timestamp
=================================================================
==4191383==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff1804c48f at pc 0x5608edffe39d bp 0x7fff1804c110 sp 0x7fff1804c108
WRITE of size 1 at 0x7fff1804c48f thread T0
#0 0x5608edffe39c in arrow::internal::detail::FormatOneChar(char, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:132:67
apache#1 0x5608ee035c00 in arrow::internal::detail::FormatYYYY_MM_DD(arrow_vendored::date::year_month_day, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:351:5
apache#2 0x5608ee05e8a0 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:521:5
apache#3 0x5608ee05d60f in decltype(std::declval<arrow::internal::StringFormatter<arrow::TimestampType, void>&>()(std::chrono::duration<long, std::ratio<1l, 1l> >{}, std::declval<long&>(), std::declval<arrow::StringAppender&>())) arrow::util::VisitDuration<arrow::internal::StringFormatter<arrow::TimestampType, void>&, long&, arrow::StringAppender&>(arrow::TimeUnit::type, arrow::internal::StringFormatter<arrow::Timestam
pType, void>&, long&, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/time.h:60:14
apache#4 0x5608ee05d122 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<arrow::StringAppender&>(long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:527:12
apache#5 0x5608edfeffb3 in void arrow::AssertFormatting<arrow::internal::StringFormatter<arrow::TimestampType, void>, long>(arrow::internal::StringFormatter<arrow::TimestampType, void>&, long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:52:3
apache#6 0x5608edfece95 in arrow::Formatting_Timestamp_Test::TestBody() /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:540:5
apache#7 0x7fd95d7901de in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd901de) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#8 0x7fd95d784905 in testing::Test::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84905) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#9 0x7fd95d784a84 in testing::TestInfo::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84a84) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#10 0x7fd95d785038 in testing::TestSuite::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd85038) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#11 0x7fd95d78573e in testing::internal::UnitTestImpl::RunAllTests() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd8573e) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#12 0x7fd95d7907a6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd907a6) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#13 0x7fd95d784b4b in testing::UnitTest::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84b4b) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#14 0x5608ee54506d in RUN_ALL_TESTS() /usr/include/gtest/gtest.h:2490:46
apache#15 0x5608ee544fb9 in main /home/felipeo/code/arrow/cpp/src/arrow/util/logging_test.cc:129:10
apache#16 0x7fd93de29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
apache#17 0x7fd93de29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
apache#18 0x5608ed7b4f64 in _start (/home/felipeo/code/arrow/cpp/ninja/debug/arrow-utility-test+0x1224f64) (BuildId: 81cfdc36b7a960a7249ecd5884beaa869140ab89)
Address 0x7fff1804c48f is located in stack of thread T0 at offset 399 in frame
#0 0x5608ee05dc9f in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:486
@felipecrv
formatting.h: Make sure space is allocated for the 'Z' in formatted t…
d3afed7
…imestamp
@github-actions
github-actionsBot
commented
Apr 5, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #41044has been automatically assigned in GitHub to PR creator.
kou
kou
approved these changes
Apr 5, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Apr 5, 2024
@felipecrv
felipecrv
merged commit 6aa3321
into
apache:mainApr 6, 2024
@felipecrvfelipecrv
removed
the 
awaiting merge
Awaiting merge
label
Apr 6, 2024
@felipecrvfelipecrv
mentioned this pull request
Apr 6, 2024

Closed

@felipecrv
felipecrv
deleted the

timestamp_formatting

branch
April 6, 2024 02:08
@pitrou
pitrou
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Apr 6, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6aa3321.
There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@AlenkaF
AlenkaF
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thank you for fixing this @felipecrv!
felipecrv added a commit
to felipecrv/arrow-testing
that referenced
this pull request
Apr 9, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h
cfdbea9
Bug was fixed here apache/arrow#41045
@felipecrvfelipecrv
mentioned this pull request
Apr 9, 2024
 Merged

@felipecrv
felipecrv
commented
Apr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
Done here apache/arrow-testing#100
@pitrou is arrow-testing bumped automatically or I should do it as well once the PR above is merged?
@pitrou
pitrou
commented
Apr 10, 2024

Copy link


Copy Markdown

Member
It's a regular git submodule, so you should open a PR here to bump it.
pitrou pushed a commit
to apache/arrow-testing
that referenced
this pull request
Apr 10, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h (#…
735ae71
…100)
Bug was fixed here apache/arrow#41045
@felipecrv
felipecrv
commented
Apr 11, 2024

Copy link


Copy Markdown

ContributorAuthor
It's a regular git submodule, so you should open a PR here to bump it.
#41139
vibhatha pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
@felipecrv@vibhatha
apacheGH-41044: [C++] formatting.h: Make sure space is allocated for …
11918b4
…the 'Z' when formatting timestamps (apache#41045)
### What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
### Are these changes tested?
- A test
- Comments clarifying somethings around `formatting.h`
- Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): apache#39272
* GitHub Issue: apache#41044
Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@zeroshadezeroshadezeroshade approved these changes
@pitroupitrouAwaiting requested review from pitroupitrou is a code owner
@AlenkaFAlenkaFAwaiting requested review from AlenkaF
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@felipecrv@pitrou@AlenkaF@kou@zeroshade

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps - #41045
Merged
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Apr 6, 2024
Merged
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps#41045
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Conversation
@felipecrv
@felipecrvfelipecrv
commented
Apr 5, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
Are these changes tested?
  • A test
  • Comments clarifying somethings around formatting.h
  • Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): #39272
@felipecrv
formatting.h: Clarify meaning of cursor in FormatOneChar
e9b04fe
@felipecrv
formatting_util_test.cc: Add a test case that uses all the bytes in f…
87c2d49
…ormatting buffer
With ASAN, this reproduces the issue.
[ RUN ] Formatting.Timestamp
=================================================================
==4191383==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff1804c48f at pc 0x5608edffe39d bp 0x7fff1804c110 sp 0x7fff1804c108
WRITE of size 1 at 0x7fff1804c48f thread T0
#0 0x5608edffe39c in arrow::internal::detail::FormatOneChar(char, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:132:67
apache#1 0x5608ee035c00 in arrow::internal::detail::FormatYYYY_MM_DD(arrow_vendored::date::year_month_day, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:351:5
apache#2 0x5608ee05e8a0 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:521:5
apache#3 0x5608ee05d60f in decltype(std::declval<arrow::internal::StringFormatter<arrow::TimestampType, void>&>()(std::chrono::duration<long, std::ratio<1l, 1l> >{}, std::declval<long&>(), std::declval<arrow::StringAppender&>())) arrow::util::VisitDuration<arrow::internal::StringFormatter<arrow::TimestampType, void>&, long&, arrow::StringAppender&>(arrow::TimeUnit::type, arrow::internal::StringFormatter<arrow::Timestam
pType, void>&, long&, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/time.h:60:14
apache#4 0x5608ee05d122 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<arrow::StringAppender&>(long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:527:12
apache#5 0x5608edfeffb3 in void arrow::AssertFormatting<arrow::internal::StringFormatter<arrow::TimestampType, void>, long>(arrow::internal::StringFormatter<arrow::TimestampType, void>&, long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:52:3
apache#6 0x5608edfece95 in arrow::Formatting_Timestamp_Test::TestBody() /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:540:5
apache#7 0x7fd95d7901de in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd901de) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#8 0x7fd95d784905 in testing::Test::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84905) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#9 0x7fd95d784a84 in testing::TestInfo::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84a84) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#10 0x7fd95d785038 in testing::TestSuite::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd85038) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#11 0x7fd95d78573e in testing::internal::UnitTestImpl::RunAllTests() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd8573e) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#12 0x7fd95d7907a6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd907a6) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#13 0x7fd95d784b4b in testing::UnitTest::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84b4b) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#14 0x5608ee54506d in RUN_ALL_TESTS() /usr/include/gtest/gtest.h:2490:46
apache#15 0x5608ee544fb9 in main /home/felipeo/code/arrow/cpp/src/arrow/util/logging_test.cc:129:10
apache#16 0x7fd93de29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
apache#17 0x7fd93de29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
apache#18 0x5608ed7b4f64 in _start (/home/felipeo/code/arrow/cpp/ninja/debug/arrow-utility-test+0x1224f64) (BuildId: 81cfdc36b7a960a7249ecd5884beaa869140ab89)
Address 0x7fff1804c48f is located in stack of thread T0 at offset 399 in frame
#0 0x5608ee05dc9f in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:486
@felipecrv
formatting.h: Make sure space is allocated for the 'Z' in formatted t…
d3afed7
…imestamp
@github-actions
github-actionsBot
commented
Apr 5, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #41044has been automatically assigned in GitHub to PR creator.
kou
kou
approved these changes
Apr 5, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Apr 5, 2024
@felipecrv
felipecrv
merged commit 6aa3321
into
apache:mainApr 6, 2024
@felipecrvfelipecrv
removed
the 
awaiting merge
Awaiting merge
label
Apr 6, 2024
@felipecrvfelipecrv
mentioned this pull request
Apr 6, 2024

Closed

@felipecrv
felipecrv
deleted the

timestamp_formatting

branch
April 6, 2024 02:08
@pitrou
pitrou
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Apr 6, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6aa3321.
There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@AlenkaF
AlenkaF
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thank you for fixing this @felipecrv!
felipecrv added a commit
to felipecrv/arrow-testing
that referenced
this pull request
Apr 9, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h
cfdbea9
Bug was fixed here apache/arrow#41045
@felipecrvfelipecrv
mentioned this pull request
Apr 9, 2024
 Merged

@felipecrv
felipecrv
commented
Apr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
Done here apache/arrow-testing#100
@pitrou is arrow-testing bumped automatically or I should do it as well once the PR above is merged?
@pitrou
pitrou
commented
Apr 10, 2024

Copy link


Copy Markdown

Member
It's a regular git submodule, so you should open a PR here to bump it.
pitrou pushed a commit
to apache/arrow-testing
that referenced
this pull request
Apr 10, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h (#…
735ae71
…100)
Bug was fixed here apache/arrow#41045
@felipecrv
felipecrv
commented
Apr 11, 2024

Copy link


Copy Markdown

ContributorAuthor
It's a regular git submodule, so you should open a PR here to bump it.
#41139
vibhatha pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
@felipecrv@vibhatha
apacheGH-41044: [C++] formatting.h: Make sure space is allocated for …
11918b4
…the 'Z' when formatting timestamps (apache#41045)
### What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
### Are these changes tested?
- A test
- Comments clarifying somethings around `formatting.h`
- Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): apache#39272
* GitHub Issue: apache#41044
Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@zeroshadezeroshadezeroshade approved these changes
@pitroupitrouAwaiting requested review from pitroupitrou is a code owner
@AlenkaFAlenkaFAwaiting requested review from AlenkaF
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@felipecrv@pitrou@AlenkaF@kou@zeroshade

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps - #41045
Merged
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Apr 6, 2024
Merged
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps#41045
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Conversation
@felipecrv
@felipecrvfelipecrv
commented
Apr 5, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
Are these changes tested?
  • A test
  • Comments clarifying somethings around formatting.h
  • Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): #39272
@felipecrv
formatting.h: Clarify meaning of cursor in FormatOneChar
e9b04fe
@felipecrv
formatting_util_test.cc: Add a test case that uses all the bytes in f…
87c2d49
…ormatting buffer
With ASAN, this reproduces the issue.
[ RUN ] Formatting.Timestamp
=================================================================
==4191383==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff1804c48f at pc 0x5608edffe39d bp 0x7fff1804c110 sp 0x7fff1804c108
WRITE of size 1 at 0x7fff1804c48f thread T0
#0 0x5608edffe39c in arrow::internal::detail::FormatOneChar(char, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:132:67
apache#1 0x5608ee035c00 in arrow::internal::detail::FormatYYYY_MM_DD(arrow_vendored::date::year_month_day, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:351:5
apache#2 0x5608ee05e8a0 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:521:5
apache#3 0x5608ee05d60f in decltype(std::declval<arrow::internal::StringFormatter<arrow::TimestampType, void>&>()(std::chrono::duration<long, std::ratio<1l, 1l> >{}, std::declval<long&>(), std::declval<arrow::StringAppender&>())) arrow::util::VisitDuration<arrow::internal::StringFormatter<arrow::TimestampType, void>&, long&, arrow::StringAppender&>(arrow::TimeUnit::type, arrow::internal::StringFormatter<arrow::Timestam
pType, void>&, long&, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/time.h:60:14
apache#4 0x5608ee05d122 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<arrow::StringAppender&>(long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:527:12
apache#5 0x5608edfeffb3 in void arrow::AssertFormatting<arrow::internal::StringFormatter<arrow::TimestampType, void>, long>(arrow::internal::StringFormatter<arrow::TimestampType, void>&, long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:52:3
apache#6 0x5608edfece95 in arrow::Formatting_Timestamp_Test::TestBody() /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:540:5
apache#7 0x7fd95d7901de in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd901de) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#8 0x7fd95d784905 in testing::Test::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84905) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#9 0x7fd95d784a84 in testing::TestInfo::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84a84) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#10 0x7fd95d785038 in testing::TestSuite::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd85038) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#11 0x7fd95d78573e in testing::internal::UnitTestImpl::RunAllTests() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd8573e) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#12 0x7fd95d7907a6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd907a6) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#13 0x7fd95d784b4b in testing::UnitTest::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84b4b) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#14 0x5608ee54506d in RUN_ALL_TESTS() /usr/include/gtest/gtest.h:2490:46
apache#15 0x5608ee544fb9 in main /home/felipeo/code/arrow/cpp/src/arrow/util/logging_test.cc:129:10
apache#16 0x7fd93de29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
apache#17 0x7fd93de29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
apache#18 0x5608ed7b4f64 in _start (/home/felipeo/code/arrow/cpp/ninja/debug/arrow-utility-test+0x1224f64) (BuildId: 81cfdc36b7a960a7249ecd5884beaa869140ab89)
Address 0x7fff1804c48f is located in stack of thread T0 at offset 399 in frame
#0 0x5608ee05dc9f in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:486
@felipecrv
formatting.h: Make sure space is allocated for the 'Z' in formatted t…
d3afed7
…imestamp
@github-actions
github-actionsBot
commented
Apr 5, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #41044has been automatically assigned in GitHub to PR creator.
kou
kou
approved these changes
Apr 5, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Apr 5, 2024
@felipecrv
felipecrv
merged commit 6aa3321
into
apache:mainApr 6, 2024
@felipecrvfelipecrv
removed
the 
awaiting merge
Awaiting merge
label
Apr 6, 2024
@felipecrvfelipecrv
mentioned this pull request
Apr 6, 2024

Closed

@felipecrv
felipecrv
deleted the

timestamp_formatting

branch
April 6, 2024 02:08
@pitrou
pitrou
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Apr 6, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6aa3321.
There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@AlenkaF
AlenkaF
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thank you for fixing this @felipecrv!
felipecrv added a commit
to felipecrv/arrow-testing
that referenced
this pull request
Apr 9, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h
cfdbea9
Bug was fixed here apache/arrow#41045
@felipecrvfelipecrv
mentioned this pull request
Apr 9, 2024
 Merged

@felipecrv
felipecrv
commented
Apr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
Done here apache/arrow-testing#100
@pitrou is arrow-testing bumped automatically or I should do it as well once the PR above is merged?
@pitrou
pitrou
commented
Apr 10, 2024

Copy link


Copy Markdown

Member
It's a regular git submodule, so you should open a PR here to bump it.
pitrou pushed a commit
to apache/arrow-testing
that referenced
this pull request
Apr 10, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h (#…
735ae71
…100)
Bug was fixed here apache/arrow#41045
@felipecrv
felipecrv
commented
Apr 11, 2024

Copy link


Copy Markdown

ContributorAuthor
It's a regular git submodule, so you should open a PR here to bump it.
#41139
vibhatha pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
@felipecrv@vibhatha
apacheGH-41044: [C++] formatting.h: Make sure space is allocated for …
11918b4
…the 'Z' when formatting timestamps (apache#41045)
### What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
### Are these changes tested?
- A test
- Comments clarifying somethings around `formatting.h`
- Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): apache#39272
* GitHub Issue: apache#41044
Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@zeroshadezeroshadezeroshade approved these changes
@pitroupitrouAwaiting requested review from pitroupitrou is a code owner
@AlenkaFAlenkaFAwaiting requested review from AlenkaF
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@felipecrv@pitrou@AlenkaF@kou@zeroshade

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps - #41045
Merged
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Apr 6, 2024
Merged
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps#41045
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Conversation
@felipecrv
@felipecrvfelipecrv
commented
Apr 5, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
Are these changes tested?
  • A test
  • Comments clarifying somethings around formatting.h
  • Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): #39272
@felipecrv
formatting.h: Clarify meaning of cursor in FormatOneChar
e9b04fe
@felipecrv
formatting_util_test.cc: Add a test case that uses all the bytes in f…
87c2d49
…ormatting buffer
With ASAN, this reproduces the issue.
[ RUN ] Formatting.Timestamp
=================================================================
==4191383==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff1804c48f at pc 0x5608edffe39d bp 0x7fff1804c110 sp 0x7fff1804c108
WRITE of size 1 at 0x7fff1804c48f thread T0
#0 0x5608edffe39c in arrow::internal::detail::FormatOneChar(char, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:132:67
apache#1 0x5608ee035c00 in arrow::internal::detail::FormatYYYY_MM_DD(arrow_vendored::date::year_month_day, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:351:5
apache#2 0x5608ee05e8a0 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:521:5
apache#3 0x5608ee05d60f in decltype(std::declval<arrow::internal::StringFormatter<arrow::TimestampType, void>&>()(std::chrono::duration<long, std::ratio<1l, 1l> >{}, std::declval<long&>(), std::declval<arrow::StringAppender&>())) arrow::util::VisitDuration<arrow::internal::StringFormatter<arrow::TimestampType, void>&, long&, arrow::StringAppender&>(arrow::TimeUnit::type, arrow::internal::StringFormatter<arrow::Timestam
pType, void>&, long&, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/time.h:60:14
apache#4 0x5608ee05d122 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<arrow::StringAppender&>(long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:527:12
apache#5 0x5608edfeffb3 in void arrow::AssertFormatting<arrow::internal::StringFormatter<arrow::TimestampType, void>, long>(arrow::internal::StringFormatter<arrow::TimestampType, void>&, long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:52:3
apache#6 0x5608edfece95 in arrow::Formatting_Timestamp_Test::TestBody() /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:540:5
apache#7 0x7fd95d7901de in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd901de) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#8 0x7fd95d784905 in testing::Test::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84905) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#9 0x7fd95d784a84 in testing::TestInfo::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84a84) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#10 0x7fd95d785038 in testing::TestSuite::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd85038) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#11 0x7fd95d78573e in testing::internal::UnitTestImpl::RunAllTests() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd8573e) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#12 0x7fd95d7907a6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd907a6) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#13 0x7fd95d784b4b in testing::UnitTest::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84b4b) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#14 0x5608ee54506d in RUN_ALL_TESTS() /usr/include/gtest/gtest.h:2490:46
apache#15 0x5608ee544fb9 in main /home/felipeo/code/arrow/cpp/src/arrow/util/logging_test.cc:129:10
apache#16 0x7fd93de29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
apache#17 0x7fd93de29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
apache#18 0x5608ed7b4f64 in _start (/home/felipeo/code/arrow/cpp/ninja/debug/arrow-utility-test+0x1224f64) (BuildId: 81cfdc36b7a960a7249ecd5884beaa869140ab89)
Address 0x7fff1804c48f is located in stack of thread T0 at offset 399 in frame
#0 0x5608ee05dc9f in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:486
@felipecrv
formatting.h: Make sure space is allocated for the 'Z' in formatted t…
d3afed7
…imestamp
@github-actions
github-actionsBot
commented
Apr 5, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #41044has been automatically assigned in GitHub to PR creator.
kou
kou
approved these changes
Apr 5, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Apr 5, 2024
@felipecrv
felipecrv
merged commit 6aa3321
into
apache:mainApr 6, 2024
@felipecrvfelipecrv
removed
the 
awaiting merge
Awaiting merge
label
Apr 6, 2024
@felipecrvfelipecrv
mentioned this pull request
Apr 6, 2024

Closed

@felipecrv
felipecrv
deleted the

timestamp_formatting

branch
April 6, 2024 02:08
@pitrou
pitrou
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Apr 6, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6aa3321.
There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@AlenkaF
AlenkaF
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thank you for fixing this @felipecrv!
felipecrv added a commit
to felipecrv/arrow-testing
that referenced
this pull request
Apr 9, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h
cfdbea9
Bug was fixed here apache/arrow#41045
@felipecrvfelipecrv
mentioned this pull request
Apr 9, 2024
 Merged

@felipecrv
felipecrv
commented
Apr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
Done here apache/arrow-testing#100
@pitrou is arrow-testing bumped automatically or I should do it as well once the PR above is merged?
@pitrou
pitrou
commented
Apr 10, 2024

Copy link


Copy Markdown

Member
It's a regular git submodule, so you should open a PR here to bump it.
pitrou pushed a commit
to apache/arrow-testing
that referenced
this pull request
Apr 10, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h (#…
735ae71
…100)
Bug was fixed here apache/arrow#41045
@felipecrv
felipecrv
commented
Apr 11, 2024

Copy link


Copy Markdown

ContributorAuthor
It's a regular git submodule, so you should open a PR here to bump it.
#41139
vibhatha pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
@felipecrv@vibhatha
apacheGH-41044: [C++] formatting.h: Make sure space is allocated for …
11918b4
…the 'Z' when formatting timestamps (apache#41045)
### What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
### Are these changes tested?
- A test
- Comments clarifying somethings around `formatting.h`
- Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): apache#39272
* GitHub Issue: apache#41044
Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@zeroshadezeroshadezeroshade approved these changes
@pitroupitrouAwaiting requested review from pitroupitrou is a code owner
@AlenkaFAlenkaFAwaiting requested review from AlenkaF
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@felipecrv@pitrou@AlenkaF@kou@zeroshade

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps - #41045
Merged
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Apr 6, 2024
Merged
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps#41045
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Conversation
@felipecrv
@felipecrvfelipecrv
commented
Apr 5, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
Are these changes tested?
  • A test
  • Comments clarifying somethings around formatting.h
  • Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): #39272
@felipecrv
formatting.h: Clarify meaning of cursor in FormatOneChar
e9b04fe
@felipecrv
formatting_util_test.cc: Add a test case that uses all the bytes in f…
87c2d49
…ormatting buffer
With ASAN, this reproduces the issue.
[ RUN ] Formatting.Timestamp
=================================================================
==4191383==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff1804c48f at pc 0x5608edffe39d bp 0x7fff1804c110 sp 0x7fff1804c108
WRITE of size 1 at 0x7fff1804c48f thread T0
#0 0x5608edffe39c in arrow::internal::detail::FormatOneChar(char, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:132:67
apache#1 0x5608ee035c00 in arrow::internal::detail::FormatYYYY_MM_DD(arrow_vendored::date::year_month_day, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:351:5
apache#2 0x5608ee05e8a0 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:521:5
apache#3 0x5608ee05d60f in decltype(std::declval<arrow::internal::StringFormatter<arrow::TimestampType, void>&>()(std::chrono::duration<long, std::ratio<1l, 1l> >{}, std::declval<long&>(), std::declval<arrow::StringAppender&>())) arrow::util::VisitDuration<arrow::internal::StringFormatter<arrow::TimestampType, void>&, long&, arrow::StringAppender&>(arrow::TimeUnit::type, arrow::internal::StringFormatter<arrow::Timestam
pType, void>&, long&, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/time.h:60:14
apache#4 0x5608ee05d122 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<arrow::StringAppender&>(long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:527:12
apache#5 0x5608edfeffb3 in void arrow::AssertFormatting<arrow::internal::StringFormatter<arrow::TimestampType, void>, long>(arrow::internal::StringFormatter<arrow::TimestampType, void>&, long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:52:3
apache#6 0x5608edfece95 in arrow::Formatting_Timestamp_Test::TestBody() /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:540:5
apache#7 0x7fd95d7901de in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd901de) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#8 0x7fd95d784905 in testing::Test::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84905) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#9 0x7fd95d784a84 in testing::TestInfo::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84a84) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#10 0x7fd95d785038 in testing::TestSuite::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd85038) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#11 0x7fd95d78573e in testing::internal::UnitTestImpl::RunAllTests() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd8573e) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#12 0x7fd95d7907a6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd907a6) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#13 0x7fd95d784b4b in testing::UnitTest::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84b4b) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#14 0x5608ee54506d in RUN_ALL_TESTS() /usr/include/gtest/gtest.h:2490:46
apache#15 0x5608ee544fb9 in main /home/felipeo/code/arrow/cpp/src/arrow/util/logging_test.cc:129:10
apache#16 0x7fd93de29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
apache#17 0x7fd93de29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
apache#18 0x5608ed7b4f64 in _start (/home/felipeo/code/arrow/cpp/ninja/debug/arrow-utility-test+0x1224f64) (BuildId: 81cfdc36b7a960a7249ecd5884beaa869140ab89)
Address 0x7fff1804c48f is located in stack of thread T0 at offset 399 in frame
#0 0x5608ee05dc9f in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:486
@felipecrv
formatting.h: Make sure space is allocated for the 'Z' in formatted t…
d3afed7
…imestamp
@github-actions
github-actionsBot
commented
Apr 5, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #41044has been automatically assigned in GitHub to PR creator.
kou
kou
approved these changes
Apr 5, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Apr 5, 2024
@felipecrv
felipecrv
merged commit 6aa3321
into
apache:mainApr 6, 2024
@felipecrvfelipecrv
removed
the 
awaiting merge
Awaiting merge
label
Apr 6, 2024
@felipecrvfelipecrv
mentioned this pull request
Apr 6, 2024

Closed

@felipecrv
felipecrv
deleted the

timestamp_formatting

branch
April 6, 2024 02:08
@pitrou
pitrou
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Apr 6, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6aa3321.
There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@AlenkaF
AlenkaF
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thank you for fixing this @felipecrv!
felipecrv added a commit
to felipecrv/arrow-testing
that referenced
this pull request
Apr 9, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h
cfdbea9
Bug was fixed here apache/arrow#41045
@felipecrvfelipecrv
mentioned this pull request
Apr 9, 2024
 Merged

@felipecrv
felipecrv
commented
Apr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
Done here apache/arrow-testing#100
@pitrou is arrow-testing bumped automatically or I should do it as well once the PR above is merged?
@pitrou
pitrou
commented
Apr 10, 2024

Copy link


Copy Markdown

Member
It's a regular git submodule, so you should open a PR here to bump it.
pitrou pushed a commit
to apache/arrow-testing
that referenced
this pull request
Apr 10, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h (#…
735ae71
…100)
Bug was fixed here apache/arrow#41045
@felipecrv
felipecrv
commented
Apr 11, 2024

Copy link


Copy Markdown

ContributorAuthor
It's a regular git submodule, so you should open a PR here to bump it.
#41139
vibhatha pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
@felipecrv@vibhatha
apacheGH-41044: [C++] formatting.h: Make sure space is allocated for …
11918b4
…the 'Z' when formatting timestamps (apache#41045)
### What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
### Are these changes tested?
- A test
- Comments clarifying somethings around `formatting.h`
- Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): apache#39272
* GitHub Issue: apache#41044
Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@zeroshadezeroshadezeroshade approved these changes
@pitroupitrouAwaiting requested review from pitroupitrou is a code owner
@AlenkaFAlenkaFAwaiting requested review from AlenkaF
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@felipecrv@pitrou@AlenkaF@kou@zeroshade

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps - #41045
Merged
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Apr 6, 2024
Merged
GH-41044: [C++] formatting.h: Make sure space is allocated for the 'Z' when formatting timestamps#41045
felipecrv merged 3 commits into
apache:mainfrom 
felipecrv:timestamp_formatting
Conversation
@felipecrv
@felipecrvfelipecrv
commented
Apr 5, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
Are these changes tested?
  • A test
  • Comments clarifying somethings around formatting.h
  • Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): #39272
@felipecrv
formatting.h: Clarify meaning of cursor in FormatOneChar
e9b04fe
@felipecrv
formatting_util_test.cc: Add a test case that uses all the bytes in f…
87c2d49
…ormatting buffer
With ASAN, this reproduces the issue.
[ RUN ] Formatting.Timestamp
=================================================================
==4191383==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff1804c48f at pc 0x5608edffe39d bp 0x7fff1804c110 sp 0x7fff1804c108
WRITE of size 1 at 0x7fff1804c48f thread T0
#0 0x5608edffe39c in arrow::internal::detail::FormatOneChar(char, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:132:67
apache#1 0x5608ee035c00 in arrow::internal::detail::FormatYYYY_MM_DD(arrow_vendored::date::year_month_day, char**) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:351:5
apache#2 0x5608ee05e8a0 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:521:5
apache#3 0x5608ee05d60f in decltype(std::declval<arrow::internal::StringFormatter<arrow::TimestampType, void>&>()(std::chrono::duration<long, std::ratio<1l, 1l> >{}, std::declval<long&>(), std::declval<arrow::StringAppender&>())) arrow::util::VisitDuration<arrow::internal::StringFormatter<arrow::TimestampType, void>&, long&, arrow::StringAppender&>(arrow::TimeUnit::type, arrow::internal::StringFormatter<arrow::Timestam
pType, void>&, long&, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/time.h:60:14
apache#4 0x5608ee05d122 in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<arrow::StringAppender&>(long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h:527:12
apache#5 0x5608edfeffb3 in void arrow::AssertFormatting<arrow::internal::StringFormatter<arrow::TimestampType, void>, long>(arrow::internal::StringFormatter<arrow::TimestampType, void>&, long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:52:3
apache#6 0x5608edfece95 in arrow::Formatting_Timestamp_Test::TestBody() /home/felipeo/code/arrow/cpp/src/arrow/util/formatting_util_test.cc:540:5
apache#7 0x7fd95d7901de in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd901de) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#8 0x7fd95d784905 in testing::Test::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84905) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#9 0x7fd95d784a84 in testing::TestInfo::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84a84) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#10 0x7fd95d785038 in testing::TestSuite::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd85038) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#11 0x7fd95d78573e in testing::internal::UnitTestImpl::RunAllTests() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd8573e) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#12 0x7fd95d7907a6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd907a6) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#13 0x7fd95d784b4b in testing::UnitTest::Run() (/home/felipeo/code/arrow/cpp/ninja/debug/libarrow_testing.so.1600+0xd84b4b) (BuildId: dd9af0bafdb1786050262e8f6002568a9f08ecf6)
apache#14 0x5608ee54506d in RUN_ALL_TESTS() /usr/include/gtest/gtest.h:2490:46
apache#15 0x5608ee544fb9 in main /home/felipeo/code/arrow/cpp/src/arrow/util/logging_test.cc:129:10
apache#16 0x7fd93de29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
apache#17 0x7fd93de29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
apache#18 0x5608ed7b4f64 in _start (/home/felipeo/code/arrow/cpp/ninja/debug/arrow-utility-test+0x1224f64) (BuildId: 81cfdc36b7a960a7249ecd5884beaa869140ab89)
Address 0x7fff1804c48f is located in stack of thread T0 at offset 399 in frame
#0 0x5608ee05dc9f in decltype(std::declval<arrow::StringAppender&>()(std::basic_string_view<char, std::char_traits<char> >{})) arrow::internal::StringFormatter<arrow::TimestampType, void>::operator()<std::chrono::duration<long, std::ratio<1l, 1000l> >, arrow::StringAppender&>(std::chrono::duration<long, std::ratio<1l, 1000l> >, long, arrow::StringAppender&) /home/felipeo/code/arrow/cpp/src/arrow/util/formatting.h
:486
@felipecrv
formatting.h: Make sure space is allocated for the 'Z' in formatted t…
d3afed7
…imestamp
@github-actions
github-actionsBot
commented
Apr 5, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #41044has been automatically assigned in GitHub to PR creator.
kou
kou
approved these changes
Apr 5, 2024
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Apr 5, 2024
@felipecrv
felipecrv
merged commit 6aa3321
into
apache:mainApr 6, 2024
@felipecrvfelipecrv
removed
the 
awaiting merge
Awaiting merge
label
Apr 6, 2024
@felipecrvfelipecrv
mentioned this pull request
Apr 6, 2024

Closed

@felipecrv
felipecrv
deleted the

timestamp_formatting

branch
April 6, 2024 02:08
@pitrou
pitrou
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Apr 6, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6aa3321.
There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
@AlenkaF
AlenkaF
commented
Apr 6, 2024

Copy link


Copy Markdown

Member
Thank you for fixing this @felipecrv!
felipecrv added a commit
to felipecrv/arrow-testing
that referenced
this pull request
Apr 9, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h
cfdbea9
Bug was fixed here apache/arrow#41045
@felipecrvfelipecrv
mentioned this pull request
Apr 9, 2024
 Merged

@felipecrv
felipecrv
commented
Apr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks @felipecrv . The regression file must also be added to https://github.com/apache/arrow-testing/tree/master/data (which will test it in the ASAN UBSAN build).
Done here apache/arrow-testing#100
@pitrou is arrow-testing bumped automatically or I should do it as well once the PR above is merged?
@pitrou
pitrou
commented
Apr 10, 2024

Copy link


Copy Markdown

Member
It's a regular git submodule, so you should open a PR here to bump it.
pitrou pushed a commit
to apache/arrow-testing
that referenced
this pull request
Apr 10, 2024
@felipecrv
GH-41044: [C++] Add bug repro file that triggers bug in formatting.h (#…
735ae71
…100)
Bug was fixed here apache/arrow#41045
@felipecrv
felipecrv
commented
Apr 11, 2024

Copy link


Copy Markdown

ContributorAuthor
It's a regular git submodule, so you should open a PR here to bump it.
#41139
vibhatha pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
@felipecrv@vibhatha
apacheGH-41044: [C++] formatting.h: Make sure space is allocated for …
11918b4
…the 'Z' when formatting timestamps (apache#41045)
### What changes are included in this PR?
A test that reproduces an issue found by the fuzzer and a fix for it.
### Are these changes tested?
- A test
- Comments clarifying somethings around `formatting.h`
- Increasing the size of the local buffer used to format timestamps
The issue was introduced only recently (unreleased): apache#39272
* GitHub Issue: apache#41044
Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@zeroshadezeroshadezeroshade approved these changes
@pitroupitrouAwaiting requested review from pitroupitrou is a code owner
@AlenkaFAlenkaFAwaiting requested review from AlenkaF
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@felipecrv@pitrou@AlenkaF@kou@zeroshade