Skip to content

GH-40108: [JS] Remove SWC dependency and move types to dev deps - #41274

Closed
domoritz wants to merge 2 commits into
apache:mainfrom
domoritz:dom/40108
Closed

GH-40108: [JS] Remove SWC dependency and move types to dev deps#41274
domoritz wants to merge 2 commits into
apache:mainfrom
domoritz:dom/40108

Conversation

@domoritz

@domoritzdomoritz commented Apr 18, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@domoritz
domoritz requested a review from trxcllnt as a code ownerApril 18, 2024 03:05
@github-actions

github-actionsBot commented Apr 18, 2024

Copy link
Copy Markdown

⚠️ GitHub issue apache/arrow-js#65has been automatically assigned in GitHub to PR creator.

@domoritzdomoritz changed the title GH-40108: [JS] Remove dependenciesGH-40108: [JS] Remove SWC dependencyApr 18, 2024
@domoritzdomoritz mentioned this pull request Apr 18, 2024
Open
@domoritzdomoritz added this to the 17.0.0 milestone Apr 18, 2024
trxcllnt
trxcllnt requested changes Apr 18, 2024
View reviewed changes

@trxcllnttrxcllnt left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the ts-node docs:

SWC uses @swc/helpers instead of tslib. If you have enabled importHelpers, you must also install @swc/helpers.

@domoritz

domoritz commented Apr 18, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I thought I disabled swc though so ts node shouldn't use it anymore. See https://github.com/apache/arrow/pull/41274/files#diff-bb9cf0fd13f06ac1b6668c895fdba550244bc31245ee5a43121a1609af54f067L22

@domoritzdomoritz changed the title GH-40108: [JS] Remove SWC dependencyGH-40108: [JS] Remove SWC dependency and move types to dev depsApr 18, 2024
@trxcllnt

trxcllnt commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

IIRC the reason we're using swc was that the regular ts-node compilation speed is so slow, it was timing out the integration tests.

@trxcllnt

trxcllnt commented Apr 19, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Specifically this commit: c6cc6c0. The CI run for the previous commit timed out after 60 minutes.

@domoritz

domoritz commented Apr 19, 2024

Copy link
Copy Markdown
MemberAuthor

Yeah, looks like we need 45 minutes rather than 25 compared to #41260. So yeah, not a change we should make.

@domoritz

domoritz commented Apr 19, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Closing this for now as it seems like we need to make more major cleanups.

@domoritz
domoritz deleted the dom/40108 branch April 19, 2024 02:40
@github-actions

github-actionsBot commented May 26, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #40108 has no components, please add labels for components.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trxcllnttrxcllnttrxcllnt requested changes

Assignees

No one assigned

Labels

awaiting committer reviewAwaiting committer reviewComponent: JavaScript

Projects

None yet

Milestone

17.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@domoritz@trxcllnt