Skip to content

GH-41287: [Java] ListViewVector Implementation - #41285

Merged
lidavidm merged 34 commits into
apache:mainfrom
vibhatha:listview-poc
May 16, 2024
Merged

GH-41287: [Java] ListViewVector Implementation#41285
lidavidm merged 34 commits into
apache:mainfrom
vibhatha:listview-poc

Conversation

@vibhatha

@vibhathavibhatha commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Rationale for this change

Apache Arrow format defines ListView and this has been introduced into other language bindings and the objective of this PR is to provide the initial ListView support to Java by adding ListViewVector.

Non-Goals

The following list of issues propose the extended work depending on this PR. They were separated to streamline the implementation process.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@vibhathavibhatha changed the title [Java] ListView Implementation WIPGH-41287: [Java] ListViewVector Implementation [WIP]Apr 18, 2024
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Apr 26, 2024
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Apr 30, 2024
Comment threadjava/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java Outdated
Comment threadjava/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java Outdated
@vibhatha
vibhatha requested a review from lidavidmMay 3, 2024 05:32
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels May 3, 2024
Comment threadjava/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java Outdated
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels May 3, 2024
@vibhatha
vibhatha marked this pull request as ready for review May 8, 2024 00:59
@vibhatha
vibhatha requested a review from lidavidmMay 8, 2024 01:00
@vibhathavibhatha changed the title GH-41287: [Java] ListViewVector Implementation [WIP]GH-41287: [Java] ListViewVector ImplementationMay 8, 2024
@vibhatha

Copy link
Copy Markdown
ContributorAuthor

@lidavidm CIs are passing!

@lidavidm
lidavidm merged commit 0574988 into apache:mainMay 16, 2024
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0574988.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vibhatha@lidavidm