Uh oh!
There was an error while loading. Please reload this page.
MINOR: [C++][CMake] Remove unused CMAKE_SKIP_INSTALL_ALL_DEPENDENCY - #41332
Merged
Conversation
wgtmac
commented
Apr 22, 2024
MemberAuthor
I found this is not cleaned up when reading the CMake code. cc @kou |
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 08aefc3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 24, 2024
…pache#41332) ### Rationale for this change CMAKE_SKIP_INSTALL_ALL_DEPENDENCY was removed in apache#75 but it seems that there is still one line remaining. ### What changes are included in this PR? Remove unused CMAKE_SKIP_INSTALL_ALL_DEPENDENCY. ### Are these changes tested? Pass all CIs. ### Are there any user-facing changes? No. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Gang Wu <ustcwg@gmail.com>
vibhatha pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…pache#41332) ### Rationale for this change CMAKE_SKIP_INSTALL_ALL_DEPENDENCY was removed in apache#75 but it seems that there is still one line remaining. ### What changes are included in this PR? Remove unused CMAKE_SKIP_INSTALL_ALL_DEPENDENCY. ### Are these changes tested? Pass all CIs. ### Are there any user-facing changes? No. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Gang Wu <ustcwg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
CMAKE_SKIP_INSTALL_ALL_DEPENDENCY was removed in #75 but it seems that there is still one line remaining.
What changes are included in this PR?
Remove unused CMAKE_SKIP_INSTALL_ALL_DEPENDENCY.
Are these changes tested?
Pass all CIs.
Are there any user-facing changes?
No.