Skip to content

GH-41463: [C++] Skip TestConcurrentFillFromScalar for platforms without threading support - #41461

Merged
jorisvandenbossche merged 1 commit into
apache:mainfrom
zanmato1984:skip-scalar-test
May 1, 2024
Merged

GH-41463: [C++] Skip TestConcurrentFillFromScalar for platforms without threading support#41461
jorisvandenbossche merged 1 commit into
apache:mainfrom
zanmato1984:skip-scalar-test

Conversation

@zanmato1984

@zanmato1984zanmato1984 commented Apr 30, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Rationale for this change

See #41463 and #40237 (comment)

What changes are included in this PR?

Skip test for platforms that have no threading support.

Are these changes tested?

Change is test.

Are there any user-facing changes?

None.

@zanmato1984

zanmato1984 commented Apr 30, 2024

Copy link
Copy Markdown
ContributorAuthor

cc @jorisvandenbossche

@raulcd

raulcd commented Apr 30, 2024

Copy link
Copy Markdown
Member

Can we create an issue for this? This is not MINOR and it is currently failing on the 16.1.0 maintenance branch. It should be cherry-picked and for it to be cherry-picked and milestoned correctly we require an issue.

@jorisvandenbossche

jorisvandenbossche commented Apr 30, 2024

Copy link
Copy Markdown
Member

This should not be on 16.1.0, though?

@zanmato1984zanmato1984 changed the title MINOR: [C++] Skip TestConcurrentFillFromScalar for platforms without threading supportGH-41463: [C++] Skip TestConcurrentFillFromScalar for platforms without threading supportApr 30, 2024
@github-actions

github-actionsBot commented Apr 30, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #41463has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche

jorisvandenbossche commented Apr 30, 2024

Copy link
Copy Markdown
Member

Or was it added explicitly to 16.1 because of fixing a data race?

@zanmato1984

zanmato1984 commented Apr 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Can we create an issue for this? This is not MINOR and it is currently failing on the 16.1.0 maintenance branch. It should be cherry-picked and for it to be cherry-picked and milestoned correctly we require an issue.

Thanks for reminding. I've filed #41463 and updated the PR description. Sorry for the trouble.

@raulcd

raulcd commented Apr 30, 2024

Copy link
Copy Markdown
Member

Or was it added explicitly to 16.1 because of fixing a data race?

It was tagged as 16.1.0 and is to was a bug fix to fix the data race I cherry-picked it. Wasn't that expected to be on the release?

@github-actionsgithub-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 30, 2024
@jorisvandenbossche

jorisvandenbossche commented Apr 30, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-ubuntu-22.04-cpp-emscripten

@github-actions

github-actionsBot commented Apr 30, 2024

Copy link
Copy Markdown

Revision: bb87a96

Submitted crossbow builds: ursacomputing/crossbow @ actions-8dd2f94f75

TaskStatus
test-ubuntu-22.04-cpp-emscriptenGitHub Actions

@jorisvandenbossche
jorisvandenbossche merged commit 2502915 into apache:mainMay 1, 2024
@jorisvandenbosschejorisvandenbossche removed the awaiting committer review Awaiting committer review label May 1, 2024
@jorisvandenbosschejorisvandenbossche mentioned this pull request May 1, 2024
Closed
@jorisvandenbossche

jorisvandenbossche commented May 1, 2024

Copy link
Copy Markdown
Member

Thanks @zanmato1984 for the quick follow-up

@github-actionsgithub-actionsBot added the awaiting merge Awaiting merge label May 1, 2024
@conbench-apache-arrow

conbench-apache-arrowBot commented May 1, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 2502915.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.

raulcd pushed a commit that referenced this pull request May 3, 2024
@zanmato1984@raulcd
GH-41463: [C++] Skip TestConcurrentFillFromScalar for platforms witho…
2122262
…ut threading support (#41461)
### Rationale for this change
See #41463 and #40237 (comment)
### What changes are included in this PR?
Skip test for platforms that have no threading support.
### Are these changes tested?
Change is test.
### Are there any user-facing changes?
None.
* GitHub Issue: #41463
Authored-by: Ruoxi Sun <zanmato1984@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
@zanmato1984@vibhatha
apacheGH-41463: [C++] Skip TestConcurrentFillFromScalar for platforms…
1a72ffd
… without threading support (apache#41461)
### Rationale for this change
See apache#41463 and apache#40237 (comment)
### What changes are included in this PR?
Skip test for platforms that have no threading support.
### Are these changes tested?
Change is test.
### Are there any user-facing changes?
None.
* GitHub Issue: apache#41463
Authored-by: Ruoxi Sun <zanmato1984@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes
@mapleFUmapleFUmapleFU approved these changes

Assignees

No one assigned

Labels

awaiting mergeAwaiting mergeComponent: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanmato1984@raulcd@jorisvandenbossche@mapleFU