GH-40819: [Java] Adding Spotless to Algorithm module by vibhatha · Pull Request #41825 · apache/arrow

vibhatha · 2024-05-25T05:33:26Z

Rationale for this change

Adding code style and formatting options for Algorithm module.

What changes are included in this PR?

Code formatting spotless plugin has been added.

Are these changes tested?

Yes, but doesn't involve test cases, the plugin itself corrects.

Are there any user-facing changes?

No

GitHub Issue: [Java] Adding Spotless to Algorithm module #40819

vibhatha · 2024-05-25T06:44:55Z

@laurentgo I made a new PR. Would you mind giving an early review?

vibhatha · 2024-05-28T01:57:41Z

Thank you @laurentgo for the feedback. I will update.

vibhatha · 2024-05-29T07:51:27Z

@github-actions crossbow submit -g java

github-actions · 2024-05-29T07:53:48Z

Revision: 6d43ea7b02b8005eec480c072ec0ab10c4583839

Submitted crossbow builds: ursacomputing/crossbow @ actions-700d797d93

Task	Status
java-jars
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.11-spark-master
test-conda-python-3.8-spark-v3.5.0
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-05-29T23:44:03Z

@github-actions crossbow submit -g java

github-actions · 2024-05-29T23:46:25Z

Revision: 451a350d83ab733d65ac806372c83246470760b8

Submitted crossbow builds: ursacomputing/crossbow @ actions-07022b7a25

Task	Status
java-jars
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.11-spark-master
test-conda-python-3.8-spark-v3.5.0
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-05-30T01:17:37Z

@github-actions crossbow submit -g java

github-actions · 2024-05-30T01:20:06Z

Revision: 451a350d83ab733d65ac806372c83246470760b8

Submitted crossbow builds: ursacomputing/crossbow @ actions-101e5e213b

Task	Status
java-jars
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.11-spark-master
test-conda-python-3.8-spark-v3.5.0
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

Co-authored-by: David Li <li.davidm96@gmail.com>

vibhatha · 2024-06-07T09:07:07Z

@lidavidm I rebased the PR, conflicts resolved.

conbench-apache-arrow · 2024-06-11T14:58:14Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f086b76.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 58 possible false positives for unstable benchmarks that are known to sometimes produce them.

) ### Rationale for this change Adding code style and formatting options for Algorithm module. ### What changes are included in this PR? Code formatting spotless plugin has been added. ### Are these changes tested? Yes, but doesn't involve test cases, the plugin itself corrects. ### Are there any user-facing changes? No * GitHub Issue: apache#40819 Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com> Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@users.noreply.github.com> Co-authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>

github-actionsBot added Component: Java Component: Documentation awaiting review Awaiting review labels May 25, 2024

laurentgo reviewed May 27, 2024
View reviewed changes

github-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 27, 2024

vibhatha force-pushed the feat-spotless-algorithm branch from 415cd41 to 875e16aCompare May 29, 2024 02:05

vibhatha marked this pull request as ready for review May 29, 2024 07:34

vibhatha requested a review from lidavidm as a code owner May 29, 2024 07:34

vibhatha marked this pull request as draft May 29, 2024 07:34

vibhatha marked this pull request as ready for review May 29, 2024 07:51

vibhatha requested a review from laurentgo May 29, 2024 07:51

github-actionsBot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 29, 2024

vibhatha force-pushed the feat-spotless-algorithm branch from 6d43ea7 to 4ecc5f3Compare May 29, 2024 14:28

github-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels May 29, 2024

laurentgo reviewed May 30, 2024
View reviewed changes

Comment threadjava/algorithm/pom.xml Outdated
Comment threadjava/algorithm/pom.xml Outdated
Comment threadjava/algorithm/pom.xml Outdated
Comment threadjava/algorithm/pom.xml Outdated

vibhatha force-pushed the feat-spotless-algorithm branch from 451a350 to 0ab443bCompare May 30, 2024 13:16

vibhatha requested a review from laurentgo June 2, 2024 23:30

vibhatha mentioned this pull request Jun 2, 2024
[Java] Adding POM License formatting for all modules #41929
Closed

vibhatha force-pushed the feat-spotless-algorithm branch from 1084b45 to 64dc87dCompare June 4, 2024 04:59

lidavidm approved these changes Jun 6, 2024
View reviewed changes

github-actionsBot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 6, 2024

vibhathaand others added 18 commits June 7, 2024 12:53

feat: adding spotless initial
c7837bf

fix: minor
9fef71e

fix: addressing reviews 1
43acd93

fix: addressing reviews
b191a1a

fix: addressing reviews v2
492a08a

fix: path issue resolved
28cb751

fix: addressing reviews
94f521a

fix: adding missing file
52fdb5e

fix: adding maven.multiModuleProjectDirectory
fa3eb6e

fix: addressing reviews
8b75469

fix: addressing reviews v2
bf40a02

fix: addressing reviews on docs
2122cd9

fix: adding suggestion v1
289d33c
Co-authored-by: David Li <li.davidm96@gmail.com>

fi
4935b1b
Co-authored-by: David Li <li.davidm96@gmail.com>

fix: adding suggestion v3
a4db52e
Co-authored-by: David Li <li.davidm96@gmail.com>

fix: adding suggestion v4
3c916fa
Co-authored-by: David Li <li.davidm96@gmail.com>

fix: adding suggestion v5
b47b344
Co-authored-by: David Li <li.davidm96@gmail.com>

fix: adding suggestion
a70f7c5

vibhatha force-pushed the feat-spotless-algorithm branch from ca8ac49 to a70f7c5Compare June 7, 2024 07:36

lidavidm approved these changes Jun 10, 2024
View reviewed changes

lidavidm merged commit f086b76 into apache:mainJun 10, 2024

lidavidm removed the awaiting merge Awaiting merge label Jun 10, 2024

lidavidm mentioned this pull request Jun 10, 2024
[Java] Adding Spotless to Algorithm module #40819
Closed

github-actionsBot added the awaiting merge Awaiting merge label Jun 10, 2024

Uh oh!

Conversation

vibhatha commented May 25, 2024• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

vibhatha commented May 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vibhatha commented May 28, 2024

Uh oh!

vibhatha commented May 29, 2024

Uh oh!

github-actionsBot commented May 29, 2024

Uh oh!

vibhatha commented May 29, 2024

Uh oh!

github-actionsBot commented May 29, 2024

Uh oh!

vibhatha commented May 30, 2024

Uh oh!

github-actionsBot commented May 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vibhatha commented Jun 7, 2024

Uh oh!

conbench-apache-arrowBot commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vibhatha commented May 25, 2024•
edited by github-actions Bot
Loading