Skip to content

GH-41955: [C++] Follow up of adding null_bitmap to MapArray::FromArrays - #41956

Merged
felipecrv merged 11 commits into
apache:mainfrom
AlenkaF:gh-41955-post-map-array-corrections
Jun 13, 2024
Merged

GH-41955: [C++] Follow up of adding null_bitmap to MapArray::FromArrays#41956
felipecrv merged 11 commits into
apache:mainfrom
AlenkaF:gh-41955-post-map-array-corrections

Conversation

@AlenkaF

@AlenkaFAlenkaF commented Jun 4, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Rationale for this change

There have been some new comments regarding the work done in #41757.

What changes are included in this PR?

This PR addresses the comments from #41757 (review)

Are these changes tested?

Yes. Existing tests should pass.

Are there any user-facing changes?

No.

@AlenkaF
AlenkaF marked this pull request as draft June 4, 2024 11:46
jorisvandenbossche
jorisvandenbossche reviewed Jun 4, 2024
View reviewed changes
Comment threadcpp/src/arrow/array/array_nested.cc Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes Component: Python awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Jun 4, 2024
@AlenkaF
AlenkaF marked this pull request as ready for review June 4, 2024 13:53
felipecrv
felipecrv reviewed Jun 5, 2024
View reviewed changes
Comment threadcpp/src/arrow/array/array_nested.cc Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 5, 2024
felipecrv
felipecrv reviewed Jun 5, 2024
View reviewed changes
Comment threadcpp/src/arrow/array/array_nested.cc Outdated
@AlenkaF
AlenkaFforce-pushed the gh-41955-post-map-array-corrections branch from 7094d3f to 83adabeCompareJune 6, 2024 11:23
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 6, 2024
@AlenkaF
AlenkaF requested a review from felipecrvJune 10, 2024 04:18
kou
kou approved these changes Jun 10, 2024
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment threadcpp/src/arrow/array/array_nested.cc Outdated
Comment threadcpp/src/arrow/array/array_nested.cc Outdated
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 10, 2024
felipecrv
felipecrv reviewed Jun 13, 2024
View reviewed changes
Comment threadcpp/src/arrow/array/array_nested.cc Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting merge Awaiting merge awaiting changes Awaiting changes labels Jun 13, 2024
@AlenkaF
AlenkaFforce-pushed the gh-41955-post-map-array-corrections branch from 7b2b6a4 to e0b9c36CompareJune 13, 2024 11:42
@AlenkaF

AlenkaF commented Jun 13, 2024

Copy link
Copy Markdown
MemberAuthor

Failures are not related (seen on other PRs also).

@AlenkaF
AlenkaF requested a review from felipecrvJune 13, 2024 14:13
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 13, 2024
@felipecrv
felipecrv merged commit fe1f7c0 into apache:mainJun 13, 2024
@felipecrvfelipecrv removed the awaiting merge Awaiting merge label Jun 13, 2024
@felipecrvfelipecrv mentioned this pull request Jun 13, 2024
Closed
@AlenkaF
AlenkaF deleted the gh-41955-post-map-array-corrections branch June 13, 2024 17:27
@conbench-apache-arrow

conbench-apache-arrowBot commented Jun 14, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit fe1f7c0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.

@ianmcookianmcook mentioned this pull request Jun 15, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche left review comments
@koukoukou approved these changes
@felipecrvfelipecrvfelipecrv approved these changes

Assignees

No one assigned

Labels

Component: C++Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlenkaF@kou@felipecrv@jorisvandenbossche