Uh oh!
There was an error while loading. Please reload this page.
GH-38553 : [C++] Replace null_count with MayHaveNulls in ListArrayFromArray and MapArray - #41957
Merged
Merged
Conversation
felipecrv
approved these changes
Jun 4, 2024
felipecrv
commented
Jun 4, 2024
Contributor
Thank you @AlenkaF! |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e4baf6b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Offsets could have
null_count() == -1(kUnknownNullCount) meaning that offsets might contain nulls that are not accounted for which can produce failures (#38553) when working withListArrayorMapArray.null_count()should be replaced withMayHaveNulls().What changes are included in this PR?
null_countis replaced withMayHaveNullsinListArrayFromArray,MapArray::FromArraysInternalandMapArray::ValidateChildData. Some tests had to be updated.Are these changes tested?
Yes.
Are there any user-facing changes?
No.